From fb18bc0803063d2cf182bfa9e019e3fb7142aefd Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Wed, 26 Feb 2020 22:58:56 +0100 Subject: [PATCH] cleanup: don't update tabs twice in MainTab::rejectChanges The updateDiveInfo() call updates all tabs. No need to do it right afterwards. Signed-off-by: Berthold Stoeger --- desktop-widgets/tab-widgets/maintab.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/desktop-widgets/tab-widgets/maintab.cpp b/desktop-widgets/tab-widgets/maintab.cpp index 9bdf4d35d..cfb442500 100644 --- a/desktop-widgets/tab-widgets/maintab.cpp +++ b/desktop-widgets/tab-widgets/maintab.cpp @@ -611,10 +611,6 @@ void MainTab::rejectChanges() clear_dive(&displayed_dive); updateDiveInfo(); - for (auto widget: extraWidgets) { - widget->updateData(); - } - // TODO: This is a temporary hack until the equipment tab is included in the undo system: // The equipment tab is hardcoded at the first place of the "extra widgets". ((TabDiveEquipment *)extraWidgets[0])->rejectChanges();