From fc7f0c621501e90b723fb66c81effc6b47065647 Mon Sep 17 00:00:00 2001 From: Dirk Hohndel Date: Fri, 21 Nov 2014 09:46:24 -0800 Subject: [PATCH] Use getSaveFileName() as the file open dialog This way we can specify file names that don't exist and therefore make our git syntax (/path/to/dir[branch]) work. Thanks to Tomaz for pointing this out. Signed-off-by: Dirk Hohndel --- qt-ui/mainwindow.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qt-ui/mainwindow.cpp b/qt-ui/mainwindow.cpp index d908fcd08..0b97d8c94 100644 --- a/qt-ui/mainwindow.cpp +++ b/qt-ui/mainwindow.cpp @@ -208,7 +208,10 @@ void MainWindow::on_actionOpen_triggered() if (!okToClose(tr("Please save or cancel the current dive edit before opening a new file."))) return; - QString filename = QFileDialog::getOpenFileName(this, tr("Open file"), lastUsedDir(), filter()); + // yes, this look wrong to use getSaveFileName() for the open dialog, but we need to be able + // to enter file names that don't exist in order to use our git syntax /path/to/dir[branch] + // with is a potentially valid input, but of course won't exist. So getOpenFileName() wouldn't work + QString filename = QFileDialog::getSaveFileName(this, tr("Open file"), lastUsedDir(), filter()); if (filename.isEmpty()) return; updateLastUsedDir(QFileInfo(filename).dir().path());