mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Cleanup: remove MapLocation::coordinateChanged signal

Browse source 
Nobody was listening for that signal. Remove it. This, quite
obviously, makse the setCoordinateNoEmit() function redundant.
Merge with setCoordinateNoEmit().

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2019-09-01 00:05:15 +02:00 • committed by Dirk Hohndel
parent 15f418e046
commit fe07a47989
2 changed files with 1 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

8
qt-models/maplocationmodel.cpp
View file

@ -61,12 +61,6 @@ QGeoCoordinate MapLocation::coordinate()
} }
void MapLocation::setCoordinate(QGeoCoordinate coord) void MapLocation::setCoordinate(QGeoCoordinate coord)
{
m_coordinate = coord;
emit coordinateChanged();
}
void MapLocation::setCoordinateNoEmit(QGeoCoordinate coord)
{ {
m_coordinate = coord; m_coordinate = coord;
} }
@ -246,7 +240,7 @@ void MapLocationModel::diveSiteChanged(struct dive_site *ds, int field)
const qreal latitude_r = ds->location.lat.udeg * 0.000001; const qreal latitude_r = ds->location.lat.udeg * 0.000001;
const qreal longitude_r = ds->location.lon.udeg * 0.000001; const qreal longitude_r = ds->location.lon.udeg * 0.000001;
QGeoCoordinate coord(latitude_r, longitude_r); QGeoCoordinate coord(latitude_r, longitude_r);
m_mapLocations[row]->setCoordinateNoEmit(coord); m_mapLocations[row]->setCoordinate(coord);
} }
break; break;
case LocationInformationModel::NAME: case LocationInformationModel::NAME:

4
qt-models/maplocationmodel.h
View file

@ -21,7 +21,6 @@ public:
QVariant getRole(int role) const; QVariant getRole(int role) const;
QGeoCoordinate coordinate(); QGeoCoordinate coordinate();
void setCoordinate(QGeoCoordinate coord); void setCoordinate(QGeoCoordinate coord);
void setCoordinateNoEmit(QGeoCoordinate coord);
struct dive_site *divesite(); struct dive_site *divesite();
enum Roles { enum Roles {
@ -39,9 +38,6 @@ private:
QString m_name; QString m_name;
public: public:
bool m_selected = false; bool m_selected = false;
signals:
void coordinateChanged();
}; };
class MapLocationModel : public QAbstractListModel class MapLocationModel : public QAbstractListModel