Commit graph

6 commits

Author SHA1 Message Date
Dirk Hohndel
4e1b66414e Add missing widget title for manual dive entry / edit
Buffer was used uninitialized instead.

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2013-05-15 22:32:08 -07:00
Dirk Hohndel
b6ec313096 Edit depth/duration dialog incorrectly always used metric
The label changed, but when the value was pre-set, it was always set as
metric (but then "correctly" interpreted as ft when reading it back - i.e.
it was incorrectly devided by 3.3).

Reported-by: Thomas Maisl <tom@maisl.net>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2013-05-15 13:08:40 -04:00
Dirk Hohndel
6dfd16a1f5 When editing a manually entered dive, make sure divelist is updated
Editing a manually entered dive allows the user to edit duration, max
depth and mean depth. These values are stored in the first (and only)
divecomputer and the duration, maxdepth and meandepth fields of the dive
are populated in fixup_dive() after the dive was initially parsed.

In order for this to work we need to clear out the existing fields (so
that values can get smaller) and rerun fixup_dive().

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2013-05-14 21:22:03 -04:00
Dirk Hohndel
8e18c860a9 Arrange tags in a table for dive edit dialog
This makes things look nicer and also reduces vertical size of the edit
dialog - which should now fit on a 600px display again.

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2013-05-14 10:56:42 -04:00
Henrik Brautaset Aronsen
f5ef74202b Require libzip, xslt and osm-gps-map in all builds
Conditional inclusion of libzip, xslt and osm-gps-map just
makes testing more cumbersome, since testers might lack
Subsurface features without knowing.

Signed-off-by: Henrik Brautaset Aronsen <subsurface@henrik.synth.no>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2013-05-11 22:02:24 -07:00
Dirk Hohndel
4c775289a7 Separate Gtk related code from core logic: info
Surprisingly straight forward, just a couple of places where we really mix
significant logic with UI code (for example setting the window title).

I had to move amount_selected from display-gtk.h to display.h - I guess
the number of dives that are selected is UI independent. But I wonder if
we still will track this as a global variable in a Qt UI (since the Gtk
selection logic is the main reason this existed in the first place).

Added a new info.h files for the necessary declarations.

This should make no difference to functionality.

Cherry-picked from Qt branch; fixed merge issues mostly caused by
dive_tags and Makefile changes.

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2013-04-15 21:49:14 -07:00