mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity
subsurface/qt-ui
History
Dirk Hohndel e5561d7668 Fix selection tracking bug 
When trying to remember a newly manually created dive across the
sort_table() call I abused the dive->selected flag and didn't clear it out
afterwards (most likely thinking "hey, I'm calling selectDive() on this
anyway").

This caused the UI code to correctly mark the dive as selected, but when
it called down to the C code to keep the internal data structures in sync,
that code didn't update amount_selected as it thought this dive had
already been selected. And that caused other parts of the code to get
confused, which manifested for example in the failed upload to
divelogs.de.

So this clears out the flag after abusing it to remember a dive. Maybe we
should add a 'remembered' flag instead, but for now this fixes the issue.

Fixes #351

Initial-fix-by: Lubomir I. Ivanov <neolit123@gmail.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2013-12-10 06:25:30 +01:00
..
css Added missing CSS file. 2013-09-02 05:57:08 -03:00
marble Work around broken Marble on Debian 2013-05-18 09:49:37 -07:00
about.cpp Fix all leak-at-exit from singletons in Subsurface 2013-11-30 09:28:42 -08:00
about.h Make the classes generated by uic be real members of our classes 2013-10-03 12:13:48 -07:00
about.ui Removed another unused text 2013-11-29 12:11:12 -08:00
completionmodels.cpp Fix all leak-at-exit from singletons in Subsurface 2013-11-30 09:28:42 -08:00
completionmodels.h Added a custom widget for tagging dives 2013-11-02 03:37:31 +01:00
csvimportdialog.cpp Allow comma separated CSV files 2013-12-04 15:27:09 -08:00
csvimportdialog.h Add optional support for stopdepth import from csv 2013-11-21 15:54:28 -08:00
csvimportdialog.ui Add application icon to dialogs 2013-11-30 12:01:32 -08:00
divecomputermanagementdialog.cpp Fix all leak-at-exit from singletons in Subsurface 2013-11-30 09:28:42 -08:00
divecomputermanagementdialog.h Random white space cleanup 2013-10-15 04:37:31 -07:00
divecomputermanagementdialog.ui Add application icon to dialogs 2013-11-30 12:01:32 -08:00
divelistview.cpp Divelogs.de: add a divelist context menu item for upload 2013-12-09 15:51:17 +02:00
divelistview.h Divelogs.de: add a divelist context menu item for upload 2013-12-09 15:51:17 +02:00
diveplanner.cpp Planner: fix potential assert in clear() 2013-12-10 05:22:01 +01:00
diveplanner.h Remove some unused variables 2013-12-09 22:47:28 +01:00
diveplanner.ui Add some limits to the GF's 2013-12-04 15:49:55 -08:00
downloadfromdivecomputer.cpp When the user cancels a download, reject already downloaded dives 2013-12-08 06:33:46 +01:00
downloadfromdivecomputer.h When the user cancels a download, reject already downloaded dives 2013-12-08 06:33:46 +01:00
downloadfromdivecomputer.ui Add application icon to dialogs 2013-11-30 12:01:32 -08:00
globe.cpp Attempt to fix the 'click goes to 0,0' thing on the globe. 2013-12-03 18:48:17 -08:00
globe.h Fixes Setting the dive-location via the map. 2013-12-02 09:44:55 -08:00
graphicsview-common.cpp graphicsview-common.cpp: Add more contrast to certain B/W colors 2013-10-15 04:23:43 -07:00
graphicsview-common.h Use the same line dimensions as the profile, on the planner. 2013-09-16 19:21:13 -03:00
groupedlineedit.cpp Work around QPlainTextEdit / QPainter bug on Mac 2013-11-22 09:44:28 -08:00
groupedlineedit.h Corrected indentation, added license/copyright 2013-11-02 17:10:30 +01:00
kmessagewidget.cpp Added the Message and the Buttons on the Equipment Tab 2013-09-18 23:23:04 -03:00
kmessagewidget.h Random white space cleanup 2013-10-15 04:37:31 -07:00
maintab.cpp Fix selection tracking bug 2013-12-10 06:25:30 +01:00
maintab.h Make sure the save/cancel message is always shown 2013-12-03 13:01:16 -08:00
maintab.ui Make sure the save/cancel message is always shown 2013-12-03 13:01:16 -08:00
mainwindow.cpp Implement a settingsChanged in DivePlannerWidget 2013-12-09 07:51:40 +01:00
mainwindow.h Open external links in default browser 2013-12-05 07:31:29 -08:00
mainwindow.ui Implement a settingsChanged in DivePlannerWidget 2013-12-09 07:51:40 +01:00
modeldelegates.cpp Print: fix missing vertical line at the last column 2013-11-30 17:35:55 +02:00
modeldelegates.h Fixed the Tab behavior on the QCombobox Delegate 2013-10-15 09:49:12 -07:00
models.cpp Build language list from Subsurface translations 2013-12-07 12:06:33 -08:00
models.h Added a language preference to the Settings. 2013-12-06 09:49:05 -08:00
plotareascene.cpp Add Qtr_ macros that uses gettext in a tr() compatible manner 2013-04-13 20:44:02 -07:00
plotareascene.h Add Qtr_ macros that uses gettext in a tr() compatible manner 2013-04-13 20:44:02 -07:00
preferences.cpp Rename the radio button to match label kgs->kg 2013-12-08 16:17:52 +01:00
preferences.h Added a filter option to the Language Chooser 2013-12-06 11:56:00 -08:00
preferences.ui Update the diffrent units when switching system 2013-12-08 16:18:00 +01:00
printdialog.cpp PrintDialog: reset the progress bar each time the dialog opens 2013-12-04 15:52:21 +02:00
printdialog.h PrintDialog: reset the progress bar each time the dialog opens 2013-12-04 15:52:21 +02:00
printlayout.cpp Silence signed vs. unsigned compare warning 2013-12-08 09:41:42 +01:00
printlayout.h Cleanup some uninitialized variables 2013-12-04 15:57:53 -08:00
printoptions.cpp Print: adjustments to PrintDialog 2013-11-30 18:56:25 +02:00
printoptions.h Make the classes generated by uic be real members of our classes 2013-10-03 12:13:48 -07:00
printoptions.ui Remove more unused windowTitle properties 2013-11-29 11:02:15 -08:00
profilegraphics.cpp Remove some unused variables 2013-12-09 22:47:28 +01:00
profilegraphics.h Remove some unused variables 2013-12-09 22:47:28 +01:00
renumber.ui Renumber dialog should default to start at 1 2013-12-07 06:49:52 -08:00
shifttimes.ui Add application icon to dialogs 2013-11-30 12:01:32 -08:00
simplewidgets.cpp Fix all leak-at-exit from singletons in Subsurface 2013-11-30 09:28:42 -08:00
simplewidgets.h Fix all leak-at-exit from singletons in Subsurface 2013-11-30 09:28:42 -08:00
starwidget.cpp Fix uninitialised variable read 2013-11-30 09:24:59 -08:00
starwidget.h Fix uninitialised variable read 2013-11-30 09:24:59 -08:00
subsurfacewebservices.cpp Remove some unused variables 2013-12-09 22:47:28 +01:00
subsurfacewebservices.h Divelogs.de: change the 'Apply' button to 'Done' for upload 2013-12-09 18:40:52 +01:00
tableview.cpp Fixes the correct sizes of the tables when first open. 2013-11-22 07:32:53 -08:00
tableview.h Partially revert d72c69db7a and fix its errors 2013-11-13 11:58:47 +09:00
tableview.ui Remove more unused windowTitle properties 2013-11-29 11:02:15 -08:00
tagwidget.cpp Remove debug output left in the previous commit by mistake 2013-11-07 16:32:23 +09:00
tagwidget.h Fix the inconsistent behaviour of QCompleter 2013-11-02 17:10:34 +01:00
webservices.ui Webservices: make the dialog title more generic 2013-12-10 05:52:26 +01:00