mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity
subsurface/desktop-widgets
History
Michael Keller 10fc3bfd47 Bugfix: Fix Incorrect Volumes Displayed for Tank Types. 
Fix an issue introduced in #4148.
Essentially the refactoring missed the fact that in the imperial system
tank size is tracked as the free gas volume, but in the metric system
(which is the one used in most of Subsurface's calculations) tank size
is tracked as water capacity.
So when updating a tank template tracking imperial measurements, the
given (metric) volume in l has to be multiplied by the working pressure,
and vice versa.
This also combines all the logic dealing with `tank_info` data in one
place, hopefully making it less likely that this will be broken by
inconsistencies in the future.

Fixes #4239.

Signed-off-by: Michael Keller <github@ike.ch>
2024-06-09 11:15:59 +02:00
..
css
preferences Delete desktop-widgets/preferences/preferences_dc.ui 2024-04-26 08:14:16 +12:00
qml statistics: don't import QtQuick in StatsView QML file 2022-11-19 15:07:07 -08:00
tab-widgets Cleanup: Improve the Use of 'Planned dive' and 'Manually added dive'. 2024-05-25 20:13:45 +02:00
about.cpp Desktop: Add Button and Link to 'Contribute' Page. 2024-02-04 14:50:18 -08:00
about.h Desktop: Add Button and Link to 'Contribute' Page. 2024-02-04 14:50:18 -08:00
about.ui Desktop: Add Button and Link to 'Contribute' Page. 2024-02-04 14:50:18 -08:00
addfilterpreset.ui
btdeviceselectiondialog.cpp
btdeviceselectiondialog.h
btdeviceselectiondialog.ui
CMakeLists.txt Update to use AUTOMOC 2024-01-20 09:38:22 -08:00
configuredivecomputerdialog.cpp core: make logfile_name and dumpfile_name std::string 2024-03-24 17:53:19 +01:00
configuredivecomputerdialog.h dive download: pass current filename to dialog 2024-03-24 17:53:19 +01:00
configuredivecomputerdialog.ui Desktop: Use Persisted Device Information for Dive Computer Configuration. 2023-06-12 12:40:44 -07:00
divecomponentselection.ui
divelistview.cpp cleanup: replace Q_FOREACH and foreach by range base for 2024-03-24 17:53:19 +01:00
divelistview.h cleanup: more Coverity silencing 2024-01-17 14:23:19 -08:00
divelogexportdialog.cpp
divelogexportdialog.h
divelogexportdialog.ui Desktop: Change 'CSV summary dive details' output from TSV to CSV. 2023-05-18 10:31:31 +03:00
divelogimportdialog.cpp Replace remaining qDebug()s by report_info() 2024-04-23 07:47:11 +07:00
divelogimportdialog.h
divelogimportdialog.ui
divepicturewidget.cpp
divepicturewidget.h
diveplanner.cpp Planner: Fix Editing of Plans in Multi-Divecomputer Dives. 2024-05-11 12:51:45 +12:00
diveplanner.h Planner: Fix Editing of Plans in Multi-Divecomputer Dives. 2024-05-11 12:51:45 +12:00
diveplanner.ui
diveshareexportdialog.cpp
diveshareexportdialog.h
diveshareexportdialog.ui
divesiteimportdialog.cpp cleanup: more Coverity silencing 2024-01-17 14:23:19 -08:00
divesiteimportdialog.h
divesiteimportdialog.ui
divesitelistview.cpp core: introduce divelog structure 2023-04-14 21:20:23 +02:00
divesitelistview.h desktop: make dive site list an independent widget 2022-09-23 15:50:49 +02:00
divesitelistview.ui desktop: make dive site list an independent widget 2022-09-23 15:50:49 +02:00
downloadfromdivecomputer.cpp Import: Make Directory Selectable when Importing .fit Files. 2024-05-11 12:52:05 +12:00
downloadfromdivecomputer.h Update downloadfromdivecomputer.h 2024-04-22 16:52:19 +12:00
downloadfromdivecomputer.ui Update downloadfromdivecomputer.ui 2024-04-22 16:52:19 +12:00
filterconstraintwidget.cpp
filterconstraintwidget.h
filterwidget.cpp core: port filterpreset.cpp to std::string 2024-03-10 11:01:42 +13:00
filterwidget.h
filterwidget.ui
findmovedimagesdialog.cpp cleanup: silence std::move()-related Coverity warnings 2024-01-15 15:11:36 -08:00
findmovedimagesdialog.h
findmovedimagesdialog.ui
groupedlineedit.cpp cleanup: replace Q_FOREACH and foreach by range base for 2024-03-24 17:53:19 +01:00
groupedlineedit.h
importgps.cpp
importgps.h
importgps.ui
kmessagewidget.cpp cleanup: replace Q_FOREACH and foreach by range base for 2024-03-24 17:53:19 +01:00
kmessagewidget.h
listfilter.ui
locationinformation.cpp code consistency: replace qMin/qMax by std::min/std::max 2024-01-17 14:23:19 -08:00
locationinformation.h Desktop: Add mergeing into the selected dive site. 2023-05-20 07:24:39 +02:00
locationinformation.ui
mainwindow.cpp Desktop: Fix Gas Editing for Manually Added Dives. 2024-06-01 23:22:40 +12:00
mainwindow.h Planner: Improve Exit Warning. 2024-05-17 16:44:04 +12:00
mainwindow.ui Desktop: Regroup File Menu Entries. 2023-06-17 20:19:35 +02:00
mapwidget.cpp Replace remaining qDebug()s by report_info() 2024-04-23 07:47:11 +07:00
mapwidget.h map: fold selectionChanged() into setSelection() 2023-04-16 20:23:59 +02:00
modeldelegates.cpp Bugfix: Fix Incorrect Volumes Displayed for Tank Types. 2024-06-09 11:15:59 +02:00
modeldelegates.h desktop: unglobalize ComboBox-models 2024-04-16 08:56:49 +12:00
notificationwidget.cpp
notificationwidget.h
plannerDetails.ui
plannerSettings.ui
printdialog.cpp printing: pass current filename to dialog 2024-03-24 17:53:19 +01:00
printdialog.h printing: pass current filename to dialog 2024-03-24 17:53:19 +01:00
printer.cpp printing: don't access displayed_dive in printing code 2023-04-16 20:23:59 +02:00
printer.h printing: don't access displayed_dive in printing code 2023-04-16 20:23:59 +02:00
printoptions.cpp Add printing option for page orientation 2023-03-28 21:08:37 -07:00
printoptions.h Add printing option for page orientation 2023-03-28 21:08:37 -07:00
printoptions.ui Add printing option for page orientation 2023-03-28 21:08:37 -07:00
profilewidget.cpp Desktop: Fix Undo for Gaschanges on Manually Added Dives. 2024-06-02 11:38:21 +02:00
profilewidget.h Desktop: Fix Gas Editing for Manually Added Dives. 2024-06-01 23:22:40 +12:00
profilewidget.ui Desktop: Add a Button to Hide the Infobox in the Dive Profile. 2023-06-25 14:40:23 +02:00
qtwaitingspinner.cpp
qtwaitingspinner.h
renumber.ui
searchbar.ui
setpoint.ui
shiftimagetimes.ui
shifttimes.ui
simplewidgets.cpp core: use C++-primitives for g_tag_list 2024-04-23 07:47:11 +07:00
simplewidgets.h desktop: pass dive list to ShiftTimesDialog 2023-01-18 15:42:47 -08:00
starwidget.cpp
starwidget.h
statswidget.cpp Qt6: prevent QML object from being garbage collected 2022-03-12 08:28:32 -08:00
statswidget.h Qt6: prevent QML object from being garbage collected 2022-03-12 08:28:32 -08:00
statswidget.ui
subsurfacewebservices.cpp Remove diabled debugging output in subsurfacewebservices.cpp 2024-04-23 07:47:11 +07:00
subsurfacewebservices.h Qt6: update the connect calls for QNetworkReply 2022-04-18 07:24:39 +02:00
tableview.cpp
tableview.h
tableview.ui
tagwidget.cpp desktop: let tag-widget completion popup accept composition events 2022-08-13 11:19:37 -07:00
tagwidget.h desktop: improve composition on TagWidgets 2022-08-13 11:19:37 -07:00
templateedit.cpp printing: don't access displayed_dive in printing code 2023-04-16 20:23:59 +02:00
templateedit.h
templateedit.ui
templatelayout.cpp core: use C++-primitives for g_tag_list 2024-04-23 07:47:11 +07:00
templatelayout.h cleanup: silence std::move()-related Coverity warnings 2024-01-15 15:11:36 -08:00
textedit.cpp
textedit.h
tripselectiondialog.cpp core: introduce divelog structure 2023-04-14 21:20:23 +02:00
tripselectiondialog.h
tripselectiondialog.ui
updatemanager.cpp remove app uuid 2024-01-07 16:01:55 -08:00
updatemanager.h
urldialog.ui Allow more than one media file when importing from the web 2022-04-01 08:28:05 -07:00
usermanual.cpp
usermanual.h
webservices.ui