subsurface/desktop-widgets
Berthold Stoeger 285ea9b7ca Cleanup: don't initialize DivePlannerPointsModel at startup
The whole point of having X::instance() functions is to solve
the infamous "Static Initialization Order Fiasco": When having
global objects in different translation units, their order
of initialization is undefined. Thus, when these objects access
each other one cannot guarantee the correct order of
initialization. The X::instance() functions generate the objects
on first use.

DivePlannerPointsModel has such an instance() function. However,
for convenience(?) in diveplanner.cpp we find the global variable
 static DivePlannerPointsModel* plannerModel =
	DivePlannerPointsModel::instance();
Thus, the DivePlannerPointsModel constructor is run before main(),
negating the whole purpose of the instance() function.

Let's remove this line to avoid hard-to-debug startup issues.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2020-02-06 08:51:32 -08:00
..
css
preferences core/settings:: remove string functions for units 2020-01-20 09:55:26 -08:00
statistics
tab-widgets Cleanup: lower-case filenames in core/subsurface-qt/ 2020-02-04 02:16:46 +01:00
about.cpp
about.h
about.ui
btdeviceselectiondialog.cpp
btdeviceselectiondialog.h
btdeviceselectiondialog.ui
CMakeLists.txt Desktop: Import dive coordinates directly from GPS 2020-01-24 09:51:02 -08:00
configuredivecomputerdialog.cpp
configuredivecomputerdialog.h
configuredivecomputerdialog.ui
divecomponentselection.ui
divecomputermanagementdialog.cpp
divecomputermanagementdialog.h
divecomputermanagementdialog.ui
divelistview.cpp Dive sites: select each dive site only once 2020-02-04 02:18:28 +01:00
divelistview.h Cleanup: lower-case filenames in core/subsurface-qt/ 2020-02-04 02:16:46 +01:00
divelogexportdialog.cpp
divelogexportdialog.h
divelogexportdialog.ui
divelogimportdialog.cpp
divelogimportdialog.h
divelogimportdialog.ui
divepicturewidget.cpp
divepicturewidget.h
diveplanner.cpp Cleanup: don't initialize DivePlannerPointsModel at startup 2020-02-06 08:51:32 -08:00
diveplanner.h
diveplanner.ui
diveshareexportdialog.cpp
diveshareexportdialog.h
diveshareexportdialog.ui
divesiteimportdialog.cpp
divesiteimportdialog.h
divesiteimportdialog.ui
downloadfromdivecomputer.cpp
downloadfromdivecomputer.h
downloadfromdivecomputer.ui
filterwidget2.cpp
filterwidget2.h
filterwidget2.ui
findmovedimagesdialog.cpp
findmovedimagesdialog.h
findmovedimagesdialog.ui
groupedlineedit.cpp
groupedlineedit.h
importgps.cpp core: move GPX parsing into core 2020-01-24 09:51:02 -08:00
importgps.h core: move GPX parsing into core 2020-01-24 09:51:02 -08:00
importgps.ui Desktop: Import dive coordinates directly from GPS 2020-01-24 09:51:02 -08:00
kmessagewidget.cpp
kmessagewidget.h
listfilter.ui
locationinformation.cpp Dive site: don't save invalid GPS coordinates 2020-02-06 08:50:22 -08:00
locationinformation.h Dive site: give visual clue for invalid coordinates 2020-02-06 08:50:22 -08:00
locationinformation.ui Desktop: Import dive coordinates directly from GPS 2020-01-24 09:51:02 -08:00
mainwindow.cpp Cleanup: lower-case filenames in core/subsurface-qt/ 2020-02-04 02:16:46 +01:00
mainwindow.h
mainwindow.ui
mapwidget.cpp
mapwidget.h Cleanup: lower-case filenames in core/subsurface-qt/ 2020-02-04 02:16:46 +01:00
modeldelegates.cpp
modeldelegates.h
notificationwidget.cpp
notificationwidget.h
plannerDetails.ui
plannerSettings.ui
printdialog.cpp
printdialog.h
printer.cpp
printer.h
printoptions.cpp
printoptions.h
printoptions.ui
qtwaitingspinner.cpp
qtwaitingspinner.h
renumber.ui
searchbar.ui
setpoint.ui
shiftimagetimes.ui
shifttimes.ui
simplewidgets.cpp
simplewidgets.h
starwidget.cpp
starwidget.h
subsurfacewebservices.cpp
subsurfacewebservices.h
tableview.cpp
tableview.h
tableview.ui
tagwidget.cpp
tagwidget.h
templateedit.cpp
templateedit.h
templateedit.ui
templatelayout.cpp
templatelayout.h Cleanup: lower-case filenames in core/subsurface-qt/ 2020-02-04 02:16:46 +01:00
textedit.cpp
textedit.h
updatemanager.cpp
updatemanager.h
urldialog.ui
usermanual.cpp
usermanual.h
usersurvey.cpp
usersurvey.h
usersurvey.ui
webservices.ui