mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity
subsurface/desktop-widgets
History
Berthold Stoeger f27d440bb3 Dive site: don't emit divesChanged signals when editing dive site 
When editing the dive site, for certain fields a divesChanged signal
was emitted so that the dive-list can be updated.

Arguably it is wrong to decide which fields are relevant to the
dive list in the undo-command code. Therefore, let the list
catch the dive-site-edited signal and decide itself.

But the actual reason for this commit is that if the dive-site
field of a dive changes, we might have to reload the dive-location-model
because suddenly a new dive site appears. Now if this is done
in QML context on some Qt version (notably 5.9) we get crashes
later on. But that can happen if the user moves a flag. So in that
case only send a diveSiteChanged signal.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2019-09-06 11:48:47 -07:00
..
css
preferences Cleanup: move error reporting function declarations to errorhelper.h 2019-08-08 16:26:30 -07:00
statistics Cleanup: reinstate override modifiers 2018-09-29 15:23:25 -07:00
tab-widgets Cleanup: remove TabDiveSite::updateFilter() function 2019-09-06 11:48:47 -07:00
about.cpp update year to 2019 in about screens 2019-01-02 09:45:01 -08:00
about.h
about.ui
btdeviceselectiondialog.cpp Cleanup: remove unnecessary QRegularExpression copies 2019-06-06 14:52:42 +03:00
btdeviceselectiondialog.h Bluetooth: use standard Qt code on Windows 2018-09-30 08:09:37 -07:00
btdeviceselectiondialog.ui Desktop: add checkbox to show all BT devices 2019-02-14 09:05:58 -08:00
CMakeLists.txt Create DivesiteImportDialog to select sites to import 2019-05-06 10:48:44 +02:00
command.cpp Undo: make editing of dive number undoable 2019-07-19 21:44:13 -07:00
command.h Undo: make editing of dive number undoable 2019-07-19 21:44:13 -07:00
command_base.cpp Undo: hide multi-dive-edit warning message on subsequent edit 2019-06-15 11:20:49 -07:00
command_base.h Cleanup: move trip-related functions into own translation unit 2019-06-19 13:11:10 -07:00
command_divelist.cpp Dive merge: don't use unset dive numbers 2019-06-28 20:23:01 +09:00
command_divelist.h Cleanup: remove selectionChanged logic from dive-list commands 2019-06-23 20:08:46 +02:00
command_divesite.cpp Dive site: don't emit divesChanged signals when editing dive site 2019-09-06 11:48:47 -07:00
command_divesite.h Add undo/redo commands for importing dive sites 2019-05-06 10:48:44 +02:00
command_edit.cpp Desktop: fix crash on copy & paste 2019-08-24 14:00:06 -07:00
command_edit.h Undo: make editing of dive number undoable 2019-07-19 21:44:13 -07:00
command_edit_trip.cpp Undo: use QUndoStack::isClean() to determine unsaved changes 2019-04-12 18:19:07 +03:00
command_edit_trip.h Undo: implement undo of dive trip editing 2019-04-12 18:19:07 +03:00
command_private.cpp Cleanup: unify selection signals 2019-06-23 20:08:46 +02:00
command_private.h Cleanup: remove selectionChanged logic from dive-list commands 2019-06-23 20:08:46 +02:00
configuredivecomputerdialog.cpp Cleanup: we don't support configuring a Uemis SDA 2018-08-28 12:03:03 -07:00
configuredivecomputerdialog.h Cleanup: reinstate override modifiers 2018-09-29 15:23:25 -07:00
configuredivecomputerdialog.ui Configure ostc3: Remove obsoleted setting 2018-04-27 21:33:47 +03:00
divecomponentselection.ui Add various enhancements to profile export and dive data copy 2019-02-07 16:06:43 +01:00
divecomputermanagementdialog.cpp Dive computers: turn QMultiMap into sorted vector 2018-06-17 06:53:13 +09:00
divecomputermanagementdialog.h Cleanup: fold DiveComputerManagementDialog::update() into init() 2018-06-17 06:53:13 +09:00
divecomputermanagementdialog.ui
divelistview.cpp Map: highlight correct dive sites in dive site mode 2019-09-06 11:48:47 -07:00
divelistview.h Cleanup: unify selection signals 2019-06-23 20:08:46 +02:00
divelogexportdialog.cpp Cleanup: move file-related function declarations to file.h 2019-08-08 16:26:31 -07:00
divelogexportdialog.h Add various enhancements to profile export and dive data copy 2019-02-07 16:06:43 +01:00
divelogexportdialog.ui Add export option to export dive sites. 2019-04-13 08:18:32 -07:00
divelogimportdialog.cpp Cleanup: move trip-related functions into own translation unit 2019-06-19 13:11:10 -07:00
divelogimportdialog.h Import: Make DiveLogImportDialog modal 2018-10-04 10:22:11 +02:00
divelogimportdialog.ui
divepicturewidget.cpp Dive media: transport dive-id in drag'n'drop events 2018-07-18 09:06:37 -07:00
divepicturewidget.h Cleanup: reinstate override modifiers 2018-09-29 15:23:25 -07:00
diveplanner.cpp Implement height-to-pressure functions in planner 2019-05-17 09:46:05 +02:00
diveplanner.h Planner: Add checkbox to force OC bailout 2019-01-13 15:02:07 -08:00
diveplanner.ui Choose water presets from a qcombobox in planner, custom value possible 2018-03-02 08:38:22 -08:00
diveshareexportdialog.cpp Revert "desktop-widgets: remove QSettings from desktop-widgets" 2018-08-29 03:09:10 -07:00
diveshareexportdialog.h
diveshareexportdialog.ui
divesiteimportdialog.cpp Create DivesiteImportDialog to select sites to import 2019-05-06 10:48:44 +02:00
divesiteimportdialog.h Create DivesiteImportDialog to select sites to import 2019-05-06 10:48:44 +02:00
divesiteimportdialog.ui Create DivesiteImportDialog to select sites to import 2019-05-06 10:48:44 +02:00
downloadfromdivecomputer.cpp Fix broken windows build with latest MXE 2019-08-29 12:55:25 -07:00
downloadfromdivecomputer.h Fix broken windows build with latest MXE 2019-08-29 12:55:25 -07:00
downloadfromdivecomputer.ui Desktop/remember DCs: avoid highlighted button 2018-09-23 11:49:30 -07:00
filterwidget2.cpp Turn application state into enum 2019-05-12 12:33:55 -07:00
filterwidget2.h Filter: call update title directly in filter model 2019-04-12 18:19:07 +03:00
filterwidget2.ui Desktop: correct tooltip for filter close button 2019-07-29 07:24:05 +02:00
findmovedimagesdialog.cpp Desktop: fix another variable name conflict 2019-03-18 19:40:32 -07:00
findmovedimagesdialog.h Dive pictures: implement FindMovedImagesDialog 2018-07-04 02:27:36 +08:00
findmovedimagesdialog.ui UI change of "images"/"photo" to "media" or "media files" 2018-07-15 09:38:12 -07:00
groupedlineedit.cpp
groupedlineedit.h Cleanup: reinstate override modifiers 2018-09-29 15:23:25 -07:00
kmessagewidget.cpp
kmessagewidget.h Cleanup: reinstate override modifiers 2018-09-29 15:23:25 -07:00
listfilter.ui Start to implement a simplified version of the filter widget 2018-12-14 01:05:18 +08:00
locationinformation.cpp Cleanup: remove DiveLocationLineEdit::currType 2019-07-04 10:41:09 +09:00
locationinformation.h Cleanup: remove DiveLocationLineEdit::currType 2019-07-04 10:41:09 +09:00
locationinformation.ui Dive site: add proximity field to dive site list 2019-04-12 18:19:07 +03:00
mainwindow.cpp Map: don't fully reset model on selection change 2019-09-06 11:48:47 -07:00
mainwindow.h Cleanup: move error reporting function declarations to errorhelper.h 2019-08-08 16:26:30 -07:00
mainwindow.ui Reword configure dive computer 2019-06-03 19:55:19 +02:00
mapwidget.cpp Desktop: show all selected dive sites on click 2019-09-06 11:48:47 -07:00
mapwidget.h Desktop: show all selected dive sites on click 2019-09-06 11:48:47 -07:00
modeldelegates.cpp Dive site: show distance to current dive using extra data 2019-05-11 12:35:11 -07:00
modeldelegates.h Dive site: show distance to current dive using extra data 2019-05-11 12:35:11 -07:00
notificationwidget.cpp Use queued connection to thread-safe MainWindow error handling 2018-01-31 14:47:26 +01:00
notificationwidget.h Use queued connection to thread-safe MainWindow error handling 2018-01-31 14:47:26 +01:00
plannerDetails.ui
plannerSettings.ui Add UI element for final surface segment in planner 2019-03-29 06:51:12 -07:00
printdialog.cpp Drop old filter code 2018-12-14 01:05:18 +08:00
printdialog.h Cleanup: replace virtual by override where appropriate 2018-07-31 11:02:34 +02:00
printer.cpp Cleanup: small coding style fixes 2019-05-15 07:42:14 -07:00
printer.h Remove partial support for QWebEngine 2019-03-20 08:45:02 -07:00
printoptions.cpp replace deprecated qSort() with std::sort() 2019-04-12 12:59:17 +03:00
printoptions.h Cleanup: remove all Q_NULLPTR instances 2019-04-02 07:34:46 -07:00
printoptions.ui
qtwaitingspinner.cpp
qtwaitingspinner.h
renumber.ui
searchbar.ui
setpoint.ui
shiftimagetimes.ui UI change of "images"/"photo" to "media" or "media files" 2018-07-15 09:38:12 -07:00
shifttimes.ui
simplewidgets.cpp Core: dynamically resize weight table 2019-07-18 06:01:07 -07:00
simplewidgets.h Cleanup: remove Q_PROPERTYs from MinMaxWidget 2019-06-10 17:59:35 +03:00
starwidget.cpp Cleanup: remove parameter from currentDiveChanged signal 2018-07-30 12:20:26 -07:00
starwidget.h Cleanup: reinstate override modifiers 2018-09-29 15:23:25 -07:00
subsurfacewebservices.cpp Cleanup: move file-related function declarations to file.h 2019-08-08 16:26:31 -07:00
subsurfacewebservices.h Cleanup: Devirtualize WebServices::downloadTimedOut() 2018-09-29 15:16:11 -07:00
tableview.cpp
tableview.h Cleanup: reinstate override modifiers 2018-09-29 15:23:25 -07:00
tableview.ui
tagwidget.cpp Desktop: remove edit-check in tag-widget completer 2019-04-14 03:38:22 +12:00
tagwidget.h Undo: implement undo of tag editing 2019-04-12 18:19:07 +03:00
templateedit.cpp Warnings: replace memcpy by assignment 2018-11-19 13:51:03 -08:00
templateedit.h
templateedit.ui
templatelayout.cpp Cleanup: turn CylinderObjectHelper into value type 2019-08-22 10:13:40 -07:00
templatelayout.h Cleanup: turn CylinderObjectHelper into value type 2019-08-22 10:13:40 -07:00
textedit.cpp Desktop: create new custom TextEdit widget for notes-field 2019-04-12 18:19:07 +03:00
textedit.h Desktop: create new custom TextEdit widget for notes-field 2019-04-12 18:19:07 +03:00
updatemanager.cpp core: move updatecheck to its own domain 2019-02-09 10:37:55 -08:00
updatemanager.h
urldialog.ui UI change of "images"/"photo" to "media" or "media files" 2018-07-15 09:38:12 -07:00
usermanual.cpp Coding style: remove Java-style function definition 2019-04-12 18:19:07 +03:00
usermanual.h Remove partial support for QWebEngine 2019-03-20 08:45:02 -07:00
usersurvey.cpp Revert "desktop-widgets: remove QSettings from desktop-widgets" 2018-08-29 03:09:10 -07:00
usersurvey.h
usersurvey.ui
webservices.ui