subsurface/core/subsurface-qt/CylinderObjectHelper.cpp
Berthold Stoeger f25fa2adc5 Cleanup: turn CylinderObjectHelper into value type
CylinderObjectHelper is used for structured formatting of cylinder
values in grantlee types. Instead of keeping a reference to a
cylinder, turn it into a value type containing the formatted strings.

This should be distinctly safer, as we don't risk having stale
references flying around. Moreover, we don't have to use pointers
but can use containers containing plain CylinderObjectHelper. Thus,
no explicit memory management is needed, making the code distinctly
easier to understand.

Sadly, currently grantlee does not support Q_GADGET based Q_PROPERTY.
Therefore a GRANTLEE_*_LOOKUP block has to be added. This can be
removed in due course, as a patch to remedy this issue is in current
grantlee master.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2019-08-22 10:13:40 -07:00

18 lines
649 B
C++

// SPDX-License-Identifier: GPL-2.0
#include "CylinderObjectHelper.h"
#include "../qthelper.h"
static QString EMPTY_CYLINDER_STRING = QStringLiteral("");
CylinderObjectHelper::CylinderObjectHelper(cylinder_t *cylinder)
{
if (!cylinder)
return;
description = cylinder->type.description ? cylinder->type.description:
EMPTY_CYLINDER_STRING;
size = get_volume_string(cylinder->type.size, true);
workingPressure = get_pressure_string(cylinder->type.workingpressure, true);
startPressure = get_pressure_string(cylinder->start, true);
endPressure = get_pressure_string(cylinder->end, true);
gasMix = get_gas_string(cylinder->gasmix);
}