subsurface/tests
Berthold Stoeger e20ec9248c core: fix leak when clearing dive log
46cf2fc086 fixed a bug where clearing of a divelog, such as the one
used for import, would erase dives in the global(!) divelog.

However, the new code used the function clear_dive_table(), which
only cleared the table without unregistering the dives. In particular,
the dives were not removed from the trips, which means that the trips
were not free()d.

This reinstates the old code, but now passes a divelog paremeter
to delete_single_dive() instead of accessing the global divelog.
Moreover, delete dives from the back to avoid unnecessary
copying.

An alternative and definitely simpler solution might be to just
add a "clear_trip_table()" after "clear_dive_table()".

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2024-05-13 08:58:03 +12:00
..
.gitignore tests: add .gitignore to ignore qmlc files 2018-07-12 17:12:56 +02:00
CMakeLists.txt Add tests for formatDiveGasString 2023-10-18 21:34:56 +13:00
testAirPressure.cpp core: introduce divelog structure 2023-04-14 21:20:23 +02:00
testAirPressure.h Convert the atmospheric pressure in the Information Tab to an editable field 2019-05-15 07:37:14 -07:00
testdivesiteduplication.cpp core: introduce divelog structure 2023-04-14 21:20:23 +02:00
testdivesiteduplication.h Whitespace cleanup tests 2018-07-26 16:32:51 +03:00
testformatDiveGasString.cpp Add another test for formatDiveGasString 2023-10-18 21:34:56 +13:00
testformatDiveGasString.h Add another test for formatDiveGasString 2023-10-18 21:34:56 +13:00
testgitstorage.cpp core: fix leak when clearing dive log 2024-05-13 08:58:03 +12:00
testgitstorage.h testing/git-storage: fairly fundamental rewrite of the storage test 2020-04-15 07:58:10 -07:00
testgpscoords.cpp Whitespace cleanup tests 2018-07-26 16:32:51 +03:00
testgpscoords.h Whitespace cleanup tests 2018-07-26 16:32:51 +03:00
testhelper.cpp Tests: allow compilation with older Qt versions 2018-10-12 08:22:44 -07:00
testhelper.h Bluetooth: add helper to separate BT name and address 2018-10-12 08:22:44 -07:00
testmerge.cpp core: introduce divelog structure 2023-04-14 21:20:23 +02:00
testmerge.h Whitespace cleanup tests 2018-07-26 16:32:51 +03:00
testparse.cpp core: turn a memblock in the parser to std::string 2024-03-10 11:01:42 +13:00
testparse.h Test case for multicylinder support on CSV import 2020-05-26 11:33:10 -07:00
testparseperformance.cpp Convert qDebug() to report_info() in testing code 2024-04-23 07:47:11 +07:00
testparseperformance.h Add performance test case 2018-08-31 06:33:46 -07:00
testpicture.cpp core: introduce divelog structure 2023-04-14 21:20:23 +02:00
testpicture.h Whitespace cleanup tests 2018-07-26 16:32:51 +03:00
testplan.cpp Planner: Fix Editing of Plans in Multi-Divecomputer Dives. 2024-05-11 12:51:45 +12:00
testplan.h Fix invalid bailout gas choice when planning a CCR dive. 2023-02-17 10:49:24 +01:00
testplannershared.cpp Cleanup: rename plannerShared to PlannerShared 2020-02-04 02:17:52 +01:00
testplannershared.h backend-shared: remove asc/desc functions 2020-01-20 15:49:02 -08:00
testprofile.cpp core: introduce divelog structure 2023-04-14 21:20:23 +02:00
testprofile.h cloudstorage: adapt tests 2021-04-19 12:51:01 -07:00
testqml.cpp tests: deactivate testQML 2019-12-29 12:32:02 -08:00
testqml.h tests: change testqml to allow direct register of C++ objects 2018-09-11 17:22:58 -07:00
testqPrefCloudStorage.cpp cloudstorage: adapt tests 2021-04-19 12:51:01 -07:00
testqPrefCloudStorage.h tests: add signal test to call testqPref*cpp 2018-09-11 17:25:00 -07:00
testqPrefDisplay.cpp desktop: remove user survey 2020-04-19 14:27:54 -07:00
testqPrefDisplay.h tests: add signal test to call testqPref*cpp 2018-09-11 17:25:00 -07:00
testqPrefDiveComputer.cpp tests: correct testqPref*.cpp to use static qPref* functions. 2019-12-05 11:48:26 -08:00
testqPrefDiveComputer.h tests: add signal test to call testqPref*cpp 2018-09-11 17:25:00 -07:00
testqPrefDivePlanner.cpp tests: correct testqPref*.cpp to use static qPref* functions. 2019-12-05 11:48:26 -08:00
testqPrefDivePlanner.h tests: add signal test to call testqPref*cpp 2018-09-11 17:25:00 -07:00
testqPrefEquipment.cpp Equipment: Include Unused Tanks in Merge if Preference is Enabled. 2023-07-25 11:19:03 +12:00
testqPrefEquipment.h Preferences UI: create new equipment tab 2019-12-25 02:57:42 +09:00
testqPrefGeneral.cpp Preferences UI: add dive log tab 2019-12-25 02:57:42 +09:00
testqPrefGeneral.h tests: add signal test to call testqPref*cpp 2018-09-11 17:25:00 -07:00
testqPrefGeocoding.cpp tests: correct testqPref*.cpp to use static qPref* functions. 2019-12-05 11:48:26 -08:00
testqPrefGeocoding.h tests: add signal test to call testqPref*cpp 2018-09-11 17:25:00 -07:00
testqPrefLanguage.cpp tests: correct testqPref*.cpp to use static qPref* functions. 2019-12-05 11:48:26 -08:00
testqPrefLanguage.h tests: add signal test to call testqPref*cpp 2018-09-11 17:25:00 -07:00
testqPrefLog.cpp tests: fix TestQPrefLog 2019-12-29 12:31:43 -08:00
testqPrefLog.h Preferences: add some tests 2019-12-25 02:57:42 +09:00
testqPrefMedia.cpp Preferences: Create a test program for qPrefMedia 2019-12-25 02:57:42 +09:00
testqPrefMedia.h Preferences: Create a test program for qPrefMedia 2019-12-25 02:57:42 +09:00
testqPrefPartialPressureGas.cpp tests: correct testqPref*.cpp to use static qPref* functions. 2019-12-05 11:48:26 -08:00
testqPrefPartialPressureGas.h tests: add signal test to call testqPref*cpp 2018-09-11 17:25:00 -07:00
testqPrefProxy.cpp tests: correct testqPref*.cpp to use static qPref* functions. 2019-12-05 11:48:26 -08:00
testqPrefProxy.h tests: add signal test to call testqPref*cpp 2018-09-11 17:25:00 -07:00
testqPrefTechnicalDetails.cpp Desktop: Add a Button to Hide the Infobox in the Dive Profile. 2023-06-25 14:40:23 +02:00
testqPrefTechnicalDetails.h tests: add signal test to call testqPref*cpp 2018-09-11 17:25:00 -07:00
testqPrefUnits.cpp core/settings:: remove string functions for units 2020-01-20 09:55:26 -08:00
testqPrefUnits.h tests: add signal test to call testqPref*cpp 2018-09-11 17:25:00 -07:00
testqPrefUpdateManager.cpp preferences: remove pointless member 2021-01-06 10:18:23 -08:00
testqPrefUpdateManager.h tests: add signal test to call testqPref*cpp 2018-09-11 17:25:00 -07:00
testrenumber.cpp core: introduce divelog structure 2023-04-14 21:20:23 +02:00
testrenumber.h Whitespace cleanup tests 2018-07-26 16:32:51 +03:00
testtaglist.cpp core: use C++-primitives for g_tag_list 2024-04-23 07:47:11 +07:00
testtaglist.h Change taglist_get_tagstring to support 'unlimited' tag list size 2018-04-09 07:59:51 -07:00
testunitconversion.cpp core: move floating point functions to own header file 2022-08-30 22:34:38 +02:00
testunitconversion.h Whitespace cleanup tests 2018-07-26 16:32:51 +03:00
tst_qPrefCloudStorage.qml cloudstorage: some cleanup of cloud url handling 2021-04-19 12:51:01 -07:00
tst_qPrefDisplay.qml desktop: remove user survey 2020-04-19 14:27:54 -07:00
tst_qPrefDiveComputer.qml Tests: remove testing of download_mode 2018-10-15 19:46:18 +02:00
tst_qPrefDivePlanner.qml tests: add signal test to call tst_qPref*qml 2018-09-11 17:25:00 -07:00
tst_qPrefGeneral.qml tests: add signal test to call tst_qPref*qml 2018-09-11 17:25:00 -07:00
tst_qPrefGeocoding.qml tests: add signal test to call tst_qPref*qml 2018-09-11 17:25:00 -07:00
tst_qPrefLanguage.qml tests: add signal test to call tst_qPref*qml 2018-09-11 17:25:00 -07:00
tst_qPrefPartialPressureGas.qml tests: add signal test to call tst_qPref*qml 2018-09-11 17:25:00 -07:00
tst_qPrefProxy.qml tests: add signal test to call tst_qPref*qml 2018-09-11 17:25:00 -07:00
tst_qPrefTechnicalDetails.qml Equipment: Include Unused Tanks in Merge if Preference is Enabled. 2023-07-25 11:19:03 +12:00
tst_qPrefUnits.qml tests: add signal test to call tst_qPref*qml 2018-09-11 17:25:00 -07:00
tst_qPrefUpdateManager.qml tests: add signal test to call tst_qPref*qml 2018-09-11 17:25:00 -07:00