mirror of
https://github.com/subsurface/subsurface.git
synced 2025-02-19 22:16:15 +00:00
27810f3217
This one is extremely obscure: TankItem::setData(), which is called on every replot, was passed the DivePlotDataModel, even though it doesn't access that model at all. Instead, it connect()s to the model to stay informed of changes to the data. First of all, this should obviously be done once in the constructor, not on every replot. But also, the setData() function is called on every replot one lines before sending the model-changed signal. Thus, the tankitem was always repainted twice. Just remove the whole connect() thing and go for a more deterministic model. Should the tankbar not be repainted anywhere, add the appropriate calls there. Accordingly rename the "modelDataChanged" slot to "replot". Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
31 lines
712 B
C++
31 lines
712 B
C++
// SPDX-License-Identifier: GPL-2.0
|
|
#ifndef TANKITEM_H
|
|
#define TANKITEM_H
|
|
|
|
#include <QGraphicsItem>
|
|
#include <QBrush>
|
|
#include "profile-widget/divelineitem.h"
|
|
#include "profile-widget/divecartesianaxis.h"
|
|
#include "core/dive.h"
|
|
|
|
class TankItem : public QObject, public QGraphicsRectItem
|
|
{
|
|
Q_OBJECT
|
|
|
|
public:
|
|
explicit TankItem(QObject *parent = 0);
|
|
void setHorizontalAxis(DiveCartesianAxis *horizontal);
|
|
void setData(struct plot_info *plotInfo, struct dive *d);
|
|
|
|
public slots:
|
|
void replot();
|
|
|
|
private:
|
|
void createBar(int startTime, int stopTime, struct gasmix gas);
|
|
DiveCartesianAxis *hAxis;
|
|
int plotEndTime;
|
|
QBrush air, nitrox, oxygen, trimix;
|
|
QList<QGraphicsRectItem *> rects;
|
|
};
|
|
|
|
#endif // TANKITEM_H
|