mirror of
https://github.com/subsurface/subsurface.git
synced 2024-11-30 22:20:21 +00:00
152e6966c9
The copy/pasting of dive-sites was fundamentally broken in at least two ways: 1) The dive-site pointer in struct dive was simply overwritten, which breaks internal consistency. Also, no dive-site changed signals where sent. 2) The copied dive-site was stored as a pointer in a struct dive. Thus, the user could copy a dive, then delete the dive-site and paste. This would lead to a dangling pointer and ultimately crash the application. Fix this by storing the UUID of the dive-site, not a pointer. To do that, don't store a copy of the dive, but collect all the data in a `dive_paste_data` structure. If the dive site has been deleted on paste, do nothing. Send the appropriate signals on pasting. The mobile version had an additional bug: It kept a pointer to the dive to be copied, which might become stale by undo. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at> |
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| command.cpp | ||
| command.h | ||
| command_base.cpp | ||
| command_base.h | ||
| command_device.cpp | ||
| command_device.h | ||
| command_divelist.cpp | ||
| command_divelist.h | ||
| command_divesite.cpp | ||
| command_divesite.h | ||
| command_edit.cpp | ||
| command_edit.h | ||
| command_edit_trip.cpp | ||
| command_edit_trip.h | ||
| command_event.cpp | ||
| command_event.h | ||
| command_filter.cpp | ||
| command_filter.h | ||
| command_pictures.cpp | ||
| command_pictures.h | ||