mirror of
				https://github.com/subsurface/subsurface.git
				synced 2025-02-19 22:16:15 +00:00 
			
		
		
		
	When connecting a model to the TableModel class, it would connect clicking on an item to the remove() slot of the model. This breaks the program flow implied by the undo code: Ui --> Undo-Command --> Model --> UI Moreover, the naming of the remove() slot is illogical, because clicks can also have different effects, as for example in the cylinder-table. Therefore, move the connect() call from TableModel to the callers. In the case of TabDiveSite, move the remove() function from the model to the TabWidget, where it makes more sense. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
		
			
				
	
	
		
			52 lines
		
	
	
	
		
			1.1 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			52 lines
		
	
	
	
		
			1.1 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| // SPDX-License-Identifier: GPL-2.0
 | |
| #ifndef TABLEVIEW_H
 | |
| #define TABLEVIEW_H
 | |
| 
 | |
| /* This TableView is prepared to have the CSS,
 | |
|  * the methods to restore / save the state of
 | |
|  * the column widths and the 'plus' button.
 | |
|  */
 | |
| #include <QWidget>
 | |
| 
 | |
| #include "ui_tableview.h"
 | |
| 
 | |
| #include "core/metrics.h"
 | |
| 
 | |
| class QPushButton;
 | |
| class QAbstractItemModel;
 | |
| class QModelIndex;
 | |
| class QTableView;
 | |
| 
 | |
| class TableView : public QGroupBox {
 | |
| 	Q_OBJECT
 | |
| 
 | |
| 	struct TableMetrics {
 | |
| 		const IconMetrics* icon; // icon metrics
 | |
| 		int rm_col_width; // column width of REMOVE column
 | |
| 		int header_ht; // height of the header
 | |
| 	};
 | |
| public:
 | |
| 	TableView(QWidget *parent = 0);
 | |
| 	~TableView();
 | |
| 	void setModel(QAbstractItemModel *model);
 | |
| 	void setBtnToolTip(const QString &tooltip);
 | |
| 	void fixPlusPosition();
 | |
| 	void edit(const QModelIndex &index);
 | |
| 	int  defaultColumnWidth(int col); // default column width for column col
 | |
| 	QTableView *view();
 | |
| 
 | |
| protected:
 | |
| 	void showEvent(QShowEvent *) override;
 | |
| 	void resizeEvent(QResizeEvent *) override;
 | |
| 
 | |
| signals:
 | |
| 	void addButtonClicked();
 | |
| 	void itemClicked(const QModelIndex &);
 | |
| 
 | |
| private:
 | |
| 	Ui::TableView ui;
 | |
| 	QPushButton *plusBtn;
 | |
| 	TableMetrics metrics;
 | |
| };
 | |
| 
 | |
| #endif // TABLEVIEW_H
 |