subsurface/core/subsurface-qt
Berthold Stoeger dd8e4fae2a Make handling of booleans consistent on the C++-side of preferences
In general, the C++-side of the preferences code consistently uses
the bool data type for boolean settings. There are five exceptions,
which use short instead:
  showPo2
  showPn2
  showPhe
  saveUserIdLocal
  displayInvalidDives
This patch attempts to make the code more consistent by turning
these into bools as well.

Tests showed that writing as short and reading as bool is handled
gracefully by the Qt variant code. Therefore, an upgrade should not
cause user-visible changes to their settings.

As a bonus, two extern declarations of the set_save_userid_local()
function, which is not defined anywhere, were removed.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2017-11-20 20:56:13 +01:00
..
CylinderObjectHelper.cpp Add SPDX header to remaining core files 2017-04-29 13:32:55 -07:00
CylinderObjectHelper.h Add SPDX header to remaining core files 2017-04-29 13:32:55 -07:00
DiveObjectHelper.cpp QML UI: DiveList: add date box to trip header 2017-06-24 13:13:04 -07:00
DiveObjectHelper.h Add SPDX header to remaining core files 2017-04-29 13:32:55 -07:00
SettingsObjectWrapper.cpp Make handling of booleans consistent on the C++-side of preferences 2017-11-20 20:56:13 +01:00
SettingsObjectWrapper.h Make handling of booleans consistent on the C++-side of preferences 2017-11-20 20:56:13 +01:00