mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2024-11-28 13:10:19 +00:00
Code Issues Projects Releases Packages Wiki Activity
subsurface/desktop-widgets
History
Berthold Stoeger 360f07e453 Cleanup: pass gasmix by value 
In a previous commit, the get_gasmix_* functions were changed to
return by value. For consistency, also pass gasmix by value.

Note that on common 64-bit platforms struct gasmix is the size
of a pointer [2 * 32 bit vs. 64 bit] and therefore uses the
same space on the stack. On 32-bit platforms, the stack use
is probably doubled, but in return a dereference is avoided.

Supporting arbitrary gas-mixes (H2, Ar, ...) will be such an
invasive change that going back to pointers is probably the
least of our worries.

This commit is a step in const-ifying input parameters (passing
by value is the ultimate way of signaling that the input parameter
will not be changed [unless there are references to said parameter]).

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2018-08-23 05:16:38 -07:00
..
css
plugins desktop-widgets/facebook: remove SettingsObjectWrapper 2018-08-15 16:11:39 -07:00
preferences desktop-widgets/preferences: reemove SettingsObjectWrapper 2018-08-15 16:11:39 -07:00
statistics Cleanup: remove all override modifiers 2018-08-01 06:30:00 -07:00
tab-widgets Cleanup: pass gasmix by value 2018-08-23 05:16:38 -07:00
about.cpp Get ready for 2018 2017-12-30 08:23:22 -08:00
about.h Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
about.ui Use icons relative path. 2017-11-30 23:14:46 -08:00
btdeviceselectiondialog.cpp Bluetooth: don't call deviceDiscoveryError() on scan finished 2018-07-18 02:11:16 +03:00
btdeviceselectiondialog.h Cleanup: remove all override modifiers 2018-08-01 06:30:00 -07:00
btdeviceselectiondialog.ui Introduce mode field in Bluetooth device selection dialog 2017-11-16 14:26:51 +01:00
CMakeLists.txt Dive pictures: implement FindMovedImagesDialog 2018-07-04 02:27:36 +08:00
configuredivecomputerdialog.cpp desktop-widget: remove SettingsObjectWrapper and update qPref calls 2018-08-15 16:11:39 -07:00
configuredivecomputerdialog.h Cleanup: remove all override modifiers 2018-08-01 06:30:00 -07:00
configuredivecomputerdialog.ui Configure ostc3: Remove obsoleted setting 2018-04-27 21:33:47 +03:00
divecomponentselection.ui Use icons relative path. 2017-11-30 23:14:46 -08:00
divecomputermanagementdialog.cpp Dive computers: turn QMultiMap into sorted vector 2018-06-17 06:53:13 +09:00
divecomputermanagementdialog.h Cleanup: fold DiveComputerManagementDialog::update() into init() 2018-06-17 06:53:13 +09:00
divecomputermanagementdialog.ui Use icons relative path. 2017-11-30 23:14:46 -08:00
divelistview.cpp Cleanup: remove DiveListView::fixMessyQtModelBehaviour() 2018-07-30 12:21:17 -07:00
divelistview.h Cleanup: remove all override modifiers 2018-08-01 06:30:00 -07:00
divelogexportdialog.cpp Cleanup: pass gasmix by value 2018-08-23 05:16:38 -07:00
divelogexportdialog.h Cleanup: fold core/helpers.h into core/qthelper.h 2018-06-04 08:50:10 -07:00
divelogexportdialog.ui Use icons relative path. 2017-11-30 23:14:46 -08:00
divelogimportdialog.cpp desktop-widgets: Change Q_UNUSED to no parameter name 2018-05-21 12:48:04 -07:00
divelogimportdialog.h Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
divelogimportdialog.ui Use icons relative path. 2017-11-30 23:14:46 -08:00
divepicturewidget.cpp Dive media: transport dive-id in drag'n'drop events 2018-07-18 09:06:37 -07:00
divepicturewidget.h Cleanup: remove all override modifiers 2018-08-01 06:30:00 -07:00
diveplanner.cpp desktop-widget: remove SettingsObjectWrapper and update qPref calls 2018-08-15 16:11:39 -07:00
diveplanner.h Cleanup: replace virtual by override where appropriate 2018-07-31 11:02:34 +02:00
diveplanner.ui Choose water presets from a qcombobox in planner, custom value possible 2018-03-02 08:38:22 -08:00
diveshareexportdialog.cpp Cleanup: Don't clear WA_QuitOnClose attribute on dialogs 2018-06-16 04:02:47 -07:00
diveshareexportdialog.h Random whitespace cleanup 2017-05-27 11:07:20 -07:00
diveshareexportdialog.ui
downloadfromdivecomputer.cpp desktop-widget: remove SettingsObjectWrapper and update qPref calls 2018-08-15 16:11:39 -07:00
downloadfromdivecomputer.h Fix memory leak in download-from-dive-computer widget 2017-11-11 21:01:42 +01:00
downloadfromdivecomputer.ui Use icons relative path. 2017-11-30 23:14:46 -08:00
filterwidget.ui Use better aliases for icons. 2017-11-30 23:14:46 -08:00
findmovedimagesdialog.cpp UI change of "images"/"photo" to "media" or "media files" 2018-07-15 09:38:12 -07:00
findmovedimagesdialog.h Dive pictures: implement FindMovedImagesDialog 2018-07-04 02:27:36 +08:00
findmovedimagesdialog.ui UI change of "images"/"photo" to "media" or "media files" 2018-07-15 09:38:12 -07:00
groupedlineedit.cpp Unused code: GroupedLineEdit::removeAllColors() 2018-01-10 16:45:42 +01:00
groupedlineedit.h Cleanup: remove all override modifiers 2018-08-01 06:30:00 -07:00
kmessagewidget.cpp Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
kmessagewidget.h Cleanup: remove all override modifiers 2018-08-01 06:30:00 -07:00
listfilter.ui Add tool tip for negate filter button 2017-12-30 08:15:11 -08:00
locationinformation.cpp desktop: fix multi-keystroke input on location 2018-06-26 08:06:07 +02:00
locationinformation.h Cleanup: remove all override modifiers 2018-08-01 06:30:00 -07:00
locationInformation.ui Use correct alias for satellite icon for revers geo lookup 2018-01-27 12:29:00 -08:00
mainwindow.cpp desktop-widget: remove SettingsObjectWrapper and update qPref calls 2018-08-15 16:11:39 -07:00
mainwindow.h Cleanup: replace virtual by override where appropriate 2018-07-31 11:02:34 +02:00
mainwindow.ui UI change of "images"/"photo" to "media" or "media files" 2018-07-15 09:38:12 -07:00
mapwidget.cpp desktop-widget: move qmlRegister from mapwidget to shared helper 2018-07-12 08:08:00 -07:00
mapwidget.h map-widget: allow real-time updates of edited markers 2017-11-09 12:40:25 -08:00
modeldelegates.cpp Localization: remove gettextFromC::instance() 2018-06-24 20:31:14 +02:00
modeldelegates.h Cleanup: remove all override modifiers 2018-08-01 06:30:00 -07:00
notificationwidget.cpp Use queued connection to thread-safe MainWindow error handling 2018-01-31 14:47:26 +01:00
notificationwidget.h Use queued connection to thread-safe MainWindow error handling 2018-01-31 14:47:26 +01:00
plannerDetails.ui Bring back style sheet HTML for planner output 2017-02-24 01:06:09 -08:00
plannerSettings.ui Planner and profile limit minimum GFlow to 10 and minimum GFhigh to 40 2017-11-13 11:53:55 +01:00
printdialog.cpp desktop-widgets: Change Q_UNUSED to no parameter name 2018-05-21 12:48:04 -07:00
printdialog.h Cleanup: replace virtual by override where appropriate 2018-07-31 11:02:34 +02:00
printer.cpp desktop-widget: remove SettingsObjectWrapper and update qPref calls 2018-08-15 16:11:39 -07:00
printer.h Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
printoptions.cpp Cleanup: fold core/helpers.h into core/qthelper.h 2018-06-04 08:50:10 -07:00
printoptions.h cleanup: Uninitialized pointer field 2017-12-29 09:14:20 -08:00
printoptions.ui
qtwaitingspinner.cpp
qtwaitingspinner.h
renumber.ui Use icons relative path. 2017-11-30 23:14:46 -08:00
searchbar.ui Use better aliases for icons. 2017-11-30 23:14:46 -08:00
setpoint.ui Use icons relative path. 2017-11-30 23:14:46 -08:00
shiftimagetimes.ui UI change of "images"/"photo" to "media" or "media files" 2018-07-15 09:38:12 -07:00
shifttimes.ui Use icons relative path. 2017-11-30 23:14:46 -08:00
simplewidgets.cpp Cleanup: remove DiveListView::fixMessyQtModelBehaviour() 2018-07-30 12:21:17 -07:00
simplewidgets.h Cleanup: remove all override modifiers 2018-08-01 06:30:00 -07:00
starwidget.cpp Cleanup: remove parameter from currentDiveChanged signal 2018-07-30 12:20:26 -07:00
starwidget.h Cleanup: remove all override modifiers 2018-08-01 06:30:00 -07:00
subsurfacewebservices.cpp core: activate qPrefCloudStorage 2018-07-21 07:49:25 -07:00
subsurfacewebservices.h Cleanup: remove all override modifiers 2018-08-01 06:30:00 -07:00
tableview.cpp Use better aliases for icons. 2017-11-30 23:14:46 -08:00
tableview.h Cleanup: remove all override modifiers 2018-08-01 06:30:00 -07:00
tableview.ui
tagwidget.cpp Show all autocompletes after entry of comma in tag list 2017-11-17 09:19:03 +01:00
tagwidget.h Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
templateedit.cpp Fix includes for building against Qt-5.11.0 2018-05-23 13:29:37 +03:00
templateedit.h Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
templateedit.ui templateedit.ui: give the layout for "Border width" unique name 2017-03-12 09:19:03 -07:00
templatelayout.cpp Cleanup: fold core/helpers.h into core/qthelper.h 2018-06-04 08:50:10 -07:00
templatelayout.h Translations: unify gettextFromC::tr() and QObject::tr() 2018-07-04 05:33:31 +08:00
undocommands.cpp Undo: remember deleted trip in UndoRemoveDivesFromTrip::undo() 2018-07-19 02:43:08 +03:00
undocommands.h Cleanup: remove all override modifiers 2018-08-01 06:30:00 -07:00
updatemanager.cpp desktop-widget: remove SettingsObjectWrapper and update qPref calls 2018-08-15 16:11:39 -07:00
updatemanager.h Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
urldialog.ui UI change of "images"/"photo" to "media" or "media files" 2018-07-15 09:38:12 -07:00
usermanual.cpp Cleanup: fold core/helpers.h into core/qthelper.h 2018-06-04 08:50:10 -07:00
usermanual.h Desktop: Derive UserManual from QDialog 2018-05-31 21:29:29 +03:00
usersurvey.cpp Cleanup: fold core/helpers.h into core/qthelper.h 2018-06-04 08:50:10 -07:00
usersurvey.h Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
usersurvey.ui fix: User survey UI. 2017-03-06 06:40:00 -08:00
webservices.ui Use icons relative path. 2017-11-30 23:14:46 -08:00