mirror of
https://github.com/subsurface/subsurface.git
synced 2024-11-28 05:00:20 +00:00
f4b948e80d
When populating the events of a profile, a pointer to the current gasmix was passed around to properly calculate isobaric_counterdiffusion. The DiveEventItem::setupToolTipString() function updated this gasmix when processing gas change events. I inadvertently broke the code when replacing gasmix-pointers by values. We could of course simply revert this part of the commit. However, the data flow was horrible anyway: for example is supposed that the setup functions were called in the correct order (i.e. DiveEventItem::setupToolTipString() is called after all other functions using the gasmix). Not exactly easy to follow. Therefore, keep passing around the gasmix as value to make it clear that the functions don't modify it. Keep the gasmix up-to-date at the caller's site in ProfileWidget2::plotDive(). Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at> |
||
|---|---|---|
| .. | ||
| animationfunctions.cpp | ||
| animationfunctions.h | ||
| CMakeLists.txt | ||
| divecartesianaxis.cpp | ||
| divecartesianaxis.h | ||
| diveeventitem.cpp | ||
| diveeventitem.h | ||
| divelineitem.cpp | ||
| divelineitem.h | ||
| divepixmapitem.cpp | ||
| divepixmapitem.h | ||
| diveprofileitem.cpp | ||
| diveprofileitem.h | ||
| diverectitem.cpp | ||
| diverectitem.h | ||
| divetextitem.cpp | ||
| divetextitem.h | ||
| divetooltipitem.cpp | ||
| divetooltipitem.h | ||
| profilewidget2.cpp | ||
| profilewidget2.h | ||
| qmlprofile.cpp | ||
| qmlprofile.h | ||
| ruleritem.cpp | ||
| ruleritem.h | ||
| tankitem.cpp | ||
| tankitem.h | ||