mirror of
https://github.com/subsurface/subsurface.git
synced 2024-11-28 05:00:20 +00:00
4b801f1f50
The DivePlannerPointsModel::createTemporaryPlan() function had two distinct and independent parts: 1) create the data points. 2) create the dive sample and calculate variations. The second part was only exectuted if the recalc flag was set. Out of the two callers, one was explicitly disabling and setting the recalc flag to avoid the second part. The much more logical thing is to simply split the function in two and only call the first part. To avoid any functional change, the second caller (the profile) still tests for the recalc flag. However, if it shouldn't replot a new plan, why calculate it in the first place!? And why does the display function change the plan at all? This appears all very ill-thought out and should be changed in due course. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at> |
||
|---|---|---|
| .. | ||
| animationfunctions.cpp | ||
| animationfunctions.h | ||
| CMakeLists.txt | ||
| divecartesianaxis.cpp | ||
| divecartesianaxis.h | ||
| diveeventitem.cpp | ||
| diveeventitem.h | ||
| divehandler.cpp | ||
| divehandler.h | ||
| divelineitem.cpp | ||
| divelineitem.h | ||
| divepixmapitem.cpp | ||
| divepixmapitem.h | ||
| diveprofileitem.cpp | ||
| diveprofileitem.h | ||
| diverectitem.cpp | ||
| diverectitem.h | ||
| divetextitem.cpp | ||
| divetextitem.h | ||
| divetooltipitem.cpp | ||
| divetooltipitem.h | ||
| profilewidget2.cpp | ||
| profilewidget2.h | ||
| qmlprofile.cpp | ||
| qmlprofile.h | ||
| ruleritem.cpp | ||
| ruleritem.h | ||
| tankitem.cpp | ||
| tankitem.h | ||