mirror of
https://github.com/subsurface/subsurface.git
synced 2024-11-28 05:00:20 +00:00
a748e7f239
Internal floating point (FP) calculations should be performed using double unless there is a very good reason. This avoids headaches with conversions. Indeed, the vast majority of FP calculations were already done using double. This patch adapts most remaining calculations. Not converted where things that were based on binary representations and variables which weren't used anyway. An analysis of all instances follows: core/plannernotes.c, l.404: This was a comparison between two floats. On the left side, first an integer was cast to float then multiplied with and integer and divided by a constant double. The right hand side was an integer cast to a float. Simply divide by 1000.0 first to convert to double and continue with calculations. On the right hand side, remove the cast, because the integer will be implicitely cast to double for comparison. This conversion actually emits less instructions, because no conversion to double and back is performed. core/planner.c, l.613: Same analysis as previous case. subsurface-desktop-main.cpp, l.155: A local variable representing the version OpenGL version. Turn this into integer logic. Not only does this avoid dreaded FP rounding issues, it also works correctly for minor version > 10 (not that such a thing is to be expected anytime soon). abstractpreferenceswidget.[h/cpp]: A widget where the position is described as a float. Turn into double. desktop-widgets/divelogexportdialog.cpp, l.313: total_weight is described as float. Use double arithmetics instead. This instance fixes a truncation warning emitted by gcc.
22 lines
488 B
C++
22 lines
488 B
C++
// SPDX-License-Identifier: GPL-2.0
|
|
#include "abstractpreferenceswidget.h"
|
|
|
|
AbstractPreferencesWidget::AbstractPreferencesWidget(const QString& name, const QIcon& icon, double positionHeight)
|
|
: QWidget(), _icon(icon), _name(name), _positionHeight(positionHeight)
|
|
{
|
|
}
|
|
|
|
QIcon AbstractPreferencesWidget::icon() const
|
|
{
|
|
return _icon;
|
|
}
|
|
|
|
QString AbstractPreferencesWidget::name() const
|
|
{
|
|
return _name;
|
|
}
|
|
|
|
double AbstractPreferencesWidget::positionHeight() const
|
|
{
|
|
return _positionHeight;
|
|
}
|