mirror of
https://github.com/subsurface/subsurface.git
synced 2024-11-28 05:00:20 +00:00
152e6966c9
The copy/pasting of dive-sites was fundamentally broken in at least two ways: 1) The dive-site pointer in struct dive was simply overwritten, which breaks internal consistency. Also, no dive-site changed signals where sent. 2) The copied dive-site was stored as a pointer in a struct dive. Thus, the user could copy a dive, then delete the dive-site and paste. This would lead to a dangling pointer and ultimately crash the application. Fix this by storing the UUID of the dive-site, not a pointer. To do that, don't store a copy of the dive, but collect all the data in a `dive_paste_data` structure. If the dive site has been deleted on paste, do nothing. Send the appropriate signals on pasting. The mobile version had an additional bug: It kept a pointer to the dive to be copied, which might become stale by undo. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
135 lines
3 KiB
C++
135 lines
3 KiB
C++
// SPDX-License-Identifier: GPL-2.0
|
|
#ifndef SIMPLEWIDGETS_H
|
|
#define SIMPLEWIDGETS_H
|
|
|
|
class MinMaxAvgWidgetPrivate;
|
|
class QAbstractButton;
|
|
class QNetworkReply;
|
|
class FilterModelBase;
|
|
struct dive;
|
|
|
|
#include "core/units.h"
|
|
#include <QWidget>
|
|
#include <QGroupBox>
|
|
#include <QDialog>
|
|
#include <QTextEdit>
|
|
|
|
#include "ui_renumber.h"
|
|
#include "ui_setpoint.h"
|
|
#include "ui_shifttimes.h"
|
|
#include "ui_shiftimagetimes.h"
|
|
#include "ui_urldialog.h"
|
|
#include "ui_listfilter.h"
|
|
#include "ui_addfilterpreset.h"
|
|
|
|
class RenumberDialog : public QDialog {
|
|
Q_OBJECT
|
|
public:
|
|
explicit RenumberDialog(bool selectedOnly, QWidget *parent);
|
|
private
|
|
slots:
|
|
void buttonClicked(QAbstractButton *button);
|
|
|
|
private:
|
|
Ui::RenumberDialog ui;
|
|
bool selectedOnly;
|
|
};
|
|
|
|
class SetpointDialog : public QDialog {
|
|
Q_OBJECT
|
|
public:
|
|
SetpointDialog(struct dive *d, int dcNr, int time);
|
|
private
|
|
slots:
|
|
void buttonClicked(QAbstractButton *button);
|
|
|
|
private:
|
|
Ui::SetpointDialog ui;
|
|
struct dive *d;
|
|
int dcNr;
|
|
int time;
|
|
};
|
|
|
|
class ShiftTimesDialog : public QDialog {
|
|
Q_OBJECT
|
|
public:
|
|
// Must be called with non-empty dives vector!
|
|
explicit ShiftTimesDialog(std::vector<dive *> dives, QWidget *parent);
|
|
private
|
|
slots:
|
|
void buttonClicked(QAbstractButton *button);
|
|
void changeTime();
|
|
|
|
private:
|
|
int64_t when;
|
|
std::vector<dive *> dives;
|
|
Ui::ShiftTimesDialog ui;
|
|
};
|
|
|
|
class ShiftImageTimesDialog : public QDialog {
|
|
Q_OBJECT
|
|
public:
|
|
explicit ShiftImageTimesDialog(QWidget *parent, QStringList fileNames);
|
|
time_t amount() const;
|
|
void setOffset(time_t offset);
|
|
bool matchAll();
|
|
private
|
|
slots:
|
|
void syncCameraClicked();
|
|
void dcDateTimeChanged(const QDateTime &);
|
|
void timeEdited(const QString &timeText);
|
|
void backwardsChanged(bool);
|
|
void updateInvalid();
|
|
void matchAllImagesToggled(bool);
|
|
|
|
private:
|
|
QStringList fileNames;
|
|
QVector<timestamp_t> timestamps;
|
|
Ui::ShiftImageTimesDialog ui;
|
|
time_t m_amount;
|
|
time_t dcImageEpoch;
|
|
bool matchAllImages;
|
|
};
|
|
|
|
class URLDialog : public QDialog {
|
|
Q_OBJECT
|
|
public:
|
|
explicit URLDialog(QWidget *parent);
|
|
QString url() const;
|
|
private:
|
|
Ui::URLDialog ui;
|
|
};
|
|
|
|
class AddFilterPresetDialog : public QDialog {
|
|
Q_OBJECT
|
|
public:
|
|
explicit AddFilterPresetDialog(const QString &defaultName, QWidget *parent);
|
|
QString doit(); // returns name of filter preset or empty string if user cancelled the dialog
|
|
private
|
|
slots:
|
|
void nameChanged(const QString &text);
|
|
private:
|
|
Ui::AddFilterPresetDialog ui;
|
|
};
|
|
|
|
class TextHyperlinkEventFilter : public QObject {
|
|
Q_OBJECT
|
|
public:
|
|
explicit TextHyperlinkEventFilter(QTextEdit *txtEdit);
|
|
|
|
bool eventFilter(QObject *target, QEvent *evt) override;
|
|
|
|
private:
|
|
void handleUrlClick(const QString &urlStr);
|
|
void handleUrlTooltip(const QString &urlStr, const QPoint &pos);
|
|
bool stringMeetsOurUrlRequirements(const QString &maybeUrlStr);
|
|
QString fromCursorTilWhitespace(QTextCursor *cursor, bool searchBackwards);
|
|
QString tryToFormulateUrl(QTextCursor *cursor);
|
|
|
|
QTextEdit const *const textEdit;
|
|
QWidget const *const scrollView;
|
|
|
|
Q_DISABLE_COPY(TextHyperlinkEventFilter)
|
|
};
|
|
|
|
#endif // SIMPLEWIDGETS_H
|