mirror of
https://github.com/subsurface/subsurface.git
synced 2024-11-28 05:00:20 +00:00
a9b1fbdcc5
The native buffer of a membuffer is not NUL-terminated, so when you want to detach it and use it as a C string, you had to first do 'mb_cstring()' that adds the proper termination/ This was all documented in the header files, and all but two users did it correctly. But there were those two users, and the exported interface was unnecessarily hard to use. We do want the "just detach the raw buffer" internally in the membuffer code, but let's not make the exported interface be that hard to use. So this switches the exported interface to be 'detach_cstring()', which does that 'mb_cstring()' for you, and avoids the possibility that you'd use a non-terminated memory buffer as a C string. The old 'detach_buffer()' is now purely the internal membuffer implementation, and not used by others. Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
33 lines
720 B
C
33 lines
720 B
C
// SPDX-License-Identifier: GPL-2.0
|
|
#ifdef __clang__
|
|
// Clang has a bug on zero-initialization of C structs.
|
|
#pragma clang diagnostic ignored "-Wmissing-field-initializers"
|
|
#endif
|
|
#include <stdarg.h>
|
|
#include "errorhelper.h"
|
|
#include "membuffer.h"
|
|
|
|
#define VA_BUF(b, fmt) do { va_list args; va_start(args, fmt); put_vformat(b, fmt, args); va_end(args); } while (0)
|
|
|
|
int verbose;
|
|
|
|
static void (*error_cb)(char *) = NULL;
|
|
|
|
int report_error(const char *fmt, ...)
|
|
{
|
|
struct membuffer buf = { 0 };
|
|
|
|
/* if there is no error callback registered, don't produce errors */
|
|
if (!error_cb)
|
|
return -1;
|
|
|
|
VA_BUF(&buf, fmt);
|
|
error_cb(detach_cstring(&buf));
|
|
|
|
return -1;
|
|
}
|
|
|
|
void set_error_cb(void(*cb)(char *))
|
|
{
|
|
error_cb = cb;
|
|
}
|