mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2024-11-28 05:00:20 +00:00
Code Issues Projects Releases Packages Wiki Activity
subsurface/qt-models
History
Michael Keller 10fc3bfd47 Bugfix: Fix Incorrect Volumes Displayed for Tank Types. 
Fix an issue introduced in #4148.
Essentially the refactoring missed the fact that in the imperial system
tank size is tracked as the free gas volume, but in the metric system
(which is the one used in most of Subsurface's calculations) tank size
is tracked as water capacity.
So when updating a tank template tracking imperial measurements, the
given (metric) volume in l has to be multiplied by the working pressure,
and vice versa.
This also combines all the logic dealing with `tank_info` data in one
place, hopefully making it less likely that this will be broken by
inconsistencies in the future.

Fixes #4239.

Signed-off-by: Michael Keller <github@ike.ch>
2024-06-09 11:15:59 +02:00
..
cleanertablemodel.cpp Cleanup: return directly from data() methods 2019-06-19 13:11:10 -07:00
cleanertablemodel.h CylindersModel: fold CHANGED() macro into setData() 2020-04-07 00:13:35 +02:00
CMakeLists.txt build-system: make map support its own thing 2022-04-18 07:24:38 +02:00
completionmodels.cpp core: use C++-primitives for g_tag_list 2024-04-23 07:47:11 +07:00
completionmodels.h core: replace dive master by dive guide 2022-02-15 09:35:43 -08:00
cylindermodel.cpp Desktop: Fix Gas Editing for Manually Added Dives. 2024-06-01 23:22:40 +12:00
cylindermodel.h Equipment: Include Unused Tanks in Merge if Preference is Enabled. 2023-07-25 11:19:03 +12:00
divecomputerextradatamodel.cpp cleanup: split out divecomputer functions from dive.c 2020-10-25 13:59:52 -07:00
divecomputerextradatamodel.h cleanup: generalize ExtraDataModel to display data of any dc 2020-05-07 08:46:15 -07:00
diveimportedmodel.cpp core: use divelog struct in downloader code 2023-04-14 21:20:23 +02:00
diveimportedmodel.h core: use divelog in importDives() and process_imported_dives() 2023-04-14 21:20:23 +02:00
divelocationmodel.cpp core: replace SSRF_INFO macro by report_info() 2024-03-12 10:31:07 -04:00
divelocationmodel.h desktop: fix saving of column-widths of device and site tables 2020-11-07 11:37:51 -08:00
divepicturemodel.cpp cleanup: more Coverity silencing 2024-01-17 14:23:19 -08:00
divepicturemodel.h undo: make picture (media) deletion undoable 2020-05-06 13:58:09 -07:00
diveplannermodel.cpp Desktop: Fix Gas Editing for Manually Added Dives. 2024-06-01 23:22:40 +12:00
diveplannermodel.h Desktop: Fix Gas Editing for Manually Added Dives. 2024-06-01 23:22:40 +12:00
divesiteimportmodel.cpp Desktop: Fix build for Qt6 2023-04-26 07:14:07 +02:00
divesiteimportmodel.h Create DivesiteImportDialog to select sites to import 2019-05-06 10:48:44 +02:00
divesummarymodel.cpp Ignore invalid dives in subsurface-mobile dive summary 2021-10-11 20:20:20 +03:00
divesummarymodel.h mobile/summary: add section headers 2020-02-08 10:29:36 -08:00
divetripmodel.cpp cleanup: remove unused roles in DiveTripModelBase 2024-06-05 09:16:32 +12:00
divetripmodel.h cleanup: remove unused roles in DiveTripModelBase 2024-06-05 09:16:32 +12:00
filterconstraintmodel.cpp filter: add filter constraint model 2020-09-29 16:13:03 -07:00
filterconstraintmodel.h filter: add filter constraint model 2020-09-29 16:13:03 -07:00
filtermodels.cpp selection: rename selectionChanged() to divesSelected() 2023-04-16 20:23:59 +02:00
filtermodels.h selection: move current dc logic to profile widget 2023-04-16 20:23:59 +02:00
filterpresetmodel.cpp core: port filterpreset.cpp to std::string 2024-03-10 11:01:42 +13:00
filterpresetmodel.h filter: connect DiveListNotifier signals to filter preset model 2020-09-29 16:13:03 -07:00
maplocationmodel.cpp cleanup: replace Q_FOREACH and foreach by range base for 2024-03-24 17:53:19 +01:00
maplocationmodel.h Cleanup: lower-case filenames in core/subsurface-qt/ 2020-02-04 02:16:46 +01:00
messagehandlermodel.cpp core: replace SSRF_INFO macro by report_info() 2024-03-12 10:31:07 -04:00
messagehandlermodel.h Cleanup: reinstate override modifiers 2018-09-29 15:23:25 -07:00
mobilelistmodel.cpp core: replace dive master by dive guide 2022-02-15 09:35:43 -08:00
mobilelistmodel.h core: replace dive master by dive guide 2022-02-15 09:35:43 -08:00
models.cpp desktop: unglobalize ComboBox-models 2024-04-16 08:56:49 +12:00
models.h desktop: unglobalize ComboBox-models 2024-04-16 08:56:49 +12:00
tankinfomodel.cpp Bugfix: Fix Incorrect Volumes Displayed for Tank Types. 2024-06-09 11:15:59 +02:00
tankinfomodel.h desktop: unglobalize ComboBox-models 2024-04-16 08:56:49 +12:00
treemodel.cpp Cleanup: make DiveTripModel a global object 2018-09-01 07:48:43 -07:00
treemodel.h Cleanup: reinstate override modifiers 2018-09-29 15:23:25 -07:00
weightmodel.cpp desktop: unglobalize ComboBox-models 2024-04-16 08:56:49 +12:00
weightmodel.h cleanup: replace to "dive.h" includes by more specific includes 2020-05-15 14:19:21 -07:00
weightsysteminfomodel.cpp desktop: unglobalize ComboBox-models 2024-04-16 08:56:49 +12:00
weightsysteminfomodel.h desktop: unglobalize ComboBox-models 2024-04-16 08:56:49 +12:00
yearlystatisticsmodel.cpp Desktop: Fix build for Qt6 2023-04-26 07:14:07 +02:00
yearlystatisticsmodel.h Show average max depth in yearly statistics 2018-12-17 12:18:26 +01:00