mirror of
https://github.com/subsurface/subsurface.git
synced 2025-02-19 22:16:15 +00:00
78e2560296
The keeps track of different sub widgets needed by other parts of the code, notably: MainTab PlannerDetails PlannerSettingsWidget ProfileWidget2 DivePlannerWidget DiveListView Access to these widgets was provided with accessor functions. Now these functions were very weird: instead of simply returning pointers that were stored in the class, they accessed a data structure which describes the different application states. But this data structure was "duck-typed", so there was an implicit agreement at which position the pointers to the widgets were put inside. The widgets were then down-cast by the accessor functions. This might make sense if the individual widgets could for some reason be replaced by other widgets [dynamic plugins?], but even then it would be strange, as one would expect to get a pointer to some base class. Therefore, directly store the properly typed pointers to the widgets and simply remove the accessor functions. Why bother? Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at> |
||
|---|---|---|
| .. | ||
| maintab.cpp | ||
| maintab.h | ||
| maintab.ui | ||
| TabBase.cpp | ||
| TabBase.h | ||
| TabDiveExtraInfo.cpp | ||
| TabDiveExtraInfo.h | ||
| TabDiveExtraInfo.ui | ||
| TabDiveInformation.cpp | ||
| TabDiveInformation.h | ||
| TabDiveInformation.ui | ||
| TabDivePhotos.cpp | ||
| TabDivePhotos.h | ||
| TabDivePhotos.ui | ||
| TabDiveStatistics.cpp | ||
| TabDiveStatistics.h | ||
| TabDiveStatistics.ui | ||