mirror of
https://github.com/subsurface/subsurface.git
synced 2025-02-19 22:16:15 +00:00
769aca9e95
In a number of places the global 'tank_info' array is being iterated based on a 'tank_info[idx].name != NULL' condition. This is dangerous because if the user has added a lot of tanks, such loops can reach 'tank_info[MAX_TANK_INFO]'. This is an out of bounds read and if the 'name' pointer there happens to be non-NULL, passing that address to a peace of code that tries to read it (like strlen()) would either SIGSEGV or have undefined behavior. Clamp all loops that iterate 'tank_info' to MAX_TANK_INFO. Signed-off-by: Lubomir I. Ivanov <neolit123@gmail.com>
97 lines
3.5 KiB
C++
97 lines
3.5 KiB
C++
// SPDX-License-Identifier: GPL-2.0
|
|
#include "preferences_defaults.h"
|
|
#include "ui_preferences_defaults.h"
|
|
#include "core/prefs-macros.h"
|
|
#include "core/subsurface-qt/SettingsObjectWrapper.h"
|
|
|
|
#include <QFileDialog>
|
|
|
|
PreferencesDefaults::PreferencesDefaults(): AbstractPreferencesWidget(tr("General"), QIcon(":preferences-other-icon"), 0 ), ui(new Ui::PreferencesDefaults())
|
|
{
|
|
ui->setupUi(this);
|
|
}
|
|
|
|
PreferencesDefaults::~PreferencesDefaults()
|
|
{
|
|
delete ui;
|
|
}
|
|
|
|
void PreferencesDefaults::on_chooseFile_clicked()
|
|
{
|
|
QFileInfo fi(system_default_filename());
|
|
QString choosenFileName = QFileDialog::getOpenFileName(this, tr("Open default log file"), fi.absolutePath(), tr("Subsurface files") + " (*.ssrf *.xml)");
|
|
|
|
if (!choosenFileName.isEmpty())
|
|
ui->defaultfilename->setText(choosenFileName);
|
|
}
|
|
|
|
void PreferencesDefaults::on_btnUseDefaultFile_toggled(bool toggle)
|
|
{
|
|
if (toggle) {
|
|
ui->defaultfilename->setText(system_default_filename());
|
|
ui->defaultfilename->setEnabled(false);
|
|
} else {
|
|
ui->defaultfilename->setEnabled(true);
|
|
}
|
|
}
|
|
|
|
void PreferencesDefaults::on_localDefaultFile_toggled(bool toggle)
|
|
{
|
|
ui->defaultfilename->setEnabled(toggle);
|
|
ui->btnUseDefaultFile->setEnabled(toggle);
|
|
ui->chooseFile->setEnabled(toggle);
|
|
}
|
|
|
|
void PreferencesDefaults::refreshSettings()
|
|
{
|
|
ui->font->setCurrentFont(QString(prefs.divelist_font));
|
|
ui->fontsize->setValue(prefs.font_size);
|
|
ui->defaultfilename->setText(prefs.default_filename);
|
|
ui->noDefaultFile->setChecked(prefs.default_file_behavior == NO_DEFAULT_FILE);
|
|
ui->cloudDefaultFile->setChecked(prefs.default_file_behavior == CLOUD_DEFAULT_FILE);
|
|
ui->localDefaultFile->setChecked(prefs.default_file_behavior == LOCAL_DEFAULT_FILE);
|
|
|
|
ui->default_cylinder->clear();
|
|
for (int i = 0; tank_info[i].name != NULL && i < MAX_TANK_INFO; i++) {
|
|
ui->default_cylinder->addItem(tank_info[i].name);
|
|
if (prefs.default_cylinder && strcmp(tank_info[i].name, prefs.default_cylinder) == 0)
|
|
ui->default_cylinder->setCurrentIndex(i);
|
|
}
|
|
ui->displayinvalid->setChecked(prefs.display_invalid_dives);
|
|
ui->velocitySlider->setValue(prefs.animation_speed);
|
|
ui->btnUseDefaultFile->setChecked(prefs.use_default_file);
|
|
|
|
if (prefs.cloud_verification_status == CS_VERIFIED) {
|
|
ui->cloudDefaultFile->setEnabled(true);
|
|
} else {
|
|
if (ui->cloudDefaultFile->isChecked())
|
|
ui->noDefaultFile->setChecked(true);
|
|
ui->cloudDefaultFile->setEnabled(false);
|
|
}
|
|
|
|
ui->defaultfilename->setEnabled(prefs.default_file_behavior == LOCAL_DEFAULT_FILE);
|
|
ui->btnUseDefaultFile->setEnabled(prefs.default_file_behavior == LOCAL_DEFAULT_FILE);
|
|
ui->chooseFile->setEnabled(prefs.default_file_behavior == LOCAL_DEFAULT_FILE);
|
|
}
|
|
|
|
void PreferencesDefaults::syncSettings()
|
|
{
|
|
auto general = SettingsObjectWrapper::instance()->general_settings;
|
|
general->setDefaultFilename(ui->defaultfilename->text());
|
|
general->setDefaultCylinder(ui->default_cylinder->currentText());
|
|
general->setUseDefaultFile(ui->btnUseDefaultFile->isChecked());
|
|
if (ui->noDefaultFile->isChecked())
|
|
general->setDefaultFileBehavior(NO_DEFAULT_FILE);
|
|
else if (ui->localDefaultFile->isChecked())
|
|
general->setDefaultFileBehavior(LOCAL_DEFAULT_FILE);
|
|
else if (ui->cloudDefaultFile->isChecked())
|
|
general->setDefaultFileBehavior(CLOUD_DEFAULT_FILE);
|
|
|
|
auto display = SettingsObjectWrapper::instance()->display_settings;
|
|
display->setDivelistFont(ui->font->currentFont().toString());
|
|
display->setFontSize(ui->fontsize->value());
|
|
display->setDisplayInvalidDives(ui->displayinvalid->isChecked());
|
|
|
|
auto animation = SettingsObjectWrapper::instance()->animation_settings;
|
|
animation->setAnimationSpeed(ui->velocitySlider->value());
|
|
}
|