mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2024-11-28 05:00:20 +00:00
Code Issues Projects Releases Packages Wiki Activity
subsurface/desktop-widgets
History
Berthold Stoeger 88ed5bf050 Desktop: destroy maintab before destructing mainwindow 
Apparently, in some Qt-versions the destructor of the base class
calls hide on child-objects (according to Qt's object hierarchy).
This is obviously called after the derived class has been destructed.

In a concrete case, the base class of the destructed MainWindow
would hide the TabDiveSite object. That would reset the filtering
if a dive site was selected, which would indirectly access the
MainWindow, which is already partially destroyed.

Therefore, destroy the MainTab before destroying the MainWindow.
Do this by keeping it as a std::unique_ptr subobject. Thus, it
will be destroyed before the MainWindow and remove itself from
Qt's object hierarchy.

Reported-by: Dirk Hohndel <dirk@hohndel.org>
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2019-04-14 03:16:48 +12:00
..
css
preferences replace deprecated qSort() with std::sort() 2019-04-12 12:59:17 +03:00
statistics Cleanup: reinstate override modifiers 2018-09-29 15:23:25 -07:00
tab-widgets Desktop: put dive site table in "row selection mode" 2019-04-13 15:48:46 +03:00
about.cpp update year to 2019 in about screens 2019-01-02 09:45:01 -08:00
about.h
about.ui Use icons relative path. 2017-11-30 23:14:46 -08:00
btdeviceselectiondialog.cpp Desktop: only show dive computers in the Bluetooth device list 2019-02-14 09:05:58 -08:00
btdeviceselectiondialog.h Bluetooth: use standard Qt code on Windows 2018-09-30 08:09:37 -07:00
btdeviceselectiondialog.ui Desktop: add checkbox to show all BT devices 2019-02-14 09:05:58 -08:00
CMakeLists.txt Undo: implement undo of dive trip editing 2019-04-12 18:19:07 +03:00
command.cpp Undo: remove ADD mode from main tab 2019-04-12 18:19:07 +03:00
command.h Undo: use QUndoStack::isClean() to determine unsaved changes 2019-04-12 18:19:07 +03:00
command_base.cpp Undo: use QUndoStack::isClean() to determine unsaved changes 2019-04-12 18:19:07 +03:00
command_base.h Dive sites: prepare for dive site ref-counting 2019-04-12 18:19:07 +03:00
command_divelist.cpp Undo: use QUndoStack::isClean() to determine unsaved changes 2019-04-12 18:19:07 +03:00
command_divelist.h Undo: remove ADD mode from main tab 2019-04-12 18:19:07 +03:00
command_divesite.cpp Undo: update filter flag when dives change 2019-04-12 18:19:07 +03:00
command_divesite.h Dive site: implement purge of unused dive sites 2019-04-12 18:19:07 +03:00
command_edit.cpp Undo: use QUndoStack::isClean() to determine unsaved changes 2019-04-12 18:19:07 +03:00
command_edit.h Cleanup: remove EDIT_TEXT and EDIT_VALUE macros in maintab.cpp 2019-04-12 18:19:07 +03:00
command_edit_trip.cpp Undo: use QUndoStack::isClean() to determine unsaved changes 2019-04-12 18:19:07 +03:00
command_edit_trip.h Undo: implement undo of dive trip editing 2019-04-12 18:19:07 +03:00
command_private.cpp Undo: move selection function into command_private.cpp file 2019-04-12 18:19:07 +03:00
command_private.h Undo: move selection function into command_private.cpp file 2019-04-12 18:19:07 +03:00
configuredivecomputerdialog.cpp Cleanup: we don't support configuring a Uemis SDA 2018-08-28 12:03:03 -07:00
configuredivecomputerdialog.h Cleanup: reinstate override modifiers 2018-09-29 15:23:25 -07:00
configuredivecomputerdialog.ui Configure ostc3: Remove obsoleted setting 2018-04-27 21:33:47 +03:00
divecomponentselection.ui Add various enhancements to profile export and dive data copy 2019-02-07 16:06:43 +01:00
divecomputermanagementdialog.cpp Dive computers: turn QMultiMap into sorted vector 2018-06-17 06:53:13 +09:00
divecomputermanagementdialog.h Cleanup: fold DiveComputerManagementDialog::update() into init() 2018-06-17 06:53:13 +09:00
divecomputermanagementdialog.ui Use icons relative path. 2017-11-30 23:14:46 -08:00
divelistview.cpp Undo: switch to edited trip 2019-04-12 18:19:07 +03:00
divelistview.h Undo: switch to edited trip 2019-04-12 18:19:07 +03:00
divelogexportdialog.cpp Dive sites: prepare for dive site ref-counting 2019-04-12 18:19:07 +03:00
divelogexportdialog.h Add various enhancements to profile export and dive data copy 2019-02-07 16:06:43 +01:00
divelogexportdialog.ui Export profile data 2019-04-04 09:33:56 -07:00
divelogimportdialog.cpp Coding style: remove Java-style function definition 2019-04-12 18:19:07 +03:00
divelogimportdialog.h Import: Make DiveLogImportDialog modal 2018-10-04 10:22:11 +02:00
divelogimportdialog.ui Use icons relative path. 2017-11-30 23:14:46 -08:00
divepicturewidget.cpp Dive media: transport dive-id in drag'n'drop events 2018-07-18 09:06:37 -07:00
divepicturewidget.h Cleanup: reinstate override modifiers 2018-09-29 15:23:25 -07:00
diveplanner.cpp Add UI element for final surface segment in planner 2019-03-29 06:51:12 -07:00
diveplanner.h Planner: Add checkbox to force OC bailout 2019-01-13 15:02:07 -08:00
diveplanner.ui Choose water presets from a qcombobox in planner, custom value possible 2018-03-02 08:38:22 -08:00
diveshareexportdialog.cpp Revert "desktop-widgets: remove QSettings from desktop-widgets" 2018-08-29 03:09:10 -07:00
diveshareexportdialog.h
diveshareexportdialog.ui
downloadfromdivecomputer.cpp Undo: make undo-system dive site-aware 2019-04-12 18:19:07 +03:00
downloadfromdivecomputer.h Leak fix: make ostcFirmwareCheck a unique_ptr 2019-03-18 09:06:32 -07:00
downloadfromdivecomputer.ui Desktop/remember DCs: avoid highlighted button 2018-09-23 11:49:30 -07:00
filterwidget2.cpp Filter: call update title directly in filter model 2019-04-12 18:19:07 +03:00
filterwidget2.h Filter: call update title directly in filter model 2019-04-12 18:19:07 +03:00
filterwidget2.ui Filter panel: add suit and notes search fields 2019-02-28 15:45:42 -08:00
findmovedimagesdialog.cpp Desktop: fix another variable name conflict 2019-03-18 19:40:32 -07:00
findmovedimagesdialog.h Dive pictures: implement FindMovedImagesDialog 2018-07-04 02:27:36 +08:00
findmovedimagesdialog.ui UI change of "images"/"photo" to "media" or "media files" 2018-07-15 09:38:12 -07:00
groupedlineedit.cpp Unused code: GroupedLineEdit::removeAllColors() 2018-01-10 16:45:42 +01:00
groupedlineedit.h Cleanup: reinstate override modifiers 2018-09-29 15:23:25 -07:00
kmessagewidget.cpp
kmessagewidget.h Cleanup: reinstate override modifiers 2018-09-29 15:23:25 -07:00
listfilter.ui Start to implement a simplified version of the filter widget 2018-12-14 01:05:18 +08:00
locationinformation.cpp Filter: allow filtering multiple dive sites 2019-04-12 18:19:07 +03:00
locationinformation.h Dive site: add proximity field to dive site list 2019-04-12 18:19:07 +03:00
locationinformation.ui Dive site: add proximity field to dive site list 2019-04-12 18:19:07 +03:00
mainwindow.cpp Desktop: destroy maintab before destructing mainwindow 2019-04-14 03:16:48 +12:00
mainwindow.h Desktop: destroy maintab before destructing mainwindow 2019-04-14 03:16:48 +12:00
mainwindow.ui Desktop: remove checkmark from Filter divelist entry in Log menu 2019-02-19 12:02:58 -08:00
mapwidget.cpp Dive site: remove edit mode from dive location widget 2019-04-12 18:19:07 +03:00
mapwidget.h Dive site: remove edit mode from dive location widget 2019-04-12 18:19:07 +03:00
modeldelegates.cpp Dive sites: simplify nr_of_dives_at_dive_site() 2019-04-12 18:19:07 +03:00
modeldelegates.h Cleanup: reinstate override modifiers 2018-09-29 15:23:25 -07:00
notificationwidget.cpp Use queued connection to thread-safe MainWindow error handling 2018-01-31 14:47:26 +01:00
notificationwidget.h Use queued connection to thread-safe MainWindow error handling 2018-01-31 14:47:26 +01:00
plannerDetails.ui
plannerSettings.ui Add UI element for final surface segment in planner 2019-03-29 06:51:12 -07:00
printdialog.cpp Drop old filter code 2018-12-14 01:05:18 +08:00
printdialog.h Cleanup: replace virtual by override where appropriate 2018-07-31 11:02:34 +02:00
printer.cpp get rid of some foreach and Q_FOREACH constructs 2019-04-12 12:59:17 +03:00
printer.h Remove partial support for QWebEngine 2019-03-20 08:45:02 -07:00
printoptions.cpp replace deprecated qSort() with std::sort() 2019-04-12 12:59:17 +03:00
printoptions.h Cleanup: remove all Q_NULLPTR instances 2019-04-02 07:34:46 -07:00
printoptions.ui
qtwaitingspinner.cpp
qtwaitingspinner.h
renumber.ui Use icons relative path. 2017-11-30 23:14:46 -08:00
searchbar.ui Use better aliases for icons. 2017-11-30 23:14:46 -08:00
setpoint.ui Use icons relative path. 2017-11-30 23:14:46 -08:00
shiftimagetimes.ui UI change of "images"/"photo" to "media" or "media files" 2018-07-15 09:38:12 -07:00
shifttimes.ui Use icons relative path. 2017-11-30 23:14:46 -08:00
simplewidgets.cpp Dive sites: prepare for dive site ref-counting 2019-04-12 18:19:07 +03:00
simplewidgets.h Drop old filter code 2018-12-14 01:05:18 +08:00
starwidget.cpp Cleanup: remove parameter from currentDiveChanged signal 2018-07-30 12:20:26 -07:00
starwidget.h Cleanup: reinstate override modifiers 2018-09-29 15:23:25 -07:00
subsurfacewebservices.cpp Dive site: add dive site ref-counting 2019-04-12 18:19:07 +03:00
subsurfacewebservices.h Cleanup: Devirtualize WebServices::downloadTimedOut() 2018-09-29 15:16:11 -07:00
tableview.cpp Use better aliases for icons. 2017-11-30 23:14:46 -08:00
tableview.h Cleanup: reinstate override modifiers 2018-09-29 15:23:25 -07:00
tableview.ui
tagwidget.cpp Undo: implement undo of tag editing 2019-04-12 18:19:07 +03:00
tagwidget.h Undo: implement undo of tag editing 2019-04-12 18:19:07 +03:00
templateedit.cpp Warnings: replace memcpy by assignment 2018-11-19 13:51:03 -08:00
templateedit.h
templateedit.ui
templatelayout.cpp get rid of some foreach and Q_FOREACH constructs 2019-04-12 12:59:17 +03:00
templatelayout.h Translations: unify gettextFromC::tr() and QObject::tr() 2018-07-04 05:33:31 +08:00
textedit.cpp Desktop: create new custom TextEdit widget for notes-field 2019-04-12 18:19:07 +03:00
textedit.h Desktop: create new custom TextEdit widget for notes-field 2019-04-12 18:19:07 +03:00
updatemanager.cpp core: move updatecheck to its own domain 2019-02-09 10:37:55 -08:00
updatemanager.h
urldialog.ui UI change of "images"/"photo" to "media" or "media files" 2018-07-15 09:38:12 -07:00
usermanual.cpp Coding style: remove Java-style function definition 2019-04-12 18:19:07 +03:00
usermanual.h Remove partial support for QWebEngine 2019-03-20 08:45:02 -07:00
usersurvey.cpp Revert "desktop-widgets: remove QSettings from desktop-widgets" 2018-08-29 03:09:10 -07:00
usersurvey.h
usersurvey.ui
webservices.ui Use icons relative path. 2017-11-30 23:14:46 -08:00