mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2024-11-30 22:20:21 +00:00
Code Issues Projects Releases Packages Wiki Activity
subsurface/qt-models
History
Berthold Stoeger fe3021b88a cleanup: consistently use get_cylinder() accessor 
get_cylinder(d, i) is more readable than d->cylinders.cylinders[i].
Moreover, it does bound checking and is more flexible with respect to
changing the core data structures. Most places already used this accessor,
but some still accessed the cylinders directly.

This patch unifies the accesses by consistently switching to get_cylinder().
The affected code is in C++ and accesses the cylinder as reference or
object, whereas the get_cylinder() function is C and returns a pointer.
This results in funky looking "*get_cylinder(d, i)" expressions.
Arguably still better than the original.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2020-08-21 08:48:22 -07:00
..
cleanertablemodel.cpp Cleanup: return directly from data() methods 2019-06-19 13:11:10 -07:00
cleanertablemodel.h CylindersModel: fold CHANGED() macro into setData() 2020-04-07 00:13:35 +02:00
CMakeLists.txt cleanup: remove redundant model source files in CMakeLists.txt 2020-05-15 14:19:21 -07:00
completionmodels.cpp code cleanup: replace use of toStdVector() 2020-01-10 02:37:03 +09:00
completionmodels.h
cylindermodel.cpp cleanup: consistently use get_cylinder() accessor 2020-08-21 08:48:22 -07:00
cylindermodel.h Make MND display depend on O2 narcotic preference 2020-07-11 10:37:49 -07:00
divecomputerextradatamodel.cpp cleanup: generalize ExtraDataModel to display data of any dc 2020-05-07 08:46:15 -07:00
divecomputerextradatamodel.h cleanup: generalize ExtraDataModel to display data of any dc 2020-05-07 08:46:15 -07:00
divecomputermodel.cpp
divecomputermodel.h
diveimportedmodel.cpp Grammar: replaces 'indexes' by 'indices' 2020-03-11 08:26:30 -07:00
diveimportedmodel.h Grammar: replaces 'indexes' by 'indices' 2020-03-11 08:26:30 -07:00
divelocationmodel.cpp cleanup: invert control-flow when resetting the core structures 2020-05-07 08:43:27 -07:00
divelocationmodel.h cleanup: invert control-flow when resetting the core structures 2020-05-07 08:43:27 -07:00
divepicturemodel.cpp undo: make picture (media) deletion undoable 2020-05-06 13:58:09 -07:00
divepicturemodel.h undo: make picture (media) deletion undoable 2020-05-06 13:58:09 -07:00
diveplannermodel.cpp cleanup: create common QDateTime -> timestamp conversion function 2020-05-22 12:31:06 -07:00
diveplannermodel.h planner: send plan in calculatedPlanNotes 2020-05-04 10:42:07 +02:00
diveplotdatamodel.cpp cleanup: remove DivePlotDataModel::diveId 2020-04-30 14:14:13 -07:00
diveplotdatamodel.h cleanup: remove DivePlotDataModel::diveId 2020-04-30 14:14:13 -07:00
divesiteimportmodel.cpp Create DivesiteImportDialog to select sites to import 2019-05-06 10:48:44 +02:00
divesiteimportmodel.h Create DivesiteImportDialog to select sites to import 2019-05-06 10:48:44 +02:00
divesummarymodel.cpp cleanup: consistently use get_cylinder() accessor 2020-08-21 08:48:22 -07:00
divesummarymodel.h mobile/summary: add section headers 2020-02-08 10:29:36 -08:00
divetripmodel.cpp cleanup: move timestampToDateTime() to qthelper.cpp 2020-05-22 12:31:06 -07:00
divetripmodel.h cleanup: invert control-flow when resetting the core structures 2020-05-07 08:43:27 -07:00
filtermodels.cpp cleanup: invert control-flow when resetting the core structures 2020-05-07 08:43:27 -07:00
filtermodels.h cleanup: invert control-flow when resetting the core structures 2020-05-07 08:43:27 -07:00
gpslistmodel.cpp cleanup: invert control-flow when resetting the core structures 2020-05-07 08:43:27 -07:00
gpslistmodel.h Cleanup: Make constructor of singletons private 2019-10-04 09:19:10 -07:00
maplocationmodel.cpp Filter: split out filter from model 2019-11-19 21:13:40 -08:00
maplocationmodel.h Cleanup: lower-case filenames in core/subsurface-qt/ 2020-02-04 02:16:46 +01:00
messagehandlermodel.cpp debug output: ensure our debug output is captured on Android 2020-04-18 09:00:21 -07:00
messagehandlermodel.h
mobilelistmodel.cpp mobile/models: add access to tags string 2020-05-14 12:57:08 -07:00
mobilelistmodel.h mobile/models: add access to tags string 2020-05-14 12:57:08 -07:00
models.cpp Cylinders: access cylinders with get_cylinder() 2019-11-09 19:19:04 +01:00
models.h Cleanup: remove includes from qt-models/models.h 2019-07-18 05:42:55 -07:00
tankinfomodel.cpp cleanup: invert control-flow when resetting the core structures 2020-05-07 08:43:27 -07:00
tankinfomodel.h Cleanup: remove biggerString() functions 2019-04-29 13:06:39 -07:00
treemodel.cpp
treemodel.h
weightmodel.cpp undo: show multiple dive warning when editing equipment 2020-04-07 00:13:35 +02:00
weightmodel.h cleanup: replace to "dive.h" includes by more specific includes 2020-05-15 14:19:21 -07:00
weightsysteminfomodel.cpp cleanup: invert control-flow when resetting the core structures 2020-05-07 08:43:27 -07:00
weightsysteminfomodel.h Cleanup: implement proper Qt-model semantics in WeightInfoModel 2019-04-29 13:06:39 -07:00
yearlystatisticsmodel.cpp Core: dynamically allocate the result of get_gas_used() 2019-11-09 19:19:04 +01:00
yearlystatisticsmodel.h Show average max depth in yearly statistics 2018-12-17 12:18:26 +01:00