subsurface/desktop-widgets/tab-widgets
Linus Torvalds a9b1fbdcc5 Don't expose 'detach_buffer()' to membuffer users
The native buffer of a membuffer is not NUL-terminated, so when you want
to detach it and use it as a C string, you had to first do
'mb_cstring()' that adds the proper termination/

This was all documented in the header files, and all but two users did
it correctly.

But there were those two users, and the exported interface was
unnecessarily hard to use.  We do want the "just detach the raw buffer"
internally in the membuffer code, but let's not make the exported
interface be that hard to use.

So this switches the exported interface to be 'detach_cstring()', which
does that 'mb_cstring()' for you, and avoids the possibility that you'd
use a non-terminated memory buffer as a C string.

The old 'detach_buffer()' is now purely the internal membuffer
implementation, and not used by others.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2019-10-27 12:42:54 -07:00
..
maintab.cpp Undo: simplify profile repainting code 2019-10-26 11:36:23 -07:00
maintab.h Fix broken windows build with latest MXE 2019-08-29 12:55:25 -07:00
maintab.ui Move the Suit text box from the Notes tab to the Equipment tab 2019-08-08 09:12:09 -07:00
TabBase.cpp Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
TabBase.h Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
TabDiveEquipment.cpp Undo: turn dive- and trip-fields into flags 2019-10-26 11:36:23 -07:00
TabDiveEquipment.h Move the Suit text box from the Notes tab to the Equipment tab 2019-08-08 09:12:09 -07:00
TabDiveEquipment.ui Move the Suit text box from the Notes tab to the Equipment tab 2019-08-08 09:12:09 -07:00
TabDiveExtraInfo.cpp Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
TabDiveExtraInfo.h Cleanup: reinstate override modifiers 2018-09-29 15:23:25 -07:00
TabDiveExtraInfo.ui Cleanup: Move dive-equipment tab into own translation units 2019-04-15 10:30:04 +12:00
TabDiveInformation.cpp Undo: turn dive- and trip-fields into flags 2019-10-26 11:36:23 -07:00
TabDiveInformation.h Desktop: make salinity a field known to the undo system 2019-10-26 11:36:23 -07:00
TabDiveInformation.ui Convert the atmospheric pressure in the Information Tab to an editable field 2019-05-15 07:37:14 -07:00
TabDivePhotos.cpp Don't expose 'detach_buffer()' to membuffer users 2019-10-27 12:42:54 -07:00
TabDivePhotos.h Write dive data as video subtitles 2019-04-16 20:38:19 +02:00
TabDivePhotos.ui Implement different zoom levels for dive photos tab 2017-12-18 12:07:10 -08:00
TabDiveSite.cpp Cleanup: return each dive site only once in selectedDiveSites() 2019-09-21 16:07:24 -07:00
TabDiveSite.h Cleanup: remove TabDiveSite::updateFilter() function 2019-09-06 11:48:47 -07:00
TabDiveSite.ui Dive sites: add fulltext filter 2019-04-12 18:19:07 +03:00
TabDiveStatistics.cpp Undo: turn dive- and trip-fields into flags 2019-10-26 11:36:23 -07:00
TabDiveStatistics.h Undo: update statistics if dive changed 2019-10-26 11:36:23 -07:00
TabDiveStatistics.ui Show average max depth in statistics tab 2018-12-17 12:18:26 +01:00