mirror of
https://github.com/subsurface/subsurface.git
synced 2024-11-28 05:00:20 +00:00
fe074ccad1
The code assumes that prefs.cloud_base_url is non NULL. Allowing that to be NULL makes no sense during normal operation of the app. Yet, most of the tests don't initialize the prefs at all. Making things worse, if we do correctly initialize the prefs (so as to reasonably approximate the behavior when running the app), things break because some of the reference outputs assume that the prefs are unset. This deserves fixing. For now, simply make sure that cloud_base_url is set for all the tests that try to parse files. Additionally, the semantics how cloud_base_url is saved to disk have changed, so adjust the test for those prefs accordingly. Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
69 lines
2.2 KiB
C++
69 lines
2.2 KiB
C++
// SPDX-License-Identifier: GPL-2.0
|
|
#include "testpicture.h"
|
|
#include "core/device.h"
|
|
#include "core/dive.h"
|
|
#include "core/divesite.h"
|
|
#include "core/errorhelper.h"
|
|
#include "core/picture.h"
|
|
#include "core/trip.h"
|
|
#include "core/file.h"
|
|
#include "core/pref.h"
|
|
#include <QString>
|
|
#include <core/qthelper.h>
|
|
|
|
void TestPicture::initTestCase()
|
|
{
|
|
/* we need to manually tell that the resource exists, because we are using it as library. */
|
|
Q_INIT_RESOURCE(subsurface);
|
|
prefs.cloud_base_url = strdup(default_prefs.cloud_base_url);
|
|
}
|
|
|
|
#define PIC1_NAME "/dives/images/wreck.jpg"
|
|
#define PIC2_NAME "/dives/images/data_after_EOI.jpg"
|
|
#define PIC1_HASH "929ad9499b7ae7a9e39ef63eb6c239604ac2adfa"
|
|
#define PIC2_HASH "fa8bd48f8f24017a81e1204f52300bd98b43d4a7"
|
|
|
|
void TestPicture::addPicture()
|
|
{
|
|
struct dive *dive, *dive1, *dive2;
|
|
struct picture *pic1, *pic2;
|
|
verbose = 1;
|
|
|
|
QCOMPARE(parse_file(SUBSURFACE_TEST_DATA "/dives/test44.xml", &dive_table, &trip_table, &dive_site_table, &device_table, &filter_preset_table), 0);
|
|
dive = get_dive(0);
|
|
// Pictures will be added to selected dives
|
|
dive->selected = true;
|
|
QVERIFY(dive != NULL);
|
|
// So far no picture in dive
|
|
QVERIFY(dive->pictures.nr == 0);
|
|
|
|
pic1 = create_picture(SUBSURFACE_TEST_DATA "/dives/images/wreck.jpg", 0, false, &dive1);
|
|
pic2 = create_picture(SUBSURFACE_TEST_DATA "/dives/images/data_after_EOI.jpg", 0, false, &dive2);
|
|
QVERIFY(pic1 != NULL);
|
|
QVERIFY(pic2 != NULL);
|
|
QVERIFY(dive1 == dive);
|
|
QVERIFY(dive2 == dive);
|
|
|
|
add_picture(&dive->pictures, *pic1);
|
|
add_picture(&dive->pictures, *pic2);
|
|
free(pic1);
|
|
free(pic2);
|
|
|
|
// Now there are two pictures
|
|
QVERIFY(dive->pictures.nr == 2);
|
|
pic1 = &dive->pictures.pictures[0];
|
|
pic2 = &dive->pictures.pictures[1];
|
|
// 1st appearing at time 21:01
|
|
// 2nd appearing at time 22:01
|
|
QVERIFY(pic1->offset.seconds == 1261);
|
|
QVERIFY(pic1->location.lat.udeg == 47934500);
|
|
QVERIFY(pic1->location.lon.udeg == 11334500);
|
|
QVERIFY(pic2->offset.seconds == 1321);
|
|
|
|
learnPictureFilename(pic1->filename, PIC1_NAME);
|
|
learnPictureFilename(pic2->filename, PIC2_NAME);
|
|
QCOMPARE(localFilePath(pic1->filename), QString(PIC1_NAME));
|
|
QCOMPARE(localFilePath(pic2->filename), QString(PIC2_NAME));
|
|
}
|
|
|
|
QTEST_GUILESS_MAIN(TestPicture)
|