mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2024-11-28 21:20:19 +00:00
Code Issues Projects Releases Packages Wiki Activity
subsurface/desktop-widgets/tab-widgets
History
Berthold Stoeger b3253304a5 Desktop: don't connect to remove() slot of model from TableModel 
When connecting a model to the TableModel class, it would connect
clicking on an item to the remove() slot of the model.

This breaks the program flow implied by the undo code:
Ui --> Undo-Command --> Model --> UI

Moreover, the naming of the remove() slot is illogical, because
clicks can also have different effects, as for example in the
cylinder-table.

Therefore, move the connect() call from TableModel to the
callers. In the case of TabDiveSite, move the remove() function
from the model to the TabWidget, where it makes more sense.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2019-12-05 10:14:25 -08:00
..
maintab.cpp Cleanup: remove unnecessary remember/restoreSelection() pair 2019-12-04 13:00:23 +01:00
maintab.h Notes tab: Use top RH for depth and duretion fields 2019-11-11 20:19:22 +01:00
maintab.ui Fixes in tab widget UI layout 2019-11-16 08:32:07 -08:00
TabBase.cpp Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
TabBase.h Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
TabDiveEquipment.cpp Desktop: don't connect to remove() slot of model from TableModel 2019-12-05 10:14:25 -08:00
TabDiveEquipment.h Move the Suit text box from the Notes tab to the Equipment tab 2019-08-08 09:12:09 -07:00
TabDiveEquipment.ui Move the Suit text box from the Notes tab to the Equipment tab 2019-08-08 09:12:09 -07:00
TabDiveExtraInfo.cpp Desktop: don't connect to remove() slot of model from TableModel 2019-12-05 10:14:25 -08:00
TabDiveExtraInfo.h Cleanup: reinstate override modifiers 2018-09-29 15:23:25 -07:00
TabDiveExtraInfo.ui Cleanup: Move dive-equipment tab into own translation units 2019-04-15 10:30:04 +12:00
TabDiveInformation.cpp Desktop: add additional star widgets to Information tab 2019-12-03 20:37:57 -08:00
TabDiveInformation.h Desktop: add additional star widgets to Information tab 2019-12-03 20:37:57 -08:00
TabDiveInformation.ui Desktop: enable additional environmental star widgets 2019-12-03 20:37:57 -08:00
TabDivePhotos.cpp Don't expose 'detach_buffer()' to membuffer users 2019-10-27 12:42:54 -07:00
TabDivePhotos.h Write dive data as video subtitles 2019-04-16 20:38:19 +02:00
TabDivePhotos.ui Implement different zoom levels for dive photos tab 2017-12-18 12:07:10 -08:00
TabDiveSite.cpp Desktop: don't connect to remove() slot of model from TableModel 2019-12-05 10:14:25 -08:00
TabDiveSite.h Desktop: don't connect to remove() slot of model from TableModel 2019-12-05 10:14:25 -08:00
TabDiveSite.ui Dive sites: add fulltext filter 2019-04-12 18:19:07 +03:00
TabDiveStatistics.cpp Cleanup: use quotation marks for non-system includes 2019-12-04 13:00:23 +01:00
TabDiveStatistics.h Undo: update statistics if dive changed 2019-10-26 11:36:23 -07:00
TabDiveStatistics.ui Show average max depth in statistics tab 2018-12-17 12:18:26 +01:00