mirror of
https://github.com/subsurface/subsurface.git
synced 2024-11-28 05:00:20 +00:00
396598430b
Qt's memory management scheme is completely broken and messes with common expectations. QObjects are organized as a tree. The children are destroyed in the destructor of QObject. This means that they are destructed after the destructor of the parent object has run and its sub-object were destructed. Obviously, this makes no sense as the child objects should be able to access their parent at any time. To restore the commonly expected deterministic order of construction and destruction, one might simply do away with Qt's silly object tree and organise things using classical subobjects. However, that breaks with the Qt-generated UI classes: The objects generated by these classes are *not* destructed with the UI class. Instead, they are attached to the widget's QObject tree. Thus these are again destructed *after* the widget! Who comes up with such a scheme? In our case this means that we cannot have models used for TableViews as subobjects, because the TableView needs the model to save the column widths in the destructor. Which, as detailed above is called *after* the desctructor of the widget! Thus, turn these models into heap-allocated objects and add them to the QObject tree. Funilly, this exposes another insanity of Qt's QObject tree: Children are destructed in order of construction! One would expect that if objects are constructed in the sequence A, B, C one can expect that C can, at any time, access B and A. Not so in Qt: The destruction order is likewise A, B, C! Thus, take care to init the widgets before the model. Jeez. Finally, print a warning in the column-saving code of TableWidget, so that these kind of subtleties are caught in the future. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
38 lines
1.1 KiB
C++
38 lines
1.1 KiB
C++
// SPDX-License-Identifier: GPL-2.0
|
|
#include "TabDiveComputer.h"
|
|
#include "ui_TabDiveExtraInfo.h"
|
|
#include "qt-models/divecomputermodel.h"
|
|
|
|
TabDiveComputer::TabDiveComputer(QWidget *parent) : TabBase(parent)
|
|
{
|
|
ui.setupUi(this);
|
|
|
|
DiveComputerModel *model = new DiveComputerModel(this);
|
|
sortedModel = new DiveComputerSortedModel(this);
|
|
|
|
sortedModel->setSourceModel(model);
|
|
ui.devices->setModel(sortedModel);
|
|
ui.devices->view()->setSelectionBehavior(QAbstractItemView::SelectRows);
|
|
ui.devices->view()->setSelectionMode(QAbstractItemView::SingleSelection);
|
|
ui.devices->view()->setSortingEnabled(true);
|
|
ui.devices->view()->sortByColumn(DiveComputerModel::MODEL, Qt::AscendingOrder);
|
|
ui.devices->view()->horizontalHeader()->setStretchLastSection(true);
|
|
connect(ui.devices, &TableView::itemClicked, this, &TabDiveComputer::tableClicked);
|
|
}
|
|
|
|
void TabDiveComputer::updateData()
|
|
{
|
|
}
|
|
|
|
void TabDiveComputer::clear()
|
|
{
|
|
}
|
|
|
|
void TabDiveComputer::tableClicked(const QModelIndex &index)
|
|
{
|
|
if (!index.isValid())
|
|
return;
|
|
|
|
if (index.column() == DiveComputerModel::REMOVE)
|
|
sortedModel->remove(index);
|
|
}
|