mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-01 05:23:24 +00:00
Code Issues Projects Releases Packages Wiki Activity
subsurface/qt-models
History
Berthold Stoeger bf65f1e507 Fix comparison function in qt-models/divelocationmodel.cpp 
The function dive_site_less_than() in qt-models/divelocationmodel.cpp
does not what it promises: it uses less-or-equal instead of less-than
comparison.

Note that, even though this may sound pedantic, this is an actual bug.
Usually, sorting functions suppose that they are provided with
strict weak ordering, which <= does *not* provide.

This is the actual reason for the crash mentioned in commit
f8a3a85210.

While touching this function, make it of static linkage, since
its usage is local to this translation unit.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2017-11-26 18:49:05 -08:00
..
cleanertablemodel.cpp Add SPDX header to Qt models 2017-04-29 13:32:55 -07:00
cleanertablemodel.h Add SPDX header to Qt models 2017-04-29 13:32:55 -07:00
CMakeLists.txt qt-models/cmake: build maplocationmodel.cpp 2017-07-28 07:31:11 -07:00
completionmodels.cpp Add SPDX header to Qt models 2017-04-29 13:32:55 -07:00
completionmodels.h Add SPDX header to Qt models 2017-04-29 13:32:55 -07:00
cylindermodel.cpp Tidy up code for cylinder remove decision in cylindermodel.cpp 2017-10-30 21:45:56 +01:00
cylindermodel.h Planner: Autom. move first datapoint gas to first gaslist position 2017-10-16 17:14:17 +02:00
divecomputerextradatamodel.cpp Add SPDX header to Qt models 2017-04-29 13:32:55 -07:00
divecomputerextradatamodel.h Add SPDX header to Qt models 2017-04-29 13:32:55 -07:00
divecomputermodel.cpp Add SPDX header to Qt models 2017-04-29 13:32:55 -07:00
divecomputermodel.h Add SPDX header to Qt models 2017-04-29 13:32:55 -07:00
diveimportedmodel.cpp Only call autogroup when it's enabled 2017-11-25 08:12:28 -08:00
diveimportedmodel.h QML UI: clear the previous list when downloading 2017-06-16 01:22:44 -07:00
divelistmodel.cpp QML UI: add downloaded dives to dive list 2017-05-28 11:54:33 -07:00
divelistmodel.h QML UI: add downloaded dives to dive list 2017-05-28 11:54:33 -07:00
divelocationmodel.cpp Fix comparison function in qt-models/divelocationmodel.cpp 2017-11-26 18:49:05 -08:00
divelocationmodel.h Remove unused method LocationInformationModel::addDiveSite() 2017-11-26 23:37:01 +01:00
divepicturemodel.cpp Add SPDX header to Qt models 2017-04-29 13:32:55 -07:00
divepicturemodel.h Add SPDX header to Qt models 2017-04-29 13:32:55 -07:00
diveplannermodel.cpp Hand planner variables to profile 2017-11-25 20:13:01 +01:00
diveplannermodel.h Hand planner variables to profile 2017-11-25 20:13:01 +01:00
diveplotdatamodel.cpp Hand planner variables to profile 2017-11-25 20:13:01 +01:00
diveplotdatamodel.h Localize global planner state 2017-11-25 20:13:01 +01:00
divesitepicturesmodel.cpp Add SPDX header to Qt models 2017-04-29 13:32:55 -07:00
divesitepicturesmodel.h Add SPDX header to Qt models 2017-04-29 13:32:55 -07:00
divetripmodel.cpp Display units in dive list table based on prefs option 2017-10-09 11:49:29 +03:00
divetripmodel.h Display units in dive list table based on prefs option 2017-10-09 11:49:29 +03:00
filtermodels.cpp Use equality instead of substring comparison in suits and buddy filter 2017-11-25 15:41:55 -08:00
filtermodels.h Update filters on refreshDisplay and remember old selecttions 2017-11-25 08:24:36 -08:00
gpslistmodel.cpp Add SPDX header to Qt models 2017-04-29 13:32:55 -07:00
gpslistmodel.h Add SPDX header to Qt models 2017-04-29 13:32:55 -07:00
maplocationmodel.cpp map-widget: allow real-time updates of edited markers 2017-11-09 12:40:25 -08:00
maplocationmodel.h map-widget: allow real-time updates of edited markers 2017-11-09 12:40:25 -08:00
messagehandlermodel.cpp Android: write appLog to file 2017-07-09 17:40:29 -07:00
messagehandlermodel.h Make message handler write to console as well 2017-06-11 13:55:41 -07:00
models.cpp Add SPDX header to Qt models 2017-04-29 13:32:55 -07:00
models.h Add SPDX header to Qt models 2017-04-29 13:32:55 -07:00
ssrfsortfilterproxymodel.cpp Add SPDX header to Qt models 2017-04-29 13:32:55 -07:00
ssrfsortfilterproxymodel.h Add SPDX header to Qt models 2017-04-29 13:32:55 -07:00
tankinfomodel.cpp tankinfomodel.cpp: clamp row index to [0 - MAX_TANK_INFO] 2017-06-15 14:48:49 -07:00
tankinfomodel.h Add SPDX header to Qt models 2017-04-29 13:32:55 -07:00
treemodel.cpp Add SPDX header to Qt models 2017-04-29 13:32:55 -07:00
treemodel.h Add SPDX header to Qt models 2017-04-29 13:32:55 -07:00
weightmodel.cpp Add SPDX header to Qt models 2017-04-29 13:32:55 -07:00
weightmodel.h Add SPDX header to Qt models 2017-04-29 13:32:55 -07:00
weigthsysteminfomodel.cpp Add SPDX header to Qt models 2017-04-29 13:32:55 -07:00
weigthsysteminfomodel.h Add SPDX header to Qt models 2017-04-29 13:32:55 -07:00
yearlystatisticsmodel.cpp Creation of dive duration string and surface interval string 2017-05-26 15:50:52 -07:00
yearlystatisticsmodel.h Add SPDX header to Qt models 2017-04-29 13:32:55 -07:00