mirror of
https://github.com/subsurface/subsurface.git
synced 2025-01-19 14:25:27 +00:00
e761d00ddd
In moveDiveToTrip(), the dive was first removed from its old trip and then added to the new trip. This function is also used to remove the dive from its trip (by moving it to the "null-trip" if you whish). Even in that case add_dive_to_trip() was called. The only reason why this didn't crash is that add_dive_to_trip() checks whether old and new trip are the same. This is the case when adding to the "null-trip", since the dive was removed from the trip just before. To cut a long story short, to trust on add_dive_to_trip() not crashing if moving from the null-trip to the null-trip is way to subtly. If we remove a dive from its trip, don't call add_dive_to_trip() in the first place. Reported-by: Dirk Hohndel <dirk@hohndel.org> Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at> |
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| command.cpp | ||
| command.h | ||
| command_base.cpp | ||
| command_base.h | ||
| command_divelist.cpp | ||
| command_divelist.h | ||
| command_divesite.cpp | ||
| command_divesite.h | ||
| command_edit.cpp | ||
| command_edit.h | ||
| command_edit_trip.cpp | ||
| command_edit_trip.h | ||