mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity
subsurface/profile-widget
History
Berthold Stoeger ea88f4729d profile: set model of profile items on construction 
The profile items had a "setModel()" function to set
the DivePlotDataModel post creation. The model is never
changed. It does however mean that the model might be
null in a short period between construction and setting
the model.

To simplify reasoning about this code, set the model
in the constructor. To drive the point home that the
can never change and cannot be null, turn it into a
reference.

Yes, this is gratuitous bike-shedding, but it helps
me analysis the code.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2021-01-10 15:57:39 -08:00
..
animationfunctions.cpp Profile: add speed parameter to Animation::* functions 2019-07-12 09:59:28 +02:00
animationfunctions.h Profile: add speed parameter to Animation::* functions 2019-07-12 09:59:28 +02:00
CMakeLists.txt profile: move DiveHandler to profile-widget folder 2020-12-12 15:52:40 -08:00
divecartesianaxis.cpp preferences: create global settingsChanged signal 2020-12-12 15:52:40 -08:00
divecartesianaxis.h cleanup: turn protected into private members 2020-04-13 17:18:37 -07:00
diveeventitem.cpp cleanup: split out divecomputer functions from dive.c 2020-10-25 13:59:52 -07:00
diveeventitem.h Profile: take int instead of bool in DiveEventItem::recalculatePos 2019-07-12 09:59:28 +02:00
divehandler.cpp profile: move DiveHandler to profile-widget folder 2020-12-12 15:52:40 -08:00
divehandler.h profile: move DiveHandler to profile-widget folder 2020-12-12 15:52:40 -08:00
divelineitem.cpp Add SPDX header to profile widgets 2017-04-29 13:32:55 -07:00
divelineitem.h Add SPDX header to profile widgets 2017-04-29 13:32:55 -07:00
divepixmapitem.cpp profile: move picture removal from DivePictureItem to ProfileWidget2 2020-12-19 20:19:51 +01:00
divepixmapitem.h profile: move picture removal from DivePictureItem to ProfileWidget2 2020-12-19 20:19:51 +01:00
diveprofileitem.cpp profile: set model of profile items on construction 2021-01-10 15:57:39 -08:00
diveprofileitem.h profile: set model of profile items on construction 2021-01-10 15:57:39 -08:00
diverectitem.cpp Add SPDX header to profile widgets 2017-04-29 13:32:55 -07:00
diverectitem.h Add SPDX header to profile widgets 2017-04-29 13:32:55 -07:00
divetextitem.cpp Cleanup: move error reporting function declarations to errorhelper.h 2019-08-08 16:26:30 -07:00
divetextitem.h Add SPDX header to profile widgets 2017-04-29 13:32:55 -07:00
divetooltipitem.cpp statistics: use RoundRectItem for legend and info-box 2021-01-03 13:56:05 -08:00
divetooltipitem.h ui: create a RoundRectItem class 2021-01-03 13:56:05 -08:00
profilewidget2.cpp profile: set model of profile items on construction 2021-01-10 15:57:39 -08:00
profilewidget2.h profile: remove clearHandlers function (fixes crash) 2020-12-20 11:02:17 -08:00
qmlprofile.cpp mobile/profile: listen to dive changes and redraw profile 2020-12-21 13:12:37 -08:00
qmlprofile.h mobile/profile: listen to dive changes and redraw profile 2020-12-21 13:12:37 -08:00
ruleritem.cpp preferences: create global settingsChanged signal 2020-12-12 15:52:40 -08:00
ruleritem.h cleanup: turn protected into private members 2020-04-13 17:18:37 -07:00
tankitem.cpp cleanup: break out event-related code into event.[c|h] 2020-10-25 13:59:52 -07:00
tankitem.h Profile: don't crash when there are no cylinders 2019-11-09 19:19:04 +01:00