mirror of
https://github.com/subsurface/subsurface.git
synced 2025-02-19 22:16:15 +00:00
d21d42b691
deleteLater() can be dangerous. Remove where not necessary. Analysis: 1) `helpView` was a pointer which was initialized on demand. close() and deleteLater() were called on closure of the main window. Firstly, there's no point in calling deleteLater(), because no references to helpView are used later on. Secondly, the deletion (and closing) can be done automatically in the destructor, by passing `this` as parent object. 2) `survey`: pretty much the same situation. But here, `this` was already passed as parent object. 3) `progressDialog` is a global (not thread safe!) pointer. The object is deleted after use. There is no point in using deleteLater(), because the callers are not active after hideProgressBar(), which is the place were the deleteLater() call was found. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at> |
||
|---|---|---|
| .. | ||
| css | ||
| plugins | ||
| preferences | ||
| statistics | ||
| tab-widgets | ||
| about.cpp | ||
| about.h | ||
| about.ui | ||
| btdeviceselectiondialog.cpp | ||
| btdeviceselectiondialog.h | ||
| btdeviceselectiondialog.ui | ||
| CMakeLists.txt | ||
| configuredivecomputerdialog.cpp | ||
| configuredivecomputerdialog.h | ||
| configuredivecomputerdialog.ui | ||
| divecomponentselection.ui | ||
| divecomputermanagementdialog.cpp | ||
| divecomputermanagementdialog.h | ||
| divecomputermanagementdialog.ui | ||
| divelistview.cpp | ||
| divelistview.h | ||
| divelogexportdialog.cpp | ||
| divelogexportdialog.h | ||
| divelogexportdialog.ui | ||
| divelogimportdialog.cpp | ||
| divelogimportdialog.h | ||
| divelogimportdialog.ui | ||
| divepicturewidget.cpp | ||
| divepicturewidget.h | ||
| diveplanner.cpp | ||
| diveplanner.h | ||
| diveplanner.ui | ||
| diveshareexportdialog.cpp | ||
| diveshareexportdialog.h | ||
| diveshareexportdialog.ui | ||
| downloadfromdivecomputer.cpp | ||
| downloadfromdivecomputer.h | ||
| downloadfromdivecomputer.ui | ||
| filterwidget.ui | ||
| groupedlineedit.cpp | ||
| groupedlineedit.h | ||
| kmessagewidget.cpp | ||
| kmessagewidget.h | ||
| listfilter.ui | ||
| locationinformation.cpp | ||
| locationinformation.h | ||
| locationInformation.ui | ||
| mainwindow.cpp | ||
| mainwindow.h | ||
| mainwindow.ui | ||
| mapwidget.cpp | ||
| mapwidget.h | ||
| modeldelegates.cpp | ||
| modeldelegates.h | ||
| notificationwidget.cpp | ||
| notificationwidget.h | ||
| plannerDetails.ui | ||
| plannerSettings.ui | ||
| printdialog.cpp | ||
| printdialog.h | ||
| printer.cpp | ||
| printer.h | ||
| printoptions.cpp | ||
| printoptions.h | ||
| printoptions.ui | ||
| qtwaitingspinner.cpp | ||
| qtwaitingspinner.h | ||
| renumber.ui | ||
| searchbar.ui | ||
| setpoint.ui | ||
| shiftimagetimes.ui | ||
| shifttimes.ui | ||
| simplewidgets.cpp | ||
| simplewidgets.h | ||
| starwidget.cpp | ||
| starwidget.h | ||
| subsurfacewebservices.cpp | ||
| subsurfacewebservices.h | ||
| tableview.cpp | ||
| tableview.h | ||
| tableview.ui | ||
| tagwidget.cpp | ||
| tagwidget.h | ||
| templateedit.cpp | ||
| templateedit.h | ||
| templateedit.ui | ||
| templatelayout.cpp | ||
| templatelayout.h | ||
| undocommands.cpp | ||
| undocommands.h | ||
| updatemanager.cpp | ||
| updatemanager.h | ||
| urldialog.ui | ||
| usermanual.cpp | ||
| usermanual.h | ||
| usersurvey.cpp | ||
| usersurvey.h | ||
| usersurvey.ui | ||
| webservices.ui | ||