mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2024-11-28 21:20:19 +00:00
Code Issues Projects Releases Packages Wiki Activity
subsurface/desktop-widgets
History
Berthold Stoeger d21d42b691 Cleanup: remove three instances of deleteLater() in mainwindow.cpp 
deleteLater() can be dangerous. Remove where not necessary.

Analysis:

1) `helpView` was a pointer which was initialized on demand. close() and
deleteLater() were called on closure of the main window. Firstly, there's
no point in calling deleteLater(), because no references to helpView
are used later on. Secondly, the deletion (and closing) can be done
automatically in the destructor, by passing `this` as parent object.

2) `survey`: pretty much the same situation. But here, `this` was already
passed as parent object.

3) `progressDialog` is a global (not thread safe!) pointer. The object
is deleted after use. There is no point in using deleteLater(), because
the callers are not active after hideProgressBar(), which is the
place were the deleteLater() call was found.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2018-05-26 09:21:46 -07:00
..
css Move qt-ui to desktop-widgets 2015-10-30 10:36:49 -07:00
plugins desktop-widgets/.../facebook: Change Q_UNUSED to no parameter name 2018-05-21 12:48:04 -07:00
preferences Core: remove dive.h from files that don't need it 2018-05-14 10:13:39 -07:00
statistics desktop-widgets/statistics: Change Q_UNUSED to no parameter name 2018-05-21 12:48:04 -07:00
tab-widgets Dive pictures: change removePicture() interface 2018-05-21 22:17:28 +03:00
about.cpp Get ready for 2018 2017-12-30 08:23:22 -08:00
about.h Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
about.ui Use icons relative path. 2017-11-30 23:14:46 -08:00
btdeviceselectiondialog.cpp Cleanup: Use QString as parameter for [get|save]BtDeviceInfo() 2018-02-26 08:52:34 +01:00
btdeviceselectiondialog.h cleanup: remove unused include 2017-12-23 11:17:47 +01:00
btdeviceselectiondialog.ui Introduce mode field in Bluetooth device selection dialog 2017-11-16 14:26:51 +01:00
CMakeLists.txt map-widget: move the widget and its resources to 'map-widget' 2017-11-05 14:48:56 -08:00
configuredivecomputerdialog.cpp desktop-widgets: Change Q_UNUSED to no parameter name 2018-05-21 12:48:04 -07:00
configuredivecomputerdialog.h Remove old duplicated code 2017-06-21 18:43:15 -07:00
configuredivecomputerdialog.ui Configure ostc3: Remove obsoleted setting 2018-04-27 21:33:47 +03:00
divecomponentselection.ui Use icons relative path. 2017-11-30 23:14:46 -08:00
divecomputermanagementdialog.cpp Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
divecomputermanagementdialog.h Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
divecomputermanagementdialog.ui Use icons relative path. 2017-11-30 23:14:46 -08:00
divelistview.cpp Cleanup: Don't defer deletion of oldModel in DiveListView::reload() 2018-05-25 14:15:42 +03:00
divelistview.h divelist: prevent a crash for missing column width 2017-10-03 15:43:03 -07:00
divelogexportdialog.cpp desktop-widgets: Change Q_UNUSED to no parameter name 2018-05-21 12:48:04 -07:00
divelogexportdialog.h Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
divelogexportdialog.ui Use icons relative path. 2017-11-30 23:14:46 -08:00
divelogimportdialog.cpp desktop-widgets: Change Q_UNUSED to no parameter name 2018-05-21 12:48:04 -07:00
divelogimportdialog.h Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
divelogimportdialog.ui Use icons relative path. 2017-11-30 23:14:46 -08:00
divepicturewidget.cpp Implement different zoom levels for dive photos tab 2017-12-18 12:07:10 -08:00
divepicturewidget.h Implement different zoom levels for dive photos tab 2017-12-18 12:07:10 -08:00
diveplanner.cpp Planner: Add combo box for dive mode selection 2018-05-14 23:47:00 +03:00
diveplanner.h Core: remove dive.h from files that don't need it 2018-05-14 10:13:39 -07:00
diveplanner.ui Choose water presets from a qcombobox in planner, custom value possible 2018-03-02 08:38:22 -08:00
diveshareexportdialog.cpp Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
diveshareexportdialog.h Random whitespace cleanup 2017-05-27 11:07:20 -07:00
diveshareexportdialog.ui Move qt-ui to desktop-widgets 2015-10-30 10:36:49 -07:00
downloadfromdivecomputer.cpp desktop-widgets: Change Q_UNUSED to no parameter name 2018-05-21 12:48:04 -07:00
downloadfromdivecomputer.h Fix memory leak in download-from-dive-computer widget 2017-11-11 21:01:42 +01:00
downloadfromdivecomputer.ui Use icons relative path. 2017-11-30 23:14:46 -08:00
filterwidget.ui Use better aliases for icons. 2017-11-30 23:14:46 -08:00
groupedlineedit.cpp Unused code: GroupedLineEdit::removeAllColors() 2018-01-10 16:45:42 +01:00
groupedlineedit.h Unused code: GroupedLineEdit::removeAllColors() 2018-01-10 16:45:42 +01:00
kmessagewidget.cpp Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
kmessagewidget.h Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
listfilter.ui Add tool tip for negate filter button 2017-12-30 08:15:11 -08:00
locationinformation.cpp desktop-widgets: Change Q_UNUSED to no parameter name 2018-05-21 12:48:04 -07:00
locationinformation.h locationinformation: don't update map location on typing 2017-11-27 22:59:22 +01:00
locationInformation.ui Use correct alias for satellite icon for revers geo lookup 2018-01-27 12:29:00 -08:00
mainwindow.cpp Cleanup: remove three instances of deleteLater() in mainwindow.cpp 2018-05-26 09:21:46 -07:00
mainwindow.h Desktop: On dive edit from the dive list or map, switch to new state 2018-05-13 07:08:34 -07:00
mainwindow.ui Turn take-cloud-online menu action into checkbox 2018-01-06 10:46:07 -08:00
mapwidget.cpp Core: remove dive.h from files that don't need it 2018-05-14 10:13:39 -07:00
mapwidget.h map-widget: allow real-time updates of edited markers 2017-11-09 12:40:25 -08:00
modeldelegates.cpp desktop-widgets: Change Q_UNUSED to no parameter name 2018-05-21 12:48:04 -07:00
modeldelegates.h Planner: Add combo box for dive mode selection 2018-05-14 23:47:00 +03:00
notificationwidget.cpp Use queued connection to thread-safe MainWindow error handling 2018-01-31 14:47:26 +01:00
notificationwidget.h Use queued connection to thread-safe MainWindow error handling 2018-01-31 14:47:26 +01:00
plannerDetails.ui Bring back style sheet HTML for planner output 2017-02-24 01:06:09 -08:00
plannerSettings.ui Planner and profile limit minimum GFlow to 10 and minimum GFhigh to 40 2017-11-13 11:53:55 +01:00
printdialog.cpp desktop-widgets: Change Q_UNUSED to no parameter name 2018-05-21 12:48:04 -07:00
printdialog.h Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
printer.cpp Dive pictures: Don't plot pictures twice when changing current dive 2018-05-17 07:24:54 -07:00
printer.h Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
printoptions.cpp Fix typo connot > cannot. 2017-11-28 11:36:19 +02:00
printoptions.h cleanup: Uninitialized pointer field 2017-12-29 09:14:20 -08:00
printoptions.ui Move qt-ui to desktop-widgets 2015-10-30 10:36:49 -07:00
qtwaitingspinner.cpp Move qt-ui to desktop-widgets 2015-10-30 10:36:49 -07:00
qtwaitingspinner.h Move qt-ui to desktop-widgets 2015-10-30 10:36:49 -07:00
renumber.ui Use icons relative path. 2017-11-30 23:14:46 -08:00
searchbar.ui Use better aliases for icons. 2017-11-30 23:14:46 -08:00
setpoint.ui Use icons relative path. 2017-11-30 23:14:46 -08:00
shiftimagetimes.ui Use icons relative path. 2017-11-30 23:14:46 -08:00
shifttimes.ui Use icons relative path. 2017-11-30 23:14:46 -08:00
simplewidgets.cpp desktop-widgets: Change Q_UNUSED to no parameter name 2018-05-21 12:48:04 -07:00
simplewidgets.h Turn filter list options into context menu 2017-12-26 13:08:49 -08:00
starwidget.cpp desktop-widgets: Change Q_UNUSED to no parameter name 2018-05-21 12:48:04 -07:00
starwidget.h Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
subsurfacewebservices.cpp desktop-widgets: replace (void) with no parameter name 2018-05-24 08:34:14 -07:00
subsurfacewebservices.h Remove redundant declaration of set_userid() 2017-11-26 23:17:23 +01:00
tableview.cpp Use better aliases for icons. 2017-11-30 23:14:46 -08:00
tableview.h Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
tableview.ui Move qt-ui to desktop-widgets 2015-10-30 10:36:49 -07:00
tagwidget.cpp Show all autocompletes after entry of comma in tag list 2017-11-17 09:19:03 +01:00
tagwidget.h Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
templateedit.cpp Fix includes for building against Qt-5.11.0 2018-05-23 13:29:37 +03:00
templateedit.h Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
templateedit.ui templateedit.ui: give the layout for "Border width" unique name 2017-03-12 09:19:03 -07:00
templatelayout.cpp Cleanup: consistently use qPrintable() 2018-03-14 13:55:36 +02:00
templatelayout.h Use temperature_t for temperatures in struct stats_t 2018-02-24 11:45:17 -08:00
undocommands.cpp Core: introduce new subsurface-string header 2018-05-14 10:13:39 -07:00
undocommands.h Core: remove dive.h from files that don't need it 2018-05-14 10:13:39 -07:00
updatemanager.cpp desktop-widgets isn't built for mobile 2017-12-01 13:29:13 -08:00
updatemanager.h Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
urldialog.ui Make the URL dialog contain QLineEdit 2017-01-12 14:06:54 -08:00
usermanual.cpp Use better aliases for icons. 2017-11-30 23:14:46 -08:00
usermanual.h Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
usersurvey.cpp Use icons relative path. 2017-11-30 23:14:46 -08:00
usersurvey.h Add SPDX header to desktop widgets 2017-04-29 13:32:55 -07:00
usersurvey.ui fix: User survey UI. 2017-03-06 06:40:00 -08:00
webservices.ui Use icons relative path. 2017-11-30 23:14:46 -08:00