mirror of
https://github.com/subsurface/subsurface.git
synced 2025-02-19 22:16:15 +00:00
f5b11daffd
Currently, get_gasmix_from_event() and get_gasmix() return pointers to either static or to (possibly changing) dive data. This seems like a dangerous practice and the returned data should be used immediately. Instead, return the gasmix by value. This is in preparation of const-ifying input parameters of a number of core functions, which will ultimately let the merge() function take const-arguments in preparation of undo of dive-merging. On common 64-bit systems gasmix (two "int"s) is the size of a pointer and can be returned in a register. On 32-bit systems a pointer to the struct to be filled out will be passed. Since get_gasmix() now returns a value, the first invocation is tested by a NULL-initialized "struct event *". Document this in a comment. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at> |
||
|---|---|---|
| .. | ||
| animationfunctions.cpp | ||
| animationfunctions.h | ||
| CMakeLists.txt | ||
| divecartesianaxis.cpp | ||
| divecartesianaxis.h | ||
| diveeventitem.cpp | ||
| diveeventitem.h | ||
| divelineitem.cpp | ||
| divelineitem.h | ||
| divepixmapitem.cpp | ||
| divepixmapitem.h | ||
| diveprofileitem.cpp | ||
| diveprofileitem.h | ||
| diverectitem.cpp | ||
| diverectitem.h | ||
| divetextitem.cpp | ||
| divetextitem.h | ||
| divetooltipitem.cpp | ||
| divetooltipitem.h | ||
| profilewidget2.cpp | ||
| profilewidget2.h | ||
| qmlprofile.cpp | ||
| qmlprofile.h | ||
| ruleritem.cpp | ||
| ruleritem.h | ||
| tankitem.cpp | ||
| tankitem.h | ||