subsurface/core
Berthold Stoeger f5eafe2a71 Cleanup: Fold add_hash() call into learnHash() function
learnHash() was always called in conjunction with add_hash(). The
pattern was that a local filename and a hash were connected in
the hash-to-filename and the filename-to-hash maps. Then, the
original picture-filename or url were registered in the filename-to-hash
map.

This commit changes learnHash() to take three parameters (original-filename,
local-filename and hash) and do all of the above. The new code is
simpler because no dummy picture struct has to be generated in
DiveListView::loadImageFromURL().

The tests were extended to check for all hash<->filename associations.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2018-03-05 18:04:57 +02:00
..
subsurface-qt For prefs option show_icd add missing call for loading 2018-02-25 02:04:30 +02:00
android.cpp win32: optimize the console and logging logic 2017-11-03 07:49:11 -07:00
btdiscovery.cpp Cleanup: Use QString as parameter for [get|save]BtDeviceInfo() 2018-02-26 08:52:34 +01:00
btdiscovery.h Cleanup: Use QString as parameter for [get|save]BtDeviceInfo() 2018-02-26 08:52:34 +01:00
checkcloudconnection.cpp Allocate CheckCloudConnection object on stack 2017-12-06 02:23:47 +01:00
checkcloudconnection.h Remove self-include of core/checkcloudconnection.h 2017-12-06 02:23:47 +01:00
cloudstorage.cpp Cleanup: remove outdated TODO item 2018-02-12 11:11:34 -08:00
cloudstorage.h Remove bogus member that hides global variable 2017-10-26 20:44:02 +02:00
CMakeLists.txt Refactor CSV import 2018-01-08 06:06:12 +02:00
cochran.c Start cleaning up sensor indexing for multiple sensors 2017-07-21 16:33:19 -07:00
cochran.h Cochran import: better support for older models 2017-05-31 21:53:00 -07:00
color.cpp Typo: indice -> index 2018-01-10 21:25:02 +01:00
color.h Typo: indice -> index 2018-01-10 21:25:02 +01:00
compressibility.r Move subsurface-core to core and qt-mobile to mobile-widgets 2016-04-04 22:33:58 -07:00
configuredivecomputer.cpp Save Subsurface version to libdivecomputer logfile 2017-09-28 08:51:34 +02:00
configuredivecomputer.h Add SPDX header to remaining core files 2017-04-29 13:32:55 -07:00
configuredivecomputerthreads.cpp Configure DC dialog: Add a few missing translations 2018-03-05 16:19:49 +01:00
configuredivecomputerthreads.h Add SPDX header to remaining core files 2017-04-29 13:32:55 -07:00
connectionlistmodel.cpp Do not add double ConnectionList items 2018-01-24 16:19:09 +01:00
connectionlistmodel.h Add function to clear connectionModel data 2017-10-12 09:32:12 +02:00
datatrak.c Cleanup: avoid memory leak 2017-12-27 17:14:43 -08:00
datatrak.h Datatrak import rework: Add another memory size ckeck 2017-05-07 07:48:12 -07:00
deco.c Cleanup: Unify qthelper.h and qthelperfromc.h 2018-02-26 19:06:02 +02:00
deco.h Localize global planner state 2017-11-25 20:13:01 +01:00
device.c Init every struct sample with default values 2017-11-13 20:50:10 -08:00
device.h Add SPDX header to core C files 2017-04-29 13:32:55 -07:00
devicedetails.cpp Implement OSTC4 specific settings 2017-05-04 10:50:15 -07:00
devicedetails.h Implement OSTC4 specific settings 2017-05-04 10:50:15 -07:00
display.h Display values in info box only if value is interesting 2017-11-13 20:50:10 -08:00
dive.c Updated strategy for removing cylinders 2018-02-27 09:17:57 +01:00
dive.h Updated strategy for removing cylinders 2018-02-27 09:17:57 +01:00
divecomputer.cpp Use helper function empty_string() instead of manual checks 2018-01-11 06:07:13 +01:00
divecomputer.h Add SPDX header to remaining core files 2017-04-29 13:32:55 -07:00
divelist.c Cleanup: Unify qthelper.h and qthelperfromc.h 2018-02-26 19:06:02 +02:00
divelist.h Unused code: remove trip_has_selected_dives() 2018-01-10 16:45:42 +01:00
divelogexportlogic.cpp Whitespace cleanup in core/divelogexportlogic.cpp 2018-02-24 11:45:17 -08:00
divelogexportlogic.h Add SPDX header to remaining core files 2017-04-29 13:32:55 -07:00
divesite-helper.cpp Cleanup: rename file to avoid confusion 2017-12-08 16:29:49 +01:00
divesite.c Introduce helper function empty_string() 2018-01-11 06:07:13 +01:00
divesite.h Tags for geo references: Nicer look, translations and warning message 2017-10-17 06:12:07 -04:00
divesitehelpers.cpp Remove unused urls 2018-01-06 09:21:16 +01:00
divesitehelpers.h Add SPDX header to remaining core files 2017-04-29 13:32:55 -07:00
downloadfromdcthread.cpp Workaround for invalid bluetooth device names 2017-12-31 07:56:33 -08:00
downloadfromdcthread.h Make Bluetooth naming consistent 2017-11-13 20:48:17 -08:00
equipment.c Unused code: remove weightsystems_equal() 2018-01-10 16:45:42 +01:00
errorhelper.c Make report_error() reentrant 2018-01-31 14:47:26 +01:00
exif.cpp Coding-style: remove superfluous parentheses 2018-02-17 19:38:52 -08:00
exif.h Add SPDX header to remaining core files 2017-04-29 13:32:55 -07:00
file.c Cleanup: Unify qthelper.h and qthelperfromc.h 2018-02-26 19:06:02 +02:00
file.h Make a few functions of static linkage 2018-01-08 09:52:55 +02:00
gas-model.c Compute and display gas density 2017-05-26 15:52:04 -07:00
gaspressures.c Cleanup: durations are now signed 2017-12-17 10:25:01 -08:00
gaspressures.h Add SPDX header to remaining core files 2017-04-29 13:32:55 -07:00
gettext.h Add SPDX header to remaining core files 2017-04-29 13:32:55 -07:00
gettextfromc.cpp Remove superfluous QScopedPointer<>s in singletons 2017-12-24 11:04:10 -08:00
gettextfromc.h Add SPDX header to remaining core files 2017-04-29 13:32:55 -07:00
git-access.c Cleanup: Unify qthelper.h and qthelperfromc.h 2018-02-26 19:06:02 +02:00
git-access.h Support non-https:// repositories for saving 2018-01-19 09:45:08 +02:00
gpslocation.cpp GpsLocation::clearGpsData() is only used in SUBSURFACE_MOBILE 2018-01-10 16:45:42 +01:00
gpslocation.h GpsLocation::clearGpsData() is only used in SUBSURFACE_MOBILE 2018-01-10 16:45:42 +01:00
helpers.h Use correct numeric format based on selected locale (Qt domain part) 2018-03-05 16:28:18 +01:00
imagedownloader.cpp Cleanup: Fold add_hash() call into learnHash() function 2018-03-05 18:04:57 +02:00
imagedownloader.h core/imagedownloader.cpp: remove recursion 2018-03-05 18:04:57 +02:00
import-cobalt.c Move Cobalt DB import to its own file 2017-11-29 01:22:17 +01:00
import-csv.c Cleanup: Unify qthelper.h and qthelperfromc.h 2018-02-26 19:06:02 +02:00
import-csv.h Make a few functions of static linkage 2018-01-08 09:52:55 +02:00
import-divinglog.c Check different sensors on divinglog import 2017-12-27 20:45:24 +01:00
import-shearwater.c Move Shearwater DB import into its own file 2017-11-29 01:22:17 +01:00
import-suunto.c Cleanup: durations are now signed 2017-12-17 10:25:01 -08:00
isocialnetworkintegration.cpp Add SPDX header to remaining core files 2017-04-29 13:32:55 -07:00
isocialnetworkintegration.h Add SPDX header to remaining core files 2017-04-29 13:32:55 -07:00
libdivecomputer.c Coding-style: remove superfluous parentheses 2018-02-17 19:38:52 -08:00
libdivecomputer.h QML UI: add dev_info data to AppLog 2017-07-09 12:50:22 -07:00
linux.c Coding-style: remove superfluous parentheses 2018-02-17 19:38:52 -08:00
liquivision.c cleanup: initilize local variable 2018-01-10 16:45:42 +01:00
load-git.c Cleanup: Unify qthelper.h and qthelperfromc.h 2018-02-26 19:06:02 +02:00
macos.c Coding-style: remove superfluous parentheses 2018-02-17 19:38:52 -08:00
membuffer.c Localization: Make Qt's locale-aware formatting accessible from C 2018-03-05 16:23:55 +01:00
membuffer.h Localization: Make Qt's locale-aware formatting accessible from C 2018-03-05 16:23:55 +01:00
metrics.cpp Add SPDX header to remaining core files 2017-04-29 13:32:55 -07:00
metrics.h Add SPDX header to remaining core files 2017-04-29 13:32:55 -07:00
ostctools.c cleanup: Unchecked return value from library 2017-12-29 09:14:20 -08:00
parse-xml.c Warning Fix: add missing include to core/parse-xml.c 2018-03-02 02:46:31 +02:00
parse.c Coding-style: remove superfluous parentheses 2018-02-17 19:38:52 -08:00
parse.h Don't define cur_setting in header file 2018-01-05 00:29:20 +01:00
planner.c Cleanup: Unify qthelper.h and qthelperfromc.h 2018-02-26 19:06:02 +02:00
planner.h Move planner notes to separate file 2017-05-26 15:44:36 -07:00
plannernotes.c Localization: implement *_loc() functions in plannernotes.c 2018-03-05 16:23:55 +01:00
pluginmanager.cpp Unused code: remove PluginManager::socialNetworkIntegrationPlugins() 2018-01-10 16:45:42 +01:00
pluginmanager.h Unused code: remove PluginManager::socialNetworkIntegrationPlugins() 2018-01-10 16:45:42 +01:00
pref.h Add a preference to turn on ICD warnings 2018-02-10 10:26:34 +01:00
prefs-macros.h Fix ownership issues in preferences code 2017-11-25 07:41:09 -08:00
profile.c Localization: implement *_loc() functions in profile.c 2018-03-05 16:23:55 +01:00
profile.h Hand planner variables to profile 2017-11-25 20:13:01 +01:00
qt-ble.cpp Cleanup: Use QString as parameter for [get|save]BtDeviceInfo() 2018-02-26 08:52:34 +01:00
qt-ble.h iOS build: need to more includes 2017-07-19 06:21:23 -07:00
qt-gui.h Remove dead code 2017-11-19 12:20:43 -08:00
qt-init.cpp Use different preference file for mobile 2018-01-19 09:39:07 +02:00
qthelper.cpp Cleanup: Fold add_hash() call into learnHash() function 2018-03-05 18:04:57 +02:00
qthelper.h Cleanup: Fold add_hash() call into learnHash() function 2018-03-05 18:04:57 +02:00
qtserialbluetooth.cpp Fix typo: successfull -> successful and succesfully -> successfully 2017-11-20 10:01:15 +01:00
save-git.c Cleanup: Unify qthelper.h and qthelperfromc.h 2018-02-26 19:06:02 +02:00
save-html.c Cleanup: Unify qthelper.h and qthelperfromc.h 2018-02-26 19:06:02 +02:00
save-html.h Add SPDX header to core C files 2017-04-29 13:32:55 -07:00
save-xml.c Cleanup: Unify qthelper.h and qthelperfromc.h 2018-02-26 19:06:02 +02:00
serial_ftdi.c Update to the latest libdc version 2017-12-12 21:16:19 -08:00
sha1.c Move subsurface-core to core and qt-mobile to mobile-widgets 2016-04-04 22:33:58 -07:00
sha1.h Move subsurface-core to core and qt-mobile to mobile-widgets 2016-04-04 22:33:58 -07:00
statistics.c Updated strategy for removing cylinders 2018-02-27 09:17:57 +01:00
statistics.h Use duration_t for total_sac_time in struct stats_t 2018-02-24 11:45:17 -08:00
strndup.h Add SPDX header to core C files 2017-04-29 13:32:55 -07:00
strtod.c Add SPDX header to core C files 2017-04-29 13:32:55 -07:00
subsurfacestartup.c Cleanup: Unify qthelper.h and qthelperfromc.h 2018-02-26 19:06:02 +02:00
subsurfacestartup.h Fix ownership issues in preferences code 2017-11-25 07:41:09 -08:00
subsurfacesysinfo.cpp Random whitespace cleanup 2017-05-27 11:07:20 -07:00
subsurfacesysinfo.h Add SPDX header to remaining core files 2017-04-29 13:32:55 -07:00
taxonomy.c Fix two bugs in taxonomy_set_country 2017-10-07 08:16:53 -07:00
taxonomy.h Add taxonomy helper functions 2017-10-04 08:05:09 -07:00
time.c Add SPDX header to core C files 2017-04-29 13:32:55 -07:00
uemis-downloader.c uemis: code refactoring 2018-01-31 14:47:47 +01:00
uemis.c cleanup: fix possbile buffer overrun 2018-01-10 16:45:42 +01:00
uemis.h Add SPDX header to core C files 2017-04-29 13:32:55 -07:00
units.h Choose water presets from a qcombobox in planner, custom value possible 2018-03-02 08:38:22 -08:00
version.c Add SPDX header to remaining core files 2017-04-29 13:32:55 -07:00
version.h Move subsurface-core to core and qt-mobile to mobile-widgets 2016-04-04 22:33:58 -07:00
webservice.h Add SPDX header to remaining core files 2017-04-29 13:32:55 -07:00
windows.c Coding-style: remove superfluous parentheses 2018-02-17 19:38:52 -08:00
windowtitleupdate.cpp Add SPDX header to remaining core files 2017-04-29 13:32:55 -07:00
windowtitleupdate.h Add SPDX header to remaining core files 2017-04-29 13:32:55 -07:00
worldmap-options.h Add SPDX header to core C files 2017-04-29 13:32:55 -07:00
worldmap-save.c worldmap-save: don't use an API key 2017-07-30 16:28:30 -07:00
worldmap-save.h Add SPDX header to core C files 2017-04-29 13:32:55 -07:00