mirror of
https://github.com/subsurface/subsurface.git
synced 2024-11-28 05:00:20 +00:00
ce140f2925
An interesting crash: 1) On the dive site tab select a dive site such that only one trip is shown. 2) Unselect all dives. 3) Press CTRL-A while the dive list has focus. 4) This will select a trip. 5) In MainTab::updateDiveInfo() this will switch to the previous tab active when in trip mode. 6) This will reset the filter. 7) This will reset the currentTrip field which we just set. 8) Since we just set the currentTrip field, we don't expect it to change and reference a null pointer. To fix, don't switch tabs when on the dive site tab. This also improves user experience as there seems to be no reason to switch away from the dive site tab. Currently the index of the dive site tab is hard-coded - this should be changed! Fixes #2077 Reported-by: Doug Junkins <junkins@foghead.com> Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at> |
||
|---|---|---|
| .. | ||
| maintab.cpp | ||
| maintab.h | ||
| maintab.ui | ||
| TabBase.cpp | ||
| TabBase.h | ||
| TabDiveEquipment.cpp | ||
| TabDiveEquipment.h | ||
| TabDiveEquipment.ui | ||
| TabDiveExtraInfo.cpp | ||
| TabDiveExtraInfo.h | ||
| TabDiveExtraInfo.ui | ||
| TabDiveInformation.cpp | ||
| TabDiveInformation.h | ||
| TabDiveInformation.ui | ||
| TabDivePhotos.cpp | ||
| TabDivePhotos.h | ||
| TabDivePhotos.ui | ||
| TabDiveSite.cpp | ||
| TabDiveSite.h | ||
| TabDiveSite.ui | ||
| TabDiveStatistics.cpp | ||
| TabDiveStatistics.h | ||
| TabDiveStatistics.ui | ||