mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Desktop: Change 'CSV summary dive details' output from TSV to CSV.

Browse source 
Change the output formato for the Export / 'CSV summary dive details'
from TSV to CSV, to make it consistent with the menu item name, and with
the other 'CSV' export function.
This was changed to TSV by @mturkia in
6c82578540,
but I could not find any discussion as to why.
Also removed replacement of the field separator in any fields, as,
according to the CSV RFC (https://datatracker.ietf.org/doc/html/rfc4180)
this is not required as long as the fields containing separators are
enclosed in quotes, and any quotes within the fields are doubled up.
Tested with a fairly large log file, and importing into Google Sheets is
working fine for the output produced.
Also made capitalisation of the Export menu items consistent.

Signed-off-by: Michael Keller <github@ike.ch>
This commit is contained in:
Michael Keller 2023-04-28 13:15:31 +12:00 • committed by mturkia
parent cf95c3bd82
commit 1bd7806dcf
3 changed files with 16 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

4
desktop-widgets/divelogexportdialog.ui
View file

@ -267,7 +267,7 @@
<item>
<widget class="QRadioButton" name="exportCSV">
<property name="text">
<string>CSV Dive computer dive profile</string>
<string>CSV dive computer dive profile</string>
</property>
<attribute name="buttonGroup">
<string notr="true">exportGroup</string>
@ -277,7 +277,7 @@
<item>
<widget class="QRadioButton" name="exportProfileData">
<property name="text">
<string>CSV Computed Profile Panel data</string>
<string>CSV computed profile panel data</string>
</property>
<attribute name="buttonGroup">
<string notr="true">exportGroup</string>