mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix possible crash attempting network connection

Browse source 
If we didn't get back a JSON encoded string (i.e., if the response
contained no '"') we would access a QList past its boundary.

I'm somewhat hopeful that this is a last second fix for an annoying bug
I've been trying to figure out for a while.

See #514

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Dirk Hohndel 2014-08-08 10:39:46 -07:00
parent 6fdbf2069d
commit 4a125384ac
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
qt-ui/updatemanager.cpp
View file

@ -47,7 +47,11 @@ void UpdateManager::requestReceived()
} else {
//No network error
QString response(reply->readAll());
QString responseBody = response.split("\"").at(1);
QString responseBody;
if (response.contains('"'))
responseBody = response.split("\"").at(1);
else
responseBody = response;
msgbox.setIcon(QMessageBox::Information);