mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2024-11-30 22:20:21 +00:00
Code Issues Projects Releases Packages Wiki Activity

Cleanup: Remove 'data' field from 'DeviceDetails'.

Browse source 
`device_data_t data` in DeviceDetails has never been populated since it was first
added, and consequently is not used. This is confusing, especially as certain
fields inside `device_data_t` have been added directly to `DeviceDetails` in the meantime (e.g. `firmwareVersion`).

Separated from #3568 as per
https://github.com/subsurface/subsurface/pull/3568#pullrequestreview-1274995287.

Signed-off-by: Michael Keller <github@ike.ch>
This commit is contained in:
Michael Keller 2023-01-31 11:14:37 +13:00 committed by bstoeger
parent 7ecc4c7034
commit ada32f999e
2 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
core/devicedetails.cpp
View file

@ -13,7 +13,6 @@ setpoint::setpoint(unsigned char sp, unsigned char depth) :
DeviceDetails::DeviceDetails(QObject *parent) : DeviceDetails::DeviceDetails(QObject *parent) :
QObject(parent), QObject(parent),
data(0),
syncTime(false), syncTime(false),
setPointFallback(0), setPointFallback(0),
ccrMode(0), ccrMode(0),

1
core/devicedetails.h
View file

@ -26,7 +26,6 @@ class DeviceDetails : public QObject
public: public:
explicit DeviceDetails(QObject *parent = 0); explicit DeviceDetails(QObject *parent = 0);
device_data_t *data;
QString serialNo; QString serialNo;
QString firmwareVersion; QString firmwareVersion;
QString customText; QString customText;