mirror of
https://github.com/subsurface/subsurface.git
synced 2025-02-01 02:23:25 +00:00
a554c66fa3
This bug admittedly hits almost nobody, but if you had multiple cylinder pressure sensors on the same cylinder (attached to multiple dive computers, of course), we would take the beginning pressure from the first dive computer, and the ending pressure from the last dive computer. That came about because we'd just walk all the dive computer samples in order, and the first time we see a relevant sample and we don't have a beginning pressure, we'd take that pressure. So the beginning pressure was from the first dive computer, and once we'd seen a valid beginning pressure, that would never change. But as we're walking along, we'd continue to update the ending pressure from the last relevant sample we see, which means that as we go on to look at the other dive computers, we'd continue to update the ending pressure with data from them. And mixing beginning/ending pressures from two different sensors just does not make sense. This changes the logic to be the same for beginning and ending pressures: we only update it once, with the first relevant sample we see. But we walk the samples twice: forwards from the beginning to find the first beginning pressure, and backwards from the end to find the ending pressure. That means that as we move on to the second dive computer, we've now filled in the ending pressure from the first one, and will no longer update it any more. NOTE! We don't stop scanning the samples (or the dive computers) just because we've found a valid pressure value. We'll always walk all the samples because there might be multiple different cylinders that get pressure data from different samples (and different dive computers). We could have some early-out logic when we've filled in all relevant cylinders, but since this just runs once per dive it's not worth it. Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Dirk Hohndel <dirk@hohndel.org> |
||
|---|---|---|
| .. | ||
| subsurface-qt | ||
| android.cpp | ||
| checkcloudconnection.cpp | ||
| checkcloudconnection.h | ||
| cloudstorage.cpp | ||
| cloudstorage.h | ||
| CMakeLists.txt | ||
| cochran.c | ||
| cochran.h | ||
| color.cpp | ||
| color.h | ||
| compressibility.r | ||
| configuredivecomputer.cpp | ||
| configuredivecomputer.h | ||
| configuredivecomputerthreads.cpp | ||
| configuredivecomputerthreads.h | ||
| datatrak.c | ||
| datatrak.h | ||
| deco.c | ||
| deco.h | ||
| device.c | ||
| device.h | ||
| devicedetails.cpp | ||
| devicedetails.h | ||
| display.h | ||
| dive.c | ||
| dive.h | ||
| divecomputer.cpp | ||
| divecomputer.h | ||
| divelist.c | ||
| divelist.h | ||
| divelogexportlogic.cpp | ||
| divelogexportlogic.h | ||
| divesite.c | ||
| divesite.cpp | ||
| divesite.h | ||
| divesitehelpers.cpp | ||
| divesitehelpers.h | ||
| equipment.c | ||
| exif.cpp | ||
| exif.h | ||
| file.c | ||
| file.h | ||
| gas-model.c | ||
| gaspressures.c | ||
| gaspressures.h | ||
| gettext.h | ||
| gettextfromc.cpp | ||
| gettextfromc.h | ||
| git-access.c | ||
| git-access.h | ||
| gpslocation.cpp | ||
| gpslocation.h | ||
| helpers.h | ||
| imagedownloader.cpp | ||
| imagedownloader.h | ||
| isocialnetworkintegration.cpp | ||
| isocialnetworkintegration.h | ||
| libdivecomputer.c | ||
| libdivecomputer.h | ||
| linux.c | ||
| liquivision.c | ||
| load-git.c | ||
| macos.c | ||
| membuffer.c | ||
| membuffer.h | ||
| metrics.cpp | ||
| metrics.h | ||
| ostctools.c | ||
| parse-xml.c | ||
| planner.c | ||
| planner.h | ||
| pluginmanager.cpp | ||
| pluginmanager.h | ||
| pref.h | ||
| prefs-macros.h | ||
| profile.c | ||
| profile.h | ||
| qt-gui.h | ||
| qt-init.cpp | ||
| qthelper.cpp | ||
| qthelper.h | ||
| qthelperfromc.h | ||
| qtserialbluetooth.cpp | ||
| save-git.c | ||
| save-html.c | ||
| save-html.h | ||
| save-xml.c | ||
| serial_ftdi.c | ||
| sha1.c | ||
| sha1.h | ||
| statistics.c | ||
| statistics.h | ||
| strndup.h | ||
| strtod.c | ||
| subsurfacestartup.c | ||
| subsurfacestartup.h | ||
| subsurfacesysinfo.cpp | ||
| subsurfacesysinfo.h | ||
| taxonomy.c | ||
| taxonomy.h | ||
| time.c | ||
| uemis-downloader.c | ||
| uemis.c | ||
| uemis.h | ||
| units.h | ||
| version.c | ||
| version.h | ||
| webservice.h | ||
| windows.c | ||
| windowtitleupdate.cpp | ||
| windowtitleupdate.h | ||
| worldmap-options.h | ||
| worldmap-save.c | ||
| worldmap-save.h | ||