subsurface/core
Berthold Stoeger 3aa1bb5bfa core: add remove_event_from_dc() function
We have a remove_event() function that
1) frees the event
2) works on the current divecomputer
3) compares the events because the profile has copies of events

However, for undo commands
1) we want to keep the event so that we can readd it later
2) we have to work on arbitrary divecomputers
3) we don't work with copies of events

Therefore, create a new remove_event_from_dc() function that
does all that. Moreover, make the event argument to remove_event()
const to (slightly) point out the difference in the API.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2020-04-07 00:13:35 +02:00
..
settings cleanup: don't call uiLanguage() in qPref::loadSync() 2020-03-22 12:01:09 -07:00
subsurface-qt undo: add cylinder undo commands by copy & paste 2020-04-07 00:13:34 +02:00
android.cpp android/usb: simply restart the download after receiving permission 2020-03-16 07:58:20 -07:00
applicationstate.cpp Turn application state into enum 2019-05-12 12:33:55 -07:00
applicationstate.h Turn application state into enum 2019-05-12 12:33:55 -07:00
btdiscovery.cpp Add Cressi BLE name filtering for bluetooth discovery 2020-02-16 12:52:56 -08:00
btdiscovery.h Revert the singleton PR 2019-09-27 16:26:58 -07:00
checkcloudconnection.cpp Cloud storage: remove outdated certificate hack 2019-10-09 22:38:29 +03:00
checkcloudconnection.h
cloudstorage.cpp core: correct cloudstorage.cpp to use static qPrefCloudStorage functions. 2019-12-05 11:48:26 -08:00
cloudstorage.h
CMakeLists.txt Add timestamps to libdivecomputer.log 2020-03-10 17:42:54 -07:00
cochran.c code cleanup: introduce empty_cylinder constant 2020-01-10 02:37:03 +09:00
cochran.h
color.cpp
color.h Indicate negative cylider pressure 2019-08-08 08:56:44 -07:00
compressibility.r
configuredivecomputer.cpp Cleanup: move file-related function declarations to file.h 2019-08-08 16:26:31 -07:00
configuredivecomputer.h Fix broken windows build with latest MXE 2019-08-29 12:55:25 -07:00
configuredivecomputerthreads.cpp Cleanup: move error reporting function declarations to errorhelper.h 2019-08-08 16:26:30 -07:00
configuredivecomputerthreads.h
connectionlistmodel.cpp Mobile: reinstate roleNames function in ConnectionListModel 2019-04-16 23:43:14 +12:00
connectionlistmodel.h Mobile: reinstate roleNames function in ConnectionListModel 2019-04-16 23:43:14 +12:00
datatrak.c code cleanup: introduce empty_cylinder constant 2020-01-10 02:37:03 +09:00
datatrak.h
deco.c Parser: remove global state 2019-08-08 16:26:31 -07:00
deco.h Parser: remove global state 2019-08-08 16:26:31 -07:00
device.c
device.h Cleanup: move error reporting function declarations to errorhelper.h 2019-08-08 16:26:30 -07:00
devicedetails.cpp
devicedetails.h
display.h Selection: move selection functions from divelist.c to selection.c 2019-12-04 13:00:23 +01:00
dive.c core: add remove_event_from_dc() function 2020-04-07 00:13:35 +02:00
dive.h core: add remove_event_from_dc() function 2020-04-07 00:13:35 +02:00
divecomputer.cpp Cleanup: move error reporting function declarations to errorhelper.h 2019-08-08 16:26:30 -07:00
divecomputer.h
divefilter.cpp Filter: hide invalid dives 2020-03-20 15:20:44 -07:00
divefilter.h filter: implement searching for tags and people in mobile filter 2020-03-01 10:21:44 -08:00
divelist.c Core: consider invalid flag when adding dives 2020-03-20 15:20:44 -07:00
divelist.h Selection: move selection functions from divelist.c to selection.c 2019-12-04 13:00:23 +01:00
divelogexportlogic.cpp Cleanup: move error reporting function declarations to errorhelper.h 2019-08-08 16:26:30 -07:00
divelogexportlogic.h
divemode.h Cleanup: move planner/deco related declarations planner/deco.h 2019-08-08 16:26:31 -07:00
divesite-helper.cpp
divesite.c mobile/edit: don't add dive site twice to table 2020-03-17 14:05:24 -07:00
divesite.h mobile/edit: don't add dive site twice to table 2020-03-17 14:05:24 -07:00
divesitehelpers.cpp cleanup: split uiLanguage() in two functions 2020-03-22 12:01:09 -07:00
divesitehelpers.h
downloadfromdcthread.cpp android/usb: better memory management 2020-03-16 07:58:20 -07:00
downloadfromdcthread.h android/usb: better memory management 2020-03-16 07:58:20 -07:00
equipment.c cleanup: move fill_default_cylinder from planner.c to equipment.c 2020-04-07 00:13:34 +02:00
equipment.h cleanup: move fill_default_cylinder from planner.c to equipment.c 2020-04-07 00:13:34 +02:00
errorhelper.c Don't expose 'detach_buffer()' to membuffer users 2019-10-27 12:42:54 -07:00
errorhelper.h Cleanup: move error reporting function declarations to errorhelper.h 2019-08-08 16:26:30 -07:00
exif.cpp
exif.h
file.c git: load into arbitrary dive tables 2020-03-17 16:50:20 -07:00
file.h Cleanup: move file-related function declarations to file.h 2019-08-08 16:26:31 -07:00
format.cpp
format.h
fulltext.cpp core/fulltext: give progress update while populating index 2020-04-04 12:00:25 -07:00
fulltext.h filter: compile fulltext index on mobile 2020-03-01 10:21:44 -08:00
gas-model.c Cleanup: replace macro by inline function in gas-model.c 2019-08-08 15:22:09 -07:00
gas.c Cleanup: move gas-functions to own translation unit 2019-06-19 13:11:10 -07:00
gas.h Cleanup: move gas-functions to own translation unit 2019-06-19 13:11:10 -07:00
gaspressures.c Cylinders: access cylinders with get_cylinder() 2019-11-09 19:19:04 +01:00
gaspressures.h Cleanup: Make gaspressures.h a regular include file 2019-06-19 13:11:10 -07:00
gettext.h
gettextfromc.cpp
gettextfromc.h
git-access.c Cleanup: move file-related function declarations to file.h 2019-08-08 16:26:31 -07:00
git-access.h git: load into arbitrary dive tables 2020-03-17 16:50:20 -07:00
gpslocation.cpp cleanup: remove unnecessary include 2020-03-19 00:25:13 +01:00
gpslocation.h mobile: use undo-command to apply gps fixes 2020-03-09 12:41:57 -07:00
imagedownloader.cpp code cleanup: consistently initialize zero duration_t 2020-01-10 02:37:03 +09:00
imagedownloader.h
import-cobalt.c Cleanup: return cylinder from cylinder_start() in parser 2019-11-09 19:19:04 +01:00
import-csv.c Correcting typos of the word celsius 2020-02-09 12:45:55 -08:00
import-csv.h
import-divinglog.c Cylinders: access cylinders with get_cylinder() 2019-11-09 19:19:04 +01:00
import-shearwater.c Cylinders: access cylinders with get_cylinder() 2019-11-09 19:19:04 +01:00
import-suunto.c Cleanup: return cylinder from cylinder_start() in parser 2019-11-09 19:19:04 +01:00
ios.cpp Cleanup: move file-related function declarations to file.h 2019-08-08 16:26:31 -07:00
libdivecomputer.c android/usb: pass in the UsbDevice when downloading 2020-03-16 07:58:20 -07:00
libdivecomputer.h android/usb: pass in the UsbDevice when downloading 2020-03-16 07:58:20 -07:00
liquivision.c code cleanup: introduce empty_cylinder constant 2020-01-10 02:37:03 +09:00
load-git.c cleanup: copy saved_git_id, don't use local buffer 2020-04-04 10:13:14 -07:00
macos.c Add missing header files to macos.c 2019-08-11 08:20:38 +02:00
membuffer.c Don't expose 'detach_buffer()' to membuffer users 2019-10-27 12:42:54 -07:00
membuffer.h Don't expose 'detach_buffer()' to membuffer users 2019-10-27 12:42:54 -07:00
metadata.cpp code cleanup: replace created() with birthTime() for Qt >= 5.10 2020-01-10 02:37:03 +09:00
metadata.h
metrics.cpp
metrics.h
ostctools.c Cleanup: clean up resource handling in ostctools.c 2019-10-26 19:17:53 -07:00
parse-gpx.cpp Parse GPX dive coordinates: Qt XML framework 2020-01-25 23:25:33 +02:00
parse-gpx.h cleanup: fix mis-spelling of UCT in comments as well 2020-03-19 08:41:19 -07:00
parse-xml.c Core: introduce invalid flag for dives 2020-03-20 15:20:44 -07:00
parse.c cleanup: remove record_dive() function 2020-03-17 16:50:20 -07:00
parse.h Cleanup: return cylinder from cylinder_start() in parser 2019-11-09 19:19:04 +01:00
planner.c cleanup: use SAMPLE_EVENT_BOOKMARK in add_event() calls 2020-04-07 00:13:35 +02:00
planner.h Cleanup: remove global disclaimer variable 2019-09-10 21:31:21 +02:00
plannernotes.c Cylinders: access cylinders with get_cylinder() 2019-11-09 19:19:04 +01:00
pref.h mobile: remove filter settings 2020-03-01 10:21:44 -08:00
profile.c Grammar: replaces 'indexes' by 'indices' 2020-03-11 08:26:30 -07:00
profile.h Add current GF to infobox 2019-11-28 12:23:04 -08:00
qt-ble.cpp Update to new libdivecomputer version 2020-01-27 09:51:31 -08:00
qt-ble.h Update to new libdivecomputer version 2020-01-27 09:51:31 -08:00
qt-gui.h
qt-init.cpp translations: use German translation for non-Swiss German locales 2020-03-22 12:02:48 -07:00
qthelper.cpp undo: reorder cylinders on remove-cylinder undo/redo 2020-04-07 00:13:35 +02:00
qthelper.h undo: reorder cylinders on remove-cylinder undo/redo 2020-04-07 00:13:35 +02:00
qtserialbluetooth.cpp iostream: fix incorrect rfcomm error case when writing 2020-03-14 11:34:46 -07:00
save-git.c Core: introduce invalid flag for dives 2020-03-20 15:20:44 -07:00
save-html.c Cleanup: remove const bool parameters and return types 2020-02-09 12:13:18 -08:00
save-html.h Cleanup: move error reporting function declarations to errorhelper.h 2019-08-08 16:26:30 -07:00
save-profiledata.c Cleanup: remove const bool parameters and return types 2020-02-09 12:13:18 -08:00
save-profiledata.h Cleanup: move file-related function declarations to file.h 2019-08-08 16:26:31 -07:00
save-xml.c Undo: implement invalidate-dive command 2020-03-20 15:20:44 -07:00
selection.cpp cleanup: remove current_dive parameter from divesSelected signal 2020-03-12 07:09:01 -07:00
selection.h Selection: provide convenience function for single-dive selection 2019-12-07 10:23:44 -08:00
serial_ftdi.c
serial_usb_android.cpp android/usb: remove "autoselect driver" option for unknown VID/PIDs 2020-03-16 07:58:20 -07:00
serial_usb_android.h android/usb: pass in the UsbDevice when downloading 2020-03-16 07:58:20 -07:00
sha1.c
sha1.h
ssrf.h core: remove LOG_STP from mobile 2019-12-13 07:04:00 -05:00
statistics.c Ignore invalid dives in statistics 2020-03-20 15:20:44 -07:00
statistics.h Core: dynamically allocate the result of get_gas_used() 2019-11-09 19:19:04 +01:00
strndup.h
strtod.c
structured_list.h Cleanup: fix comment to STRUCTURED_LIST_FREE 2019-06-19 13:11:10 -07:00
subsurface-string.h
subsurfacestartup.c mobile: allow disabling BT support from the command line 2020-03-06 10:00:13 +01:00
subsurfacestartup.h Cleanup: move error reporting function declarations to errorhelper.h 2019-08-08 16:26:30 -07:00
subsurfacesysinfo.cpp
subsurfacesysinfo.h
table.h Core: implement move functions for dive and dive_site table 2019-10-02 08:04:49 -07:00
tag.c Don't expose 'detach_buffer()' to membuffer users 2019-10-27 12:42:54 -07:00
tag.h Cleanup: move tag functions into own translation unit 2019-06-19 13:11:10 -07:00
taxonomy.c
taxonomy.h
time.c
timer.c Add timestamps to libdivecomputer.log 2020-03-10 17:42:54 -07:00
timer.h Add timestamps to libdivecomputer.log 2020-03-10 17:42:54 -07:00
trip.c core/trip handling: add helper function to get trip from id 2020-03-10 09:25:57 -07:00
trip.h core/trip handling: add helper function to get trip from id 2020-03-10 09:25:57 -07:00
uemis-downloader.c Check if all required bytes were read 2019-11-16 12:34:30 -08:00
uemis.c Core: remove MAX_CYLINDERS restriction 2019-11-09 19:19:04 +01:00
uemis.h
units.c Fix broken windows build with latest MXE 2019-08-29 12:55:25 -07:00
units.h mobile-widgets: add pure interface for passing values to QML 2020-01-18 17:31:58 -08:00
unix.c Don't expose 'detach_buffer()' to membuffer users 2019-10-27 12:42:54 -07:00
uploadDiveLogsDE.cpp core: fix incorrect changes in divelogs.de export 2020-02-17 10:50:51 -08:00
uploadDiveLogsDE.h Cleanup: remove const bool parameters and return types 2020-02-09 12:13:18 -08:00
uploadDiveShare.cpp core: divehare avoid race problem. 2019-12-12 10:10:01 -05:00
uploadDiveShare.h core: divehare change slot names 2019-12-12 10:10:01 -05:00
version.c
version.h
videoframeextractor.cpp Cleanup: move error reporting function declarations to errorhelper.h 2019-08-08 16:26:30 -07:00
videoframeextractor.h
webservice.h
windows.c Cleanup: move file-related function declarations to file.h 2019-08-08 16:26:31 -07:00
windowtitleupdate.cpp
windowtitleupdate.h
worldmap-options.h
worldmap-save.c Cleanup: remove const bool parameters and return types 2020-02-09 12:13:18 -08:00
worldmap-save.h Cleanup: remove const bool parameters and return types 2020-02-09 12:13:18 -08:00
xmp_parser.cpp Cleanup: use helper to avoid NULL dereference 2019-10-28 05:44:33 -07:00
xmp_parser.h