subsurface/qt-ui
Linus Torvalds 3aaf8b1f5a Make gas use statistics be coherent and more complete
The gas use logic in the dive statistics page is confused.

The SAC case had a special case for "unknown", but only for
the first gas. Other gases had the normal empty case.

Also, the logic was really odd - if you had gases that weren't used (or
pressures not known) intermixed with gases you *did* have pressure for,
the statistics got really confused.

The list of gases showed all gases that we know about during the dive,
but then the gas use and SAC-rate lists wouldn't necessarily match,
because the loops that computed those stopped after the first gas that
didn't have any pressure change.

To make things worse, the first cylinder was special-cased again, so it
all lined up for the single-cylinder case.

This makes all the cylinders act the same way, leaving unknown gas use
(and thus SAC) just empty for that gas.

It also fixes the SAC calculation case where we don't have real samples,
and the profile is a fake profile - possibly with gas changes in between
the fake points. We now make the SAC calculations match what we show -
which is admittedly not at all necessarily what the dive was, but at
least we're consistent.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2014-08-06 09:14:34 -07:00
..
css Fix TableWidget ( equipment ones ) on dark scheme. 2013-12-12 03:26:39 +01:00
marble Resync included header with upstream 2014-01-15 15:49:50 +07:00
profile Don't zoom the profile when the left button is pressed 2014-08-06 06:21:24 -07:00
about.cpp Quit Subsurface with about window in front 2014-04-25 10:21:55 -07:00
about.h Headers cleanup. 2014-06-26 15:47:02 -07:00
about.ui SubsurfaceAbout class cleanup. 2014-02-08 08:00:27 -08:00
completionmodels.cpp Gratuitous whitespace changes 2014-05-22 11:40:22 -07:00
completionmodels.h Put include guard to every header 2014-02-11 12:37:01 -08:00
divecomputermanagementdialog.cpp misc capitalisation and spelling 2014-07-11 07:06:26 -07:00
divecomputermanagementdialog.h Massive automated whitespace cleanup 2014-02-27 20:09:57 -08:00
divecomputermanagementdialog.ui divecomputermanagementdilog capitalisation consitency 2014-07-10 16:26:20 -07:00
divelistview.cpp Do not recreate all the dive just because a picture was added. 2014-08-04 10:38:00 -07:00
divelistview.h Fix crash when trying to add a dive or plan when a filter is active. 2014-06-26 15:49:19 -07:00
divelogexportdialog.cpp HTML: export yearly statistics to JSON files. 2014-08-04 10:03:12 -07:00
divelogexportdialog.h HTML: export yearly statistics to JSON files. 2014-08-04 10:03:12 -07:00
divelogexportdialog.ui Add missing application icon 2014-07-18 10:21:42 -07:00
divelogimportdialog.cpp Add quirks for Seabear CSV settings for pressure 2014-07-10 12:40:41 -07:00
divelogimportdialog.h Add support for importing pressure from CSV files 2014-07-10 12:40:25 -07:00
divelogimportdialog.ui divelogimportdialog capitalisation consitency 2014-07-10 16:27:50 -07:00
divepicturewidget.cpp Picture handling: cleaning up the mess 2014-08-05 12:37:14 -07:00
divepicturewidget.h Picture handling: cleaning up the mess 2014-08-05 12:37:14 -07:00
diveplanner.cpp Don't recalculate plan automatically with low GFHigh 2014-08-05 08:06:17 -07:00
diveplanner.h Don't recalculate plan automatically with low GFHigh 2014-08-05 08:06:17 -07:00
diveplanner.ui Planner: limit altitude and pressure 2014-07-15 17:19:49 -07:00
downloadfromdivecomputer.cpp Try to avoid inconsistent selection state after divecomputer download 2014-07-14 21:44:57 -07:00
downloadfromdivecomputer.h Headers cleanup. 2014-06-26 15:47:02 -07:00
downloadfromdivecomputer.ui downloadfromdivecomputer capitalisation consitency 2014-07-10 16:29:24 -07:00
globe.cpp Correctly remove the Close button from most message widgets 2014-08-04 22:45:17 -07:00
globe.h Headers cleanup. 2014-06-26 15:47:02 -07:00
graphicsview-common.cpp Make heartrate grid less confusing 2014-04-28 12:45:42 -07:00
graphicsview-common.h Make heartrate grid less confusing 2014-04-28 12:45:42 -07:00
groupedlineedit.cpp C++ Correctness and code cleanup. 2014-07-29 09:38:10 -07:00
groupedlineedit.h Massive automated whitespace cleanup 2014-02-27 20:09:57 -08:00
kmessagewidget.cpp Correctly remove the Close button from most message widgets 2014-08-04 22:45:17 -07:00
kmessagewidget.h Another small tweak to whitespace tool 2014-03-05 13:02:23 -08:00
maintab.cpp Make gas use statistics be coherent and more complete 2014-08-06 09:14:34 -07:00
maintab.h Maintab: fix trip location / notes editing 2014-07-30 08:52:11 -07:00
maintab.ui Fix time zone conversions 2014-07-29 13:01:46 -07:00
mainwindow.cpp Disable the Toolbox when in edit mode. 2014-08-04 09:48:35 -07:00
mainwindow.h Disable the Toolbox when in edit mode. 2014-08-04 09:48:35 -07:00
mainwindow.ui pN2 » pN₂, pO2 » pO₂ 2014-07-16 13:17:09 -07:00
modeldelegates.cpp Whitespace fixes. 2014-07-23 07:47:15 -07:00
modeldelegates.h Add the HTML Delegate to printing. 2014-07-18 10:14:27 -07:00
models.cpp Don't show a SAC of 0.0l/min (or cuft/min) 2014-08-06 07:39:19 -07:00
models.h Printing: print depth unit in table 2014-07-11 21:59:21 -07:00
plannerSettings.ui Fix unresizable DiveList 2014-08-04 09:49:51 -07:00
preferences.cpp Animation speed is a value, not a boolean 2014-07-23 07:50:03 -07:00
preferences.h Added a 'use default file' button on preferences. 2014-07-16 15:52:29 -07:00
preferences.ui Don't make the preferences dialog so huge 2014-08-06 07:51:12 -07:00
printdialog.cpp Printing: only give up if no size is available 2014-08-05 10:01:38 -07:00
printdialog.h Printing: only give up if no size is available 2014-08-05 10:01:38 -07:00
printlayout.cpp Print: rename the variable 'isHeading' to 'newHeading' 2014-08-05 12:49:35 -07:00
printlayout.h PrintLayout: disable the QPainter scaling 2014-07-24 21:06:19 -07:00
printoptions.cpp Printing: add 1 dive per page option 2014-07-24 11:33:28 -07:00
printoptions.h Printing: add 1 dive per page option 2014-07-24 11:33:28 -07:00
printoptions.ui Fix the layout on the Print Dialog 2014-08-04 09:50:55 -07:00
renumber.ui Make some dialogs modal to MainWindow 2014-03-12 10:14:17 -07:00
searchbar.ui Add a horizontal spacer to make the searchbar layout better 2014-07-11 17:00:23 -07:00
shiftimagetimes.ui shifimmagetimes capitalisation consitency and title 2014-07-11 07:05:10 -07:00
shifttimes.ui shiftimes capitalisation consitency and title 2014-07-11 07:05:17 -07:00
simplewidgets.cpp Misc UI capitalisation consitencies and other text changes 2014-07-11 10:44:09 -07:00
simplewidgets.h Calendar widget should hide when clicking somewhere else 2014-06-30 16:05:43 -07:00
starwidget.cpp Change the Star Widget to use QImage instead of QPixmap 2014-06-20 15:43:10 -07:00
starwidget.h Change the Star Widget to use QImage instead of QPixmap 2014-06-20 15:43:10 -07:00
subsurfacewebservices.cpp Web: use subsurface_fopen() for non-ASCII paths on Win32 2014-08-05 07:42:51 -07:00
subsurfacewebservices.h Give Subsurface a distinct User Agent string 2014-07-31 11:20:11 -07:00
tableview.cpp Misc UI capitalisation consitencies and other text changes 2014-07-11 10:44:09 -07:00
tableview.h Massive automated whitespace cleanup 2014-02-27 20:09:57 -08:00
tableview.ui Remove more unused windowTitle properties 2013-11-29 11:02:15 -08:00
tagwidget.cpp Misc UI capitalisation consitencies and other text changes 2014-07-11 10:44:09 -07:00
tagwidget.h Headers cleanup. 2014-06-26 15:47:02 -07:00
updatemanager.cpp Give Subsurface a distinct User Agent string 2014-07-31 11:20:11 -07:00
updatemanager.h Rely on QNetworkReply finished() signal instead of AccessManager one 2014-07-16 13:56:46 -07:00
usermanual.cpp Add missing application icon 2014-07-18 10:21:42 -07:00
usermanual.h Use a layout to lay down the search and the help 2014-07-11 16:59:14 -07:00
usersurvey.cpp Give Subsurface a distinct User Agent string 2014-07-31 11:20:11 -07:00
usersurvey.h Give Subsurface a distinct User Agent string 2014-07-31 11:20:11 -07:00
usersurvey.ui Fix layout for User Survey 2014-07-16 09:11:04 -07:00
webservices.ui webservice capitalisation consitency 2014-07-11 07:05:38 -07:00