mirror of
https://github.com/subsurface/subsurface.git
synced 2025-02-19 22:16:15 +00:00
f92e2e752f
fixup_dive_dc() is called for each dive computer when we add a new dive. It does various housekeeping functions, cleaning up the sample data, and fixing up dive details as a result of the sample data. The function has grown to be a monster over time, and particularly the central "walk every sample" loop has become an unreadable mess. And the thing is, this isn't even all that performance-critical: it's only done once per dive and dc, and there is no reason to have a single illegible and complex loop. So split up that loop into several smaller pieces that each will loop individually over the sample data, and do just one thing. So now we have separate functions for - fixing up the depth samples with interpolation - fixing up dive temperature data - correcting the cylinder pressure sensor index - cleaning up the actual sample pressures Yes, this way we walk the samples multiple times, but the end result is that the code is much easier to understand. There should be no actual behavioral differences from this cleanup, except for the fact that since the code is much more understandable, this cleanup also fixed a bug: In the temperature fixup, we would fix up the overall dive temperatures based on the dive computer temperatures. But we would then fix up the overall dive computer temperature based on the sample temperature *afterwards*, which wouldn't then be reflected in the overall dive temperatures. There was another non-symptomatic bug that became obvious when doing this cleanup: the code used to calculate a 'depthtime' over the dive that was never actually used. That's a historical artifact of old code that had become dead when the average depth calculations were moved to a function of their own earlier. This is preparatory for fixing the overall cylinder pressure stats, which are currently wrong for dives with multiple dive computers: we currently take the starting cylinder pressure from the *first* dive computer that has cylinder pressure information, but we take the ending cylinder pressure from the *last* dive computer with cylinder pressure information. This does not fix that bug, but without this cleanup fixing that would be a nightmare due to the previous complicated "do everything in one single loop" model. Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Dirk Hohndel <dirk@hohndel.org> |
||
|---|---|---|
| .. | ||
| subsurface-qt | ||
| android.cpp | ||
| checkcloudconnection.cpp | ||
| checkcloudconnection.h | ||
| cloudstorage.cpp | ||
| cloudstorage.h | ||
| CMakeLists.txt | ||
| cochran.c | ||
| cochran.h | ||
| color.cpp | ||
| color.h | ||
| compressibility.r | ||
| configuredivecomputer.cpp | ||
| configuredivecomputer.h | ||
| configuredivecomputerthreads.cpp | ||
| configuredivecomputerthreads.h | ||
| datatrak.c | ||
| datatrak.h | ||
| deco.c | ||
| deco.h | ||
| device.c | ||
| device.h | ||
| devicedetails.cpp | ||
| devicedetails.h | ||
| display.h | ||
| dive.c | ||
| dive.h | ||
| divecomputer.cpp | ||
| divecomputer.h | ||
| divelist.c | ||
| divelist.h | ||
| divelogexportlogic.cpp | ||
| divelogexportlogic.h | ||
| divesite.c | ||
| divesite.cpp | ||
| divesite.h | ||
| divesitehelpers.cpp | ||
| divesitehelpers.h | ||
| equipment.c | ||
| exif.cpp | ||
| exif.h | ||
| file.c | ||
| file.h | ||
| gas-model.c | ||
| gaspressures.c | ||
| gaspressures.h | ||
| gettext.h | ||
| gettextfromc.cpp | ||
| gettextfromc.h | ||
| git-access.c | ||
| git-access.h | ||
| gpslocation.cpp | ||
| gpslocation.h | ||
| helpers.h | ||
| imagedownloader.cpp | ||
| imagedownloader.h | ||
| isocialnetworkintegration.cpp | ||
| isocialnetworkintegration.h | ||
| libdivecomputer.c | ||
| libdivecomputer.h | ||
| linux.c | ||
| liquivision.c | ||
| load-git.c | ||
| macos.c | ||
| membuffer.c | ||
| membuffer.h | ||
| metrics.cpp | ||
| metrics.h | ||
| ostctools.c | ||
| parse-xml.c | ||
| planner.c | ||
| planner.h | ||
| pluginmanager.cpp | ||
| pluginmanager.h | ||
| pref.h | ||
| prefs-macros.h | ||
| profile.c | ||
| profile.h | ||
| qt-gui.h | ||
| qt-init.cpp | ||
| qthelper.cpp | ||
| qthelper.h | ||
| qthelperfromc.h | ||
| qtserialbluetooth.cpp | ||
| save-git.c | ||
| save-html.c | ||
| save-html.h | ||
| save-xml.c | ||
| serial_ftdi.c | ||
| sha1.c | ||
| sha1.h | ||
| statistics.c | ||
| statistics.h | ||
| strndup.h | ||
| strtod.c | ||
| subsurfacestartup.c | ||
| subsurfacestartup.h | ||
| subsurfacesysinfo.cpp | ||
| subsurfacesysinfo.h | ||
| taxonomy.c | ||
| taxonomy.h | ||
| time.c | ||
| uemis-downloader.c | ||
| uemis.c | ||
| uemis.h | ||
| units.h | ||
| version.c | ||
| version.h | ||
| webservice.h | ||
| windows.c | ||
| windowtitleupdate.cpp | ||
| windowtitleupdate.h | ||
| worldmap-options.h | ||
| worldmap-save.c | ||
| worldmap-save.h | ||