This marks the UI as modified and updates the maxdepth of the dive; it
ignores changes to the duration, doesn't modify the profile, so it's
nowhere near ready.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
And hide them for now. This doesn't change anything visible, it's just
putting in place the pieces for later use.
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Two different menu path lead to "open a logfile". The File-Open-Logfile
and Import-Import Logfile. The first opens a new logbook, and the second adds the
data to the current log.
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
Lets try to be consistent. A dive computer can be in upload mode, and is uploading, but
seen from the host PC, we are downloading.
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
The here edited section is confusing. It references double clicking,
which does not work in 4.6 (and not sure it ever worked)
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
Do not repeat the almost same text in the next sentence.
When entering a dive location name, auto location of
dive site names makes it easy to select an existing dive site name.
When typing the name of a dive site,
a dropdown list appears showing all sites with similar names.
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
The way keybord shortcuts work is confusing. 2 ways are used:
- denoted as ctrl-? for some of them
- denoted as underlined character in menu items, proabably language
dependent, and inconsistent.
Despite all this, try to describe it in the manual as it is.
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
Manual added gas gas changes have effect to the right of the profile, not as erroneously
stated to the left of the point of gas change.
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
In the original version, parsing and comparing output was
done in separate test methods. This was forbidding use of
QTest cleanup to call clear_dive_file_data().
As a side effect a failure in one test would make other tests
failing too (since call to clear_dive_file_data was skipped
by QCOMPARE failure).
Added a FILE_COMPARE macro to avoid code duplication.
Signed-off-by: Jeremie Guichard <djebrest@gmail.com>
In case of QCOMPARE failure, code following the comparison
is not executed, this results in application state not being
properly resorted and often gives several test failures,
when only one test really fails.
Using QTest cleanup method allows restoring proper state,
before next test is executed.
Signed-off-by: Jeremie Guichard <djebrest@gmail.com>
Method originally called testSetup is more a precondition
to test execution rather than an actual test.
QTest recommends to use initTestCase for that purpose.
Signed-off-by: Jeremie Guichard <djebrest@gmail.com>
Expected value is the second argument of QCOMPARE,
having the arguments in the right order avoid confusion
when looking at error message in case of test failure.
Signed-off-by: Jeremie Guichard <djebrest@gmail.com>
Windows implementation of fwrite changes \n to \r\n
for files opened in text mode.
It caused failures in TestMerge and TestParse when
comparing written files against reference data.
Signed-off-by: Jeremie Guichard <djebrest@gmail.com>
Update install rules to create a staging_tests folder
for easy deployment to test target.
Update test rules for compile time testing
when wine is available on build machine.
Signed-off-by: Jeremie Guichard <djebrest@gmail.com>
The utility could be used for other targets,
path should therefore depend on the inputted target parameter
Signed-off-by: Jeremie Guichard <djebrest@gmail.com>
