2017-04-27 18:24:53 +00:00
|
|
|
// SPDX-License-Identifier: GPL-2.0
|
2011-09-20 19:40:34 +00:00
|
|
|
/* dive.c */
|
|
|
|
/* maintains the internal dive list structure */
|
2011-09-03 20:19:26 +00:00
|
|
|
#include <string.h>
|
|
|
|
#include <stdio.h>
|
2014-04-17 14:34:21 +00:00
|
|
|
#include <stdlib.h>
|
2013-10-07 13:15:52 +00:00
|
|
|
#include <limits.h>
|
2020-05-01 11:43:52 +00:00
|
|
|
#include "dive.h"
|
2013-10-06 15:55:58 +00:00
|
|
|
#include "gettext.h"
|
2018-05-11 15:25:41 +00:00
|
|
|
#include "subsurface-string.h"
|
2014-06-01 19:07:29 +00:00
|
|
|
#include "libdivecomputer.h"
|
Make gas use statistics be coherent and more complete
The gas use logic in the dive statistics page is confused.
The SAC case had a special case for "unknown", but only for
the first gas. Other gases had the normal empty case.
Also, the logic was really odd - if you had gases that weren't used (or
pressures not known) intermixed with gases you *did* have pressure for,
the statistics got really confused.
The list of gases showed all gases that we know about during the dive,
but then the gas use and SAC-rate lists wouldn't necessarily match,
because the loops that computed those stopped after the first gas that
didn't have any pressure change.
To make things worse, the first cylinder was special-cased again, so it
all lined up for the single-cylinder case.
This makes all the cylinders act the same way, leaving unknown gas use
(and thus SAC) just empty for that gas.
It also fixes the SAC calculation case where we don't have real samples,
and the profile is a fake profile - possibly with gas changes in between
the fake points. We now make the SAC calculations match what we show -
which is admittedly not at all necessarily what the dive was, but at
least we're consistent.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2014-07-30 17:08:33 +00:00
|
|
|
#include "device.h"
|
2015-06-18 00:58:31 +00:00
|
|
|
#include "divelist.h"
|
2019-03-04 22:20:29 +00:00
|
|
|
#include "divesite.h"
|
2020-03-04 18:29:59 +00:00
|
|
|
#include "errorhelper.h"
|
2020-10-25 08:14:16 +00:00
|
|
|
#include "event.h"
|
2020-10-25 12:28:55 +00:00
|
|
|
#include "extradata.h"
|
2020-10-25 17:14:23 +00:00
|
|
|
#include "interpolate.h"
|
2018-02-24 22:28:13 +00:00
|
|
|
#include "qthelper.h"
|
2018-04-09 08:09:34 +00:00
|
|
|
#include "membuffer.h"
|
2020-04-10 07:42:14 +00:00
|
|
|
#include "picture.h"
|
2020-10-25 12:28:55 +00:00
|
|
|
#include "sample.h"
|
2019-05-30 16:29:36 +00:00
|
|
|
#include "tag.h"
|
2019-05-31 14:09:14 +00:00
|
|
|
#include "trip.h"
|
2019-05-30 16:29:36 +00:00
|
|
|
#include "structured_list.h"
|
2020-02-16 21:26:47 +00:00
|
|
|
#include "fulltext.h"
|
|
|
|
|
2014-07-02 18:50:28 +00:00
|
|
|
/* one could argue about the best place to have this variable -
|
|
|
|
* it's used in the UI, but it seems to make the most sense to have it
|
|
|
|
* here */
|
|
|
|
struct dive displayed_dive;
|
|
|
|
|
2018-06-16 14:30:03 +00:00
|
|
|
// For user visible text but still not translated
|
2018-05-17 08:04:41 +00:00
|
|
|
const char *divemode_text_ui[] = {
|
|
|
|
QT_TRANSLATE_NOOP("gettextFromC", "Open circuit"),
|
|
|
|
QT_TRANSLATE_NOOP("gettextFromC", "CCR"),
|
|
|
|
QT_TRANSLATE_NOOP("gettextFromC", "pSCR"),
|
|
|
|
QT_TRANSLATE_NOOP("gettextFromC", "Freedive")
|
|
|
|
};
|
|
|
|
|
|
|
|
// For writing/reading files.
|
2018-06-04 14:30:00 +00:00
|
|
|
const char *divemode_text[] = {"OC", "CCR", "PSCR", "Freedive"};
|
2014-11-16 22:11:34 +00:00
|
|
|
|
2020-09-02 18:14:45 +00:00
|
|
|
static int calculate_depth_to_mbar(int depth, pressure_t surface_pressure, int salinity);
|
|
|
|
|
2017-07-26 01:33:10 +00:00
|
|
|
/*
|
|
|
|
* The legacy format for sample pressures has a single pressure
|
|
|
|
* for each sample that can have any sensor, plus a possible
|
|
|
|
* "o2pressure" that is fixed to the Oxygen sensor for a CCR dive.
|
|
|
|
*
|
|
|
|
* For more complex pressure data, we have to use explicit
|
2020-03-11 10:30:51 +00:00
|
|
|
* cylinder indices for each sample.
|
2017-07-26 01:33:10 +00:00
|
|
|
*
|
|
|
|
* This function returns a negative number for "no legacy mode",
|
|
|
|
* or a non-negative number that indicates the o2 sensor index.
|
|
|
|
*/
|
2018-08-23 17:18:43 +00:00
|
|
|
int legacy_format_o2pressures(const struct dive *dive, const struct divecomputer *dc)
|
2017-07-26 01:33:10 +00:00
|
|
|
{
|
|
|
|
int i, o2sensor;
|
|
|
|
|
|
|
|
o2sensor = (dc->divemode == CCR) ? get_cylinder_idx_by_use(dive, OXYGEN) : -1;
|
|
|
|
for (i = 0; i < dc->samples; i++) {
|
2018-08-23 17:18:43 +00:00
|
|
|
const struct sample *s = dc->sample + i;
|
2017-07-26 01:33:10 +00:00
|
|
|
int seen_pressure = 0, idx;
|
|
|
|
|
|
|
|
for (idx = 0; idx < MAX_SENSORS; idx++) {
|
|
|
|
int sensor = s->sensor[idx];
|
|
|
|
pressure_t p = s->pressure[idx];
|
|
|
|
|
|
|
|
if (!p.mbar)
|
|
|
|
continue;
|
|
|
|
if (sensor == o2sensor)
|
|
|
|
continue;
|
|
|
|
if (seen_pressure)
|
|
|
|
return -1;
|
|
|
|
seen_pressure = 1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Use legacy mode: if we have no O2 sensor we return a
|
|
|
|
* positive sensor index that is guaranmteed to not match
|
|
|
|
* any sensor (we encode it as 8 bits).
|
|
|
|
*/
|
|
|
|
return o2sensor < 0 ? 256 : o2sensor;
|
|
|
|
}
|
|
|
|
|
2020-03-04 18:41:40 +00:00
|
|
|
/* warning: does not test idx for validity */
|
|
|
|
struct event *create_gas_switch_event(struct dive *dive, struct divecomputer *dc, int seconds, int idx)
|
|
|
|
{
|
|
|
|
/* The gas switch event format is insane for historical reasons */
|
|
|
|
struct gasmix mix = get_cylinder(dive, idx)->gasmix;
|
|
|
|
int o2 = get_o2(mix);
|
|
|
|
int he = get_he(mix);
|
|
|
|
struct event *ev;
|
|
|
|
int value;
|
|
|
|
|
|
|
|
o2 = (o2 + 5) / 10;
|
|
|
|
he = (he + 5) / 10;
|
|
|
|
value = o2 + (he << 16);
|
|
|
|
|
|
|
|
ev = create_event(seconds, he ? SAMPLE_EVENT_GASCHANGE2 : SAMPLE_EVENT_GASCHANGE, 0, value, "gaschange");
|
|
|
|
ev->gas.index = idx;
|
|
|
|
ev->gas.mix = mix;
|
|
|
|
return ev;
|
|
|
|
}
|
|
|
|
|
2020-03-04 18:29:59 +00:00
|
|
|
void add_gas_switch_event(struct dive *dive, struct divecomputer *dc, int seconds, int idx)
|
|
|
|
{
|
|
|
|
/* sanity check so we don't crash */
|
2020-04-27 19:12:24 +00:00
|
|
|
/* FIXME: The planner uses a dummy cylinder one past the official number of cylinders
|
|
|
|
* in the table to mark no-cylinder surface interavals. This is horrendous. Fix ASAP. */
|
|
|
|
//if (idx < 0 || idx >= dive->cylinders.nr) {
|
|
|
|
if (idx < 0 || idx >= dive->cylinders.nr + 1 || idx >= dive->cylinders.allocated) {
|
2020-03-04 18:29:59 +00:00
|
|
|
report_error("Unknown cylinder index: %d", idx);
|
|
|
|
return;
|
|
|
|
}
|
2020-03-04 18:41:40 +00:00
|
|
|
struct event *ev = create_gas_switch_event(dive, dc, seconds, idx);
|
|
|
|
add_event_to_dc(dc, ev);
|
2020-03-04 18:29:59 +00:00
|
|
|
}
|
|
|
|
|
2014-07-12 19:48:27 +00:00
|
|
|
/* since the name is an array as part of the structure (how silly is that?) we
|
|
|
|
* have to actually remove the existing event and replace it with a new one.
|
|
|
|
* WARNING, WARNING... this may end up freeing event in case that event is indeed
|
|
|
|
* WARNING, WARNING... part of this divecomputer on this dive! */
|
2018-03-03 09:10:51 +00:00
|
|
|
void update_event_name(struct dive *d, struct event *event, const char *name)
|
2014-07-12 19:48:27 +00:00
|
|
|
{
|
|
|
|
if (!d || !event)
|
|
|
|
return;
|
|
|
|
struct divecomputer *dc = get_dive_dc(d, dc_number);
|
|
|
|
if (!dc)
|
|
|
|
return;
|
|
|
|
struct event **removep = &dc->events;
|
|
|
|
struct event *remove;
|
|
|
|
while ((*removep)->next && !same_event(*removep, event))
|
|
|
|
removep = &(*removep)->next;
|
|
|
|
if (!same_event(*removep, event))
|
|
|
|
return;
|
|
|
|
remove = *removep;
|
|
|
|
*removep = (*removep)->next;
|
|
|
|
add_event(dc, event->time.seconds, event->type, event->flags, event->value, name);
|
|
|
|
free(remove);
|
2016-04-03 22:31:59 +00:00
|
|
|
invalidate_dive_cache(d);
|
2014-07-12 19:48:27 +00:00
|
|
|
}
|
|
|
|
|
2018-08-16 22:58:30 +00:00
|
|
|
struct gasmix get_gasmix_from_event(const struct dive *dive, const struct event *ev)
|
2014-06-01 19:07:29 +00:00
|
|
|
{
|
Start using the actual cylinder data for gas switch events
Now that gas switch events always have indices into the cylinder table,
start using that to look up the gas mix from the cylinders rather than
from the gas switch event itself. In other words, the cylinder index is
now the primary data for gas switch events.
This means that now as you change the cylinder information, the gas
switch events will automatically update to reflect those changes.
Note that on loading data from the outside (either from a xml file, from
a git/cloud account, or from a dive computer), we may or may not
initially have an index for the gas change event. The external data may
be from an older version of subsurface, or it may be from a
libdivecomputer download that just doesn't give index data at all.
In that case, we will do:
- if there is no index, but there is explicit gas mix information, we
will look up the index based on that gas mix, picking the cylinder
that has the closest mix.
- if there isn't even explicit gas mix data, so we only have the event
value from libdivecomputer, we will turn that value into a gasmix,
and use that to look up the cylinder index as above.
- if no valid cylinder information is available at all, gas switch
events will just be dropped.
When saving the data, we now always save the cylinder index, and the gas
mix associated with that cylinder (that gas mix will be ignored on load,
since the index is the primary, but it makes the event much easier to
read).
It is worth noting we do not modify the libdivecomputer value, even if
the gasmix has changed, so that remains as a record of the original
download.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-02 21:07:06 +00:00
|
|
|
if (ev && event_is_gaschange(ev)) {
|
|
|
|
int index = ev->gas.index;
|
2020-04-30 22:56:44 +00:00
|
|
|
// FIXME: The planner uses one past cylinder-count to signify "surface air". Remove in due course.
|
|
|
|
if (index == dive->cylinders.nr)
|
|
|
|
return gasmix_air;
|
2019-08-04 16:44:57 +00:00
|
|
|
if (index >= 0 && index < dive->cylinders.nr)
|
2019-08-04 20:13:49 +00:00
|
|
|
return get_cylinder(dive, index)->gasmix;
|
2018-08-16 11:35:14 +00:00
|
|
|
return ev->gas.mix;
|
Start using the actual cylinder data for gas switch events
Now that gas switch events always have indices into the cylinder table,
start using that to look up the gas mix from the cylinders rather than
from the gas switch event itself. In other words, the cylinder index is
now the primary data for gas switch events.
This means that now as you change the cylinder information, the gas
switch events will automatically update to reflect those changes.
Note that on loading data from the outside (either from a xml file, from
a git/cloud account, or from a dive computer), we may or may not
initially have an index for the gas change event. The external data may
be from an older version of subsurface, or it may be from a
libdivecomputer download that just doesn't give index data at all.
In that case, we will do:
- if there is no index, but there is explicit gas mix information, we
will look up the index based on that gas mix, picking the cylinder
that has the closest mix.
- if there isn't even explicit gas mix data, so we only have the event
value from libdivecomputer, we will turn that value into a gasmix,
and use that to look up the cylinder index as above.
- if no valid cylinder information is available at all, gas switch
events will just be dropped.
When saving the data, we now always save the cylinder index, and the gas
mix associated with that cylinder (that gas mix will be ignored on load,
since the index is the primary, but it makes the event much easier to
read).
It is worth noting we do not modify the libdivecomputer value, even if
the gasmix has changed, so that remains as a record of the original
download.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-02 21:07:06 +00:00
|
|
|
}
|
2020-04-30 22:56:44 +00:00
|
|
|
return gasmix_air;
|
2014-06-01 19:07:29 +00:00
|
|
|
}
|
|
|
|
|
2018-07-17 21:05:03 +00:00
|
|
|
// we need this to be uniq. oh, and it has no meaning whatsoever
|
|
|
|
// - that's why we have the silly initial number and increment by 3 :-)
|
|
|
|
int dive_getUniqID()
|
|
|
|
{
|
|
|
|
static int maxId = 83529;
|
|
|
|
maxId += 3;
|
|
|
|
return maxId;
|
|
|
|
}
|
|
|
|
|
2011-09-12 19:56:34 +00:00
|
|
|
struct dive *alloc_dive(void)
|
|
|
|
{
|
|
|
|
struct dive *dive;
|
|
|
|
|
2012-11-24 02:05:38 +00:00
|
|
|
dive = malloc(sizeof(*dive));
|
2011-09-12 19:56:34 +00:00
|
|
|
if (!dive)
|
|
|
|
exit(1);
|
2012-11-24 02:05:38 +00:00
|
|
|
memset(dive, 0, sizeof(*dive));
|
2018-07-17 21:05:03 +00:00
|
|
|
dive->id = dive_getUniqID();
|
2011-09-12 19:56:34 +00:00
|
|
|
return dive;
|
|
|
|
}
|
|
|
|
|
2018-10-16 05:41:48 +00:00
|
|
|
/* copy an element in a list of dive computer extra data */
|
|
|
|
static void copy_extra_data(struct extra_data *sed, struct extra_data *ded)
|
|
|
|
{
|
|
|
|
ded->key = copy_string(sed->key);
|
|
|
|
ded->value = copy_string(sed->value);
|
|
|
|
}
|
|
|
|
|
2014-07-02 22:29:02 +00:00
|
|
|
/* this is very different from the copy_divecomputer later in this file;
|
|
|
|
* this function actually makes full copies of the content */
|
2018-08-23 17:18:43 +00:00
|
|
|
static void copy_dc(const struct divecomputer *sdc, struct divecomputer *ddc)
|
2014-07-02 22:29:02 +00:00
|
|
|
{
|
|
|
|
*ddc = *sdc;
|
2014-07-03 04:05:22 +00:00
|
|
|
ddc->model = copy_string(sdc->model);
|
2018-10-16 05:50:38 +00:00
|
|
|
ddc->serial = copy_string(sdc->serial);
|
|
|
|
ddc->fw_version = copy_string(sdc->fw_version);
|
2014-07-02 22:29:02 +00:00
|
|
|
copy_samples(sdc, ddc);
|
|
|
|
copy_events(sdc, ddc);
|
2018-10-16 05:41:48 +00:00
|
|
|
STRUCTURED_LIST_COPY(struct extra_data, sdc->extra_data, ddc->extra_data, copy_extra_data);
|
2014-07-02 22:29:02 +00:00
|
|
|
}
|
|
|
|
|
2018-08-13 02:47:07 +00:00
|
|
|
static void dc_cylinder_renumber(struct dive *dive, struct divecomputer *dc, const int mapping[]);
|
|
|
|
|
2018-10-15 19:17:23 +00:00
|
|
|
/* copy dive computer list and renumber the cylinders
|
|
|
|
* space for the first divecomputer is provided by the
|
|
|
|
* caller, the remainder is allocated */
|
2018-08-13 02:47:07 +00:00
|
|
|
static void copy_dc_renumber(struct dive *d, const struct divecomputer *sdc, struct divecomputer *ddc, const int cylinders_map[])
|
|
|
|
{
|
2018-10-15 19:17:23 +00:00
|
|
|
for (;;) {
|
2018-10-16 05:41:48 +00:00
|
|
|
copy_dc(sdc, ddc);
|
2018-10-15 19:17:23 +00:00
|
|
|
dc_cylinder_renumber(d, ddc, cylinders_map);
|
|
|
|
if (!sdc->next)
|
|
|
|
break;
|
|
|
|
sdc = sdc->next;
|
|
|
|
ddc->next = calloc(1, sizeof(struct divecomputer));
|
|
|
|
ddc = ddc->next;
|
|
|
|
}
|
|
|
|
ddc->next = NULL;
|
2018-08-13 02:47:07 +00:00
|
|
|
}
|
|
|
|
|
2018-09-27 19:55:03 +00:00
|
|
|
static void free_dive_structures(struct dive *d)
|
2014-07-02 22:29:02 +00:00
|
|
|
{
|
|
|
|
if (!d)
|
|
|
|
return;
|
2020-02-16 21:26:47 +00:00
|
|
|
fulltext_unregister(d);
|
2014-07-02 22:29:02 +00:00
|
|
|
/* free the strings */
|
|
|
|
free(d->buddy);
|
|
|
|
free(d->divemaster);
|
|
|
|
free(d->notes);
|
|
|
|
free(d->suit);
|
|
|
|
/* free tags, additional dive computers, and pictures */
|
|
|
|
taglist_free(d->tag_list);
|
2019-10-06 08:48:41 +00:00
|
|
|
free_dive_dcs(&d->dc);
|
2019-08-04 16:44:57 +00:00
|
|
|
clear_cylinder_table(&d->cylinders);
|
|
|
|
free(d->cylinders.cylinders);
|
2019-06-26 15:21:03 +00:00
|
|
|
clear_weightsystem_table(&d->weightsystems);
|
|
|
|
free(d->weightsystems.weightsystems);
|
2020-04-11 15:41:56 +00:00
|
|
|
clear_picture_table(&d->pictures);
|
|
|
|
free(d->pictures.pictures);
|
2018-09-27 19:55:03 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void free_dive(struct dive *d)
|
|
|
|
{
|
|
|
|
free_dive_structures(d);
|
|
|
|
free(d);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* copy_dive makes duplicates of many components of a dive;
|
|
|
|
* in order not to leak memory, we need to free those .
|
|
|
|
* copy_dive doesn't play with the divetrip and forward/backward pointers
|
|
|
|
* so we can ignore those */
|
|
|
|
void clear_dive(struct dive *d)
|
|
|
|
{
|
|
|
|
if (!d)
|
|
|
|
return;
|
|
|
|
free_dive_structures(d);
|
2014-07-02 22:29:02 +00:00
|
|
|
memset(d, 0, sizeof(struct dive));
|
|
|
|
}
|
|
|
|
|
2014-07-03 20:34:27 +00:00
|
|
|
/* make a true copy that is independent of the source dive;
|
|
|
|
* all data structures are duplicated, so the copy can be modified without
|
|
|
|
* any impact on the source */
|
2019-03-31 08:20:13 +00:00
|
|
|
static void copy_dive_nodc(const struct dive *s, struct dive *d)
|
2014-07-02 22:29:02 +00:00
|
|
|
{
|
|
|
|
clear_dive(d);
|
|
|
|
/* simply copy things over, but then make actual copies of the
|
|
|
|
* relevant components that are referenced through pointers,
|
|
|
|
* so all the strings and the structured lists */
|
|
|
|
*d = *s;
|
2019-08-04 16:44:57 +00:00
|
|
|
memset(&d->cylinders, 0, sizeof(d->cylinders));
|
2019-06-26 15:21:03 +00:00
|
|
|
memset(&d->weightsystems, 0, sizeof(d->weightsystems));
|
2020-04-11 15:41:56 +00:00
|
|
|
memset(&d->pictures, 0, sizeof(d->pictures));
|
2020-02-16 21:26:47 +00:00
|
|
|
d->full_text = NULL;
|
2016-04-03 22:31:59 +00:00
|
|
|
invalidate_dive_cache(d);
|
2014-07-03 04:05:22 +00:00
|
|
|
d->buddy = copy_string(s->buddy);
|
|
|
|
d->divemaster = copy_string(s->divemaster);
|
|
|
|
d->notes = copy_string(s->notes);
|
|
|
|
d->suit = copy_string(s->suit);
|
2019-08-04 16:44:57 +00:00
|
|
|
copy_cylinders(&s->cylinders, &d->cylinders);
|
2019-06-26 15:21:03 +00:00
|
|
|
copy_weights(&s->weightsystems, &d->weightsystems);
|
2020-04-11 15:41:56 +00:00
|
|
|
copy_pictures(&s->pictures, &d->pictures);
|
2019-05-30 15:49:17 +00:00
|
|
|
d->tag_list = taglist_copy(s->tag_list);
|
2019-03-31 08:20:13 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
void copy_dive(const struct dive *s, struct dive *d)
|
|
|
|
{
|
|
|
|
copy_dive_nodc(s, d);
|
2016-04-03 22:31:59 +00:00
|
|
|
|
|
|
|
// Copy the first dc explicitly, then the list of subsequent dc's
|
|
|
|
copy_dc(&s->dc, &d->dc);
|
2014-07-06 18:02:28 +00:00
|
|
|
STRUCTURED_LIST_COPY(struct divecomputer, s->dc.next, d->dc.next, copy_dc);
|
2014-07-02 22:29:02 +00:00
|
|
|
}
|
|
|
|
|
2019-03-31 08:20:13 +00:00
|
|
|
static void copy_dive_onedc(const struct dive *s, const struct divecomputer *sdc, struct dive *d)
|
|
|
|
{
|
|
|
|
copy_dive_nodc(s, d);
|
|
|
|
copy_dc(sdc, &d->dc);
|
|
|
|
d->dc.next = NULL;
|
|
|
|
}
|
|
|
|
|
2014-07-03 20:34:27 +00:00
|
|
|
/* make a clone of the source dive and clean out the source dive;
|
|
|
|
* this is specifically so we can create a dive in the displayed_dive and then
|
|
|
|
* add it to the divelist.
|
|
|
|
* Note the difference to copy_dive() / clean_dive() */
|
2019-05-19 16:28:56 +00:00
|
|
|
struct dive *move_dive(struct dive *s)
|
2014-07-03 20:34:27 +00:00
|
|
|
{
|
|
|
|
struct dive *dive = alloc_dive();
|
2014-10-11 11:25:52 +00:00
|
|
|
*dive = *s; // so all the pointers in dive point to the things s pointed to
|
2014-07-03 20:34:27 +00:00
|
|
|
memset(s, 0, sizeof(struct dive)); // and now the pointers in s are gone
|
|
|
|
return dive;
|
|
|
|
}
|
|
|
|
|
2014-08-16 13:55:31 +00:00
|
|
|
#define CONDITIONAL_COPY_STRING(_component) \
|
|
|
|
if (what._component) \
|
|
|
|
d->_component = copy_string(s->_component)
|
|
|
|
|
|
|
|
// copy elements, depending on bits in what that are set
|
2018-08-23 17:18:43 +00:00
|
|
|
void selective_copy_dive(const struct dive *s, struct dive *d, struct dive_components what, bool clear)
|
2014-08-16 13:55:31 +00:00
|
|
|
{
|
2014-08-17 00:33:09 +00:00
|
|
|
if (clear)
|
|
|
|
clear_dive(d);
|
2014-08-16 13:55:31 +00:00
|
|
|
CONDITIONAL_COPY_STRING(notes);
|
|
|
|
CONDITIONAL_COPY_STRING(divemaster);
|
|
|
|
CONDITIONAL_COPY_STRING(buddy);
|
|
|
|
CONDITIONAL_COPY_STRING(suit);
|
|
|
|
if (what.rating)
|
|
|
|
d->rating = s->rating;
|
|
|
|
if (what.visibility)
|
|
|
|
d->visibility = s->visibility;
|
2019-03-05 21:58:47 +00:00
|
|
|
if (what.divesite) {
|
|
|
|
unregister_dive_from_dive_site(d);
|
|
|
|
add_dive_to_dive_site(d, s->dive_site);
|
|
|
|
}
|
2014-08-16 13:55:31 +00:00
|
|
|
if (what.tags)
|
2019-02-22 19:52:50 +00:00
|
|
|
d->tag_list = taglist_copy(s->tag_list);
|
2014-08-16 13:55:31 +00:00
|
|
|
if (what.cylinders)
|
Core: split copy_cylinders() in two functions
copy_cylinders() copied the cylinders of one dive onto another dive
and then reset to the original gas values. Presumably, when copy and
pasting cylinders from one dive to another, only the types should
be copied, not the gases.
Moreover, the function could either copy all or only the used cylinders.
Firstly, the code was bogus: when restoring the pressures the indices
were mixed up: the old indices were used. Thus, when there where
uncopied cylinders, not all pressure values were restored.
Secondly, it is not clear that all callers actually want to restore
the pressure data. It rather appears the two (out of three) callers
actually just want to copy the cylinders.
Therefore, split the function in
1) copy_cylinders(): copy the cylinders with pressure data
2) copy_cylinder_types(): copy only the cylinder information
Since there is only one caller of copy_cylinder_types(), the "used_only"
argument can be removed. Since all cylinders are copied there is
no point in storing the pressure data. Don't overwrite it in
the first place.
The resulting two functions should be distinctly easier to understand.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2019-07-25 20:29:07 +00:00
|
|
|
copy_cylinder_types(s, d);
|
2014-08-16 13:55:31 +00:00
|
|
|
if (what.weights)
|
2019-06-26 15:21:03 +00:00
|
|
|
copy_weights(&s->weightsystems, &d->weightsystems);
|
2021-05-16 03:39:47 +00:00
|
|
|
if (what.number)
|
|
|
|
d->number = s->number;
|
|
|
|
if (what.when)
|
|
|
|
d->when = s->when;
|
2014-08-16 13:55:31 +00:00
|
|
|
}
|
|
|
|
#undef CONDITIONAL_COPY_STRING
|
|
|
|
|
2020-04-12 11:39:01 +00:00
|
|
|
/* copies all events from all dive computers before a given time
|
|
|
|
this is used when editing a dive in the planner to preserve the events
|
|
|
|
of the old dive */
|
|
|
|
void copy_events_until(const struct dive *sd, struct dive *dd, int time)
|
|
|
|
{
|
|
|
|
if (!sd || !dd)
|
|
|
|
return;
|
|
|
|
|
|
|
|
const struct divecomputer *s = &sd->dc;
|
|
|
|
struct divecomputer *d = &dd->dc;
|
|
|
|
|
|
|
|
while (s && d) {
|
|
|
|
const struct event *ev;
|
|
|
|
ev = s->events;
|
|
|
|
while (ev != NULL) {
|
|
|
|
// Don't add events the planner knows about
|
|
|
|
if (ev->time.seconds < time && !event_is_gaschange(ev) && !event_is_divemodechange(ev))
|
|
|
|
add_event(d, ev->time.seconds, ev->type, ev->flags, ev->value, ev->name);
|
|
|
|
ev = ev->next;
|
|
|
|
}
|
|
|
|
s = s->next;
|
|
|
|
d = d->next;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-08-23 17:18:43 +00:00
|
|
|
int nr_cylinders(const struct dive *dive)
|
Initial implementation of git save format
This saves the dive data into a git object repository instead of a
single XML file.
We create a git object tree with each dive as a separate file,
hierarchically by trip and date.
NOTE 1: This largely duplicates the XML saving code, because trying to
share it seemed just too painful: the logic is very similar, but the
details of the actual strings end up differing sufficiently that there
are tons of trivial differences.
The git save format is line-based with minimal quoting, while XML quotes
everything with either "<..\>" or using single quotes around attributes.
NOTE 2: You currently need a dummy "file" to save to, which points to
the real save location: the git repository and branch to be used. We
should make this a config thing, but for testing, do something like
this:
echo git /home/torvalds/scuba:linus > git-test
to create that git information file, and when you use "Save To" and
specify "git-test" as the file to save to, subsurface will use the new
git save logic to save to the branch "linus" in the repository found at
"/home/torvalds/scuba".
NOTE 3: The git save format uses just the git object directory, it does
*not* check out the result in any git working tree or index. So after
you do a save, you can do
git log -p linus
to see what actually happened in that branch, but it will not affect any
actual checked-out state in the repository.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2014-03-06 21:28:39 +00:00
|
|
|
{
|
2019-08-04 16:44:57 +00:00
|
|
|
return dive->cylinders.nr;
|
Initial implementation of git save format
This saves the dive data into a git object repository instead of a
single XML file.
We create a git object tree with each dive as a separate file,
hierarchically by trip and date.
NOTE 1: This largely duplicates the XML saving code, because trying to
share it seemed just too painful: the logic is very similar, but the
details of the actual strings end up differing sufficiently that there
are tons of trivial differences.
The git save format is line-based with minimal quoting, while XML quotes
everything with either "<..\>" or using single quotes around attributes.
NOTE 2: You currently need a dummy "file" to save to, which points to
the real save location: the git repository and branch to be used. We
should make this a config thing, but for testing, do something like
this:
echo git /home/torvalds/scuba:linus > git-test
to create that git information file, and when you use "Save To" and
specify "git-test" as the file to save to, subsurface will use the new
git save logic to save to the branch "linus" in the repository found at
"/home/torvalds/scuba".
NOTE 3: The git save format uses just the git object directory, it does
*not* check out the result in any git working tree or index. So after
you do a save, you can do
git log -p linus
to see what actually happened in that branch, but it will not affect any
actual checked-out state in the repository.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2014-03-06 21:28:39 +00:00
|
|
|
}
|
|
|
|
|
2018-08-23 17:18:43 +00:00
|
|
|
int nr_weightsystems(const struct dive *dive)
|
Initial implementation of git save format
This saves the dive data into a git object repository instead of a
single XML file.
We create a git object tree with each dive as a separate file,
hierarchically by trip and date.
NOTE 1: This largely duplicates the XML saving code, because trying to
share it seemed just too painful: the logic is very similar, but the
details of the actual strings end up differing sufficiently that there
are tons of trivial differences.
The git save format is line-based with minimal quoting, while XML quotes
everything with either "<..\>" or using single quotes around attributes.
NOTE 2: You currently need a dummy "file" to save to, which points to
the real save location: the git repository and branch to be used. We
should make this a config thing, but for testing, do something like
this:
echo git /home/torvalds/scuba:linus > git-test
to create that git information file, and when you use "Save To" and
specify "git-test" as the file to save to, subsurface will use the new
git save logic to save to the branch "linus" in the repository found at
"/home/torvalds/scuba".
NOTE 3: The git save format uses just the git object directory, it does
*not* check out the result in any git working tree or index. So after
you do a save, you can do
git log -p linus
to see what actually happened in that branch, but it will not affect any
actual checked-out state in the repository.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2014-03-06 21:28:39 +00:00
|
|
|
{
|
2019-06-26 15:21:03 +00:00
|
|
|
return dive->weightsystems.nr;
|
Initial implementation of git save format
This saves the dive data into a git object repository instead of a
single XML file.
We create a git object tree with each dive as a separate file,
hierarchically by trip and date.
NOTE 1: This largely duplicates the XML saving code, because trying to
share it seemed just too painful: the logic is very similar, but the
details of the actual strings end up differing sufficiently that there
are tons of trivial differences.
The git save format is line-based with minimal quoting, while XML quotes
everything with either "<..\>" or using single quotes around attributes.
NOTE 2: You currently need a dummy "file" to save to, which points to
the real save location: the git repository and branch to be used. We
should make this a config thing, but for testing, do something like
this:
echo git /home/torvalds/scuba:linus > git-test
to create that git information file, and when you use "Save To" and
specify "git-test" as the file to save to, subsurface will use the new
git save logic to save to the branch "linus" in the repository found at
"/home/torvalds/scuba".
NOTE 3: The git save format uses just the git object directory, it does
*not* check out the result in any git working tree or index. So after
you do a save, you can do
git log -p linus
to see what actually happened in that branch, but it will not affect any
actual checked-out state in the repository.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2014-03-06 21:28:39 +00:00
|
|
|
}
|
|
|
|
|
2019-08-04 16:44:57 +00:00
|
|
|
void copy_used_cylinders(const struct dive *s, struct dive *d, bool used_only)
|
Core: split copy_cylinders() in two functions
copy_cylinders() copied the cylinders of one dive onto another dive
and then reset to the original gas values. Presumably, when copy and
pasting cylinders from one dive to another, only the types should
be copied, not the gases.
Moreover, the function could either copy all or only the used cylinders.
Firstly, the code was bogus: when restoring the pressures the indices
were mixed up: the old indices were used. Thus, when there where
uncopied cylinders, not all pressure values were restored.
Secondly, it is not clear that all callers actually want to restore
the pressure data. It rather appears the two (out of three) callers
actually just want to copy the cylinders.
Therefore, split the function in
1) copy_cylinders(): copy the cylinders with pressure data
2) copy_cylinder_types(): copy only the cylinder information
Since there is only one caller of copy_cylinder_types(), the "used_only"
argument can be removed. Since all cylinders are copied there is
no point in storing the pressure data. Don't overwrite it in
the first place.
The resulting two functions should be distinctly easier to understand.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2019-07-25 20:29:07 +00:00
|
|
|
{
|
2019-08-04 16:44:57 +00:00
|
|
|
int i;
|
Core: split copy_cylinders() in two functions
copy_cylinders() copied the cylinders of one dive onto another dive
and then reset to the original gas values. Presumably, when copy and
pasting cylinders from one dive to another, only the types should
be copied, not the gases.
Moreover, the function could either copy all or only the used cylinders.
Firstly, the code was bogus: when restoring the pressures the indices
were mixed up: the old indices were used. Thus, when there where
uncopied cylinders, not all pressure values were restored.
Secondly, it is not clear that all callers actually want to restore
the pressure data. It rather appears the two (out of three) callers
actually just want to copy the cylinders.
Therefore, split the function in
1) copy_cylinders(): copy the cylinders with pressure data
2) copy_cylinder_types(): copy only the cylinder information
Since there is only one caller of copy_cylinder_types(), the "used_only"
argument can be removed. Since all cylinders are copied there is
no point in storing the pressure data. Don't overwrite it in
the first place.
The resulting two functions should be distinctly easier to understand.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2019-07-25 20:29:07 +00:00
|
|
|
if (!s || !d)
|
|
|
|
return;
|
|
|
|
|
2019-08-04 16:44:57 +00:00
|
|
|
clear_cylinder_table(&d->cylinders);
|
|
|
|
for (i = 0; i < s->cylinders.nr; i++) {
|
2019-08-04 20:13:49 +00:00
|
|
|
if (!used_only || is_cylinder_used(s, i) || get_cylinder(s, i)->cylinder_use == NOT_USED)
|
|
|
|
add_cloned_cylinder(&d->cylinders, *get_cylinder(s, i));
|
Core: split copy_cylinders() in two functions
copy_cylinders() copied the cylinders of one dive onto another dive
and then reset to the original gas values. Presumably, when copy and
pasting cylinders from one dive to another, only the types should
be copied, not the gases.
Moreover, the function could either copy all or only the used cylinders.
Firstly, the code was bogus: when restoring the pressures the indices
were mixed up: the old indices were used. Thus, when there where
uncopied cylinders, not all pressure values were restored.
Secondly, it is not clear that all callers actually want to restore
the pressure data. It rather appears the two (out of three) callers
actually just want to copy the cylinders.
Therefore, split the function in
1) copy_cylinders(): copy the cylinders with pressure data
2) copy_cylinder_types(): copy only the cylinder information
Since there is only one caller of copy_cylinder_types(), the "used_only"
argument can be removed. Since all cylinders are copied there is
no point in storing the pressure data. Don't overwrite it in
the first place.
The resulting two functions should be distinctly easier to understand.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2019-07-25 20:29:07 +00:00
|
|
|
}
|
2013-11-07 08:25:42 +00:00
|
|
|
}
|
|
|
|
|
2011-09-03 20:36:25 +00:00
|
|
|
/*
|
|
|
|
* So when we re-calculate maxdepth and meandepth, we will
|
|
|
|
* not override the old numbers if they are close to the
|
|
|
|
* new ones.
|
|
|
|
*
|
|
|
|
* Why? Because a dive computer may well actually track the
|
2017-03-06 12:27:39 +00:00
|
|
|
* max. depth and mean depth at finer granularity than the
|
2011-09-03 20:36:25 +00:00
|
|
|
* samples it stores. So it's possible that the max and mean
|
|
|
|
* have been reported more correctly originally.
|
|
|
|
*
|
2011-09-04 01:48:39 +00:00
|
|
|
* Only if the values calculated from the samples are clearly
|
2011-09-03 20:36:25 +00:00
|
|
|
* different do we override the normal depth values.
|
|
|
|
*
|
|
|
|
* This considers 1m to be "clearly different". That's
|
|
|
|
* a totally random number.
|
|
|
|
*/
|
|
|
|
static void update_depth(depth_t *depth, int new)
|
|
|
|
{
|
2011-09-04 20:06:47 +00:00
|
|
|
if (new) {
|
|
|
|
int old = depth->mm;
|
2011-09-03 20:36:25 +00:00
|
|
|
|
2011-09-04 20:06:47 +00:00
|
|
|
if (abs(old - new) > 1000)
|
|
|
|
depth->mm = new;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void update_temperature(temperature_t *temperature, int new)
|
|
|
|
{
|
|
|
|
if (new) {
|
|
|
|
int old = temperature->mkelvin;
|
|
|
|
|
|
|
|
if (abs(old - new) > 1000)
|
|
|
|
temperature->mkelvin = new;
|
|
|
|
}
|
2011-09-03 20:36:25 +00:00
|
|
|
}
|
|
|
|
|
Fix per-cylinder SAC rate calculations when cylinder use isn't known
John Van Ostrand reports that when he dives using two cylinders using
sidemounts, the per-cylinder SAC rate display is very misleading.
What happens is that since the two cylinders are used together (but
without a manifold), John is alternating between the two but not
actually adding gas switches in the profile. As a result, the profile
looks like only one cylinder is used, even though clearly the other
cylinder gets breathed down too.
The per-cylinder SAC rate calculations would entirely ignore the
cylinder that didn't have gas switch events to it, and looking at the
info window it would look like John had a truly exceptional SAC rate.
But then in the general statistics panel that actually takes the whole
gas use into account, the very different real SAC rate would show up.
The basic issue is that if we don't have full use information for the
different cylinders, we would account the whole dive to just a partial
set. We did have a special case for this, but that special case only
really worked if the first cylinder truly was the only cylinder used.
This patch makes us see the difference between "only one cylinder was
used, and I can use the overall mean depth for it" and "more than one
cylinder was used, but I don't know what the mean depths might be".
Reported-by: John Van Ostrand <john@vanostrand.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-05 22:53:02 +00:00
|
|
|
/* Which cylinders had gas used? */
|
|
|
|
#define SOME_GAS 5000
|
2019-07-15 19:34:39 +00:00
|
|
|
static bool cylinder_used(const cylinder_t *cyl)
|
Fix per-cylinder SAC rate calculations when cylinder use isn't known
John Van Ostrand reports that when he dives using two cylinders using
sidemounts, the per-cylinder SAC rate display is very misleading.
What happens is that since the two cylinders are used together (but
without a manifold), John is alternating between the two but not
actually adding gas switches in the profile. As a result, the profile
looks like only one cylinder is used, even though clearly the other
cylinder gets breathed down too.
The per-cylinder SAC rate calculations would entirely ignore the
cylinder that didn't have gas switch events to it, and looking at the
info window it would look like John had a truly exceptional SAC rate.
But then in the general statistics panel that actually takes the whole
gas use into account, the very different real SAC rate would show up.
The basic issue is that if we don't have full use information for the
different cylinders, we would account the whole dive to just a partial
set. We did have a special case for this, but that special case only
really worked if the first cylinder truly was the only cylinder used.
This patch makes us see the difference between "only one cylinder was
used, and I can use the overall mean depth for it" and "more than one
cylinder was used, but I don't know what the mean depths might be".
Reported-by: John Van Ostrand <john@vanostrand.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-05 22:53:02 +00:00
|
|
|
{
|
2019-07-15 19:34:39 +00:00
|
|
|
int start_mbar, end_mbar;
|
Fix per-cylinder SAC rate calculations when cylinder use isn't known
John Van Ostrand reports that when he dives using two cylinders using
sidemounts, the per-cylinder SAC rate display is very misleading.
What happens is that since the two cylinders are used together (but
without a manifold), John is alternating between the two but not
actually adding gas switches in the profile. As a result, the profile
looks like only one cylinder is used, even though clearly the other
cylinder gets breathed down too.
The per-cylinder SAC rate calculations would entirely ignore the
cylinder that didn't have gas switch events to it, and looking at the
info window it would look like John had a truly exceptional SAC rate.
But then in the general statistics panel that actually takes the whole
gas use into account, the very different real SAC rate would show up.
The basic issue is that if we don't have full use information for the
different cylinders, we would account the whole dive to just a partial
set. We did have a special case for this, but that special case only
really worked if the first cylinder truly was the only cylinder used.
This patch makes us see the difference between "only one cylinder was
used, and I can use the overall mean depth for it" and "more than one
cylinder was used, but I don't know what the mean depths might be".
Reported-by: John Van Ostrand <john@vanostrand.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-05 22:53:02 +00:00
|
|
|
|
2019-07-15 19:34:39 +00:00
|
|
|
start_mbar = cyl->start.mbar ?: cyl->sample_start.mbar;
|
|
|
|
end_mbar = cyl->end.mbar ?: cyl->sample_end.mbar;
|
Fix per-cylinder SAC rate calculations when cylinder use isn't known
John Van Ostrand reports that when he dives using two cylinders using
sidemounts, the per-cylinder SAC rate display is very misleading.
What happens is that since the two cylinders are used together (but
without a manifold), John is alternating between the two but not
actually adding gas switches in the profile. As a result, the profile
looks like only one cylinder is used, even though clearly the other
cylinder gets breathed down too.
The per-cylinder SAC rate calculations would entirely ignore the
cylinder that didn't have gas switch events to it, and looking at the
info window it would look like John had a truly exceptional SAC rate.
But then in the general statistics panel that actually takes the whole
gas use into account, the very different real SAC rate would show up.
The basic issue is that if we don't have full use information for the
different cylinders, we would account the whole dive to just a partial
set. We did have a special case for this, but that special case only
really worked if the first cylinder truly was the only cylinder used.
This patch makes us see the difference between "only one cylinder was
used, and I can use the overall mean depth for it" and "more than one
cylinder was used, but I don't know what the mean depths might be".
Reported-by: John Van Ostrand <john@vanostrand.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-05 22:53:02 +00:00
|
|
|
|
2019-07-15 19:34:39 +00:00
|
|
|
// More than 5 bar used? This matches statistics.c
|
|
|
|
// heuristics
|
|
|
|
return start_mbar > end_mbar + SOME_GAS;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Get list of used cylinders. Returns the number of used cylinders. */
|
|
|
|
static int get_cylinder_used(const struct dive *dive, bool used[])
|
|
|
|
{
|
|
|
|
int i, num = 0;
|
Fix per-cylinder SAC rate calculations when cylinder use isn't known
John Van Ostrand reports that when he dives using two cylinders using
sidemounts, the per-cylinder SAC rate display is very misleading.
What happens is that since the two cylinders are used together (but
without a manifold), John is alternating between the two but not
actually adding gas switches in the profile. As a result, the profile
looks like only one cylinder is used, even though clearly the other
cylinder gets breathed down too.
The per-cylinder SAC rate calculations would entirely ignore the
cylinder that didn't have gas switch events to it, and looking at the
info window it would look like John had a truly exceptional SAC rate.
But then in the general statistics panel that actually takes the whole
gas use into account, the very different real SAC rate would show up.
The basic issue is that if we don't have full use information for the
different cylinders, we would account the whole dive to just a partial
set. We did have a special case for this, but that special case only
really worked if the first cylinder truly was the only cylinder used.
This patch makes us see the difference between "only one cylinder was
used, and I can use the overall mean depth for it" and "more than one
cylinder was used, but I don't know what the mean depths might be".
Reported-by: John Van Ostrand <john@vanostrand.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-05 22:53:02 +00:00
|
|
|
|
2019-08-04 16:44:57 +00:00
|
|
|
for (i = 0; i < dive->cylinders.nr; i++) {
|
2019-08-04 20:13:49 +00:00
|
|
|
used[i] = cylinder_used(get_cylinder(dive, i));
|
2019-07-15 19:34:39 +00:00
|
|
|
if (used[i])
|
|
|
|
num++;
|
Fix per-cylinder SAC rate calculations when cylinder use isn't known
John Van Ostrand reports that when he dives using two cylinders using
sidemounts, the per-cylinder SAC rate display is very misleading.
What happens is that since the two cylinders are used together (but
without a manifold), John is alternating between the two but not
actually adding gas switches in the profile. As a result, the profile
looks like only one cylinder is used, even though clearly the other
cylinder gets breathed down too.
The per-cylinder SAC rate calculations would entirely ignore the
cylinder that didn't have gas switch events to it, and looking at the
info window it would look like John had a truly exceptional SAC rate.
But then in the general statistics panel that actually takes the whole
gas use into account, the very different real SAC rate would show up.
The basic issue is that if we don't have full use information for the
different cylinders, we would account the whole dive to just a partial
set. We did have a special case for this, but that special case only
really worked if the first cylinder truly was the only cylinder used.
This patch makes us see the difference between "only one cylinder was
used, and I can use the overall mean depth for it" and "more than one
cylinder was used, but I don't know what the mean depths might be".
Reported-by: John Van Ostrand <john@vanostrand.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-05 22:53:02 +00:00
|
|
|
}
|
2019-07-15 19:34:39 +00:00
|
|
|
return num;
|
Fix per-cylinder SAC rate calculations when cylinder use isn't known
John Van Ostrand reports that when he dives using two cylinders using
sidemounts, the per-cylinder SAC rate display is very misleading.
What happens is that since the two cylinders are used together (but
without a manifold), John is alternating between the two but not
actually adding gas switches in the profile. As a result, the profile
looks like only one cylinder is used, even though clearly the other
cylinder gets breathed down too.
The per-cylinder SAC rate calculations would entirely ignore the
cylinder that didn't have gas switch events to it, and looking at the
info window it would look like John had a truly exceptional SAC rate.
But then in the general statistics panel that actually takes the whole
gas use into account, the very different real SAC rate would show up.
The basic issue is that if we don't have full use information for the
different cylinders, we would account the whole dive to just a partial
set. We did have a special case for this, but that special case only
really worked if the first cylinder truly was the only cylinder used.
This patch makes us see the difference between "only one cylinder was
used, and I can use the overall mean depth for it" and "more than one
cylinder was used, but I don't know what the mean depths might be".
Reported-by: John Van Ostrand <john@vanostrand.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-05 22:53:02 +00:00
|
|
|
}
|
|
|
|
|
2019-07-15 19:34:39 +00:00
|
|
|
/* Are there any used cylinders which we do not know usage about? */
|
|
|
|
static bool has_unknown_used_cylinders(const struct dive *dive, const struct divecomputer *dc,
|
|
|
|
const bool used_cylinders[], int num)
|
Fix per-cylinder SAC rate calculations when cylinder use isn't known
John Van Ostrand reports that when he dives using two cylinders using
sidemounts, the per-cylinder SAC rate display is very misleading.
What happens is that since the two cylinders are used together (but
without a manifold), John is alternating between the two but not
actually adding gas switches in the profile. As a result, the profile
looks like only one cylinder is used, even though clearly the other
cylinder gets breathed down too.
The per-cylinder SAC rate calculations would entirely ignore the
cylinder that didn't have gas switch events to it, and looking at the
info window it would look like John had a truly exceptional SAC rate.
But then in the general statistics panel that actually takes the whole
gas use into account, the very different real SAC rate would show up.
The basic issue is that if we don't have full use information for the
different cylinders, we would account the whole dive to just a partial
set. We did have a special case for this, but that special case only
really worked if the first cylinder truly was the only cylinder used.
This patch makes us see the difference between "only one cylinder was
used, and I can use the overall mean depth for it" and "more than one
cylinder was used, but I don't know what the mean depths might be".
Reported-by: John Van Ostrand <john@vanostrand.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-05 22:53:02 +00:00
|
|
|
{
|
2019-07-15 19:34:39 +00:00
|
|
|
int idx;
|
2018-08-16 22:58:30 +00:00
|
|
|
const struct event *ev;
|
2019-08-04 16:44:57 +00:00
|
|
|
bool *used_and_unknown = malloc(dive->cylinders.nr * sizeof(bool));
|
|
|
|
memcpy(used_and_unknown, used_cylinders, dive->cylinders.nr * sizeof(bool));
|
Fix per-cylinder SAC rate calculations when cylinder use isn't known
John Van Ostrand reports that when he dives using two cylinders using
sidemounts, the per-cylinder SAC rate display is very misleading.
What happens is that since the two cylinders are used together (but
without a manifold), John is alternating between the two but not
actually adding gas switches in the profile. As a result, the profile
looks like only one cylinder is used, even though clearly the other
cylinder gets breathed down too.
The per-cylinder SAC rate calculations would entirely ignore the
cylinder that didn't have gas switch events to it, and looking at the
info window it would look like John had a truly exceptional SAC rate.
But then in the general statistics panel that actually takes the whole
gas use into account, the very different real SAC rate would show up.
The basic issue is that if we don't have full use information for the
different cylinders, we would account the whole dive to just a partial
set. We did have a special case for this, but that special case only
really worked if the first cylinder truly was the only cylinder used.
This patch makes us see the difference between "only one cylinder was
used, and I can use the overall mean depth for it" and "more than one
cylinder was used, but I don't know what the mean depths might be".
Reported-by: John Van Ostrand <john@vanostrand.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-05 22:53:02 +00:00
|
|
|
|
|
|
|
/* We know about using the O2 cylinder in a CCR dive */
|
|
|
|
if (dc->divemode == CCR) {
|
|
|
|
int o2_cyl = get_cylinder_idx_by_use(dive, OXYGEN);
|
2019-07-15 19:34:39 +00:00
|
|
|
if (o2_cyl >= 0 && used_and_unknown[o2_cyl]) {
|
|
|
|
used_and_unknown[o2_cyl] = false;
|
|
|
|
num--;
|
|
|
|
}
|
Fix per-cylinder SAC rate calculations when cylinder use isn't known
John Van Ostrand reports that when he dives using two cylinders using
sidemounts, the per-cylinder SAC rate display is very misleading.
What happens is that since the two cylinders are used together (but
without a manifold), John is alternating between the two but not
actually adding gas switches in the profile. As a result, the profile
looks like only one cylinder is used, even though clearly the other
cylinder gets breathed down too.
The per-cylinder SAC rate calculations would entirely ignore the
cylinder that didn't have gas switch events to it, and looking at the
info window it would look like John had a truly exceptional SAC rate.
But then in the general statistics panel that actually takes the whole
gas use into account, the very different real SAC rate would show up.
The basic issue is that if we don't have full use information for the
different cylinders, we would account the whole dive to just a partial
set. We did have a special case for this, but that special case only
really worked if the first cylinder truly was the only cylinder used.
This patch makes us see the difference between "only one cylinder was
used, and I can use the overall mean depth for it" and "more than one
cylinder was used, but I don't know what the mean depths might be".
Reported-by: John Van Ostrand <john@vanostrand.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-05 22:53:02 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/* We know about the explicit first cylinder (or first) */
|
2019-07-15 19:34:39 +00:00
|
|
|
idx = explicit_first_cylinder(dive, dc);
|
|
|
|
if (used_and_unknown[idx]) {
|
|
|
|
used_and_unknown[idx] = false;
|
|
|
|
num--;
|
|
|
|
}
|
Fix per-cylinder SAC rate calculations when cylinder use isn't known
John Van Ostrand reports that when he dives using two cylinders using
sidemounts, the per-cylinder SAC rate display is very misleading.
What happens is that since the two cylinders are used together (but
without a manifold), John is alternating between the two but not
actually adding gas switches in the profile. As a result, the profile
looks like only one cylinder is used, even though clearly the other
cylinder gets breathed down too.
The per-cylinder SAC rate calculations would entirely ignore the
cylinder that didn't have gas switch events to it, and looking at the
info window it would look like John had a truly exceptional SAC rate.
But then in the general statistics panel that actually takes the whole
gas use into account, the very different real SAC rate would show up.
The basic issue is that if we don't have full use information for the
different cylinders, we would account the whole dive to just a partial
set. We did have a special case for this, but that special case only
really worked if the first cylinder truly was the only cylinder used.
This patch makes us see the difference between "only one cylinder was
used, and I can use the overall mean depth for it" and "more than one
cylinder was used, but I don't know what the mean depths might be".
Reported-by: John Van Ostrand <john@vanostrand.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-05 22:53:02 +00:00
|
|
|
|
|
|
|
/* And we have possible switches to other gases */
|
|
|
|
ev = get_next_event(dc->events, "gaschange");
|
2019-07-15 19:34:39 +00:00
|
|
|
while (ev && num > 0) {
|
|
|
|
idx = get_cylinder_index(dive, ev);
|
|
|
|
if (idx >= 0 && used_and_unknown[idx]) {
|
|
|
|
used_and_unknown[idx] = false;
|
|
|
|
num--;
|
|
|
|
}
|
Fix per-cylinder SAC rate calculations when cylinder use isn't known
John Van Ostrand reports that when he dives using two cylinders using
sidemounts, the per-cylinder SAC rate display is very misleading.
What happens is that since the two cylinders are used together (but
without a manifold), John is alternating between the two but not
actually adding gas switches in the profile. As a result, the profile
looks like only one cylinder is used, even though clearly the other
cylinder gets breathed down too.
The per-cylinder SAC rate calculations would entirely ignore the
cylinder that didn't have gas switch events to it, and looking at the
info window it would look like John had a truly exceptional SAC rate.
But then in the general statistics panel that actually takes the whole
gas use into account, the very different real SAC rate would show up.
The basic issue is that if we don't have full use information for the
different cylinders, we would account the whole dive to just a partial
set. We did have a special case for this, but that special case only
really worked if the first cylinder truly was the only cylinder used.
This patch makes us see the difference between "only one cylinder was
used, and I can use the overall mean depth for it" and "more than one
cylinder was used, but I don't know what the mean depths might be".
Reported-by: John Van Ostrand <john@vanostrand.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-05 22:53:02 +00:00
|
|
|
ev = get_next_event(ev->next, "gaschange");
|
|
|
|
}
|
|
|
|
|
2019-07-15 19:34:39 +00:00
|
|
|
free(used_and_unknown);
|
|
|
|
return num > 0;
|
Fix per-cylinder SAC rate calculations when cylinder use isn't known
John Van Ostrand reports that when he dives using two cylinders using
sidemounts, the per-cylinder SAC rate display is very misleading.
What happens is that since the two cylinders are used together (but
without a manifold), John is alternating between the two but not
actually adding gas switches in the profile. As a result, the profile
looks like only one cylinder is used, even though clearly the other
cylinder gets breathed down too.
The per-cylinder SAC rate calculations would entirely ignore the
cylinder that didn't have gas switch events to it, and looking at the
info window it would look like John had a truly exceptional SAC rate.
But then in the general statistics panel that actually takes the whole
gas use into account, the very different real SAC rate would show up.
The basic issue is that if we don't have full use information for the
different cylinders, we would account the whole dive to just a partial
set. We did have a special case for this, but that special case only
really worked if the first cylinder truly was the only cylinder used.
This patch makes us see the difference between "only one cylinder was
used, and I can use the overall mean depth for it" and "more than one
cylinder was used, but I don't know what the mean depths might be".
Reported-by: John Van Ostrand <john@vanostrand.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-05 22:53:02 +00:00
|
|
|
}
|
|
|
|
|
2018-08-23 17:18:43 +00:00
|
|
|
void per_cylinder_mean_depth(const struct dive *dive, struct divecomputer *dc, int *mean, int *duration)
|
2013-11-20 06:50:02 +00:00
|
|
|
{
|
|
|
|
int i;
|
2019-06-27 20:03:53 +00:00
|
|
|
int *depthtime;
|
2016-03-10 02:18:58 +00:00
|
|
|
uint32_t lasttime = 0;
|
|
|
|
int lastdepth = 0;
|
2013-11-20 06:50:02 +00:00
|
|
|
int idx = 0;
|
2019-07-15 19:34:39 +00:00
|
|
|
bool *used_cylinders;
|
|
|
|
int num_used_cylinders;
|
2013-11-20 06:50:02 +00:00
|
|
|
|
2019-08-04 17:49:43 +00:00
|
|
|
if (dive->cylinders.nr <= 0)
|
|
|
|
return;
|
|
|
|
|
2019-08-04 16:44:57 +00:00
|
|
|
for (i = 0; i < dive->cylinders.nr; i++)
|
2013-11-20 06:50:02 +00:00
|
|
|
mean[i] = duration[i] = 0;
|
2015-06-22 04:38:12 +00:00
|
|
|
if (!dc)
|
|
|
|
return;
|
Fix per-cylinder SAC rate calculations when cylinder use isn't known
John Van Ostrand reports that when he dives using two cylinders using
sidemounts, the per-cylinder SAC rate display is very misleading.
What happens is that since the two cylinders are used together (but
without a manifold), John is alternating between the two but not
actually adding gas switches in the profile. As a result, the profile
looks like only one cylinder is used, even though clearly the other
cylinder gets breathed down too.
The per-cylinder SAC rate calculations would entirely ignore the
cylinder that didn't have gas switch events to it, and looking at the
info window it would look like John had a truly exceptional SAC rate.
But then in the general statistics panel that actually takes the whole
gas use into account, the very different real SAC rate would show up.
The basic issue is that if we don't have full use information for the
different cylinders, we would account the whole dive to just a partial
set. We did have a special case for this, but that special case only
really worked if the first cylinder truly was the only cylinder used.
This patch makes us see the difference between "only one cylinder was
used, and I can use the overall mean depth for it" and "more than one
cylinder was used, but I don't know what the mean depths might be".
Reported-by: John Van Ostrand <john@vanostrand.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-05 22:53:02 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* There is no point in doing per-cylinder information
|
|
|
|
* if we don't actually know about the usage of all the
|
|
|
|
* used cylinders.
|
|
|
|
*/
|
2019-08-04 16:44:57 +00:00
|
|
|
used_cylinders = malloc(dive->cylinders.nr * sizeof(bool));
|
2019-07-15 19:34:39 +00:00
|
|
|
num_used_cylinders = get_cylinder_used(dive, used_cylinders);
|
|
|
|
if (has_unknown_used_cylinders(dive, dc, used_cylinders, num_used_cylinders)) {
|
Fix per-cylinder SAC rate calculations when cylinder use isn't known
John Van Ostrand reports that when he dives using two cylinders using
sidemounts, the per-cylinder SAC rate display is very misleading.
What happens is that since the two cylinders are used together (but
without a manifold), John is alternating between the two but not
actually adding gas switches in the profile. As a result, the profile
looks like only one cylinder is used, even though clearly the other
cylinder gets breathed down too.
The per-cylinder SAC rate calculations would entirely ignore the
cylinder that didn't have gas switch events to it, and looking at the
info window it would look like John had a truly exceptional SAC rate.
But then in the general statistics panel that actually takes the whole
gas use into account, the very different real SAC rate would show up.
The basic issue is that if we don't have full use information for the
different cylinders, we would account the whole dive to just a partial
set. We did have a special case for this, but that special case only
really worked if the first cylinder truly was the only cylinder used.
This patch makes us see the difference between "only one cylinder was
used, and I can use the overall mean depth for it" and "more than one
cylinder was used, but I don't know what the mean depths might be".
Reported-by: John Van Ostrand <john@vanostrand.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-05 22:53:02 +00:00
|
|
|
/*
|
|
|
|
* If we had more than one used cylinder, but
|
|
|
|
* do not know usage of them, we simply cannot
|
|
|
|
* account mean depth to them.
|
|
|
|
*/
|
2019-07-15 19:34:39 +00:00
|
|
|
if (num_used_cylinders > 1) {
|
|
|
|
free(used_cylinders);
|
Fix per-cylinder SAC rate calculations when cylinder use isn't known
John Van Ostrand reports that when he dives using two cylinders using
sidemounts, the per-cylinder SAC rate display is very misleading.
What happens is that since the two cylinders are used together (but
without a manifold), John is alternating between the two but not
actually adding gas switches in the profile. As a result, the profile
looks like only one cylinder is used, even though clearly the other
cylinder gets breathed down too.
The per-cylinder SAC rate calculations would entirely ignore the
cylinder that didn't have gas switch events to it, and looking at the
info window it would look like John had a truly exceptional SAC rate.
But then in the general statistics panel that actually takes the whole
gas use into account, the very different real SAC rate would show up.
The basic issue is that if we don't have full use information for the
different cylinders, we would account the whole dive to just a partial
set. We did have a special case for this, but that special case only
really worked if the first cylinder truly was the only cylinder used.
This patch makes us see the difference between "only one cylinder was
used, and I can use the overall mean depth for it" and "more than one
cylinder was used, but I don't know what the mean depths might be".
Reported-by: John Van Ostrand <john@vanostrand.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-05 22:53:02 +00:00
|
|
|
return;
|
2019-07-15 19:34:39 +00:00
|
|
|
}
|
Fix per-cylinder SAC rate calculations when cylinder use isn't known
John Van Ostrand reports that when he dives using two cylinders using
sidemounts, the per-cylinder SAC rate display is very misleading.
What happens is that since the two cylinders are used together (but
without a manifold), John is alternating between the two but not
actually adding gas switches in the profile. As a result, the profile
looks like only one cylinder is used, even though clearly the other
cylinder gets breathed down too.
The per-cylinder SAC rate calculations would entirely ignore the
cylinder that didn't have gas switch events to it, and looking at the
info window it would look like John had a truly exceptional SAC rate.
But then in the general statistics panel that actually takes the whole
gas use into account, the very different real SAC rate would show up.
The basic issue is that if we don't have full use information for the
different cylinders, we would account the whole dive to just a partial
set. We did have a special case for this, but that special case only
really worked if the first cylinder truly was the only cylinder used.
This patch makes us see the difference between "only one cylinder was
used, and I can use the overall mean depth for it" and "more than one
cylinder was used, but I don't know what the mean depths might be".
Reported-by: John Van Ostrand <john@vanostrand.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-05 22:53:02 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* For a single cylinder, use the overall mean
|
|
|
|
* and duration
|
|
|
|
*/
|
2019-08-04 16:44:57 +00:00
|
|
|
for (i = 0; i < dive->cylinders.nr; i++) {
|
2019-07-15 19:34:39 +00:00
|
|
|
if (used_cylinders[i]) {
|
Fix per-cylinder SAC rate calculations when cylinder use isn't known
John Van Ostrand reports that when he dives using two cylinders using
sidemounts, the per-cylinder SAC rate display is very misleading.
What happens is that since the two cylinders are used together (but
without a manifold), John is alternating between the two but not
actually adding gas switches in the profile. As a result, the profile
looks like only one cylinder is used, even though clearly the other
cylinder gets breathed down too.
The per-cylinder SAC rate calculations would entirely ignore the
cylinder that didn't have gas switch events to it, and looking at the
info window it would look like John had a truly exceptional SAC rate.
But then in the general statistics panel that actually takes the whole
gas use into account, the very different real SAC rate would show up.
The basic issue is that if we don't have full use information for the
different cylinders, we would account the whole dive to just a partial
set. We did have a special case for this, but that special case only
really worked if the first cylinder truly was the only cylinder used.
This patch makes us see the difference between "only one cylinder was
used, and I can use the overall mean depth for it" and "more than one
cylinder was used, but I don't know what the mean depths might be".
Reported-by: John Van Ostrand <john@vanostrand.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-05 22:53:02 +00:00
|
|
|
mean[i] = dc->meandepth.mm;
|
|
|
|
duration[i] = dc->duration.seconds;
|
|
|
|
}
|
2014-11-17 00:09:59 +00:00
|
|
|
}
|
Fix per-cylinder SAC rate calculations when cylinder use isn't known
John Van Ostrand reports that when he dives using two cylinders using
sidemounts, the per-cylinder SAC rate display is very misleading.
What happens is that since the two cylinders are used together (but
without a manifold), John is alternating between the two but not
actually adding gas switches in the profile. As a result, the profile
looks like only one cylinder is used, even though clearly the other
cylinder gets breathed down too.
The per-cylinder SAC rate calculations would entirely ignore the
cylinder that didn't have gas switch events to it, and looking at the
info window it would look like John had a truly exceptional SAC rate.
But then in the general statistics panel that actually takes the whole
gas use into account, the very different real SAC rate would show up.
The basic issue is that if we don't have full use information for the
different cylinders, we would account the whole dive to just a partial
set. We did have a special case for this, but that special case only
really worked if the first cylinder truly was the only cylinder used.
This patch makes us see the difference between "only one cylinder was
used, and I can use the overall mean depth for it" and "more than one
cylinder was used, but I don't know what the mean depths might be".
Reported-by: John Van Ostrand <john@vanostrand.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-05 22:53:02 +00:00
|
|
|
|
2019-07-15 19:34:39 +00:00
|
|
|
free(used_cylinders);
|
2013-11-20 06:50:02 +00:00
|
|
|
return;
|
|
|
|
}
|
2019-07-15 19:34:39 +00:00
|
|
|
free(used_cylinders);
|
Make gas use statistics be coherent and more complete
The gas use logic in the dive statistics page is confused.
The SAC case had a special case for "unknown", but only for
the first gas. Other gases had the normal empty case.
Also, the logic was really odd - if you had gases that weren't used (or
pressures not known) intermixed with gases you *did* have pressure for,
the statistics got really confused.
The list of gases showed all gases that we know about during the dive,
but then the gas use and SAC-rate lists wouldn't necessarily match,
because the loops that computed those stopped after the first gas that
didn't have any pressure change.
To make things worse, the first cylinder was special-cased again, so it
all lined up for the single-cylinder case.
This makes all the cylinders act the same way, leaving unknown gas use
(and thus SAC) just empty for that gas.
It also fixes the SAC calculation case where we don't have real samples,
and the profile is a fake profile - possibly with gas changes in between
the fake points. We now make the SAC calculations match what we show -
which is admittedly not at all necessarily what the dive was, but at
least we're consistent.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2014-07-30 17:08:33 +00:00
|
|
|
if (!dc->samples)
|
2018-05-05 17:26:48 +00:00
|
|
|
fake_dc(dc);
|
2018-08-16 22:58:30 +00:00
|
|
|
const struct event *ev = get_next_event(dc->events, "gaschange");
|
2019-08-04 16:44:57 +00:00
|
|
|
depthtime = malloc(dive->cylinders.nr * sizeof(*depthtime));
|
|
|
|
memset(depthtime, 0, dive->cylinders.nr * sizeof(*depthtime));
|
2013-11-20 06:50:02 +00:00
|
|
|
for (i = 0; i < dc->samples; i++) {
|
|
|
|
struct sample *sample = dc->sample + i;
|
2016-03-10 02:18:58 +00:00
|
|
|
uint32_t time = sample->time.seconds;
|
2013-11-20 06:50:02 +00:00
|
|
|
int depth = sample->depth.mm;
|
Make gas use statistics be coherent and more complete
The gas use logic in the dive statistics page is confused.
The SAC case had a special case for "unknown", but only for
the first gas. Other gases had the normal empty case.
Also, the logic was really odd - if you had gases that weren't used (or
pressures not known) intermixed with gases you *did* have pressure for,
the statistics got really confused.
The list of gases showed all gases that we know about during the dive,
but then the gas use and SAC-rate lists wouldn't necessarily match,
because the loops that computed those stopped after the first gas that
didn't have any pressure change.
To make things worse, the first cylinder was special-cased again, so it
all lined up for the single-cylinder case.
This makes all the cylinders act the same way, leaving unknown gas use
(and thus SAC) just empty for that gas.
It also fixes the SAC calculation case where we don't have real samples,
and the profile is a fake profile - possibly with gas changes in between
the fake points. We now make the SAC calculations match what we show -
which is admittedly not at all necessarily what the dive was, but at
least we're consistent.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2014-07-30 17:08:33 +00:00
|
|
|
|
|
|
|
/* Make sure to move the event past 'lasttime' */
|
|
|
|
while (ev && lasttime >= ev->time.seconds) {
|
2013-11-20 18:52:17 +00:00
|
|
|
idx = get_cylinder_index(dive, ev);
|
2013-11-20 06:50:02 +00:00
|
|
|
ev = get_next_event(ev->next, "gaschange");
|
|
|
|
}
|
Make gas use statistics be coherent and more complete
The gas use logic in the dive statistics page is confused.
The SAC case had a special case for "unknown", but only for
the first gas. Other gases had the normal empty case.
Also, the logic was really odd - if you had gases that weren't used (or
pressures not known) intermixed with gases you *did* have pressure for,
the statistics got really confused.
The list of gases showed all gases that we know about during the dive,
but then the gas use and SAC-rate lists wouldn't necessarily match,
because the loops that computed those stopped after the first gas that
didn't have any pressure change.
To make things worse, the first cylinder was special-cased again, so it
all lined up for the single-cylinder case.
This makes all the cylinders act the same way, leaving unknown gas use
(and thus SAC) just empty for that gas.
It also fixes the SAC calculation case where we don't have real samples,
and the profile is a fake profile - possibly with gas changes in between
the fake points. We now make the SAC calculations match what we show -
which is admittedly not at all necessarily what the dive was, but at
least we're consistent.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2014-07-30 17:08:33 +00:00
|
|
|
|
|
|
|
/* Do we need to fake a midway sample at an event? */
|
|
|
|
if (ev && time > ev->time.seconds) {
|
|
|
|
int newtime = ev->time.seconds;
|
|
|
|
int newdepth = interpolate(lastdepth, depth, newtime - lasttime, time - lasttime);
|
|
|
|
|
|
|
|
time = newtime;
|
|
|
|
depth = newdepth;
|
|
|
|
i--;
|
|
|
|
}
|
2013-11-20 06:50:02 +00:00
|
|
|
/* We ignore segments at the surface */
|
|
|
|
if (depth > SURFACE_THRESHOLD || lastdepth > SURFACE_THRESHOLD) {
|
|
|
|
duration[idx] += time - lasttime;
|
|
|
|
depthtime[idx] += (time - lasttime) * (depth + lastdepth) / 2;
|
|
|
|
}
|
|
|
|
lastdepth = depth;
|
|
|
|
lasttime = time;
|
|
|
|
}
|
2019-08-04 16:44:57 +00:00
|
|
|
for (i = 0; i < dive->cylinders.nr; i++) {
|
2013-11-20 06:50:02 +00:00
|
|
|
if (duration[i])
|
|
|
|
mean[i] = (depthtime[i] + duration[i] / 2) / duration[i];
|
|
|
|
}
|
2019-06-27 20:03:53 +00:00
|
|
|
free(depthtime);
|
2013-11-20 06:50:02 +00:00
|
|
|
}
|
|
|
|
|
2013-02-09 04:10:47 +00:00
|
|
|
static void update_min_max_temperatures(struct dive *dive, temperature_t temperature)
|
2013-01-24 18:58:59 +00:00
|
|
|
{
|
2013-02-09 04:10:47 +00:00
|
|
|
if (temperature.mkelvin) {
|
|
|
|
if (!dive->maxtemp.mkelvin || temperature.mkelvin > dive->maxtemp.mkelvin)
|
|
|
|
dive->maxtemp = temperature;
|
|
|
|
if (!dive->mintemp.mkelvin || temperature.mkelvin < dive->mintemp.mkelvin)
|
|
|
|
dive->mintemp = temperature;
|
2013-01-24 18:58:59 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2011-11-10 23:33:38 +00:00
|
|
|
/*
|
|
|
|
* If the cylinder tank pressures are within half a bar
|
|
|
|
* (about 8 PSI) of the sample pressures, we consider it
|
|
|
|
* to be a rounding error, and throw them away as redundant.
|
|
|
|
*/
|
|
|
|
static int same_rounded_pressure(pressure_t a, pressure_t b)
|
|
|
|
{
|
|
|
|
return abs(a.mbar - b.mbar) <= 500;
|
|
|
|
}
|
|
|
|
|
2014-10-28 20:48:15 +00:00
|
|
|
/* Some dive computers (Cobalt) don't start the dive with cylinder 0 but explicitly
|
|
|
|
* tell us what the first gas is with a gas change event in the first sample.
|
|
|
|
* Sneakily we'll use a return value of 0 (or FALSE) when there is no explicit
|
2019-12-23 21:02:10 +00:00
|
|
|
* first cylinder - in which case cylinder 0 is indeed the first cylinder.
|
2020-04-20 19:28:17 +00:00
|
|
|
* We likewise return 0 if the event concerns a cylinder that doesn't exist.
|
|
|
|
* If the dive has no cylinders, -1 is returned. */
|
2018-08-16 22:58:30 +00:00
|
|
|
int explicit_first_cylinder(const struct dive *dive, const struct divecomputer *dc)
|
2014-10-28 20:48:15 +00:00
|
|
|
{
|
2019-12-23 21:02:10 +00:00
|
|
|
int res = 0;
|
2020-04-20 19:28:17 +00:00
|
|
|
if (!dive->cylinders.nr)
|
|
|
|
return -1;
|
2015-06-22 04:38:12 +00:00
|
|
|
if (dc) {
|
2018-08-16 22:58:30 +00:00
|
|
|
const struct event *ev = get_next_event(dc->events, "gaschange");
|
2017-02-04 13:26:04 +00:00
|
|
|
if (ev && ((dc->sample && ev->time.seconds == dc->sample[0].time.seconds) || ev->time.seconds <= 1))
|
2019-12-23 21:02:10 +00:00
|
|
|
res = get_cylinder_index(dive, ev);
|
2015-06-22 04:38:12 +00:00
|
|
|
else if (dc->divemode == CCR)
|
2019-12-23 21:02:10 +00:00
|
|
|
res = MAX(get_cylinder_idx_by_use(dive, DILUENT), 0);
|
2015-06-22 04:38:12 +00:00
|
|
|
}
|
2019-12-23 21:02:10 +00:00
|
|
|
return res < dive->cylinders.nr ? res : 0;
|
2014-10-28 20:48:15 +00:00
|
|
|
}
|
|
|
|
|
2015-02-07 16:31:16 +00:00
|
|
|
/* this gets called when the dive mode has changed (so OC vs. CC)
|
|
|
|
* there are two places we might have setpoints... events or in the samples
|
|
|
|
*/
|
2018-08-16 22:58:30 +00:00
|
|
|
void update_setpoint_events(const struct dive *dive, struct divecomputer *dc)
|
2015-01-01 16:00:46 +00:00
|
|
|
{
|
2015-02-07 16:31:16 +00:00
|
|
|
struct event *ev;
|
2015-01-01 16:00:46 +00:00
|
|
|
int new_setpoint = 0;
|
|
|
|
|
2015-01-10 23:01:15 +00:00
|
|
|
if (dc->divemode == CCR)
|
2015-02-07 16:31:16 +00:00
|
|
|
new_setpoint = prefs.defaultsetpoint;
|
|
|
|
|
2015-02-10 23:19:01 +00:00
|
|
|
if (dc->divemode == OC &&
|
|
|
|
(same_string(dc->model, "Shearwater Predator") ||
|
2015-10-16 12:25:56 +00:00
|
|
|
same_string(dc->model, "Shearwater Petrel") ||
|
|
|
|
same_string(dc->model, "Shearwater Nerd"))) {
|
2015-02-07 16:31:16 +00:00
|
|
|
// make sure there's no setpoint in the samples
|
|
|
|
// this is an irreversible change - so switching a dive to OC
|
|
|
|
// by mistake when it's actually CCR is _bad_
|
2015-02-10 23:19:01 +00:00
|
|
|
// So we make sure, this comes from a Predator or Petrel and we only remove
|
2015-02-07 20:02:02 +00:00
|
|
|
// pO2 values we would have computed anyway.
|
2018-08-16 22:58:30 +00:00
|
|
|
const struct event *ev = get_next_event(dc->events, "gaschange");
|
2018-08-16 11:35:14 +00:00
|
|
|
struct gasmix gasmix = get_gasmix_from_event(dive, ev);
|
2018-08-16 22:58:30 +00:00
|
|
|
const struct event *next = get_next_event(ev, "gaschange");
|
2015-02-07 20:02:02 +00:00
|
|
|
|
|
|
|
for (int i = 0; i < dc->samples; i++) {
|
|
|
|
struct gas_pressures pressures;
|
|
|
|
if (next && dc->sample[i].time.seconds >= next->time.seconds) {
|
|
|
|
ev = next;
|
2016-04-02 20:06:54 +00:00
|
|
|
gasmix = get_gasmix_from_event(dive, ev);
|
2015-02-07 20:02:02 +00:00
|
|
|
next = get_next_event(ev, "gaschange");
|
|
|
|
}
|
2018-08-16 17:10:10 +00:00
|
|
|
fill_pressures(&pressures, calculate_depth_to_mbar(dc->sample[i].depth.mm, dc->surface_pressure, 0), gasmix ,0, dc->divemode);
|
2015-12-27 22:33:16 +00:00
|
|
|
if (abs(dc->sample[i].setpoint.mbar - (int)(1000 * pressures.o2)) <= 50)
|
2015-02-07 20:02:02 +00:00
|
|
|
dc->sample[i].setpoint.mbar = 0;
|
|
|
|
}
|
|
|
|
}
|
2015-02-07 16:31:16 +00:00
|
|
|
|
|
|
|
// an "SP change" event at t=0 is currently our marker for OC vs CCR
|
|
|
|
// this will need to change to a saner setup, but for now we can just
|
|
|
|
// check if such an event is there and adjust it, or add that event
|
2018-08-16 22:58:30 +00:00
|
|
|
ev = get_next_event_mutable(dc->events, "SP change");
|
2015-02-07 16:31:16 +00:00
|
|
|
if (ev && ev->time.seconds == 0) {
|
|
|
|
ev->value = new_setpoint;
|
|
|
|
} else {
|
2015-01-08 13:42:07 +00:00
|
|
|
if (!add_event(dc, 0, SAMPLE_EVENT_PO2, 0, new_setpoint, "SP change"))
|
2015-02-07 16:31:16 +00:00
|
|
|
fprintf(stderr, "Could not add setpoint change event\n");
|
2015-01-08 13:42:07 +00:00
|
|
|
}
|
2015-01-01 16:00:46 +00:00
|
|
|
}
|
|
|
|
|
2011-12-30 21:09:17 +00:00
|
|
|
/*
|
|
|
|
* See if the size/workingpressure looks like some standard cylinder
|
|
|
|
* size, eg "AL80".
|
2016-02-24 19:31:03 +00:00
|
|
|
*
|
|
|
|
* NOTE! We don't take compressibility into account when naming
|
|
|
|
* cylinders. That makes a certain amount of sense, since the
|
|
|
|
* cylinder name is independent from the gasmix, and different
|
|
|
|
* gasmixes have different compressibility.
|
2011-12-30 21:09:17 +00:00
|
|
|
*/
|
|
|
|
static void match_standard_cylinder(cylinder_type_t *type)
|
|
|
|
{
|
2016-02-24 19:31:03 +00:00
|
|
|
double cuft, bar;
|
2011-12-30 21:09:17 +00:00
|
|
|
int psi, len;
|
|
|
|
const char *fmt;
|
2013-03-04 01:53:43 +00:00
|
|
|
char buffer[40], *p;
|
2011-12-30 21:09:17 +00:00
|
|
|
|
|
|
|
/* Do we already have a cylinder description? */
|
|
|
|
if (type->description)
|
|
|
|
return;
|
|
|
|
|
2016-02-24 19:31:03 +00:00
|
|
|
bar = type->workingpressure.mbar / 1000.0;
|
2011-12-30 21:09:17 +00:00
|
|
|
cuft = ml_to_cuft(type->size.mliter);
|
2016-02-24 19:31:03 +00:00
|
|
|
cuft *= bar_to_atm(bar);
|
2011-12-30 21:09:17 +00:00
|
|
|
psi = to_PSI(type->workingpressure);
|
|
|
|
|
|
|
|
switch (psi) {
|
2014-02-28 04:09:57 +00:00
|
|
|
case 2300 ... 2500: /* 2400 psi: LP tank */
|
2011-12-30 21:09:17 +00:00
|
|
|
fmt = "LP%d";
|
|
|
|
break;
|
2014-02-28 04:09:57 +00:00
|
|
|
case 2600 ... 2700: /* 2640 psi: LP+10% */
|
2011-12-30 21:09:17 +00:00
|
|
|
fmt = "LP%d";
|
|
|
|
break;
|
2014-02-28 04:09:57 +00:00
|
|
|
case 2900 ... 3100: /* 3000 psi: ALx tank */
|
2011-12-30 21:09:17 +00:00
|
|
|
fmt = "AL%d";
|
|
|
|
break;
|
2014-02-28 04:09:57 +00:00
|
|
|
case 3400 ... 3500: /* 3442 psi: HP tank */
|
2011-12-30 21:09:17 +00:00
|
|
|
fmt = "HP%d";
|
|
|
|
break;
|
2014-02-28 04:09:57 +00:00
|
|
|
case 3700 ... 3850: /* HP+10% */
|
2011-12-30 21:09:17 +00:00
|
|
|
fmt = "HP%d+";
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
return;
|
|
|
|
}
|
2017-03-08 06:41:41 +00:00
|
|
|
len = snprintf(buffer, sizeof(buffer), fmt, (int)lrint(cuft));
|
2014-02-28 04:09:57 +00:00
|
|
|
p = malloc(len + 1);
|
2011-12-30 21:09:17 +00:00
|
|
|
if (!p)
|
|
|
|
return;
|
2014-02-28 04:09:57 +00:00
|
|
|
memcpy(p, buffer, len + 1);
|
2011-12-30 21:09:17 +00:00
|
|
|
type->description = p;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* There are two ways to give cylinder size information:
|
|
|
|
* - total amount of gas in cuft (depends on working pressure and physical size)
|
|
|
|
* - physical size
|
|
|
|
*
|
|
|
|
* where "physical size" is the one that actually matters and is sane.
|
|
|
|
*
|
|
|
|
* We internally use physical size only. But we save the workingpressure
|
|
|
|
* so that we can do the conversion if required.
|
|
|
|
*/
|
|
|
|
static void sanitize_cylinder_type(cylinder_type_t *type)
|
|
|
|
{
|
|
|
|
/* If we have no working pressure, it had *better* be just a physical size! */
|
|
|
|
if (!type->workingpressure.mbar)
|
|
|
|
return;
|
|
|
|
|
|
|
|
/* No size either? Nothing to go on */
|
|
|
|
if (!type->size.mliter)
|
|
|
|
return;
|
|
|
|
|
|
|
|
/* Ok, we have both size and pressure: try to match a description */
|
|
|
|
match_standard_cylinder(type);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void sanitize_cylinder_info(struct dive *dive)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
2019-08-04 16:44:57 +00:00
|
|
|
for (i = 0; i < dive->cylinders.nr; i++) {
|
2019-08-04 20:13:49 +00:00
|
|
|
sanitize_gasmix(&get_cylinder(dive, i)->gasmix);
|
|
|
|
sanitize_cylinder_type(&get_cylinder(dive, i)->type);
|
2011-12-30 21:09:17 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2012-11-10 10:40:35 +00:00
|
|
|
/* some events should never be thrown away */
|
2018-08-16 22:58:30 +00:00
|
|
|
static bool is_potentially_redundant(const struct event *event)
|
2012-11-10 10:40:35 +00:00
|
|
|
{
|
|
|
|
if (!strcmp(event->name, "gaschange"))
|
2014-01-15 18:54:41 +00:00
|
|
|
return false;
|
2012-11-10 19:02:21 +00:00
|
|
|
if (!strcmp(event->name, "bookmark"))
|
2014-01-15 18:54:41 +00:00
|
|
|
return false;
|
2012-11-10 19:02:21 +00:00
|
|
|
if (!strcmp(event->name, "heading"))
|
2014-01-15 18:54:41 +00:00
|
|
|
return false;
|
|
|
|
return true;
|
2012-11-10 10:40:35 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/* match just by name - we compare the details in the code that uses this helper */
|
2012-11-24 02:51:27 +00:00
|
|
|
static struct event *find_previous_event(struct divecomputer *dc, struct event *event)
|
2012-11-10 10:40:35 +00:00
|
|
|
{
|
2012-11-24 02:51:27 +00:00
|
|
|
struct event *ev = dc->events;
|
2012-11-10 10:40:35 +00:00
|
|
|
struct event *previous = NULL;
|
|
|
|
|
2018-01-07 10:12:48 +00:00
|
|
|
if (empty_string(event->name))
|
2012-11-10 10:40:35 +00:00
|
|
|
return NULL;
|
|
|
|
while (ev && ev != event) {
|
2015-06-22 05:07:10 +00:00
|
|
|
if (same_string(ev->name, event->name))
|
2012-11-10 10:40:35 +00:00
|
|
|
previous = ev;
|
|
|
|
ev = ev->next;
|
|
|
|
}
|
|
|
|
return previous;
|
|
|
|
}
|
|
|
|
|
2019-04-30 10:42:33 +00:00
|
|
|
pressure_t calculate_surface_pressure(const struct dive *dive)
|
2013-02-09 00:15:18 +00:00
|
|
|
{
|
2019-04-30 10:42:33 +00:00
|
|
|
const struct divecomputer *dc;
|
|
|
|
pressure_t res;
|
2013-02-09 13:45:58 +00:00
|
|
|
int sum = 0, nr = 0;
|
2013-02-09 00:15:18 +00:00
|
|
|
|
2014-10-11 11:25:52 +00:00
|
|
|
for_each_dc (dive, dc) {
|
2013-02-09 00:15:18 +00:00
|
|
|
if (dc->surface_pressure.mbar) {
|
|
|
|
sum += dc->surface_pressure.mbar;
|
|
|
|
nr++;
|
|
|
|
}
|
|
|
|
}
|
2019-04-30 10:42:33 +00:00
|
|
|
res.mbar = nr ? (sum + nr / 2) / nr : 0;
|
|
|
|
return res;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void fixup_surface_pressure(struct dive *dive)
|
|
|
|
{
|
|
|
|
dive->surface_pressure = calculate_surface_pressure(dive);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* if the surface pressure in the dive data is redundant to the calculated
|
|
|
|
* value (i.e., it was added by running fixup on the dive) return 0,
|
2019-05-15 14:42:14 +00:00
|
|
|
* otherwise return the surface pressure given in the dive */
|
2019-04-30 10:42:33 +00:00
|
|
|
pressure_t un_fixup_surface_pressure(const struct dive *d)
|
|
|
|
{
|
|
|
|
pressure_t res = d->surface_pressure;
|
|
|
|
if (res.mbar && res.mbar == calculate_surface_pressure(d).mbar)
|
|
|
|
res.mbar = 0;
|
|
|
|
return res;
|
2013-02-09 00:15:18 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void fixup_water_salinity(struct dive *dive)
|
|
|
|
{
|
|
|
|
struct divecomputer *dc;
|
2013-02-09 13:45:58 +00:00
|
|
|
int sum = 0, nr = 0;
|
2013-02-09 00:15:18 +00:00
|
|
|
|
2014-10-11 11:25:52 +00:00
|
|
|
for_each_dc (dive, dc) {
|
2013-02-09 00:15:18 +00:00
|
|
|
if (dc->salinity) {
|
2016-02-26 14:16:36 +00:00
|
|
|
if (dc->salinity < 500)
|
|
|
|
dc->salinity += FRESHWATER_SALINITY;
|
2013-02-09 00:15:18 +00:00
|
|
|
sum += dc->salinity;
|
|
|
|
nr++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (nr)
|
2014-02-28 04:09:57 +00:00
|
|
|
dive->salinity = (sum + nr / 2) / nr;
|
2013-02-09 00:15:18 +00:00
|
|
|
}
|
|
|
|
|
2020-05-04 13:54:58 +00:00
|
|
|
int get_dive_salinity(const struct dive *dive)
|
|
|
|
{
|
|
|
|
return dive->user_salinity ? dive->user_salinity : dive->salinity;
|
|
|
|
}
|
|
|
|
|
2013-02-09 14:50:53 +00:00
|
|
|
static void fixup_meandepth(struct dive *dive)
|
|
|
|
{
|
|
|
|
struct divecomputer *dc;
|
|
|
|
int sum = 0, nr = 0;
|
|
|
|
|
2014-10-11 11:25:52 +00:00
|
|
|
for_each_dc (dive, dc) {
|
2013-02-09 14:50:53 +00:00
|
|
|
if (dc->meandepth.mm) {
|
|
|
|
sum += dc->meandepth.mm;
|
|
|
|
nr++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (nr)
|
|
|
|
dive->meandepth.mm = (sum + nr / 2) / nr;
|
|
|
|
}
|
|
|
|
|
2013-02-09 15:12:30 +00:00
|
|
|
static void fixup_duration(struct dive *dive)
|
|
|
|
{
|
|
|
|
struct divecomputer *dc;
|
2017-11-05 14:56:35 +00:00
|
|
|
duration_t duration = { };
|
2013-02-09 15:12:30 +00:00
|
|
|
|
2014-10-11 11:25:52 +00:00
|
|
|
for_each_dc (dive, dc)
|
2017-11-05 14:56:35 +00:00
|
|
|
duration.seconds = MAX(duration.seconds, dc->duration.seconds);
|
2013-02-09 15:12:30 +00:00
|
|
|
|
2017-11-05 14:56:35 +00:00
|
|
|
dive->duration.seconds = duration.seconds;
|
2013-02-09 15:12:30 +00:00
|
|
|
}
|
|
|
|
|
2013-11-29 20:05:21 +00:00
|
|
|
static void fixup_watertemp(struct dive *dive)
|
|
|
|
{
|
|
|
|
if (!dive->watertemp.mkelvin)
|
|
|
|
dive->watertemp.mkelvin = dc_watertemp(&dive->dc);
|
2013-02-09 15:41:15 +00:00
|
|
|
}
|
|
|
|
|
2013-02-14 23:18:48 +00:00
|
|
|
static void fixup_airtemp(struct dive *dive)
|
|
|
|
{
|
|
|
|
if (!dive->airtemp.mkelvin)
|
|
|
|
dive->airtemp.mkelvin = dc_airtemp(&dive->dc);
|
2013-02-09 15:41:15 +00:00
|
|
|
}
|
|
|
|
|
2018-08-13 02:47:07 +00:00
|
|
|
/* if the air temperature in the dive data is redundant to the one in its
|
|
|
|
* first divecomputer (i.e., it was added by running fixup on the dive)
|
|
|
|
* return 0, otherwise return the air temperature given in the dive */
|
|
|
|
static temperature_t un_fixup_airtemp(const struct dive *a)
|
2013-02-14 17:44:18 +00:00
|
|
|
{
|
2018-08-13 02:47:07 +00:00
|
|
|
temperature_t res = a->airtemp;
|
2013-02-14 23:18:48 +00:00
|
|
|
if (a->airtemp.mkelvin && a->airtemp.mkelvin == dc_airtemp(&a->dc))
|
2018-08-13 02:47:07 +00:00
|
|
|
res.mkelvin = 0;
|
|
|
|
return res;
|
2013-02-14 17:44:18 +00:00
|
|
|
}
|
|
|
|
|
2013-02-09 00:35:39 +00:00
|
|
|
/*
|
|
|
|
* events are stored as a linked list, so the concept of
|
|
|
|
* "consecutive, identical events" is somewhat hard to
|
|
|
|
* implement correctly (especially given that on some dive
|
|
|
|
* computers events are asynchronous, so they can come in
|
|
|
|
* between what would be the non-constant sample rate).
|
|
|
|
*
|
|
|
|
* So what we do is that we throw away clearly redundant
|
|
|
|
* events that are fewer than 61 seconds apart (assuming there
|
|
|
|
* is no dive computer with a sample rate of more than 60
|
|
|
|
* seconds... that would be pretty pointless to plot the
|
|
|
|
* profile with)
|
|
|
|
*
|
|
|
|
* We first only mark the events for deletion so that we
|
|
|
|
* still know when the previous event happened.
|
|
|
|
*/
|
|
|
|
static void fixup_dc_events(struct divecomputer *dc)
|
2011-09-03 20:19:26 +00:00
|
|
|
{
|
2013-02-09 00:35:39 +00:00
|
|
|
struct event *event;
|
|
|
|
|
|
|
|
event = dc->events;
|
|
|
|
while (event) {
|
|
|
|
struct event *prev;
|
|
|
|
if (is_potentially_redundant(event)) {
|
|
|
|
prev = find_previous_event(dc, event);
|
|
|
|
if (prev && prev->value == event->value &&
|
|
|
|
prev->flags == event->flags &&
|
|
|
|
event->time.seconds - prev->time.seconds < 61)
|
2014-01-15 18:54:41 +00:00
|
|
|
event->deleted = true;
|
2013-02-09 00:35:39 +00:00
|
|
|
}
|
|
|
|
event = event->next;
|
|
|
|
}
|
|
|
|
event = dc->events;
|
|
|
|
while (event) {
|
|
|
|
if (event->next && event->next->deleted) {
|
|
|
|
struct event *nextnext = event->next->next;
|
|
|
|
free(event->next);
|
|
|
|
event->next = nextnext;
|
|
|
|
} else {
|
|
|
|
event = event->next;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-10-25 03:02:08 +00:00
|
|
|
static int interpolate_depth(struct divecomputer *dc, int idx, int lastdepth, int lasttime, int now)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
int nextdepth = lastdepth;
|
|
|
|
int nexttime = now;
|
|
|
|
|
|
|
|
for (i = idx+1; i < dc->samples; i++) {
|
|
|
|
struct sample *sample = dc->sample + i;
|
|
|
|
if (sample->depth.mm < 0)
|
|
|
|
continue;
|
|
|
|
nextdepth = sample->depth.mm;
|
|
|
|
nexttime = sample->time.seconds;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
return interpolate(lastdepth, nextdepth, now-lasttime, nexttime-lasttime);
|
|
|
|
}
|
|
|
|
|
Split up fixup_dive_dc() into multiple smaller independent functions
fixup_dive_dc() is called for each dive computer when we add a new dive.
It does various housekeeping functions, cleaning up the sample data, and
fixing up dive details as a result of the sample data.
The function has grown to be a monster over time, and particularly the
central "walk every sample" loop has become an unreadable mess.
And the thing is, this isn't even all that performance-critical: it's
only done once per dive and dc, and there is no reason to have a single
illegible and complex loop.
So split up that loop into several smaller pieces that each will loop
individually over the sample data, and do just one thing. So now we
have separate functions for
- fixing up the depth samples with interpolation
- fixing up dive temperature data
- correcting the cylinder pressure sensor index
- cleaning up the actual sample pressures
Yes, this way we walk the samples multiple times, but the end result is
that the code is much easier to understand. There should be no actual
behavioral differences from this cleanup, except for the fact that since
the code is much more understandable, this cleanup also fixed a bug:
In the temperature fixup, we would fix up the overall dive temperatures
based on the dive computer temperatures. But we would then fix up the
overall dive computer temperature based on the sample temperature
*afterwards*, which wouldn't then be reflected in the overall dive
temperatures.
There was another non-symptomatic bug that became obvious when doing
this cleanup: the code used to calculate a 'depthtime' over the dive
that was never actually used. That's a historical artifact of old code
that had become dead when the average depth calculations were moved to a
function of their own earlier.
This is preparatory for fixing the overall cylinder pressure stats,
which are currently wrong for dives with multiple dive computers: we
currently take the starting cylinder pressure from the *first* dive
computer that has cylinder pressure information, but we take the ending
cylinder pressure from the *last* dive computer with cylinder pressure
information.
This does not fix that bug, but without this cleanup fixing that would
be a nightmare due to the previous complicated "do everything in one
single loop" model.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-01 19:32:56 +00:00
|
|
|
static void fixup_dc_depths(struct dive *dive, struct divecomputer *dc)
|
2013-02-09 00:35:39 +00:00
|
|
|
{
|
Split up fixup_dive_dc() into multiple smaller independent functions
fixup_dive_dc() is called for each dive computer when we add a new dive.
It does various housekeeping functions, cleaning up the sample data, and
fixing up dive details as a result of the sample data.
The function has grown to be a monster over time, and particularly the
central "walk every sample" loop has become an unreadable mess.
And the thing is, this isn't even all that performance-critical: it's
only done once per dive and dc, and there is no reason to have a single
illegible and complex loop.
So split up that loop into several smaller pieces that each will loop
individually over the sample data, and do just one thing. So now we
have separate functions for
- fixing up the depth samples with interpolation
- fixing up dive temperature data
- correcting the cylinder pressure sensor index
- cleaning up the actual sample pressures
Yes, this way we walk the samples multiple times, but the end result is
that the code is much easier to understand. There should be no actual
behavioral differences from this cleanup, except for the fact that since
the code is much more understandable, this cleanup also fixed a bug:
In the temperature fixup, we would fix up the overall dive temperatures
based on the dive computer temperatures. But we would then fix up the
overall dive computer temperature based on the sample temperature
*afterwards*, which wouldn't then be reflected in the overall dive
temperatures.
There was another non-symptomatic bug that became obvious when doing
this cleanup: the code used to calculate a 'depthtime' over the dive
that was never actually used. That's a historical artifact of old code
that had become dead when the average depth calculations were moved to a
function of their own earlier.
This is preparatory for fixing the overall cylinder pressure stats,
which are currently wrong for dives with multiple dive computers: we
currently take the starting cylinder pressure from the *first* dive
computer that has cylinder pressure information, but we take the ending
cylinder pressure from the *last* dive computer with cylinder pressure
information.
This does not fix that bug, but without this cleanup fixing that would
be a nightmare due to the previous complicated "do everything in one
single loop" model.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-01 19:32:56 +00:00
|
|
|
int i;
|
2013-02-26 19:15:06 +00:00
|
|
|
int maxdepth = dc->maxdepth.mm;
|
Split up fixup_dive_dc() into multiple smaller independent functions
fixup_dive_dc() is called for each dive computer when we add a new dive.
It does various housekeeping functions, cleaning up the sample data, and
fixing up dive details as a result of the sample data.
The function has grown to be a monster over time, and particularly the
central "walk every sample" loop has become an unreadable mess.
And the thing is, this isn't even all that performance-critical: it's
only done once per dive and dc, and there is no reason to have a single
illegible and complex loop.
So split up that loop into several smaller pieces that each will loop
individually over the sample data, and do just one thing. So now we
have separate functions for
- fixing up the depth samples with interpolation
- fixing up dive temperature data
- correcting the cylinder pressure sensor index
- cleaning up the actual sample pressures
Yes, this way we walk the samples multiple times, but the end result is
that the code is much easier to understand. There should be no actual
behavioral differences from this cleanup, except for the fact that since
the code is much more understandable, this cleanup also fixed a bug:
In the temperature fixup, we would fix up the overall dive temperatures
based on the dive computer temperatures. But we would then fix up the
overall dive computer temperature based on the sample temperature
*afterwards*, which wouldn't then be reflected in the overall dive
temperatures.
There was another non-symptomatic bug that became obvious when doing
this cleanup: the code used to calculate a 'depthtime' over the dive
that was never actually used. That's a historical artifact of old code
that had become dead when the average depth calculations were moved to a
function of their own earlier.
This is preparatory for fixing the overall cylinder pressure stats,
which are currently wrong for dives with multiple dive computers: we
currently take the starting cylinder pressure from the *first* dive
computer that has cylinder pressure information, but we take the ending
cylinder pressure from the *last* dive computer with cylinder pressure
information.
This does not fix that bug, but without this cleanup fixing that would
be a nightmare due to the previous complicated "do everything in one
single loop" model.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-01 19:32:56 +00:00
|
|
|
int lasttime = 0, lastdepth = 0;
|
2014-10-28 20:48:15 +00:00
|
|
|
|
2012-11-24 02:51:27 +00:00
|
|
|
for (i = 0; i < dc->samples; i++) {
|
|
|
|
struct sample *sample = dc->sample + i;
|
2011-09-03 20:19:26 +00:00
|
|
|
int time = sample->time.seconds;
|
|
|
|
int depth = sample->depth.mm;
|
2014-10-28 20:48:15 +00:00
|
|
|
|
2015-10-25 03:02:08 +00:00
|
|
|
if (depth < 0) {
|
|
|
|
depth = interpolate_depth(dc, i, lastdepth, lasttime, time);
|
|
|
|
sample->depth.mm = depth;
|
|
|
|
}
|
|
|
|
|
Split up fixup_dive_dc() into multiple smaller independent functions
fixup_dive_dc() is called for each dive computer when we add a new dive.
It does various housekeeping functions, cleaning up the sample data, and
fixing up dive details as a result of the sample data.
The function has grown to be a monster over time, and particularly the
central "walk every sample" loop has become an unreadable mess.
And the thing is, this isn't even all that performance-critical: it's
only done once per dive and dc, and there is no reason to have a single
illegible and complex loop.
So split up that loop into several smaller pieces that each will loop
individually over the sample data, and do just one thing. So now we
have separate functions for
- fixing up the depth samples with interpolation
- fixing up dive temperature data
- correcting the cylinder pressure sensor index
- cleaning up the actual sample pressures
Yes, this way we walk the samples multiple times, but the end result is
that the code is much easier to understand. There should be no actual
behavioral differences from this cleanup, except for the fact that since
the code is much more understandable, this cleanup also fixed a bug:
In the temperature fixup, we would fix up the overall dive temperatures
based on the dive computer temperatures. But we would then fix up the
overall dive computer temperature based on the sample temperature
*afterwards*, which wouldn't then be reflected in the overall dive
temperatures.
There was another non-symptomatic bug that became obvious when doing
this cleanup: the code used to calculate a 'depthtime' over the dive
that was never actually used. That's a historical artifact of old code
that had become dead when the average depth calculations were moved to a
function of their own earlier.
This is preparatory for fixing the overall cylinder pressure stats,
which are currently wrong for dives with multiple dive computers: we
currently take the starting cylinder pressure from the *first* dive
computer that has cylinder pressure information, but we take the ending
cylinder pressure from the *last* dive computer with cylinder pressure
information.
This does not fix that bug, but without this cleanup fixing that would
be a nightmare due to the previous complicated "do everything in one
single loop" model.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-01 19:32:56 +00:00
|
|
|
if (depth > SURFACE_THRESHOLD) {
|
|
|
|
if (depth > maxdepth)
|
|
|
|
maxdepth = depth;
|
|
|
|
}
|
|
|
|
|
|
|
|
lastdepth = depth;
|
|
|
|
lasttime = time;
|
|
|
|
if (sample->cns > dive->maxcns)
|
|
|
|
dive->maxcns = sample->cns;
|
|
|
|
}
|
|
|
|
|
|
|
|
update_depth(&dc->maxdepth, maxdepth);
|
|
|
|
if (maxdepth > dive->maxdepth.mm)
|
|
|
|
dive->maxdepth.mm = maxdepth;
|
|
|
|
}
|
|
|
|
|
2017-12-08 14:19:13 +00:00
|
|
|
static void fixup_dc_ndl(struct divecomputer *dc)
|
2017-11-05 16:32:38 +00:00
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; i < dc->samples; i++) {
|
|
|
|
struct sample *sample = dc->sample + i;
|
|
|
|
if (sample->ndl.seconds != 0)
|
|
|
|
break;
|
|
|
|
if (sample->ndl.seconds == 0)
|
|
|
|
sample->ndl.seconds = -1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
Split up fixup_dive_dc() into multiple smaller independent functions
fixup_dive_dc() is called for each dive computer when we add a new dive.
It does various housekeeping functions, cleaning up the sample data, and
fixing up dive details as a result of the sample data.
The function has grown to be a monster over time, and particularly the
central "walk every sample" loop has become an unreadable mess.
And the thing is, this isn't even all that performance-critical: it's
only done once per dive and dc, and there is no reason to have a single
illegible and complex loop.
So split up that loop into several smaller pieces that each will loop
individually over the sample data, and do just one thing. So now we
have separate functions for
- fixing up the depth samples with interpolation
- fixing up dive temperature data
- correcting the cylinder pressure sensor index
- cleaning up the actual sample pressures
Yes, this way we walk the samples multiple times, but the end result is
that the code is much easier to understand. There should be no actual
behavioral differences from this cleanup, except for the fact that since
the code is much more understandable, this cleanup also fixed a bug:
In the temperature fixup, we would fix up the overall dive temperatures
based on the dive computer temperatures. But we would then fix up the
overall dive computer temperature based on the sample temperature
*afterwards*, which wouldn't then be reflected in the overall dive
temperatures.
There was another non-symptomatic bug that became obvious when doing
this cleanup: the code used to calculate a 'depthtime' over the dive
that was never actually used. That's a historical artifact of old code
that had become dead when the average depth calculations were moved to a
function of their own earlier.
This is preparatory for fixing the overall cylinder pressure stats,
which are currently wrong for dives with multiple dive computers: we
currently take the starting cylinder pressure from the *first* dive
computer that has cylinder pressure information, but we take the ending
cylinder pressure from the *last* dive computer with cylinder pressure
information.
This does not fix that bug, but without this cleanup fixing that would
be a nightmare due to the previous complicated "do everything in one
single loop" model.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-01 19:32:56 +00:00
|
|
|
static void fixup_dc_temp(struct dive *dive, struct divecomputer *dc)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
int mintemp = 0, lasttemp = 0;
|
|
|
|
|
|
|
|
for (i = 0; i < dc->samples; i++) {
|
|
|
|
struct sample *sample = dc->sample + i;
|
|
|
|
int temp = sample->temperature.mkelvin;
|
|
|
|
|
|
|
|
if (temp) {
|
|
|
|
/*
|
|
|
|
* If we have consecutive identical
|
|
|
|
* temperature readings, throw away
|
|
|
|
* the redundant ones.
|
|
|
|
*/
|
|
|
|
if (lasttemp == temp)
|
|
|
|
sample->temperature.mkelvin = 0;
|
|
|
|
else
|
|
|
|
lasttemp = temp;
|
|
|
|
|
|
|
|
if (!mintemp || temp < mintemp)
|
|
|
|
mintemp = temp;
|
|
|
|
}
|
|
|
|
|
|
|
|
update_min_max_temperatures(dive, sample->temperature);
|
|
|
|
}
|
|
|
|
update_temperature(&dc->watertemp, mintemp);
|
|
|
|
update_min_max_temperatures(dive, dc->watertemp);
|
|
|
|
}
|
|
|
|
|
2016-04-02 12:28:03 +00:00
|
|
|
/* Remove redundant pressure information */
|
2016-04-05 14:40:32 +00:00
|
|
|
static void simplify_dc_pressures(struct divecomputer *dc)
|
Split up fixup_dive_dc() into multiple smaller independent functions
fixup_dive_dc() is called for each dive computer when we add a new dive.
It does various housekeeping functions, cleaning up the sample data, and
fixing up dive details as a result of the sample data.
The function has grown to be a monster over time, and particularly the
central "walk every sample" loop has become an unreadable mess.
And the thing is, this isn't even all that performance-critical: it's
only done once per dive and dc, and there is no reason to have a single
illegible and complex loop.
So split up that loop into several smaller pieces that each will loop
individually over the sample data, and do just one thing. So now we
have separate functions for
- fixing up the depth samples with interpolation
- fixing up dive temperature data
- correcting the cylinder pressure sensor index
- cleaning up the actual sample pressures
Yes, this way we walk the samples multiple times, but the end result is
that the code is much easier to understand. There should be no actual
behavioral differences from this cleanup, except for the fact that since
the code is much more understandable, this cleanup also fixed a bug:
In the temperature fixup, we would fix up the overall dive temperatures
based on the dive computer temperatures. But we would then fix up the
overall dive computer temperature based on the sample temperature
*afterwards*, which wouldn't then be reflected in the overall dive
temperatures.
There was another non-symptomatic bug that became obvious when doing
this cleanup: the code used to calculate a 'depthtime' over the dive
that was never actually used. That's a historical artifact of old code
that had become dead when the average depth calculations were moved to a
function of their own earlier.
This is preparatory for fixing the overall cylinder pressure stats,
which are currently wrong for dives with multiple dive computers: we
currently take the starting cylinder pressure from the *first* dive
computer that has cylinder pressure information, but we take the ending
cylinder pressure from the *last* dive computer with cylinder pressure
information.
This does not fix that bug, but without this cleanup fixing that would
be a nightmare due to the previous complicated "do everything in one
single loop" model.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-01 19:32:56 +00:00
|
|
|
{
|
2016-04-02 12:28:03 +00:00
|
|
|
int i;
|
Start cleaning up sensor indexing for multiple sensors
This is a very timid start at making us actually use multiple sensors
without the magical special case for just CCR oxygen tracking.
It mainly does:
- turn the "sample->sensor" index into an array of two indexes, to
match the pressures themselves.
- get rid of dive->{oxygen_cylinder_index,diluent_cylinder_index},
since a CCR dive should now simply set the sample->sensor[] indices
correctly instead.
- in a couple of places, start actually looping over the sensors rather
than special-case the O2 case (although often the small "loops" are
just unrolled, since it's just two cases.
but in many cases we still end up only covering the zero sensor case,
because the CCR O2 sensor code coverage was fairly limited.
It's entirely possible (even likely) that this migth break some existing
case: it tries to be a fairly direct ("stupid") translation of the old
code, but unlike the preparatory patch this does actually does change
some semantics.
For example, right now the git loader code assumes that if the git save
data contains a o2pressure entry, it just hardcodes the O2 sensor index
to 1.
In fact, one issue is going to simply be that our file formats do not
have that multiple sensor format, but instead had very clearly encoded
things as being the CCR O2 pressure sensor.
But this is hopefully close to usable, and I will need feedback (and
maybe test cases) from people who have existing CCR dives with pressure
data.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-07-21 02:49:45 +00:00
|
|
|
int lastindex[2] = { -1, -1 };
|
|
|
|
int lastpressure[2] = { 0 };
|
Split up fixup_dive_dc() into multiple smaller independent functions
fixup_dive_dc() is called for each dive computer when we add a new dive.
It does various housekeeping functions, cleaning up the sample data, and
fixing up dive details as a result of the sample data.
The function has grown to be a monster over time, and particularly the
central "walk every sample" loop has become an unreadable mess.
And the thing is, this isn't even all that performance-critical: it's
only done once per dive and dc, and there is no reason to have a single
illegible and complex loop.
So split up that loop into several smaller pieces that each will loop
individually over the sample data, and do just one thing. So now we
have separate functions for
- fixing up the depth samples with interpolation
- fixing up dive temperature data
- correcting the cylinder pressure sensor index
- cleaning up the actual sample pressures
Yes, this way we walk the samples multiple times, but the end result is
that the code is much easier to understand. There should be no actual
behavioral differences from this cleanup, except for the fact that since
the code is much more understandable, this cleanup also fixed a bug:
In the temperature fixup, we would fix up the overall dive temperatures
based on the dive computer temperatures. But we would then fix up the
overall dive computer temperature based on the sample temperature
*afterwards*, which wouldn't then be reflected in the overall dive
temperatures.
There was another non-symptomatic bug that became obvious when doing
this cleanup: the code used to calculate a 'depthtime' over the dive
that was never actually used. That's a historical artifact of old code
that had become dead when the average depth calculations were moved to a
function of their own earlier.
This is preparatory for fixing the overall cylinder pressure stats,
which are currently wrong for dives with multiple dive computers: we
currently take the starting cylinder pressure from the *first* dive
computer that has cylinder pressure information, but we take the ending
cylinder pressure from the *last* dive computer with cylinder pressure
information.
This does not fix that bug, but without this cleanup fixing that would
be a nightmare due to the previous complicated "do everything in one
single loop" model.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-01 19:32:56 +00:00
|
|
|
|
|
|
|
for (i = 0; i < dc->samples; i++) {
|
Start cleaning up sensor indexing for multiple sensors
This is a very timid start at making us actually use multiple sensors
without the magical special case for just CCR oxygen tracking.
It mainly does:
- turn the "sample->sensor" index into an array of two indexes, to
match the pressures themselves.
- get rid of dive->{oxygen_cylinder_index,diluent_cylinder_index},
since a CCR dive should now simply set the sample->sensor[] indices
correctly instead.
- in a couple of places, start actually looping over the sensors rather
than special-case the O2 case (although often the small "loops" are
just unrolled, since it's just two cases.
but in many cases we still end up only covering the zero sensor case,
because the CCR O2 sensor code coverage was fairly limited.
It's entirely possible (even likely) that this migth break some existing
case: it tries to be a fairly direct ("stupid") translation of the old
code, but unlike the preparatory patch this does actually does change
some semantics.
For example, right now the git loader code assumes that if the git save
data contains a o2pressure entry, it just hardcodes the O2 sensor index
to 1.
In fact, one issue is going to simply be that our file formats do not
have that multiple sensor format, but instead had very clearly encoded
things as being the CCR O2 pressure sensor.
But this is hopefully close to usable, and I will need feedback (and
maybe test cases) from people who have existing CCR dives with pressure
data.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-07-21 02:49:45 +00:00
|
|
|
int j;
|
Split up fixup_dive_dc() into multiple smaller independent functions
fixup_dive_dc() is called for each dive computer when we add a new dive.
It does various housekeeping functions, cleaning up the sample data, and
fixing up dive details as a result of the sample data.
The function has grown to be a monster over time, and particularly the
central "walk every sample" loop has become an unreadable mess.
And the thing is, this isn't even all that performance-critical: it's
only done once per dive and dc, and there is no reason to have a single
illegible and complex loop.
So split up that loop into several smaller pieces that each will loop
individually over the sample data, and do just one thing. So now we
have separate functions for
- fixing up the depth samples with interpolation
- fixing up dive temperature data
- correcting the cylinder pressure sensor index
- cleaning up the actual sample pressures
Yes, this way we walk the samples multiple times, but the end result is
that the code is much easier to understand. There should be no actual
behavioral differences from this cleanup, except for the fact that since
the code is much more understandable, this cleanup also fixed a bug:
In the temperature fixup, we would fix up the overall dive temperatures
based on the dive computer temperatures. But we would then fix up the
overall dive computer temperature based on the sample temperature
*afterwards*, which wouldn't then be reflected in the overall dive
temperatures.
There was another non-symptomatic bug that became obvious when doing
this cleanup: the code used to calculate a 'depthtime' over the dive
that was never actually used. That's a historical artifact of old code
that had become dead when the average depth calculations were moved to a
function of their own earlier.
This is preparatory for fixing the overall cylinder pressure stats,
which are currently wrong for dives with multiple dive computers: we
currently take the starting cylinder pressure from the *first* dive
computer that has cylinder pressure information, but we take the ending
cylinder pressure from the *last* dive computer with cylinder pressure
information.
This does not fix that bug, but without this cleanup fixing that would
be a nightmare due to the previous complicated "do everything in one
single loop" model.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-01 19:32:56 +00:00
|
|
|
struct sample *sample = dc->sample + i;
|
Start cleaning up sensor indexing for multiple sensors
This is a very timid start at making us actually use multiple sensors
without the magical special case for just CCR oxygen tracking.
It mainly does:
- turn the "sample->sensor" index into an array of two indexes, to
match the pressures themselves.
- get rid of dive->{oxygen_cylinder_index,diluent_cylinder_index},
since a CCR dive should now simply set the sample->sensor[] indices
correctly instead.
- in a couple of places, start actually looping over the sensors rather
than special-case the O2 case (although often the small "loops" are
just unrolled, since it's just two cases.
but in many cases we still end up only covering the zero sensor case,
because the CCR O2 sensor code coverage was fairly limited.
It's entirely possible (even likely) that this migth break some existing
case: it tries to be a fairly direct ("stupid") translation of the old
code, but unlike the preparatory patch this does actually does change
some semantics.
For example, right now the git loader code assumes that if the git save
data contains a o2pressure entry, it just hardcodes the O2 sensor index
to 1.
In fact, one issue is going to simply be that our file formats do not
have that multiple sensor format, but instead had very clearly encoded
things as being the CCR O2 pressure sensor.
But this is hopefully close to usable, and I will need feedback (and
maybe test cases) from people who have existing CCR dives with pressure
data.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-07-21 02:49:45 +00:00
|
|
|
|
2017-11-27 13:40:51 +00:00
|
|
|
for (j = 0; j < MAX_SENSORS; j++) {
|
Start cleaning up sensor indexing for multiple sensors
This is a very timid start at making us actually use multiple sensors
without the magical special case for just CCR oxygen tracking.
It mainly does:
- turn the "sample->sensor" index into an array of two indexes, to
match the pressures themselves.
- get rid of dive->{oxygen_cylinder_index,diluent_cylinder_index},
since a CCR dive should now simply set the sample->sensor[] indices
correctly instead.
- in a couple of places, start actually looping over the sensors rather
than special-case the O2 case (although often the small "loops" are
just unrolled, since it's just two cases.
but in many cases we still end up only covering the zero sensor case,
because the CCR O2 sensor code coverage was fairly limited.
It's entirely possible (even likely) that this migth break some existing
case: it tries to be a fairly direct ("stupid") translation of the old
code, but unlike the preparatory patch this does actually does change
some semantics.
For example, right now the git loader code assumes that if the git save
data contains a o2pressure entry, it just hardcodes the O2 sensor index
to 1.
In fact, one issue is going to simply be that our file formats do not
have that multiple sensor format, but instead had very clearly encoded
things as being the CCR O2 pressure sensor.
But this is hopefully close to usable, and I will need feedback (and
maybe test cases) from people who have existing CCR dives with pressure
data.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-07-21 02:49:45 +00:00
|
|
|
int pressure = sample->pressure[j].mbar;
|
|
|
|
int index = sample->sensor[j];
|
|
|
|
|
|
|
|
if (index == lastindex[j]) {
|
|
|
|
/* Remove duplicate redundant pressure information */
|
|
|
|
if (pressure == lastpressure[j])
|
|
|
|
sample->pressure[j].mbar = 0;
|
|
|
|
}
|
|
|
|
lastindex[j] = index;
|
|
|
|
lastpressure[j] = pressure;
|
2011-11-19 12:09:14 +00:00
|
|
|
}
|
2011-09-03 20:19:26 +00:00
|
|
|
}
|
Split up fixup_dive_dc() into multiple smaller independent functions
fixup_dive_dc() is called for each dive computer when we add a new dive.
It does various housekeeping functions, cleaning up the sample data, and
fixing up dive details as a result of the sample data.
The function has grown to be a monster over time, and particularly the
central "walk every sample" loop has become an unreadable mess.
And the thing is, this isn't even all that performance-critical: it's
only done once per dive and dc, and there is no reason to have a single
illegible and complex loop.
So split up that loop into several smaller pieces that each will loop
individually over the sample data, and do just one thing. So now we
have separate functions for
- fixing up the depth samples with interpolation
- fixing up dive temperature data
- correcting the cylinder pressure sensor index
- cleaning up the actual sample pressures
Yes, this way we walk the samples multiple times, but the end result is
that the code is much easier to understand. There should be no actual
behavioral differences from this cleanup, except for the fact that since
the code is much more understandable, this cleanup also fixed a bug:
In the temperature fixup, we would fix up the overall dive temperatures
based on the dive computer temperatures. But we would then fix up the
overall dive computer temperature based on the sample temperature
*afterwards*, which wouldn't then be reflected in the overall dive
temperatures.
There was another non-symptomatic bug that became obvious when doing
this cleanup: the code used to calculate a 'depthtime' over the dive
that was never actually used. That's a historical artifact of old code
that had become dead when the average depth calculations were moved to a
function of their own earlier.
This is preparatory for fixing the overall cylinder pressure stats,
which are currently wrong for dives with multiple dive computers: we
currently take the starting cylinder pressure from the *first* dive
computer that has cylinder pressure information, but we take the ending
cylinder pressure from the *last* dive computer with cylinder pressure
information.
This does not fix that bug, but without this cleanup fixing that would
be a nightmare due to the previous complicated "do everything in one
single loop" model.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-01 19:32:56 +00:00
|
|
|
}
|
|
|
|
|
2019-03-19 15:22:51 +00:00
|
|
|
/* Do we need a sensor -> cylinder mapping? */
|
Fix cylinder end pressure fixup from samples
This bug admittedly hits almost nobody, but if you had multiple cylinder
pressure sensors on the same cylinder (attached to multiple dive
computers, of course), we would take the beginning pressure from the
first dive computer, and the ending pressure from the last dive
computer.
That came about because we'd just walk all the dive computer samples in
order, and the first time we see a relevant sample and we don't have a
beginning pressure, we'd take that pressure. So the beginning pressure
was from the first dive computer, and once we'd seen a valid beginning
pressure, that would never change.
But as we're walking along, we'd continue to update the ending pressure
from the last relevant sample we see, which means that as we go on to
look at the other dive computers, we'd continue to update the ending
pressure with data from them.
And mixing beginning/ending pressures from two different sensors just
does not make sense.
This changes the logic to be the same for beginning and ending
pressures: we only update it once, with the first relevant sample we
see. But we walk the samples twice: forwards from the beginning to
find the first beginning pressure, and backwards from the end to find
the ending pressure.
That means that as we move on to the second dive computer, we've now
filled in the ending pressure from the first one, and will no longer
update it any more.
NOTE! We don't stop scanning the samples (or the dive computers) just
because we've found a valid pressure value. We'll always walk all the
samples because there might be multiple different cylinders that get
pressure data from different samples (and different dive computers).
We could have some early-out logic when we've filled in all relevant
cylinders, but since this just runs once per dive it's not worth it.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-01 20:23:55 +00:00
|
|
|
static void fixup_start_pressure(struct dive *dive, int idx, pressure_t p)
|
|
|
|
{
|
2019-08-04 16:44:57 +00:00
|
|
|
if (idx >= 0 && idx < dive->cylinders.nr) {
|
2019-08-04 20:13:49 +00:00
|
|
|
cylinder_t *cyl = get_cylinder(dive, idx);
|
Fix cylinder end pressure fixup from samples
This bug admittedly hits almost nobody, but if you had multiple cylinder
pressure sensors on the same cylinder (attached to multiple dive
computers, of course), we would take the beginning pressure from the
first dive computer, and the ending pressure from the last dive
computer.
That came about because we'd just walk all the dive computer samples in
order, and the first time we see a relevant sample and we don't have a
beginning pressure, we'd take that pressure. So the beginning pressure
was from the first dive computer, and once we'd seen a valid beginning
pressure, that would never change.
But as we're walking along, we'd continue to update the ending pressure
from the last relevant sample we see, which means that as we go on to
look at the other dive computers, we'd continue to update the ending
pressure with data from them.
And mixing beginning/ending pressures from two different sensors just
does not make sense.
This changes the logic to be the same for beginning and ending
pressures: we only update it once, with the first relevant sample we
see. But we walk the samples twice: forwards from the beginning to
find the first beginning pressure, and backwards from the end to find
the ending pressure.
That means that as we move on to the second dive computer, we've now
filled in the ending pressure from the first one, and will no longer
update it any more.
NOTE! We don't stop scanning the samples (or the dive computers) just
because we've found a valid pressure value. We'll always walk all the
samples because there might be multiple different cylinders that get
pressure data from different samples (and different dive computers).
We could have some early-out logic when we've filled in all relevant
cylinders, but since this just runs once per dive it's not worth it.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-01 20:23:55 +00:00
|
|
|
if (p.mbar && !cyl->sample_start.mbar)
|
|
|
|
cyl->sample_start = p;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void fixup_end_pressure(struct dive *dive, int idx, pressure_t p)
|
|
|
|
{
|
2019-08-04 16:44:57 +00:00
|
|
|
if (idx >= 0 && idx < dive->cylinders.nr) {
|
2019-08-04 20:13:49 +00:00
|
|
|
cylinder_t *cyl = get_cylinder(dive, idx);
|
Fix cylinder end pressure fixup from samples
This bug admittedly hits almost nobody, but if you had multiple cylinder
pressure sensors on the same cylinder (attached to multiple dive
computers, of course), we would take the beginning pressure from the
first dive computer, and the ending pressure from the last dive
computer.
That came about because we'd just walk all the dive computer samples in
order, and the first time we see a relevant sample and we don't have a
beginning pressure, we'd take that pressure. So the beginning pressure
was from the first dive computer, and once we'd seen a valid beginning
pressure, that would never change.
But as we're walking along, we'd continue to update the ending pressure
from the last relevant sample we see, which means that as we go on to
look at the other dive computers, we'd continue to update the ending
pressure with data from them.
And mixing beginning/ending pressures from two different sensors just
does not make sense.
This changes the logic to be the same for beginning and ending
pressures: we only update it once, with the first relevant sample we
see. But we walk the samples twice: forwards from the beginning to
find the first beginning pressure, and backwards from the end to find
the ending pressure.
That means that as we move on to the second dive computer, we've now
filled in the ending pressure from the first one, and will no longer
update it any more.
NOTE! We don't stop scanning the samples (or the dive computers) just
because we've found a valid pressure value. We'll always walk all the
samples because there might be multiple different cylinders that get
pressure data from different samples (and different dive computers).
We could have some early-out logic when we've filled in all relevant
cylinders, but since this just runs once per dive it's not worth it.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-01 20:23:55 +00:00
|
|
|
if (p.mbar && !cyl->sample_end.mbar)
|
|
|
|
cyl->sample_end = p;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
Split up fixup_dive_dc() into multiple smaller independent functions
fixup_dive_dc() is called for each dive computer when we add a new dive.
It does various housekeeping functions, cleaning up the sample data, and
fixing up dive details as a result of the sample data.
The function has grown to be a monster over time, and particularly the
central "walk every sample" loop has become an unreadable mess.
And the thing is, this isn't even all that performance-critical: it's
only done once per dive and dc, and there is no reason to have a single
illegible and complex loop.
So split up that loop into several smaller pieces that each will loop
individually over the sample data, and do just one thing. So now we
have separate functions for
- fixing up the depth samples with interpolation
- fixing up dive temperature data
- correcting the cylinder pressure sensor index
- cleaning up the actual sample pressures
Yes, this way we walk the samples multiple times, but the end result is
that the code is much easier to understand. There should be no actual
behavioral differences from this cleanup, except for the fact that since
the code is much more understandable, this cleanup also fixed a bug:
In the temperature fixup, we would fix up the overall dive temperatures
based on the dive computer temperatures. But we would then fix up the
overall dive computer temperature based on the sample temperature
*afterwards*, which wouldn't then be reflected in the overall dive
temperatures.
There was another non-symptomatic bug that became obvious when doing
this cleanup: the code used to calculate a 'depthtime' over the dive
that was never actually used. That's a historical artifact of old code
that had become dead when the average depth calculations were moved to a
function of their own earlier.
This is preparatory for fixing the overall cylinder pressure stats,
which are currently wrong for dives with multiple dive computers: we
currently take the starting cylinder pressure from the *first* dive
computer that has cylinder pressure information, but we take the ending
cylinder pressure from the *last* dive computer with cylinder pressure
information.
This does not fix that bug, but without this cleanup fixing that would
be a nightmare due to the previous complicated "do everything in one
single loop" model.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-01 19:32:56 +00:00
|
|
|
/*
|
|
|
|
* Check the cylinder pressure sample information and fill in the
|
|
|
|
* overall cylinder pressures from those.
|
Fix cylinder end pressure fixup from samples
This bug admittedly hits almost nobody, but if you had multiple cylinder
pressure sensors on the same cylinder (attached to multiple dive
computers, of course), we would take the beginning pressure from the
first dive computer, and the ending pressure from the last dive
computer.
That came about because we'd just walk all the dive computer samples in
order, and the first time we see a relevant sample and we don't have a
beginning pressure, we'd take that pressure. So the beginning pressure
was from the first dive computer, and once we'd seen a valid beginning
pressure, that would never change.
But as we're walking along, we'd continue to update the ending pressure
from the last relevant sample we see, which means that as we go on to
look at the other dive computers, we'd continue to update the ending
pressure with data from them.
And mixing beginning/ending pressures from two different sensors just
does not make sense.
This changes the logic to be the same for beginning and ending
pressures: we only update it once, with the first relevant sample we
see. But we walk the samples twice: forwards from the beginning to
find the first beginning pressure, and backwards from the end to find
the ending pressure.
That means that as we move on to the second dive computer, we've now
filled in the ending pressure from the first one, and will no longer
update it any more.
NOTE! We don't stop scanning the samples (or the dive computers) just
because we've found a valid pressure value. We'll always walk all the
samples because there might be multiple different cylinders that get
pressure data from different samples (and different dive computers).
We could have some early-out logic when we've filled in all relevant
cylinders, but since this just runs once per dive it's not worth it.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-01 20:23:55 +00:00
|
|
|
*
|
|
|
|
* We ignore surface samples for tank pressure information.
|
|
|
|
*
|
|
|
|
* At the beginning of the dive, let the cylinder cool down
|
|
|
|
* if the diver starts off at the surface. And at the end
|
|
|
|
* of the dive, there may be surface pressures where the
|
|
|
|
* diver has already turned off the air supply (especially
|
|
|
|
* for computers like the Uemis Zurich that end up saving
|
|
|
|
* quite a bit of samples after the dive has ended).
|
Split up fixup_dive_dc() into multiple smaller independent functions
fixup_dive_dc() is called for each dive computer when we add a new dive.
It does various housekeeping functions, cleaning up the sample data, and
fixing up dive details as a result of the sample data.
The function has grown to be a monster over time, and particularly the
central "walk every sample" loop has become an unreadable mess.
And the thing is, this isn't even all that performance-critical: it's
only done once per dive and dc, and there is no reason to have a single
illegible and complex loop.
So split up that loop into several smaller pieces that each will loop
individually over the sample data, and do just one thing. So now we
have separate functions for
- fixing up the depth samples with interpolation
- fixing up dive temperature data
- correcting the cylinder pressure sensor index
- cleaning up the actual sample pressures
Yes, this way we walk the samples multiple times, but the end result is
that the code is much easier to understand. There should be no actual
behavioral differences from this cleanup, except for the fact that since
the code is much more understandable, this cleanup also fixed a bug:
In the temperature fixup, we would fix up the overall dive temperatures
based on the dive computer temperatures. But we would then fix up the
overall dive computer temperature based on the sample temperature
*afterwards*, which wouldn't then be reflected in the overall dive
temperatures.
There was another non-symptomatic bug that became obvious when doing
this cleanup: the code used to calculate a 'depthtime' over the dive
that was never actually used. That's a historical artifact of old code
that had become dead when the average depth calculations were moved to a
function of their own earlier.
This is preparatory for fixing the overall cylinder pressure stats,
which are currently wrong for dives with multiple dive computers: we
currently take the starting cylinder pressure from the *first* dive
computer that has cylinder pressure information, but we take the ending
cylinder pressure from the *last* dive computer with cylinder pressure
information.
This does not fix that bug, but without this cleanup fixing that would
be a nightmare due to the previous complicated "do everything in one
single loop" model.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-01 19:32:56 +00:00
|
|
|
*/
|
|
|
|
static void fixup_dive_pressures(struct dive *dive, struct divecomputer *dc)
|
|
|
|
{
|
Start cleaning up sensor indexing for multiple sensors
This is a very timid start at making us actually use multiple sensors
without the magical special case for just CCR oxygen tracking.
It mainly does:
- turn the "sample->sensor" index into an array of two indexes, to
match the pressures themselves.
- get rid of dive->{oxygen_cylinder_index,diluent_cylinder_index},
since a CCR dive should now simply set the sample->sensor[] indices
correctly instead.
- in a couple of places, start actually looping over the sensors rather
than special-case the O2 case (although often the small "loops" are
just unrolled, since it's just two cases.
but in many cases we still end up only covering the zero sensor case,
because the CCR O2 sensor code coverage was fairly limited.
It's entirely possible (even likely) that this migth break some existing
case: it tries to be a fairly direct ("stupid") translation of the old
code, but unlike the preparatory patch this does actually does change
some semantics.
For example, right now the git loader code assumes that if the git save
data contains a o2pressure entry, it just hardcodes the O2 sensor index
to 1.
In fact, one issue is going to simply be that our file formats do not
have that multiple sensor format, but instead had very clearly encoded
things as being the CCR O2 pressure sensor.
But this is hopefully close to usable, and I will need feedback (and
maybe test cases) from people who have existing CCR dives with pressure
data.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-07-21 02:49:45 +00:00
|
|
|
int i;
|
Fix cylinder end pressure fixup from samples
This bug admittedly hits almost nobody, but if you had multiple cylinder
pressure sensors on the same cylinder (attached to multiple dive
computers, of course), we would take the beginning pressure from the
first dive computer, and the ending pressure from the last dive
computer.
That came about because we'd just walk all the dive computer samples in
order, and the first time we see a relevant sample and we don't have a
beginning pressure, we'd take that pressure. So the beginning pressure
was from the first dive computer, and once we'd seen a valid beginning
pressure, that would never change.
But as we're walking along, we'd continue to update the ending pressure
from the last relevant sample we see, which means that as we go on to
look at the other dive computers, we'd continue to update the ending
pressure with data from them.
And mixing beginning/ending pressures from two different sensors just
does not make sense.
This changes the logic to be the same for beginning and ending
pressures: we only update it once, with the first relevant sample we
see. But we walk the samples twice: forwards from the beginning to
find the first beginning pressure, and backwards from the end to find
the ending pressure.
That means that as we move on to the second dive computer, we've now
filled in the ending pressure from the first one, and will no longer
update it any more.
NOTE! We don't stop scanning the samples (or the dive computers) just
because we've found a valid pressure value. We'll always walk all the
samples because there might be multiple different cylinders that get
pressure data from different samples (and different dive computers).
We could have some early-out logic when we've filled in all relevant
cylinders, but since this just runs once per dive it's not worth it.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-01 20:23:55 +00:00
|
|
|
|
|
|
|
/* Walk the samples from the beginning to find starting pressures.. */
|
Split up fixup_dive_dc() into multiple smaller independent functions
fixup_dive_dc() is called for each dive computer when we add a new dive.
It does various housekeeping functions, cleaning up the sample data, and
fixing up dive details as a result of the sample data.
The function has grown to be a monster over time, and particularly the
central "walk every sample" loop has become an unreadable mess.
And the thing is, this isn't even all that performance-critical: it's
only done once per dive and dc, and there is no reason to have a single
illegible and complex loop.
So split up that loop into several smaller pieces that each will loop
individually over the sample data, and do just one thing. So now we
have separate functions for
- fixing up the depth samples with interpolation
- fixing up dive temperature data
- correcting the cylinder pressure sensor index
- cleaning up the actual sample pressures
Yes, this way we walk the samples multiple times, but the end result is
that the code is much easier to understand. There should be no actual
behavioral differences from this cleanup, except for the fact that since
the code is much more understandable, this cleanup also fixed a bug:
In the temperature fixup, we would fix up the overall dive temperatures
based on the dive computer temperatures. But we would then fix up the
overall dive computer temperature based on the sample temperature
*afterwards*, which wouldn't then be reflected in the overall dive
temperatures.
There was another non-symptomatic bug that became obvious when doing
this cleanup: the code used to calculate a 'depthtime' over the dive
that was never actually used. That's a historical artifact of old code
that had become dead when the average depth calculations were moved to a
function of their own earlier.
This is preparatory for fixing the overall cylinder pressure stats,
which are currently wrong for dives with multiple dive computers: we
currently take the starting cylinder pressure from the *first* dive
computer that has cylinder pressure information, but we take the ending
cylinder pressure from the *last* dive computer with cylinder pressure
information.
This does not fix that bug, but without this cleanup fixing that would
be a nightmare due to the previous complicated "do everything in one
single loop" model.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-01 19:32:56 +00:00
|
|
|
for (i = 0; i < dc->samples; i++) {
|
Profile support for multiple concurrent pressure sensors
This finally handles multiple cylinder pressures, both overlapping and
consecutive, and it seems to work on the nasty cases I've thrown at it.
Want to just track five different cylinders all at once, without any
pesky gas switch events? Sure, you can do that. It will show five
different gas pressures for your five cylinders, and they will go down
as you breathe down the cylinders.
I obviously don't have any real data for that case, but I do have a test
file with five actual cylinders that all have samples over the whole
course of the dive. The end result looks messy as hell, but what did
you expect?
HOWEVER.
The only way to do this sanely was
- actually make the "struct plot_info" have all the cylinder pressures
(so no "sensor index and pressure" - every cylinder has a pressure for
every plot info entry)
This obviously makes the plot_info much bigger. We used to have
MAX_CYLINDERS be a fairly generous 8, which seems sane. The planning
code made that 8 be 20. That seems questionable. But whatever.
The good news is that the plot-info should hopefully get freed, and
only be allocated one dive at a time, so the fact that it is big and
nasty shouldn't be a scaling issue, though.
- the "populate_pressure_information()" function had to be rewritten
quite a bit. The good news is that it's actually simpler now, although
I would not go so far as to really call it simple. It's still
complicated and suble, but now it explicitly just does one cylinder at
a time.
It *used* to have this insanely complicated "keep track of the pressure
ranges for every cylinder at once". I just couldn't stand that model
and keep my sanity, so it now just tracks one cylinder at a time, and
doesn't have an array of live data, instead the caller will just call
it for each cylinder.
- get rid of some of our hackier stuff, like the code that populates the
plot_info data code with the currently selected cylinder number, and
clears out any other pressures. That obviously does *not* work when you
may not have a single primary cylinder any more.
Now, the above sounds like all good things. Yeah, it mostly is.
BUT.
There's a few big downsides from the above:
- there's no sane way to do this as a series of small changes.
The change to make the plot_info take an array of cylinder pressures
rather than the sensor+pressure model really isn't amenable to "fix up
one use at a time". When you switch over to the new data structure
model, you have to switch over to the new way of populating the
pressure ranges. The two just go hand in hand.
- Some of our code *depended* on the "sensor+pressure" model. I fixed all
the ones I could sanely fix. There was one particular case that I just
couldn't sanely fix, and I didn't care enough about it to do something
insane.
So the only _known_ breakage is the "TankItem" profile widget. That's
the bar at the bottom of the profile that shows which cylinder is in
use right now. You'd think that would be trivial to fix up, and yes it
would be - I could just use the regular model of
firstcyl = explicit_first_cylinder(dive, dc)
.. then iterate over the gas change events to see the others ..
but the problem with the "TankItem" widget is that it does its own
model, and it has thrown away the dive and the dive computer
information. It just doesn't even know. It only knows what cylinders
there are, and the plot_info. And it just used to look at the sensor
number in the plot_info, and be done with that. That number no longer
exists.
- I have tested it, and I think the code is better, but hey, it's a
fairly large patch to some of the more complex code in our code base.
That "interpolate missing pressure fields" code really isn't pretty. It
may be prettier, but..
Anyway, without further ado, here's the patch. No sign-off yet, because I
do think people should look and comment. But I think the patch is fine,
and I'll fix anythign that anybody can find, *except* for that TankItem
thing that I will refuse to touch. That class is ugly. It needs to have
access to the actual dive.
Note how it actually does remove more lines than it adds, and that's
despite added comments etc. The code really is simpler, but there may be
cases in there that need more work.
Known missing pieces that don't currently take advantage of concurrent
cylinder pressure data:
- the momentary SAC rate coloring for dives will need more work
- dive merging (but we expect to generally normally not merge dive
computers, which is the main source of sensor data)
- actually taking advantage of different sensor data from different
dive computers
But most of all: Testing. Lots and lots of testing to find all the
corner cases.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-07-27 17:17:05 +00:00
|
|
|
int idx;
|
Split up fixup_dive_dc() into multiple smaller independent functions
fixup_dive_dc() is called for each dive computer when we add a new dive.
It does various housekeeping functions, cleaning up the sample data, and
fixing up dive details as a result of the sample data.
The function has grown to be a monster over time, and particularly the
central "walk every sample" loop has become an unreadable mess.
And the thing is, this isn't even all that performance-critical: it's
only done once per dive and dc, and there is no reason to have a single
illegible and complex loop.
So split up that loop into several smaller pieces that each will loop
individually over the sample data, and do just one thing. So now we
have separate functions for
- fixing up the depth samples with interpolation
- fixing up dive temperature data
- correcting the cylinder pressure sensor index
- cleaning up the actual sample pressures
Yes, this way we walk the samples multiple times, but the end result is
that the code is much easier to understand. There should be no actual
behavioral differences from this cleanup, except for the fact that since
the code is much more understandable, this cleanup also fixed a bug:
In the temperature fixup, we would fix up the overall dive temperatures
based on the dive computer temperatures. But we would then fix up the
overall dive computer temperature based on the sample temperature
*afterwards*, which wouldn't then be reflected in the overall dive
temperatures.
There was another non-symptomatic bug that became obvious when doing
this cleanup: the code used to calculate a 'depthtime' over the dive
that was never actually used. That's a historical artifact of old code
that had become dead when the average depth calculations were moved to a
function of their own earlier.
This is preparatory for fixing the overall cylinder pressure stats,
which are currently wrong for dives with multiple dive computers: we
currently take the starting cylinder pressure from the *first* dive
computer that has cylinder pressure information, but we take the ending
cylinder pressure from the *last* dive computer with cylinder pressure
information.
This does not fix that bug, but without this cleanup fixing that would
be a nightmare due to the previous complicated "do everything in one
single loop" model.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-01 19:32:56 +00:00
|
|
|
struct sample *sample = dc->sample + i;
|
Fix cylinder end pressure fixup from samples
This bug admittedly hits almost nobody, but if you had multiple cylinder
pressure sensors on the same cylinder (attached to multiple dive
computers, of course), we would take the beginning pressure from the
first dive computer, and the ending pressure from the last dive
computer.
That came about because we'd just walk all the dive computer samples in
order, and the first time we see a relevant sample and we don't have a
beginning pressure, we'd take that pressure. So the beginning pressure
was from the first dive computer, and once we'd seen a valid beginning
pressure, that would never change.
But as we're walking along, we'd continue to update the ending pressure
from the last relevant sample we see, which means that as we go on to
look at the other dive computers, we'd continue to update the ending
pressure with data from them.
And mixing beginning/ending pressures from two different sensors just
does not make sense.
This changes the logic to be the same for beginning and ending
pressures: we only update it once, with the first relevant sample we
see. But we walk the samples twice: forwards from the beginning to
find the first beginning pressure, and backwards from the end to find
the ending pressure.
That means that as we move on to the second dive computer, we've now
filled in the ending pressure from the first one, and will no longer
update it any more.
NOTE! We don't stop scanning the samples (or the dive computers) just
because we've found a valid pressure value. We'll always walk all the
samples because there might be multiple different cylinders that get
pressure data from different samples (and different dive computers).
We could have some early-out logic when we've filled in all relevant
cylinders, but since this just runs once per dive it's not worth it.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-01 20:23:55 +00:00
|
|
|
|
|
|
|
if (sample->depth.mm < SURFACE_THRESHOLD)
|
|
|
|
continue;
|
|
|
|
|
Profile support for multiple concurrent pressure sensors
This finally handles multiple cylinder pressures, both overlapping and
consecutive, and it seems to work on the nasty cases I've thrown at it.
Want to just track five different cylinders all at once, without any
pesky gas switch events? Sure, you can do that. It will show five
different gas pressures for your five cylinders, and they will go down
as you breathe down the cylinders.
I obviously don't have any real data for that case, but I do have a test
file with five actual cylinders that all have samples over the whole
course of the dive. The end result looks messy as hell, but what did
you expect?
HOWEVER.
The only way to do this sanely was
- actually make the "struct plot_info" have all the cylinder pressures
(so no "sensor index and pressure" - every cylinder has a pressure for
every plot info entry)
This obviously makes the plot_info much bigger. We used to have
MAX_CYLINDERS be a fairly generous 8, which seems sane. The planning
code made that 8 be 20. That seems questionable. But whatever.
The good news is that the plot-info should hopefully get freed, and
only be allocated one dive at a time, so the fact that it is big and
nasty shouldn't be a scaling issue, though.
- the "populate_pressure_information()" function had to be rewritten
quite a bit. The good news is that it's actually simpler now, although
I would not go so far as to really call it simple. It's still
complicated and suble, but now it explicitly just does one cylinder at
a time.
It *used* to have this insanely complicated "keep track of the pressure
ranges for every cylinder at once". I just couldn't stand that model
and keep my sanity, so it now just tracks one cylinder at a time, and
doesn't have an array of live data, instead the caller will just call
it for each cylinder.
- get rid of some of our hackier stuff, like the code that populates the
plot_info data code with the currently selected cylinder number, and
clears out any other pressures. That obviously does *not* work when you
may not have a single primary cylinder any more.
Now, the above sounds like all good things. Yeah, it mostly is.
BUT.
There's a few big downsides from the above:
- there's no sane way to do this as a series of small changes.
The change to make the plot_info take an array of cylinder pressures
rather than the sensor+pressure model really isn't amenable to "fix up
one use at a time". When you switch over to the new data structure
model, you have to switch over to the new way of populating the
pressure ranges. The two just go hand in hand.
- Some of our code *depended* on the "sensor+pressure" model. I fixed all
the ones I could sanely fix. There was one particular case that I just
couldn't sanely fix, and I didn't care enough about it to do something
insane.
So the only _known_ breakage is the "TankItem" profile widget. That's
the bar at the bottom of the profile that shows which cylinder is in
use right now. You'd think that would be trivial to fix up, and yes it
would be - I could just use the regular model of
firstcyl = explicit_first_cylinder(dive, dc)
.. then iterate over the gas change events to see the others ..
but the problem with the "TankItem" widget is that it does its own
model, and it has thrown away the dive and the dive computer
information. It just doesn't even know. It only knows what cylinders
there are, and the plot_info. And it just used to look at the sensor
number in the plot_info, and be done with that. That number no longer
exists.
- I have tested it, and I think the code is better, but hey, it's a
fairly large patch to some of the more complex code in our code base.
That "interpolate missing pressure fields" code really isn't pretty. It
may be prettier, but..
Anyway, without further ado, here's the patch. No sign-off yet, because I
do think people should look and comment. But I think the patch is fine,
and I'll fix anythign that anybody can find, *except* for that TankItem
thing that I will refuse to touch. That class is ugly. It needs to have
access to the actual dive.
Note how it actually does remove more lines than it adds, and that's
despite added comments etc. The code really is simpler, but there may be
cases in there that need more work.
Known missing pieces that don't currently take advantage of concurrent
cylinder pressure data:
- the momentary SAC rate coloring for dives will need more work
- dive merging (but we expect to generally normally not merge dive
computers, which is the main source of sensor data)
- actually taking advantage of different sensor data from different
dive computers
But most of all: Testing. Lots and lots of testing to find all the
corner cases.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-07-27 17:17:05 +00:00
|
|
|
for (idx = 0; idx < MAX_SENSORS; idx++)
|
|
|
|
fixup_start_pressure(dive, sample->sensor[idx], sample->pressure[idx]);
|
Fix cylinder end pressure fixup from samples
This bug admittedly hits almost nobody, but if you had multiple cylinder
pressure sensors on the same cylinder (attached to multiple dive
computers, of course), we would take the beginning pressure from the
first dive computer, and the ending pressure from the last dive
computer.
That came about because we'd just walk all the dive computer samples in
order, and the first time we see a relevant sample and we don't have a
beginning pressure, we'd take that pressure. So the beginning pressure
was from the first dive computer, and once we'd seen a valid beginning
pressure, that would never change.
But as we're walking along, we'd continue to update the ending pressure
from the last relevant sample we see, which means that as we go on to
look at the other dive computers, we'd continue to update the ending
pressure with data from them.
And mixing beginning/ending pressures from two different sensors just
does not make sense.
This changes the logic to be the same for beginning and ending
pressures: we only update it once, with the first relevant sample we
see. But we walk the samples twice: forwards from the beginning to
find the first beginning pressure, and backwards from the end to find
the ending pressure.
That means that as we move on to the second dive computer, we've now
filled in the ending pressure from the first one, and will no longer
update it any more.
NOTE! We don't stop scanning the samples (or the dive computers) just
because we've found a valid pressure value. We'll always walk all the
samples because there might be multiple different cylinders that get
pressure data from different samples (and different dive computers).
We could have some early-out logic when we've filled in all relevant
cylinders, but since this just runs once per dive it's not worth it.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-01 20:23:55 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/* ..and from the end for ending pressures */
|
|
|
|
for (i = dc->samples; --i >= 0; ) {
|
Profile support for multiple concurrent pressure sensors
This finally handles multiple cylinder pressures, both overlapping and
consecutive, and it seems to work on the nasty cases I've thrown at it.
Want to just track five different cylinders all at once, without any
pesky gas switch events? Sure, you can do that. It will show five
different gas pressures for your five cylinders, and they will go down
as you breathe down the cylinders.
I obviously don't have any real data for that case, but I do have a test
file with five actual cylinders that all have samples over the whole
course of the dive. The end result looks messy as hell, but what did
you expect?
HOWEVER.
The only way to do this sanely was
- actually make the "struct plot_info" have all the cylinder pressures
(so no "sensor index and pressure" - every cylinder has a pressure for
every plot info entry)
This obviously makes the plot_info much bigger. We used to have
MAX_CYLINDERS be a fairly generous 8, which seems sane. The planning
code made that 8 be 20. That seems questionable. But whatever.
The good news is that the plot-info should hopefully get freed, and
only be allocated one dive at a time, so the fact that it is big and
nasty shouldn't be a scaling issue, though.
- the "populate_pressure_information()" function had to be rewritten
quite a bit. The good news is that it's actually simpler now, although
I would not go so far as to really call it simple. It's still
complicated and suble, but now it explicitly just does one cylinder at
a time.
It *used* to have this insanely complicated "keep track of the pressure
ranges for every cylinder at once". I just couldn't stand that model
and keep my sanity, so it now just tracks one cylinder at a time, and
doesn't have an array of live data, instead the caller will just call
it for each cylinder.
- get rid of some of our hackier stuff, like the code that populates the
plot_info data code with the currently selected cylinder number, and
clears out any other pressures. That obviously does *not* work when you
may not have a single primary cylinder any more.
Now, the above sounds like all good things. Yeah, it mostly is.
BUT.
There's a few big downsides from the above:
- there's no sane way to do this as a series of small changes.
The change to make the plot_info take an array of cylinder pressures
rather than the sensor+pressure model really isn't amenable to "fix up
one use at a time". When you switch over to the new data structure
model, you have to switch over to the new way of populating the
pressure ranges. The two just go hand in hand.
- Some of our code *depended* on the "sensor+pressure" model. I fixed all
the ones I could sanely fix. There was one particular case that I just
couldn't sanely fix, and I didn't care enough about it to do something
insane.
So the only _known_ breakage is the "TankItem" profile widget. That's
the bar at the bottom of the profile that shows which cylinder is in
use right now. You'd think that would be trivial to fix up, and yes it
would be - I could just use the regular model of
firstcyl = explicit_first_cylinder(dive, dc)
.. then iterate over the gas change events to see the others ..
but the problem with the "TankItem" widget is that it does its own
model, and it has thrown away the dive and the dive computer
information. It just doesn't even know. It only knows what cylinders
there are, and the plot_info. And it just used to look at the sensor
number in the plot_info, and be done with that. That number no longer
exists.
- I have tested it, and I think the code is better, but hey, it's a
fairly large patch to some of the more complex code in our code base.
That "interpolate missing pressure fields" code really isn't pretty. It
may be prettier, but..
Anyway, without further ado, here's the patch. No sign-off yet, because I
do think people should look and comment. But I think the patch is fine,
and I'll fix anythign that anybody can find, *except* for that TankItem
thing that I will refuse to touch. That class is ugly. It needs to have
access to the actual dive.
Note how it actually does remove more lines than it adds, and that's
despite added comments etc. The code really is simpler, but there may be
cases in there that need more work.
Known missing pieces that don't currently take advantage of concurrent
cylinder pressure data:
- the momentary SAC rate coloring for dives will need more work
- dive merging (but we expect to generally normally not merge dive
computers, which is the main source of sensor data)
- actually taking advantage of different sensor data from different
dive computers
But most of all: Testing. Lots and lots of testing to find all the
corner cases.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-07-27 17:17:05 +00:00
|
|
|
int idx;
|
Fix cylinder end pressure fixup from samples
This bug admittedly hits almost nobody, but if you had multiple cylinder
pressure sensors on the same cylinder (attached to multiple dive
computers, of course), we would take the beginning pressure from the
first dive computer, and the ending pressure from the last dive
computer.
That came about because we'd just walk all the dive computer samples in
order, and the first time we see a relevant sample and we don't have a
beginning pressure, we'd take that pressure. So the beginning pressure
was from the first dive computer, and once we'd seen a valid beginning
pressure, that would never change.
But as we're walking along, we'd continue to update the ending pressure
from the last relevant sample we see, which means that as we go on to
look at the other dive computers, we'd continue to update the ending
pressure with data from them.
And mixing beginning/ending pressures from two different sensors just
does not make sense.
This changes the logic to be the same for beginning and ending
pressures: we only update it once, with the first relevant sample we
see. But we walk the samples twice: forwards from the beginning to
find the first beginning pressure, and backwards from the end to find
the ending pressure.
That means that as we move on to the second dive computer, we've now
filled in the ending pressure from the first one, and will no longer
update it any more.
NOTE! We don't stop scanning the samples (or the dive computers) just
because we've found a valid pressure value. We'll always walk all the
samples because there might be multiple different cylinders that get
pressure data from different samples (and different dive computers).
We could have some early-out logic when we've filled in all relevant
cylinders, but since this just runs once per dive it's not worth it.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-01 20:23:55 +00:00
|
|
|
struct sample *sample = dc->sample + i;
|
|
|
|
|
|
|
|
if (sample->depth.mm < SURFACE_THRESHOLD)
|
|
|
|
continue;
|
|
|
|
|
Profile support for multiple concurrent pressure sensors
This finally handles multiple cylinder pressures, both overlapping and
consecutive, and it seems to work on the nasty cases I've thrown at it.
Want to just track five different cylinders all at once, without any
pesky gas switch events? Sure, you can do that. It will show five
different gas pressures for your five cylinders, and they will go down
as you breathe down the cylinders.
I obviously don't have any real data for that case, but I do have a test
file with five actual cylinders that all have samples over the whole
course of the dive. The end result looks messy as hell, but what did
you expect?
HOWEVER.
The only way to do this sanely was
- actually make the "struct plot_info" have all the cylinder pressures
(so no "sensor index and pressure" - every cylinder has a pressure for
every plot info entry)
This obviously makes the plot_info much bigger. We used to have
MAX_CYLINDERS be a fairly generous 8, which seems sane. The planning
code made that 8 be 20. That seems questionable. But whatever.
The good news is that the plot-info should hopefully get freed, and
only be allocated one dive at a time, so the fact that it is big and
nasty shouldn't be a scaling issue, though.
- the "populate_pressure_information()" function had to be rewritten
quite a bit. The good news is that it's actually simpler now, although
I would not go so far as to really call it simple. It's still
complicated and suble, but now it explicitly just does one cylinder at
a time.
It *used* to have this insanely complicated "keep track of the pressure
ranges for every cylinder at once". I just couldn't stand that model
and keep my sanity, so it now just tracks one cylinder at a time, and
doesn't have an array of live data, instead the caller will just call
it for each cylinder.
- get rid of some of our hackier stuff, like the code that populates the
plot_info data code with the currently selected cylinder number, and
clears out any other pressures. That obviously does *not* work when you
may not have a single primary cylinder any more.
Now, the above sounds like all good things. Yeah, it mostly is.
BUT.
There's a few big downsides from the above:
- there's no sane way to do this as a series of small changes.
The change to make the plot_info take an array of cylinder pressures
rather than the sensor+pressure model really isn't amenable to "fix up
one use at a time". When you switch over to the new data structure
model, you have to switch over to the new way of populating the
pressure ranges. The two just go hand in hand.
- Some of our code *depended* on the "sensor+pressure" model. I fixed all
the ones I could sanely fix. There was one particular case that I just
couldn't sanely fix, and I didn't care enough about it to do something
insane.
So the only _known_ breakage is the "TankItem" profile widget. That's
the bar at the bottom of the profile that shows which cylinder is in
use right now. You'd think that would be trivial to fix up, and yes it
would be - I could just use the regular model of
firstcyl = explicit_first_cylinder(dive, dc)
.. then iterate over the gas change events to see the others ..
but the problem with the "TankItem" widget is that it does its own
model, and it has thrown away the dive and the dive computer
information. It just doesn't even know. It only knows what cylinders
there are, and the plot_info. And it just used to look at the sensor
number in the plot_info, and be done with that. That number no longer
exists.
- I have tested it, and I think the code is better, but hey, it's a
fairly large patch to some of the more complex code in our code base.
That "interpolate missing pressure fields" code really isn't pretty. It
may be prettier, but..
Anyway, without further ado, here's the patch. No sign-off yet, because I
do think people should look and comment. But I think the patch is fine,
and I'll fix anythign that anybody can find, *except* for that TankItem
thing that I will refuse to touch. That class is ugly. It needs to have
access to the actual dive.
Note how it actually does remove more lines than it adds, and that's
despite added comments etc. The code really is simpler, but there may be
cases in there that need more work.
Known missing pieces that don't currently take advantage of concurrent
cylinder pressure data:
- the momentary SAC rate coloring for dives will need more work
- dive merging (but we expect to generally normally not merge dive
computers, which is the main source of sensor data)
- actually taking advantage of different sensor data from different
dive computers
But most of all: Testing. Lots and lots of testing to find all the
corner cases.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-07-27 17:17:05 +00:00
|
|
|
for (idx = 0; idx < MAX_SENSORS; idx++)
|
|
|
|
fixup_end_pressure(dive, sample->sensor[idx], sample->pressure[idx]);
|
Split up fixup_dive_dc() into multiple smaller independent functions
fixup_dive_dc() is called for each dive computer when we add a new dive.
It does various housekeeping functions, cleaning up the sample data, and
fixing up dive details as a result of the sample data.
The function has grown to be a monster over time, and particularly the
central "walk every sample" loop has become an unreadable mess.
And the thing is, this isn't even all that performance-critical: it's
only done once per dive and dc, and there is no reason to have a single
illegible and complex loop.
So split up that loop into several smaller pieces that each will loop
individually over the sample data, and do just one thing. So now we
have separate functions for
- fixing up the depth samples with interpolation
- fixing up dive temperature data
- correcting the cylinder pressure sensor index
- cleaning up the actual sample pressures
Yes, this way we walk the samples multiple times, but the end result is
that the code is much easier to understand. There should be no actual
behavioral differences from this cleanup, except for the fact that since
the code is much more understandable, this cleanup also fixed a bug:
In the temperature fixup, we would fix up the overall dive temperatures
based on the dive computer temperatures. But we would then fix up the
overall dive computer temperature based on the sample temperature
*afterwards*, which wouldn't then be reflected in the overall dive
temperatures.
There was another non-symptomatic bug that became obvious when doing
this cleanup: the code used to calculate a 'depthtime' over the dive
that was never actually used. That's a historical artifact of old code
that had become dead when the average depth calculations were moved to a
function of their own earlier.
This is preparatory for fixing the overall cylinder pressure stats,
which are currently wrong for dives with multiple dive computers: we
currently take the starting cylinder pressure from the *first* dive
computer that has cylinder pressure information, but we take the ending
cylinder pressure from the *last* dive computer with cylinder pressure
information.
This does not fix that bug, but without this cleanup fixing that would
be a nightmare due to the previous complicated "do everything in one
single loop" model.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-01 19:32:56 +00:00
|
|
|
}
|
|
|
|
|
2016-04-05 14:40:32 +00:00
|
|
|
simplify_dc_pressures(dc);
|
Split up fixup_dive_dc() into multiple smaller independent functions
fixup_dive_dc() is called for each dive computer when we add a new dive.
It does various housekeeping functions, cleaning up the sample data, and
fixing up dive details as a result of the sample data.
The function has grown to be a monster over time, and particularly the
central "walk every sample" loop has become an unreadable mess.
And the thing is, this isn't even all that performance-critical: it's
only done once per dive and dc, and there is no reason to have a single
illegible and complex loop.
So split up that loop into several smaller pieces that each will loop
individually over the sample data, and do just one thing. So now we
have separate functions for
- fixing up the depth samples with interpolation
- fixing up dive temperature data
- correcting the cylinder pressure sensor index
- cleaning up the actual sample pressures
Yes, this way we walk the samples multiple times, but the end result is
that the code is much easier to understand. There should be no actual
behavioral differences from this cleanup, except for the fact that since
the code is much more understandable, this cleanup also fixed a bug:
In the temperature fixup, we would fix up the overall dive temperatures
based on the dive computer temperatures. But we would then fix up the
overall dive computer temperature based on the sample temperature
*afterwards*, which wouldn't then be reflected in the overall dive
temperatures.
There was another non-symptomatic bug that became obvious when doing
this cleanup: the code used to calculate a 'depthtime' over the dive
that was never actually used. That's a historical artifact of old code
that had become dead when the average depth calculations were moved to a
function of their own earlier.
This is preparatory for fixing the overall cylinder pressure stats,
which are currently wrong for dives with multiple dive computers: we
currently take the starting cylinder pressure from the *first* dive
computer that has cylinder pressure information, but we take the ending
cylinder pressure from the *last* dive computer with cylinder pressure
information.
This does not fix that bug, but without this cleanup fixing that would
be a nightmare due to the previous complicated "do everything in one
single loop" model.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-01 19:32:56 +00:00
|
|
|
}
|
|
|
|
|
2016-04-02 20:06:54 +00:00
|
|
|
/*
|
|
|
|
* Match a gas change event against the cylinders we have
|
|
|
|
*/
|
2016-04-05 14:40:32 +00:00
|
|
|
static bool validate_gaschange(struct dive *dive, struct event *event)
|
2016-04-02 20:06:54 +00:00
|
|
|
{
|
|
|
|
int index;
|
|
|
|
int o2, he, value;
|
|
|
|
|
|
|
|
/* We'll get rid of the per-event gasmix, but for now sanitize it */
|
2018-08-16 17:10:10 +00:00
|
|
|
if (gasmix_is_air(event->gas.mix))
|
2016-04-02 20:06:54 +00:00
|
|
|
event->gas.mix.o2.permille = 0;
|
|
|
|
|
|
|
|
/* Do we already have a cylinder index for this gasmix? */
|
|
|
|
if (event->gas.index >= 0)
|
|
|
|
return true;
|
|
|
|
|
2019-08-04 16:44:57 +00:00
|
|
|
index = find_best_gasmix_match(event->gas.mix, &dive->cylinders);
|
|
|
|
if (index < 0 || index >= dive->cylinders.nr)
|
2016-04-02 20:06:54 +00:00
|
|
|
return false;
|
|
|
|
|
|
|
|
/* Fix up the event to have the right information */
|
|
|
|
event->gas.index = index;
|
2019-08-04 20:13:49 +00:00
|
|
|
event->gas.mix = get_cylinder(dive, index)->gasmix;
|
2016-04-02 20:06:54 +00:00
|
|
|
|
|
|
|
/* Convert to odd libdivecomputer format */
|
2018-08-16 17:10:10 +00:00
|
|
|
o2 = get_o2(event->gas.mix);
|
|
|
|
he = get_he(event->gas.mix);
|
2016-04-02 20:06:54 +00:00
|
|
|
|
|
|
|
o2 = (o2 + 5) / 10;
|
|
|
|
he = (he + 5) / 10;
|
|
|
|
value = o2 + (he << 16);
|
|
|
|
|
|
|
|
event->value = value;
|
|
|
|
if (he)
|
|
|
|
event->type = SAMPLE_EVENT_GASCHANGE2;
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Clean up event, return true if event is ok, false if it should be dropped as bogus */
|
2016-04-05 14:40:32 +00:00
|
|
|
static bool validate_event(struct dive *dive, struct event *event)
|
2016-04-02 20:06:54 +00:00
|
|
|
{
|
|
|
|
if (event_is_gaschange(event))
|
2016-04-05 14:40:32 +00:00
|
|
|
return validate_gaschange(dive, event);
|
2016-04-02 20:06:54 +00:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void fixup_dc_gasswitch(struct dive *dive, struct divecomputer *dc)
|
|
|
|
{
|
|
|
|
struct event **evp, *event;
|
|
|
|
|
|
|
|
evp = &dc->events;
|
|
|
|
while ((event = *evp) != NULL) {
|
2016-04-05 14:40:32 +00:00
|
|
|
if (validate_event(dive, event)) {
|
2016-04-02 20:06:54 +00:00
|
|
|
evp = &event->next;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Delete this event and try the next one */
|
|
|
|
*evp = event->next;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-03-05 20:21:28 +00:00
|
|
|
static void fixup_no_o2sensors(struct divecomputer *dc)
|
|
|
|
{
|
|
|
|
// Its only relevant to look for sensor values on CCR and PSCR dives without any no_o2sensors recorded.
|
|
|
|
if (dc->no_o2sensors != 0 || !(dc->divemode == CCR || dc->divemode == PSCR))
|
|
|
|
return;
|
|
|
|
|
|
|
|
for (int i = 0; i < dc->samples; i++) {
|
|
|
|
int nsensor = 0;
|
|
|
|
struct sample *s = dc->sample + i;
|
|
|
|
|
|
|
|
// How many o2 sensors can we find in this sample?
|
|
|
|
if (s->o2sensor[0].mbar)
|
|
|
|
nsensor++;
|
|
|
|
if (s->o2sensor[1].mbar)
|
|
|
|
nsensor++;
|
|
|
|
if (s->o2sensor[2].mbar)
|
|
|
|
nsensor++;
|
|
|
|
|
|
|
|
// If we fond more than the previous found max, record it.
|
|
|
|
if (nsensor > dc->no_o2sensors)
|
|
|
|
dc->no_o2sensors = nsensor;
|
|
|
|
|
|
|
|
// Already found the maximum posible amount.
|
|
|
|
if (nsensor == 3)
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
Split up fixup_dive_dc() into multiple smaller independent functions
fixup_dive_dc() is called for each dive computer when we add a new dive.
It does various housekeeping functions, cleaning up the sample data, and
fixing up dive details as a result of the sample data.
The function has grown to be a monster over time, and particularly the
central "walk every sample" loop has become an unreadable mess.
And the thing is, this isn't even all that performance-critical: it's
only done once per dive and dc, and there is no reason to have a single
illegible and complex loop.
So split up that loop into several smaller pieces that each will loop
individually over the sample data, and do just one thing. So now we
have separate functions for
- fixing up the depth samples with interpolation
- fixing up dive temperature data
- correcting the cylinder pressure sensor index
- cleaning up the actual sample pressures
Yes, this way we walk the samples multiple times, but the end result is
that the code is much easier to understand. There should be no actual
behavioral differences from this cleanup, except for the fact that since
the code is much more understandable, this cleanup also fixed a bug:
In the temperature fixup, we would fix up the overall dive temperatures
based on the dive computer temperatures. But we would then fix up the
overall dive computer temperature based on the sample temperature
*afterwards*, which wouldn't then be reflected in the overall dive
temperatures.
There was another non-symptomatic bug that became obvious when doing
this cleanup: the code used to calculate a 'depthtime' over the dive
that was never actually used. That's a historical artifact of old code
that had become dead when the average depth calculations were moved to a
function of their own earlier.
This is preparatory for fixing the overall cylinder pressure stats,
which are currently wrong for dives with multiple dive computers: we
currently take the starting cylinder pressure from the *first* dive
computer that has cylinder pressure information, but we take the ending
cylinder pressure from the *last* dive computer with cylinder pressure
information.
This does not fix that bug, but without this cleanup fixing that would
be a nightmare due to the previous complicated "do everything in one
single loop" model.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-01 19:32:56 +00:00
|
|
|
static void fixup_dive_dc(struct dive *dive, struct divecomputer *dc)
|
|
|
|
{
|
|
|
|
/* Fixup duration and mean depth */
|
|
|
|
fixup_dc_duration(dc);
|
|
|
|
|
|
|
|
/* Fix up sample depth data */
|
|
|
|
fixup_dc_depths(dive, dc);
|
|
|
|
|
2017-11-05 16:32:38 +00:00
|
|
|
/* Fix up first sample ndl data */
|
2017-12-08 14:19:13 +00:00
|
|
|
fixup_dc_ndl(dc);
|
2017-11-05 16:32:38 +00:00
|
|
|
|
Split up fixup_dive_dc() into multiple smaller independent functions
fixup_dive_dc() is called for each dive computer when we add a new dive.
It does various housekeeping functions, cleaning up the sample data, and
fixing up dive details as a result of the sample data.
The function has grown to be a monster over time, and particularly the
central "walk every sample" loop has become an unreadable mess.
And the thing is, this isn't even all that performance-critical: it's
only done once per dive and dc, and there is no reason to have a single
illegible and complex loop.
So split up that loop into several smaller pieces that each will loop
individually over the sample data, and do just one thing. So now we
have separate functions for
- fixing up the depth samples with interpolation
- fixing up dive temperature data
- correcting the cylinder pressure sensor index
- cleaning up the actual sample pressures
Yes, this way we walk the samples multiple times, but the end result is
that the code is much easier to understand. There should be no actual
behavioral differences from this cleanup, except for the fact that since
the code is much more understandable, this cleanup also fixed a bug:
In the temperature fixup, we would fix up the overall dive temperatures
based on the dive computer temperatures. But we would then fix up the
overall dive computer temperature based on the sample temperature
*afterwards*, which wouldn't then be reflected in the overall dive
temperatures.
There was another non-symptomatic bug that became obvious when doing
this cleanup: the code used to calculate a 'depthtime' over the dive
that was never actually used. That's a historical artifact of old code
that had become dead when the average depth calculations were moved to a
function of their own earlier.
This is preparatory for fixing the overall cylinder pressure stats,
which are currently wrong for dives with multiple dive computers: we
currently take the starting cylinder pressure from the *first* dive
computer that has cylinder pressure information, but we take the ending
cylinder pressure from the *last* dive computer with cylinder pressure
information.
This does not fix that bug, but without this cleanup fixing that would
be a nightmare due to the previous complicated "do everything in one
single loop" model.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-01 19:32:56 +00:00
|
|
|
/* Fix up dive temperatures based on dive computer samples */
|
|
|
|
fixup_dc_temp(dive, dc);
|
|
|
|
|
2016-04-02 20:06:54 +00:00
|
|
|
/* Fix up gas switch events */
|
|
|
|
fixup_dc_gasswitch(dive, dc);
|
|
|
|
|
Split up fixup_dive_dc() into multiple smaller independent functions
fixup_dive_dc() is called for each dive computer when we add a new dive.
It does various housekeeping functions, cleaning up the sample data, and
fixing up dive details as a result of the sample data.
The function has grown to be a monster over time, and particularly the
central "walk every sample" loop has become an unreadable mess.
And the thing is, this isn't even all that performance-critical: it's
only done once per dive and dc, and there is no reason to have a single
illegible and complex loop.
So split up that loop into several smaller pieces that each will loop
individually over the sample data, and do just one thing. So now we
have separate functions for
- fixing up the depth samples with interpolation
- fixing up dive temperature data
- correcting the cylinder pressure sensor index
- cleaning up the actual sample pressures
Yes, this way we walk the samples multiple times, but the end result is
that the code is much easier to understand. There should be no actual
behavioral differences from this cleanup, except for the fact that since
the code is much more understandable, this cleanup also fixed a bug:
In the temperature fixup, we would fix up the overall dive temperatures
based on the dive computer temperatures. But we would then fix up the
overall dive computer temperature based on the sample temperature
*afterwards*, which wouldn't then be reflected in the overall dive
temperatures.
There was another non-symptomatic bug that became obvious when doing
this cleanup: the code used to calculate a 'depthtime' over the dive
that was never actually used. That's a historical artifact of old code
that had become dead when the average depth calculations were moved to a
function of their own earlier.
This is preparatory for fixing the overall cylinder pressure stats,
which are currently wrong for dives with multiple dive computers: we
currently take the starting cylinder pressure from the *first* dive
computer that has cylinder pressure information, but we take the ending
cylinder pressure from the *last* dive computer with cylinder pressure
information.
This does not fix that bug, but without this cleanup fixing that would
be a nightmare due to the previous complicated "do everything in one
single loop" model.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-04-01 19:32:56 +00:00
|
|
|
/* Fix up cylinder pressures based on DC info */
|
|
|
|
fixup_dive_pressures(dive, dc);
|
2011-09-04 20:06:47 +00:00
|
|
|
|
2013-02-09 00:35:39 +00:00
|
|
|
fixup_dc_events(dc);
|
2018-03-05 20:21:28 +00:00
|
|
|
|
|
|
|
/* Fixup CCR / PSCR dives with o2sensor values, but without no_o2sensors */
|
|
|
|
fixup_no_o2sensors(dc);
|
2013-02-09 00:35:39 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
struct dive *fixup_dive(struct dive *dive)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
struct divecomputer *dc;
|
|
|
|
|
|
|
|
sanitize_cylinder_info(dive);
|
|
|
|
dive->maxcns = dive->cns;
|
|
|
|
|
2015-10-07 16:12:41 +00:00
|
|
|
/*
|
|
|
|
* Use the dive's temperatures for minimum and maximum in case
|
|
|
|
* we do not have temperatures recorded by DC.
|
|
|
|
*/
|
|
|
|
|
|
|
|
update_min_max_temperatures(dive, dive->watertemp);
|
|
|
|
|
2014-10-11 11:25:52 +00:00
|
|
|
for_each_dc (dive, dc)
|
2014-03-03 21:25:55 +00:00
|
|
|
fixup_dive_dc(dive, dc);
|
2013-02-17 20:05:08 +00:00
|
|
|
|
2013-02-09 00:35:39 +00:00
|
|
|
fixup_water_salinity(dive);
|
2019-04-30 10:42:33 +00:00
|
|
|
if (!dive->surface_pressure.mbar)
|
|
|
|
fixup_surface_pressure(dive);
|
2013-02-09 14:50:53 +00:00
|
|
|
fixup_meandepth(dive);
|
2013-02-09 15:12:30 +00:00
|
|
|
fixup_duration(dive);
|
2013-02-09 15:41:15 +00:00
|
|
|
fixup_watertemp(dive);
|
|
|
|
fixup_airtemp(dive);
|
2019-08-04 16:44:57 +00:00
|
|
|
for (i = 0; i < dive->cylinders.nr; i++) {
|
2019-08-04 20:13:49 +00:00
|
|
|
cylinder_t *cyl = get_cylinder(dive, i);
|
2011-11-09 15:37:25 +00:00
|
|
|
add_cylinder_description(&cyl->type);
|
2011-11-10 23:33:38 +00:00
|
|
|
if (same_rounded_pressure(cyl->sample_start, cyl->start))
|
2011-11-09 15:37:25 +00:00
|
|
|
cyl->start.mbar = 0;
|
2011-11-10 23:33:38 +00:00
|
|
|
if (same_rounded_pressure(cyl->sample_end, cyl->end))
|
2011-11-09 15:37:25 +00:00
|
|
|
cyl->end.mbar = 0;
|
2011-10-22 15:12:30 +00:00
|
|
|
}
|
2015-06-18 00:58:31 +00:00
|
|
|
update_cylinder_related_info(dive);
|
2019-06-26 15:21:03 +00:00
|
|
|
for (i = 0; i < dive->weightsystems.nr; i++) {
|
|
|
|
weightsystem_t *ws = &dive->weightsystems.weightsystems[i];
|
2012-08-06 21:03:24 +00:00
|
|
|
add_weightsystem_description(ws);
|
|
|
|
}
|
2014-05-18 21:53:28 +00:00
|
|
|
/* we should always have a uniq ID as that gets assigned during alloc_dive(),
|
|
|
|
* but we want to make sure... */
|
|
|
|
if (!dive->id)
|
2018-07-17 21:05:03 +00:00
|
|
|
dive->id = dive_getUniqID();
|
2011-10-22 15:12:30 +00:00
|
|
|
|
2011-09-03 20:19:26 +00:00
|
|
|
return dive;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Don't pick a zero for MERGE_MIN() */
|
|
|
|
#define MERGE_MAX(res, a, b, n) res->n = MAX(a->n, b->n)
|
2014-02-28 04:09:57 +00:00
|
|
|
#define MERGE_MIN(res, a, b, n) res->n = (a->n) ? (b->n) ? MIN(a->n, b->n) : (a->n) : (b->n)
|
2017-11-27 18:39:10 +00:00
|
|
|
#define MERGE_TXT(res, a, b, n, sep) res->n = merge_text(a->n, b->n, sep)
|
2011-09-23 03:50:07 +00:00
|
|
|
#define MERGE_NONZERO(res, a, b, n) res->n = a->n ? a->n : b->n
|
2011-09-03 20:19:26 +00:00
|
|
|
|
2012-11-17 21:20:10 +00:00
|
|
|
/*
|
|
|
|
* This is like add_sample(), but if the distance from the last sample
|
|
|
|
* is excessive, we add two surface samples in between.
|
|
|
|
*
|
|
|
|
* This is so that if you merge two non-overlapping dives, we make sure
|
|
|
|
* that the time in between the dives is at the surface, not some "last
|
|
|
|
* sample that happened to be at a depth of 1.2m".
|
|
|
|
*/
|
2018-08-13 02:47:07 +00:00
|
|
|
static void merge_one_sample(const struct sample *sample, int time, struct divecomputer *dc)
|
2012-11-17 21:20:10 +00:00
|
|
|
{
|
2014-02-28 04:09:57 +00:00
|
|
|
int last = dc->samples - 1;
|
2012-11-17 21:20:10 +00:00
|
|
|
if (last >= 0) {
|
2012-12-07 17:42:47 +00:00
|
|
|
struct sample *prev = dc->sample + last;
|
|
|
|
int last_time = prev->time.seconds;
|
|
|
|
int last_depth = prev->depth.mm;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Only do surface events if the samples are more than
|
|
|
|
* a minute apart, and shallower than 5m
|
|
|
|
*/
|
|
|
|
if (time > last_time + 60 && last_depth < 5000) {
|
2018-09-18 08:55:29 +00:00
|
|
|
struct sample surface = { 0 };
|
|
|
|
|
|
|
|
/* Init a few values from prev sample to avoid useless info in XML */
|
|
|
|
surface.bearing.degrees = prev->bearing.degrees;
|
|
|
|
surface.ndl.seconds = prev->ndl.seconds;
|
|
|
|
|
2014-02-28 04:09:57 +00:00
|
|
|
add_sample(&surface, last_time + 20, dc);
|
2012-11-24 02:51:27 +00:00
|
|
|
add_sample(&surface, time - 20, dc);
|
2012-11-17 21:20:10 +00:00
|
|
|
}
|
|
|
|
}
|
2012-11-24 02:51:27 +00:00
|
|
|
add_sample(sample, time, dc);
|
2012-11-17 21:20:10 +00:00
|
|
|
}
|
|
|
|
|
2018-08-13 02:47:07 +00:00
|
|
|
static void renumber_last_sample(struct divecomputer *dc, const int mapping[]);
|
|
|
|
static void sample_renumber(struct sample *s, int i, const int mapping[]);
|
2012-11-17 21:20:10 +00:00
|
|
|
|
2011-09-03 20:19:26 +00:00
|
|
|
/*
|
|
|
|
* Merge samples. Dive 'a' is "offset" seconds before Dive 'b'
|
|
|
|
*/
|
2018-08-13 02:47:07 +00:00
|
|
|
static void merge_samples(struct divecomputer *res,
|
|
|
|
const struct divecomputer *a, const struct divecomputer *b,
|
|
|
|
const int *cylinders_map_a, const int *cylinders_map_b,
|
|
|
|
int offset)
|
2011-09-03 20:19:26 +00:00
|
|
|
{
|
|
|
|
int asamples = a->samples;
|
|
|
|
int bsamples = b->samples;
|
|
|
|
struct sample *as = a->sample;
|
|
|
|
struct sample *bs = b->sample;
|
|
|
|
|
Try to find optimal dive sample merge offset
When we merge dives where the samples have come from different dive
computers, the samples may be offset from each other due to the dive
computers not having decided that the dive starts at quite the same
time.
For example, some dive computers may take a while to wake up when
submerged, or there may be differences in exactly when the dive
computer decides that a dive has started. Different computers tend to
have different depths that they consider the start of a real dive.
So when we merge two dives, look for differences in the sample data,
and search for the sample time offset that minimizes the differences
(logic: minimize the sum-of-square of the depth differences over a
two-minute window at the start of the dive).
This still doesn't really result in perfect merges, since different
computers will give slightly different values anyway, but it improves
the dive merging noticeably. To the point that this seems to have
found a bug in our Uemis data import (it looks like the Uemis importer
does an incorrect saltwater pressure conversion, and the data is
actually in centimeter, not in pressure).
So there is room for improvement, but this is at least a reasonable
approximation and starting point.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-11-10 11:23:13 +00:00
|
|
|
/*
|
|
|
|
* We want a positive sample offset, so that sample
|
|
|
|
* times are always positive. So if the samples for
|
|
|
|
* 'b' are before the samples for 'a' (so the offset
|
|
|
|
* is negative), we switch a and b around, and use
|
|
|
|
* the reverse offset.
|
|
|
|
*/
|
|
|
|
if (offset < 0) {
|
2018-08-13 02:47:07 +00:00
|
|
|
const int *cylinders_map_tmp;
|
Try to find optimal dive sample merge offset
When we merge dives where the samples have come from different dive
computers, the samples may be offset from each other due to the dive
computers not having decided that the dive starts at quite the same
time.
For example, some dive computers may take a while to wake up when
submerged, or there may be differences in exactly when the dive
computer decides that a dive has started. Different computers tend to
have different depths that they consider the start of a real dive.
So when we merge two dives, look for differences in the sample data,
and search for the sample time offset that minimizes the differences
(logic: minimize the sum-of-square of the depth differences over a
two-minute window at the start of the dive).
This still doesn't really result in perfect merges, since different
computers will give slightly different values anyway, but it improves
the dive merging noticeably. To the point that this seems to have
found a bug in our Uemis data import (it looks like the Uemis importer
does an incorrect saltwater pressure conversion, and the data is
actually in centimeter, not in pressure).
So there is room for improvement, but this is at least a reasonable
approximation and starting point.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-11-10 11:23:13 +00:00
|
|
|
offset = -offset;
|
|
|
|
asamples = bsamples;
|
|
|
|
bsamples = a->samples;
|
|
|
|
as = bs;
|
|
|
|
bs = a->sample;
|
2018-08-13 02:47:07 +00:00
|
|
|
cylinders_map_tmp = cylinders_map_a;
|
|
|
|
cylinders_map_a = cylinders_map_b;
|
|
|
|
cylinders_map_b = cylinders_map_tmp;
|
Try to find optimal dive sample merge offset
When we merge dives where the samples have come from different dive
computers, the samples may be offset from each other due to the dive
computers not having decided that the dive starts at quite the same
time.
For example, some dive computers may take a while to wake up when
submerged, or there may be differences in exactly when the dive
computer decides that a dive has started. Different computers tend to
have different depths that they consider the start of a real dive.
So when we merge two dives, look for differences in the sample data,
and search for the sample time offset that minimizes the differences
(logic: minimize the sum-of-square of the depth differences over a
two-minute window at the start of the dive).
This still doesn't really result in perfect merges, since different
computers will give slightly different values anyway, but it improves
the dive merging noticeably. To the point that this seems to have
found a bug in our Uemis data import (it looks like the Uemis importer
does an incorrect saltwater pressure conversion, and the data is
actually in centimeter, not in pressure).
So there is room for improvement, but this is at least a reasonable
approximation and starting point.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-11-10 11:23:13 +00:00
|
|
|
}
|
|
|
|
|
2011-09-03 20:19:26 +00:00
|
|
|
for (;;) {
|
2018-08-13 02:47:07 +00:00
|
|
|
int j;
|
2011-09-03 20:19:26 +00:00
|
|
|
int at, bt;
|
2017-11-05 14:58:24 +00:00
|
|
|
struct sample sample = { .bearing.degrees = -1, .ndl.seconds = -1 };
|
2011-09-03 20:19:26 +00:00
|
|
|
|
|
|
|
if (!res)
|
2012-11-24 02:51:27 +00:00
|
|
|
return;
|
2011-09-03 20:19:26 +00:00
|
|
|
|
|
|
|
at = asamples ? as->time.seconds : -1;
|
|
|
|
bt = bsamples ? bs->time.seconds + offset : -1;
|
|
|
|
|
|
|
|
/* No samples? All done! */
|
|
|
|
if (at < 0 && bt < 0)
|
2012-11-24 02:51:27 +00:00
|
|
|
return;
|
2011-09-03 20:19:26 +00:00
|
|
|
|
|
|
|
/* Only samples from a? */
|
|
|
|
if (bt < 0) {
|
2014-02-28 04:09:57 +00:00
|
|
|
add_sample_a:
|
2012-11-24 02:05:38 +00:00
|
|
|
merge_one_sample(as, at, res);
|
2018-08-13 02:47:07 +00:00
|
|
|
renumber_last_sample(res, cylinders_map_a);
|
2011-09-03 20:19:26 +00:00
|
|
|
as++;
|
|
|
|
asamples--;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Only samples from b? */
|
|
|
|
if (at < 0) {
|
2014-02-28 04:09:57 +00:00
|
|
|
add_sample_b:
|
2012-11-24 02:05:38 +00:00
|
|
|
merge_one_sample(bs, bt, res);
|
2018-08-13 02:47:07 +00:00
|
|
|
renumber_last_sample(res, cylinders_map_b);
|
2011-09-03 20:19:26 +00:00
|
|
|
bs++;
|
|
|
|
bsamples--;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (at < bt)
|
|
|
|
goto add_sample_a;
|
|
|
|
if (at > bt)
|
|
|
|
goto add_sample_b;
|
|
|
|
|
|
|
|
/* same-time sample: add a merged sample. Take the non-zero ones */
|
|
|
|
sample = *bs;
|
2018-08-13 02:47:07 +00:00
|
|
|
sample_renumber(&sample, 0, cylinders_map_b);
|
2011-09-03 20:19:26 +00:00
|
|
|
if (as->depth.mm)
|
|
|
|
sample.depth = as->depth;
|
|
|
|
if (as->temperature.mkelvin)
|
|
|
|
sample.temperature = as->temperature;
|
2018-08-13 02:47:07 +00:00
|
|
|
for (j = 0; j < MAX_SENSORS; ++j) {
|
|
|
|
int sensor_id;
|
|
|
|
|
|
|
|
sensor_id = cylinders_map_a[as->sensor[j]];
|
|
|
|
if (sensor_id < 0)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (as->pressure[j].mbar)
|
|
|
|
sample.pressure[j] = as->pressure[j];
|
|
|
|
if (as->sensor[j])
|
|
|
|
sample.sensor[j] = sensor_id;
|
|
|
|
}
|
2012-12-08 04:08:29 +00:00
|
|
|
if (as->cns)
|
|
|
|
sample.cns = as->cns;
|
2014-10-19 14:07:07 +00:00
|
|
|
if (as->setpoint.mbar)
|
|
|
|
sample.setpoint = as->setpoint;
|
2012-12-11 20:30:34 +00:00
|
|
|
if (as->ndl.seconds)
|
|
|
|
sample.ndl = as->ndl;
|
|
|
|
if (as->stoptime.seconds)
|
|
|
|
sample.stoptime = as->stoptime;
|
|
|
|
if (as->stopdepth.mm)
|
|
|
|
sample.stopdepth = as->stopdepth;
|
2012-12-31 02:11:01 +00:00
|
|
|
if (as->in_deco)
|
2014-01-15 18:54:41 +00:00
|
|
|
sample.in_deco = true;
|
2011-09-03 20:19:26 +00:00
|
|
|
|
2012-11-24 02:05:38 +00:00
|
|
|
merge_one_sample(&sample, at, res);
|
2011-09-03 20:19:26 +00:00
|
|
|
|
|
|
|
as++;
|
|
|
|
bs++;
|
|
|
|
asamples--;
|
|
|
|
bsamples--;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-04-06 21:29:42 +00:00
|
|
|
/*
|
|
|
|
* Does the extradata key/value pair already exist in the
|
|
|
|
* supplied dive computer data?
|
|
|
|
*
|
|
|
|
* This is not hugely efficient (with the whole "do this for
|
|
|
|
* every value you merge" it's O(n**2)) but it's not like we
|
|
|
|
* have very many extra_data entries per dive computer anyway.
|
|
|
|
*/
|
|
|
|
static bool extra_data_exists(const struct extra_data *ed, const struct divecomputer *dc)
|
|
|
|
{
|
|
|
|
const struct extra_data *p;
|
|
|
|
|
|
|
|
for (p = dc->extra_data; p; p = p->next) {
|
|
|
|
if (strcmp(p->key, ed->key))
|
|
|
|
continue;
|
|
|
|
if (strcmp(p->value, ed->value))
|
|
|
|
continue;
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Merge extra_data.
|
|
|
|
*
|
|
|
|
* The extra data from 'a' has already been copied into 'res'. So
|
|
|
|
* we really should just copy over the data from 'b' too.
|
|
|
|
*/
|
|
|
|
static void merge_extra_data(struct divecomputer *res,
|
|
|
|
const struct divecomputer *a, const struct divecomputer *b)
|
|
|
|
{
|
|
|
|
struct extra_data **ed, *src;
|
|
|
|
|
|
|
|
// Find the place to add things in the result
|
|
|
|
ed = &res->extra_data;
|
|
|
|
while (*ed)
|
|
|
|
ed = &(*ed)->next;
|
|
|
|
|
|
|
|
for (src = b->extra_data; src; src = src->next) {
|
|
|
|
if (extra_data_exists(src, a))
|
|
|
|
continue;
|
|
|
|
*ed = malloc(sizeof(struct extra_data));
|
|
|
|
if (!*ed)
|
|
|
|
break;
|
|
|
|
copy_extra_data(src, *ed);
|
|
|
|
ed = &(*ed)->next;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Terminate the result list
|
|
|
|
*ed = NULL;
|
|
|
|
}
|
|
|
|
|
2017-11-27 18:39:10 +00:00
|
|
|
static char *merge_text(const char *a, const char *b, const char *sep)
|
2011-09-03 20:19:26 +00:00
|
|
|
{
|
|
|
|
char *res;
|
Small changes in the memory management when dive-merging
This patch makes a couple of modifications:
1) divelist.c:delete_single_dive() now tries to free all memory associated
with a dive, such as the string values for divemaster, location, notes &
etc.
2) dive.c:merge_text(), now always makes a copy in memory for the returned
string - either combined or one of the two which are passed
to the function.
The reason for the above two changes is that when (say) importing the same
data over and over, technically a merge will occur for the contained dives,
but mapped pointers can go out of scope.
main.c:report_dives() calls try_to_merge() and if succeeds the two dives
that were merged are deleted from the table. when we delete a dive,
we now make sure all string data is cleared with it, but also in the actual merge
itself, which precedes, copies of the merged texts are made (with merge_text()),
so that the new, resulted dive has his own text allocations.
Signed-off-by: Lubomir I. Ivanov <neolit123@gmail.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-12-24 01:53:25 +00:00
|
|
|
if (!a && !b)
|
|
|
|
return NULL;
|
2011-09-03 20:19:26 +00:00
|
|
|
if (!a || !*a)
|
2014-07-03 04:05:22 +00:00
|
|
|
return copy_string(b);
|
2011-09-03 20:19:26 +00:00
|
|
|
if (!b || !*b)
|
Small changes in the memory management when dive-merging
This patch makes a couple of modifications:
1) divelist.c:delete_single_dive() now tries to free all memory associated
with a dive, such as the string values for divemaster, location, notes &
etc.
2) dive.c:merge_text(), now always makes a copy in memory for the returned
string - either combined or one of the two which are passed
to the function.
The reason for the above two changes is that when (say) importing the same
data over and over, technically a merge will occur for the contained dives,
but mapped pointers can go out of scope.
main.c:report_dives() calls try_to_merge() and if succeeds the two dives
that were merged are deleted from the table. when we delete a dive,
we now make sure all string data is cleared with it, but also in the actual merge
itself, which precedes, copies of the merged texts are made (with merge_text()),
so that the new, resulted dive has his own text allocations.
Signed-off-by: Lubomir I. Ivanov <neolit123@gmail.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-12-24 01:53:25 +00:00
|
|
|
return strdup(a);
|
2014-02-28 04:09:57 +00:00
|
|
|
if (!strcmp(a, b))
|
2014-07-03 04:05:22 +00:00
|
|
|
return copy_string(a);
|
2012-12-28 13:43:04 +00:00
|
|
|
res = malloc(strlen(a) + strlen(b) + 32);
|
2011-09-03 20:19:26 +00:00
|
|
|
if (!res)
|
|
|
|
return (char *)a;
|
2017-11-27 18:39:10 +00:00
|
|
|
sprintf(res, "%s%s%s", a, sep, b);
|
2011-09-03 20:19:26 +00:00
|
|
|
return res;
|
|
|
|
}
|
|
|
|
|
2018-08-13 02:47:07 +00:00
|
|
|
#define SORT(a, b) \
|
|
|
|
if (a != b) \
|
|
|
|
return a < b ? -1 : 1
|
|
|
|
#define SORT_FIELD(a, b, field) SORT(a->field, b->field)
|
2011-09-23 03:28:04 +00:00
|
|
|
|
2018-08-13 02:47:07 +00:00
|
|
|
static int sort_event(const struct event *a, const struct event *b, int time_a, int time_b)
|
2011-09-23 03:28:04 +00:00
|
|
|
{
|
2018-08-13 02:47:07 +00:00
|
|
|
SORT(time_a, time_b);
|
|
|
|
SORT_FIELD(a, b, type);
|
|
|
|
SORT_FIELD(a, b, flags);
|
|
|
|
SORT_FIELD(a, b, value);
|
2011-09-23 03:28:04 +00:00
|
|
|
return strcmp(a->name, b->name);
|
|
|
|
}
|
|
|
|
|
2018-08-16 22:58:30 +00:00
|
|
|
static int same_gas(const struct event *a, const struct event *b)
|
2016-10-04 04:14:51 +00:00
|
|
|
{
|
|
|
|
if (a->type == b->type && a->flags == b->flags && a->value == b->value && !strcmp(a->name, b->name) &&
|
2018-08-16 17:10:10 +00:00
|
|
|
same_gasmix(a->gas.mix, b->gas.mix)) {
|
2016-10-04 04:14:51 +00:00
|
|
|
return true;
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2018-08-13 02:47:07 +00:00
|
|
|
static void event_renumber(struct event *ev, const int mapping[]);
|
|
|
|
static void add_initial_gaschange(struct dive *dive, struct divecomputer *dc, int offset, int idx);
|
|
|
|
|
|
|
|
static void merge_events(struct dive *d, struct divecomputer *res,
|
|
|
|
const struct divecomputer *src1, const struct divecomputer *src2,
|
|
|
|
const int *cylinders_map1, const int *cylinders_map2,
|
|
|
|
int offset)
|
2011-09-23 03:28:04 +00:00
|
|
|
{
|
2018-08-13 02:47:07 +00:00
|
|
|
const struct event *a, *b;
|
2011-09-23 03:28:04 +00:00
|
|
|
struct event **p = &res->events;
|
2018-08-13 02:47:07 +00:00
|
|
|
const struct event *last_gas = NULL;
|
2011-09-23 03:28:04 +00:00
|
|
|
|
Try to find optimal dive sample merge offset
When we merge dives where the samples have come from different dive
computers, the samples may be offset from each other due to the dive
computers not having decided that the dive starts at quite the same
time.
For example, some dive computers may take a while to wake up when
submerged, or there may be differences in exactly when the dive
computer decides that a dive has started. Different computers tend to
have different depths that they consider the start of a real dive.
So when we merge two dives, look for differences in the sample data,
and search for the sample time offset that minimizes the differences
(logic: minimize the sum-of-square of the depth differences over a
two-minute window at the start of the dive).
This still doesn't really result in perfect merges, since different
computers will give slightly different values anyway, but it improves
the dive merging noticeably. To the point that this seems to have
found a bug in our Uemis data import (it looks like the Uemis importer
does an incorrect saltwater pressure conversion, and the data is
actually in centimeter, not in pressure).
So there is room for improvement, but this is at least a reasonable
approximation and starting point.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-11-10 11:23:13 +00:00
|
|
|
/* Always use positive offsets */
|
|
|
|
if (offset < 0) {
|
2018-08-13 02:47:07 +00:00
|
|
|
const struct divecomputer *tmp;
|
|
|
|
const int *cylinders_map_tmp;
|
Try to find optimal dive sample merge offset
When we merge dives where the samples have come from different dive
computers, the samples may be offset from each other due to the dive
computers not having decided that the dive starts at quite the same
time.
For example, some dive computers may take a while to wake up when
submerged, or there may be differences in exactly when the dive
computer decides that a dive has started. Different computers tend to
have different depths that they consider the start of a real dive.
So when we merge two dives, look for differences in the sample data,
and search for the sample time offset that minimizes the differences
(logic: minimize the sum-of-square of the depth differences over a
two-minute window at the start of the dive).
This still doesn't really result in perfect merges, since different
computers will give slightly different values anyway, but it improves
the dive merging noticeably. To the point that this seems to have
found a bug in our Uemis data import (it looks like the Uemis importer
does an incorrect saltwater pressure conversion, and the data is
actually in centimeter, not in pressure).
So there is room for improvement, but this is at least a reasonable
approximation and starting point.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-11-10 11:23:13 +00:00
|
|
|
|
|
|
|
offset = -offset;
|
|
|
|
tmp = src1;
|
|
|
|
src1 = src2;
|
|
|
|
src2 = tmp;
|
2018-08-13 02:47:07 +00:00
|
|
|
|
|
|
|
cylinders_map_tmp = cylinders_map1;
|
|
|
|
cylinders_map1 = cylinders_map2;
|
|
|
|
cylinders_map2 = cylinders_map_tmp;
|
Try to find optimal dive sample merge offset
When we merge dives where the samples have come from different dive
computers, the samples may be offset from each other due to the dive
computers not having decided that the dive starts at quite the same
time.
For example, some dive computers may take a while to wake up when
submerged, or there may be differences in exactly when the dive
computer decides that a dive has started. Different computers tend to
have different depths that they consider the start of a real dive.
So when we merge two dives, look for differences in the sample data,
and search for the sample time offset that minimizes the differences
(logic: minimize the sum-of-square of the depth differences over a
two-minute window at the start of the dive).
This still doesn't really result in perfect merges, since different
computers will give slightly different values anyway, but it improves
the dive merging noticeably. To the point that this seems to have
found a bug in our Uemis data import (it looks like the Uemis importer
does an incorrect saltwater pressure conversion, and the data is
actually in centimeter, not in pressure).
So there is room for improvement, but this is at least a reasonable
approximation and starting point.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-11-10 11:23:13 +00:00
|
|
|
}
|
|
|
|
|
2011-09-23 03:28:04 +00:00
|
|
|
a = src1->events;
|
|
|
|
b = src2->events;
|
|
|
|
|
|
|
|
while (a || b) {
|
|
|
|
int s;
|
2018-08-13 02:47:07 +00:00
|
|
|
const struct event *pick;
|
|
|
|
const int *cylinders_map;
|
|
|
|
int event_offset;
|
2017-04-29 23:21:41 +00:00
|
|
|
|
2020-08-15 14:10:56 +00:00
|
|
|
if (!b)
|
|
|
|
goto pick_a;
|
|
|
|
|
|
|
|
if (!a)
|
|
|
|
goto pick_b;
|
|
|
|
|
2018-08-13 02:47:07 +00:00
|
|
|
s = sort_event(a, b, a->time.seconds, b->time.seconds + offset);
|
2016-10-04 04:14:51 +00:00
|
|
|
|
2020-08-15 14:10:56 +00:00
|
|
|
/* Identical events? Just skip one of them (we skip a) */
|
2017-04-29 23:21:41 +00:00
|
|
|
if (!s) {
|
|
|
|
a = a->next;
|
2016-10-04 04:14:51 +00:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2017-04-29 23:21:41 +00:00
|
|
|
/* Otherwise, pick the one that sorts first */
|
|
|
|
if (s < 0) {
|
2020-08-15 14:10:56 +00:00
|
|
|
pick_a:
|
2017-04-29 23:21:41 +00:00
|
|
|
pick = a;
|
|
|
|
a = a->next;
|
2018-08-13 02:47:07 +00:00
|
|
|
event_offset = 0;
|
|
|
|
cylinders_map = cylinders_map1;
|
2017-04-29 23:21:41 +00:00
|
|
|
} else {
|
2020-08-15 14:10:56 +00:00
|
|
|
pick_b:
|
2017-04-29 23:21:41 +00:00
|
|
|
pick = b;
|
2011-09-23 03:28:04 +00:00
|
|
|
b = b->next;
|
2018-08-13 02:47:07 +00:00
|
|
|
event_offset = offset;
|
|
|
|
cylinders_map = cylinders_map2;
|
2011-09-23 03:28:04 +00:00
|
|
|
}
|
2017-04-29 23:21:41 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If that's a gas-change that matches the previous
|
|
|
|
* gas change, we'll just skip it
|
|
|
|
*/
|
|
|
|
if (event_is_gaschange(pick)) {
|
|
|
|
if (last_gas && same_gas(pick, last_gas))
|
|
|
|
continue;
|
|
|
|
last_gas = pick;
|
2011-09-23 03:28:04 +00:00
|
|
|
}
|
2017-04-29 23:21:41 +00:00
|
|
|
|
|
|
|
/* Add it to the target list */
|
2018-08-13 02:47:07 +00:00
|
|
|
*p = clone_event(pick);
|
|
|
|
(*p)->time.seconds += event_offset;
|
|
|
|
event_renumber(*p, cylinders_map);
|
|
|
|
p = &(*p)->next;
|
2011-09-23 03:28:04 +00:00
|
|
|
}
|
2018-08-13 02:47:07 +00:00
|
|
|
|
|
|
|
/* If the initial cylinder of a divecomputer was remapped, add a gas change event to that cylinder */
|
|
|
|
if (cylinders_map1[0] > 0)
|
|
|
|
add_initial_gaschange(d, res, 0, cylinders_map1[0]);
|
|
|
|
if (cylinders_map2[0] > 0)
|
|
|
|
add_initial_gaschange(d, res, offset, cylinders_map2[0]);
|
2011-09-23 03:28:04 +00:00
|
|
|
}
|
|
|
|
|
2014-11-17 00:09:59 +00:00
|
|
|
/* get_cylinder_idx_by_use(): Find the index of the first cylinder with a particular CCR use type.
|
Calculate nitrogen and helium gas pressures for CCR after import from CSV
Currently the gas pressures stored in structures of pressure are
calculated using the gasmix composition of the currently selected
cylinder. But with CCR dives the default cylinder is the oxygen
cylinder (here, index 0). However, the gas pressures need to
be calculated using gasmix data from cylinder 1 (the diluent
cylinder). This patch allows setting the appropriate cylinder
for calculating the values in the structures of pressure. It
also allows for correctly calculating gas pressures for any
open circuit cylinders (e.g. bailout) that a CCR diver may
use. This is performed as follows:
1) In dive.h create an enum variable {oxygen, diluent, bailout}
2) Within the definition of cylinder_t, add a member: cylinder_use_type
This stores an enum variable, one of the above.
3) In file.c where the Poseidon CSV data are read in, assign
the appropriate enum values to each of the cylinders.
4) Within the definition of structure dive, add two members:
int oxygen_cylinder_index
int diluent_cylinder_index
This will keep the indices of the two main CCR cylinders.
5) In dive.c create a function get_cylinder_use(). This scans the
cylinders for that dive, looking for a cylinder that has a
particular cylinder_use_type and returns that cylinder index.
6) In dive.c create a function fixup_cylinder_use() that stores the
indices of the oxygen and diluent cylinders in the variables
dive->oxygen_cylinder_index and dive->diluent_cylinder_index,
making use of the function in 4) above.
7) In profile.c, modify function calculate_gas_information_new()
to use the above functions for CCR dives to find the oxygen and
diluent cylinders and to calculate partail gas pressures based
on the diluent cylinder gas mix.
This results in the correct calculation of gas partial pressures
in the case of CCR dives, displaying the correct partial pressure
graphs in the dive profile widget.
Signed-off-by: willem ferguson <willemferguson@zoology.up.ac.za>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2014-11-03 20:11:00 +00:00
|
|
|
* The index returned corresponds to that of the first cylinder with a cylinder_use that
|
|
|
|
* equals the appropriate enum value [oxygen, diluent, bailout] given by cylinder_use_type.
|
|
|
|
* A negative number returned indicates that a match could not be found.
|
|
|
|
* Call parameters: dive = the dive being processed
|
|
|
|
* cylinder_use_type = an enum, one of {oxygen, diluent, bailout} */
|
2018-08-16 22:58:30 +00:00
|
|
|
extern int get_cylinder_idx_by_use(const struct dive *dive, enum cylinderuse cylinder_use_type)
|
Calculate nitrogen and helium gas pressures for CCR after import from CSV
Currently the gas pressures stored in structures of pressure are
calculated using the gasmix composition of the currently selected
cylinder. But with CCR dives the default cylinder is the oxygen
cylinder (here, index 0). However, the gas pressures need to
be calculated using gasmix data from cylinder 1 (the diluent
cylinder). This patch allows setting the appropriate cylinder
for calculating the values in the structures of pressure. It
also allows for correctly calculating gas pressures for any
open circuit cylinders (e.g. bailout) that a CCR diver may
use. This is performed as follows:
1) In dive.h create an enum variable {oxygen, diluent, bailout}
2) Within the definition of cylinder_t, add a member: cylinder_use_type
This stores an enum variable, one of the above.
3) In file.c where the Poseidon CSV data are read in, assign
the appropriate enum values to each of the cylinders.
4) Within the definition of structure dive, add two members:
int oxygen_cylinder_index
int diluent_cylinder_index
This will keep the indices of the two main CCR cylinders.
5) In dive.c create a function get_cylinder_use(). This scans the
cylinders for that dive, looking for a cylinder that has a
particular cylinder_use_type and returns that cylinder index.
6) In dive.c create a function fixup_cylinder_use() that stores the
indices of the oxygen and diluent cylinders in the variables
dive->oxygen_cylinder_index and dive->diluent_cylinder_index,
making use of the function in 4) above.
7) In profile.c, modify function calculate_gas_information_new()
to use the above functions for CCR dives to find the oxygen and
diluent cylinders and to calculate partail gas pressures based
on the diluent cylinder gas mix.
This results in the correct calculation of gas partial pressures
in the case of CCR dives, displaying the correct partial pressure
graphs in the dive profile widget.
Signed-off-by: willem ferguson <willemferguson@zoology.up.ac.za>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2014-11-03 20:11:00 +00:00
|
|
|
{
|
|
|
|
int cylinder_index;
|
2019-08-04 16:44:57 +00:00
|
|
|
for (cylinder_index = 0; cylinder_index < dive->cylinders.nr; cylinder_index++) {
|
2019-08-04 20:13:49 +00:00
|
|
|
if (get_cylinder(dive, cylinder_index)->cylinder_use == cylinder_use_type)
|
Calculate nitrogen and helium gas pressures for CCR after import from CSV
Currently the gas pressures stored in structures of pressure are
calculated using the gasmix composition of the currently selected
cylinder. But with CCR dives the default cylinder is the oxygen
cylinder (here, index 0). However, the gas pressures need to
be calculated using gasmix data from cylinder 1 (the diluent
cylinder). This patch allows setting the appropriate cylinder
for calculating the values in the structures of pressure. It
also allows for correctly calculating gas pressures for any
open circuit cylinders (e.g. bailout) that a CCR diver may
use. This is performed as follows:
1) In dive.h create an enum variable {oxygen, diluent, bailout}
2) Within the definition of cylinder_t, add a member: cylinder_use_type
This stores an enum variable, one of the above.
3) In file.c where the Poseidon CSV data are read in, assign
the appropriate enum values to each of the cylinders.
4) Within the definition of structure dive, add two members:
int oxygen_cylinder_index
int diluent_cylinder_index
This will keep the indices of the two main CCR cylinders.
5) In dive.c create a function get_cylinder_use(). This scans the
cylinders for that dive, looking for a cylinder that has a
particular cylinder_use_type and returns that cylinder index.
6) In dive.c create a function fixup_cylinder_use() that stores the
indices of the oxygen and diluent cylinders in the variables
dive->oxygen_cylinder_index and dive->diluent_cylinder_index,
making use of the function in 4) above.
7) In profile.c, modify function calculate_gas_information_new()
to use the above functions for CCR dives to find the oxygen and
diluent cylinders and to calculate partail gas pressures based
on the diluent cylinder gas mix.
This results in the correct calculation of gas partial pressures
in the case of CCR dives, displaying the correct partial pressure
graphs in the dive profile widget.
Signed-off-by: willem ferguson <willemferguson@zoology.up.ac.za>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2014-11-03 20:11:00 +00:00
|
|
|
return cylinder_index; // return the index of the cylinder with that cylinder use type
|
|
|
|
}
|
|
|
|
return -1; // negative number means cylinder_use_type not found in list of cylinders
|
|
|
|
}
|
|
|
|
|
2013-03-28 02:04:46 +00:00
|
|
|
/* Force an initial gaschange event to the (old) gas #0 */
|
2018-08-13 02:47:07 +00:00
|
|
|
static void add_initial_gaschange(struct dive *dive, struct divecomputer *dc, int offset, int idx)
|
2013-03-28 02:04:46 +00:00
|
|
|
{
|
2018-08-13 02:47:07 +00:00
|
|
|
/* if there is a gaschange event up to 30 sec after the initial event,
|
|
|
|
* refrain from adding the initial event */
|
|
|
|
const struct event *ev = dc->events;
|
|
|
|
while(ev && (ev = get_next_event(ev, "gaschange")) != NULL) {
|
|
|
|
if (ev->time.seconds > offset + 30)
|
|
|
|
break;
|
|
|
|
else if (ev->time.seconds > offset)
|
|
|
|
return;
|
|
|
|
ev = ev->next;
|
|
|
|
}
|
2013-03-28 02:04:46 +00:00
|
|
|
|
|
|
|
/* Old starting gas mix */
|
2018-08-13 02:47:07 +00:00
|
|
|
add_gas_switch_event(dive, dc, offset, idx);
|
2013-03-28 02:04:46 +00:00
|
|
|
}
|
|
|
|
|
2018-08-13 02:47:07 +00:00
|
|
|
static void sample_renumber(struct sample *s, int i, const int mapping[])
|
2013-03-28 02:04:46 +00:00
|
|
|
{
|
2018-08-13 02:47:07 +00:00
|
|
|
int j;
|
2013-03-28 02:04:46 +00:00
|
|
|
|
2018-08-13 02:47:07 +00:00
|
|
|
for (j = 0; j < MAX_SENSORS; j++) {
|
2021-07-18 20:26:38 +00:00
|
|
|
int sensor = -1;
|
2013-03-28 02:04:46 +00:00
|
|
|
|
2021-07-18 20:26:38 +00:00
|
|
|
if (s->sensor[j] != NO_SENSOR)
|
|
|
|
sensor = mapping[s->sensor[j]];
|
2018-08-13 02:47:07 +00:00
|
|
|
if (sensor == -1) {
|
|
|
|
// Remove sensor and gas pressure info
|
|
|
|
if (i == 0) {
|
|
|
|
s->sensor[j] = 0;
|
|
|
|
s->pressure[j].mbar = 0;
|
2017-11-29 09:16:00 +00:00
|
|
|
} else {
|
2018-08-13 02:47:07 +00:00
|
|
|
s->sensor[j] = s[-1].sensor[j];
|
|
|
|
s->pressure[j].mbar = s[-1].pressure[j].mbar;
|
2017-11-29 09:16:00 +00:00
|
|
|
}
|
2018-08-13 02:47:07 +00:00
|
|
|
} else {
|
|
|
|
s->sensor[j] = sensor;
|
Start cleaning up sensor indexing for multiple sensors
This is a very timid start at making us actually use multiple sensors
without the magical special case for just CCR oxygen tracking.
It mainly does:
- turn the "sample->sensor" index into an array of two indexes, to
match the pressures themselves.
- get rid of dive->{oxygen_cylinder_index,diluent_cylinder_index},
since a CCR dive should now simply set the sample->sensor[] indices
correctly instead.
- in a couple of places, start actually looping over the sensors rather
than special-case the O2 case (although often the small "loops" are
just unrolled, since it's just two cases.
but in many cases we still end up only covering the zero sensor case,
because the CCR O2 sensor code coverage was fairly limited.
It's entirely possible (even likely) that this migth break some existing
case: it tries to be a fairly direct ("stupid") translation of the old
code, but unlike the preparatory patch this does actually does change
some semantics.
For example, right now the git loader code assumes that if the git save
data contains a o2pressure entry, it just hardcodes the O2 sensor index
to 1.
In fact, one issue is going to simply be that our file formats do not
have that multiple sensor format, but instead had very clearly encoded
things as being the CCR O2 pressure sensor.
But this is hopefully close to usable, and I will need feedback (and
maybe test cases) from people who have existing CCR dives with pressure
data.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-07-21 02:49:45 +00:00
|
|
|
}
|
2013-03-28 02:04:46 +00:00
|
|
|
}
|
2018-08-13 02:47:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void renumber_last_sample(struct divecomputer *dc, const int mapping[])
|
|
|
|
{
|
|
|
|
int idx;
|
|
|
|
|
|
|
|
if (dc->samples <= 0)
|
|
|
|
return;
|
|
|
|
idx = dc->samples - 1;
|
|
|
|
sample_renumber(dc->sample + idx, idx, mapping);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void event_renumber(struct event *ev, const int mapping[])
|
|
|
|
{
|
|
|
|
if (!event_is_gaschange(ev))
|
|
|
|
return;
|
|
|
|
if (ev->gas.index < 0)
|
|
|
|
return;
|
|
|
|
ev->gas.index = mapping[ev->gas.index];
|
|
|
|
}
|
|
|
|
|
|
|
|
static void dc_cylinder_renumber(struct dive *dive, struct divecomputer *dc, const int mapping[])
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
struct event *ev;
|
|
|
|
|
2020-03-11 10:30:51 +00:00
|
|
|
/* Remap or delete the sensor indices */
|
2018-08-13 02:47:07 +00:00
|
|
|
for (i = 0; i < dc->samples; i++)
|
|
|
|
sample_renumber(dc->sample + i, i, mapping);
|
2014-08-17 18:26:21 +00:00
|
|
|
|
2020-03-11 10:30:51 +00:00
|
|
|
/* Remap the gas change indices */
|
2018-08-13 02:47:07 +00:00
|
|
|
for (ev = dc->events; ev; ev = ev->next)
|
|
|
|
event_renumber(ev, mapping);
|
|
|
|
|
|
|
|
/* If the initial cylinder of a dive was remapped, add a gas change event to that cylinder */
|
|
|
|
if (mapping[0] > 0)
|
|
|
|
add_initial_gaschange(dive, dc, 0, mapping[0]);
|
2013-03-28 02:04:46 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2020-03-11 10:30:51 +00:00
|
|
|
* If the cylinder indices change (due to merging dives or deleting
|
|
|
|
* cylinders in the middle), we need to change the indices in the
|
2013-03-28 02:04:46 +00:00
|
|
|
* dive computer data for this dive.
|
|
|
|
*
|
|
|
|
* Also note that we assume that the initial cylinder is cylinder 0,
|
|
|
|
* so if that got renamed, we need to create a fake gas change event
|
|
|
|
*/
|
2017-10-09 21:34:04 +00:00
|
|
|
void cylinder_renumber(struct dive *dive, int mapping[])
|
2013-03-28 02:04:46 +00:00
|
|
|
{
|
|
|
|
struct divecomputer *dc;
|
2014-10-11 11:25:52 +00:00
|
|
|
for_each_dc (dive, dc)
|
2013-03-28 02:04:46 +00:00
|
|
|
dc_cylinder_renumber(dive, dc, mapping);
|
|
|
|
}
|
|
|
|
|
2019-08-04 16:44:57 +00:00
|
|
|
int same_gasmix_cylinder(const cylinder_t *cyl, int cylid, const struct dive *dive, bool check_unused)
|
2017-10-08 03:14:57 +00:00
|
|
|
{
|
2018-08-16 17:10:10 +00:00
|
|
|
struct gasmix mygas = cyl->gasmix;
|
2019-08-04 16:44:57 +00:00
|
|
|
for (int i = 0; i < dive->cylinders.nr; i++) {
|
|
|
|
if (i == cylid)
|
2017-10-08 03:14:57 +00:00
|
|
|
continue;
|
2019-08-04 20:13:49 +00:00
|
|
|
struct gasmix gas2 = get_cylinder(dive, i)->gasmix;
|
2017-10-08 03:14:57 +00:00
|
|
|
if (gasmix_distance(mygas, gas2) == 0 && (is_cylinder_used(dive, i) || check_unused))
|
|
|
|
return i;
|
|
|
|
}
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2017-02-08 23:00:04 +00:00
|
|
|
static int pdiff(pressure_t a, pressure_t b)
|
|
|
|
{
|
|
|
|
return a.mbar && b.mbar && a.mbar != b.mbar;
|
|
|
|
}
|
|
|
|
|
2018-08-23 17:18:43 +00:00
|
|
|
static int different_manual_pressures(const cylinder_t *a, const cylinder_t *b)
|
2017-02-08 23:00:04 +00:00
|
|
|
{
|
|
|
|
return pdiff(a->start, b->start) || pdiff(a->end, b->end);
|
|
|
|
}
|
|
|
|
|
2017-02-08 19:36:08 +00:00
|
|
|
/*
|
|
|
|
* Can we find an exact match for a cylinder in another dive?
|
|
|
|
* Take the "already matched" map into account, so that we
|
|
|
|
* don't match multiple similar cylinders to one target.
|
2017-02-08 23:00:04 +00:00
|
|
|
*
|
|
|
|
* To match, the cylinders have to have the same gasmix and the
|
|
|
|
* same cylinder use (ie OC/Diluent/Oxygen), and if pressures
|
|
|
|
* have been added manually they need to match.
|
2017-02-08 19:36:08 +00:00
|
|
|
*/
|
2020-06-28 21:26:26 +00:00
|
|
|
static int match_cylinder(const cylinder_t *cyl, const struct dive *dive, const bool *try_match)
|
2017-02-08 19:36:08 +00:00
|
|
|
{
|
|
|
|
int i;
|
|
|
|
|
2019-08-04 16:44:57 +00:00
|
|
|
for (i = 0; i < dive->cylinders.nr; i++) {
|
2018-08-23 17:18:43 +00:00
|
|
|
const cylinder_t *target;
|
2017-02-08 19:36:08 +00:00
|
|
|
|
2020-06-28 21:26:26 +00:00
|
|
|
if (!try_match[i])
|
2017-02-08 19:36:08 +00:00
|
|
|
continue;
|
2020-06-28 21:26:26 +00:00
|
|
|
|
2019-08-04 20:13:49 +00:00
|
|
|
target = get_cylinder(dive, i);
|
2018-08-16 17:10:10 +00:00
|
|
|
if (!same_gasmix(cyl->gasmix, target->gasmix))
|
2017-02-08 19:36:08 +00:00
|
|
|
continue;
|
2017-02-08 23:00:04 +00:00
|
|
|
if (cyl->cylinder_use != target->cylinder_use)
|
|
|
|
continue;
|
|
|
|
if (different_manual_pressures(cyl, target))
|
|
|
|
continue;
|
2017-02-08 19:36:08 +00:00
|
|
|
|
2019-03-19 15:22:51 +00:00
|
|
|
/* open question: Should we check sizes too? */
|
2017-02-08 19:36:08 +00:00
|
|
|
return i;
|
|
|
|
}
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
core: improve merging of cylinders pressures
When merging cylinders pressures derived from samples were taken
as maximum of the start and minimum of the end pressure, which
makes sense, since we believe that this is the same cylinder.
However, for manually entered pressures, this was not done.
Moreover, when one dive had manual pressures and the other only
pressure from samples, the manual pressure was taken. However,
that could have been the wrong one, for example if the end
pressure was manually set for the cylinder of the first part of
the dive, but not the last.
Therefore, improve merging of manuall set pressures in two ways:
1) use maximum/minimum for start/end pressure
2) if the pressure of one cylinder was manually set, but not for
the other, complete with the sample pressure (if that exists).
Fixes #2884.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2020-10-03 15:03:28 +00:00
|
|
|
/*
|
|
|
|
* Function used to merge manually set start or end pressures. This
|
|
|
|
* is used to merge cylinders when merging dives. We store up to two
|
|
|
|
* values for start _and_ end pressures: one derived from samples and
|
|
|
|
* one entered manually, whereby the latter takes precedence. It may
|
|
|
|
* happen that the user merges two dives where one has a manual,
|
|
|
|
* the other only a sample-derived pressure. In such a case we want to
|
|
|
|
* supplement the non-existing manual value by a sample derived one.
|
|
|
|
* Otherwise, the merged dive would end up with incomplete pressure
|
|
|
|
* information.
|
|
|
|
* The last argument to the function specifies whether the larger
|
|
|
|
* or smaller value of the two dives should be returned. Obviously,
|
|
|
|
* for the starting pressure we want the larger and for the ending
|
|
|
|
* pressure the smaller value.
|
|
|
|
*/
|
|
|
|
static pressure_t merge_pressures(pressure_t a, pressure_t sample_a, pressure_t b, pressure_t sample_b, bool take_min)
|
|
|
|
{
|
|
|
|
if (!a.mbar && !b.mbar)
|
|
|
|
return a;
|
|
|
|
if (!a.mbar)
|
|
|
|
a = sample_a;
|
|
|
|
if (!b.mbar)
|
|
|
|
b = sample_b;
|
|
|
|
if (!a.mbar)
|
|
|
|
a = b;
|
|
|
|
if (!b.mbar)
|
|
|
|
b = a;
|
|
|
|
if (take_min && a.mbar < b.mbar)
|
|
|
|
return a;
|
|
|
|
else
|
|
|
|
return b;
|
|
|
|
}
|
|
|
|
|
2017-02-08 23:00:04 +00:00
|
|
|
/*
|
|
|
|
* We matched things up so that they have the same gasmix and
|
|
|
|
* use, but we might want to fill in any missing cylinder details
|
|
|
|
* in 'a' if we had it from 'b'.
|
|
|
|
*/
|
2020-06-28 21:26:26 +00:00
|
|
|
static void merge_one_cylinder(cylinder_t *a, const cylinder_t *b)
|
|
|
|
{
|
|
|
|
if (!a->type.size.mliter)
|
|
|
|
a->type.size.mliter = b->type.size.mliter;
|
|
|
|
if (!a->type.workingpressure.mbar)
|
|
|
|
a->type.workingpressure.mbar = b->type.workingpressure.mbar;
|
|
|
|
if (empty_string(a->type.description))
|
|
|
|
a->type.description = copy_string(b->type.description);
|
core: improve merging of cylinders pressures
When merging cylinders pressures derived from samples were taken
as maximum of the start and minimum of the end pressure, which
makes sense, since we believe that this is the same cylinder.
However, for manually entered pressures, this was not done.
Moreover, when one dive had manual pressures and the other only
pressure from samples, the manual pressure was taken. However,
that could have been the wrong one, for example if the end
pressure was manually set for the cylinder of the first part of
the dive, but not the last.
Therefore, improve merging of manuall set pressures in two ways:
1) use maximum/minimum for start/end pressure
2) if the pressure of one cylinder was manually set, but not for
the other, complete with the sample pressure (if that exists).
Fixes #2884.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2020-10-03 15:03:28 +00:00
|
|
|
|
|
|
|
/* If either cylinder has manually entered pressures, try to merge them.
|
|
|
|
* Use pressures from divecomputer samples if only one cylinder has such a value.
|
2020-10-03 22:07:59 +00:00
|
|
|
* Yes, this is an actual use case we encountered.
|
|
|
|
* Note that we don't merge the sample-derived pressure values, as this is
|
|
|
|
* perfomed after merging in fixup_dive() */
|
core: improve merging of cylinders pressures
When merging cylinders pressures derived from samples were taken
as maximum of the start and minimum of the end pressure, which
makes sense, since we believe that this is the same cylinder.
However, for manually entered pressures, this was not done.
Moreover, when one dive had manual pressures and the other only
pressure from samples, the manual pressure was taken. However,
that could have been the wrong one, for example if the end
pressure was manually set for the cylinder of the first part of
the dive, but not the last.
Therefore, improve merging of manuall set pressures in two ways:
1) use maximum/minimum for start/end pressure
2) if the pressure of one cylinder was manually set, but not for
the other, complete with the sample pressure (if that exists).
Fixes #2884.
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
2020-10-03 15:03:28 +00:00
|
|
|
a->start = merge_pressures(a->start, a->sample_start, b->start, b->sample_start, false);
|
|
|
|
a->end = merge_pressures(a->end, a->sample_end, b->end, b->sample_end, true);
|
2017-09-30 12:21:26 +00:00
|
|
|
|
2020-06-28 21:26:26 +00:00
|
|
|
/* Really? */
|
|
|
|
a->gas_used.mliter += b->gas_used.mliter;
|
|
|
|
a->deco_gas_used.mliter += b->deco_gas_used.mliter;
|
|
|
|
a->bestmix_o2 = a->bestmix_o2 && b->bestmix_o2;
|
|
|
|
a->bestmix_he = a->bestmix_he && b->bestmix_he;
|
|
|
|
}
|
2018-08-13 02:47:07 +00:00
|
|
|
|
2020-06-28 21:26:26 +00:00
|
|
|
static bool cylinder_has_data(const cylinder_t *cyl)
|
|
|
|
{
|
|
|
|
return !cyl->type.size.mliter &&
|
|
|
|
!cyl->type.workingpressure.mbar &&
|
|
|
|
!cyl->type.description &&
|
|
|
|
!cyl->gasmix.o2.permille &&
|
|
|
|
!cyl->gasmix.he.permille &&
|
|
|
|
!cyl->start.mbar &&
|
|
|
|
!cyl->end.mbar &&
|
|
|
|
!cyl->sample_start.mbar &&
|
|
|
|
!cyl->sample_end.mbar &&
|
|
|
|
!cyl->gas_used.mliter &&
|
|
|
|
!cyl->deco_gas_used.mliter;
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool cylinder_in_use(const struct dive *dive, int idx)
|
|
|
|
{
|
|
|
|
if (idx < 0 || idx >= dive->cylinders.nr)
|
|
|
|
return false;
|
|
|
|
|
|
|
|
/* This tests for gaschange events or pressure changes */
|
|
|
|
if (is_cylinder_used(dive, idx))
|
|
|
|
return true;
|
|
|
|
|
|
|
|
/* This tests for typenames or gas contents */
|
|
|
|
return cylinder_has_data(get_cylinder(dive, idx));
|
2017-02-08 23:00:04 +00:00
|
|
|
}
|
|
|
|
|
2013-03-28 02:04:46 +00:00
|
|
|
/*
|
|
|
|
* Merging cylinder information is non-trivial, because the two dive computers
|
|
|
|
* may have different ideas of what the different cylinder indexing is.
|
|
|
|
*
|
|
|
|
* Logic: take all the cylinder information from the preferred dive ('a'), and
|
|
|
|
* then try to match each of the cylinders in the other dive by the gasmix that
|
|
|
|
* is the best match and hasn't been used yet.
|
2018-08-13 02:47:07 +00:00
|
|
|
*
|
2019-08-04 16:44:57 +00:00
|
|
|
* For each dive, a cylinder-renumbering table is returned.
|
2013-03-28 02:04:46 +00:00
|
|
|
*/
|
2018-08-13 02:47:07 +00:00
|
|
|
static void merge_cylinders(struct dive *res, const struct dive *a, const struct dive *b,
|
|
|
|
int mapping_a[], int mapping_b[])
|
2013-03-28 02:04:46 +00:00
|
|
|
{
|
2018-08-13 02:47:07 +00:00
|
|
|
int i;
|
2020-06-28 21:26:26 +00:00
|
|
|
int max_cylinders = a->cylinders.nr + b->cylinders.nr;
|
|
|
|
bool *used_in_a = malloc(max_cylinders * sizeof(bool));
|
|
|
|
bool *used_in_b = malloc(max_cylinders * sizeof(bool));
|
|
|
|
bool *try_to_match = malloc(max_cylinders * sizeof(bool));
|
2017-02-08 19:36:08 +00:00
|
|
|
|
2018-08-13 02:47:07 +00:00
|
|
|
/* First, clear all cylinders in destination */
|
2019-08-04 16:44:57 +00:00
|
|
|
clear_cylinder_table(&res->cylinders);
|
2018-08-13 02:47:07 +00:00
|
|
|
|
2020-06-28 21:26:26 +00:00
|
|
|
/* Clear all cylinder mappings */
|
|
|
|
for (i = 0; i < a->cylinders.nr; i++)
|
2019-08-04 16:44:57 +00:00
|
|
|
mapping_a[i] = -1;
|
2020-06-28 21:26:26 +00:00
|
|
|
for (i = 0; i < b->cylinders.nr; i++)
|
|
|
|
mapping_b[i] = -1;
|
|
|
|
|
|
|
|
/* Calculate usage map of cylinders, clear matching map */
|
|
|
|
for (i = 0; i < max_cylinders; i++) {
|
|
|
|
used_in_a[i] = cylinder_in_use(a, i);
|
|
|
|
used_in_b[i] = cylinder_in_use(b, i);
|
|
|
|
try_to_match[i] = false;
|
2019-08-04 16:44:57 +00:00
|
|
|
}
|
|
|
|
|
2020-06-28 21:26:26 +00:00
|
|
|
/*
|
|
|
|
* For each cylinder in 'a' that is used, copy it to 'res'.
|
|
|
|
* These are also potential matches for 'b' to use.
|
|
|
|
*/
|
|
|
|
for (i = 0; i < max_cylinders; i++) {
|
|
|
|
int res_nr = res->cylinders.nr;
|
|
|
|
if (!used_in_a[i])
|
|
|
|
continue;
|
|
|
|
mapping_a[i] = res_nr;
|
|
|
|
try_to_match[res_nr] = true;
|
|
|
|
add_cloned_cylinder(&res->cylinders, *get_cylinder(a, i));
|
2017-02-08 19:36:08 +00:00
|
|
|
}
|
|
|
|
|
2020-06-28 21:26:26 +00:00
|
|
|
/*
|
|
|
|
* For each cylinder in 'b' that is used, try to match it
|
|
|
|
* with an existing cylinder in 'res' from 'a'
|
|
|
|
*/
|
2019-08-04 16:44:57 +00:00
|
|
|
for (i = 0; i < b->cylinders.nr; i++) {
|
2017-02-08 19:36:08 +00:00
|
|
|
int j;
|
2013-03-28 02:04:46 +00:00
|
|
|
|
2019-07-25 08:28:58 +00:00
|
|
|
if (!used_in_b[i])
|
2017-02-08 19:36:08 +00:00
|
|
|
continue;
|
|
|
|
|
2020-06-28 21:26:26 +00:00
|
|
|
j = match_cylinder(get_cylinder(b, i), res, try_to_match);
|
2017-02-08 19:36:08 +00:00
|
|
|
|
2020-06-28 21:26:26 +00:00
|
|
|
/* No match? Add it to the result */
|
|
|
|
if (j < 0) {
|
|
|
|
int res_nr = res->cylinders.nr;
|
|
|
|
mapping_b[i] = res_nr;
|
2019-08-04 20:13:49 +00:00
|
|
|
add_cloned_cylinder(&res->cylinders, *get_cylinder(b, i));
|
2020-06-28 21:26:26 +00:00
|
|
|
continue;
|
2019-08-04 16:44:57 +00:00
|
|
|
}
|
2020-06-28 21:26:26 +00:00
|
|
|
|
|
|
|
/* Otherwise, merge the result to the one we found */
|
|
|
|
mapping_b[i] = j;
|
|
|
|
merge_one_cylinder(get_cylinder(res,j), get_cylinder(b, i));
|
|
|
|
|
|
|
|
/* Don't match the same target more than once */
|
|
|
|
try_to_match[j] = false;
|
2017-02-02 14:31:52 +00:00
|
|
|
}
|
2019-07-25 08:28:58 +00:00
|
|
|
|
|
|
|
free(used_in_a);
|
|
|
|
free(used_in_b);
|
2020-06-28 21:26:26 +00:00
|
|
|
free(try_to_match);
|
2013-03-28 02:04:46 +00:00
|
|
|
}
|
|
|
|
|
2019-06-26 15:21:03 +00:00
|
|
|
/* Check whether a weightsystem table contains a given weightsystem */
|
|
|
|
static bool has_weightsystem(const struct weightsystem_table *t, const weightsystem_t w)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
for (i = 0; i < t->nr; i++) {
|
|
|
|
if (same_weightsystem(w, t->weightsystems[i]))
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2018-08-13 02:47:07 +00:00
|
|
|
static void merge_equipment(struct dive *res, const struct dive *a, const struct dive *b)
|
2012-10-29 18:27:14 +00:00
|
|
|
{
|
|
|
|
int i;
|
2019-06-26 15:21:03 +00:00
|
|
|
for (i = 0; i < a->weightsystems.nr; i++) {
|
|
|
|
if (!has_weightsystem(&res->weightsystems, a->weightsystems.weightsystems[i]))
|
|
|
|
add_cloned_weightsystem(&res->weightsystems, a->weightsystems.weightsystems[i]);
|
|
|
|
}
|
|
|
|
for (i = 0; i < b->weightsystems.nr; i++) {
|
|
|
|
if (!has_weightsystem(&res->weightsystems, b->weightsystems.weightsystems[i]))
|
|
|
|
add_cloned_weightsystem(&res->weightsystems, b->weightsystems.weightsystems[i]);
|
|
|
|
}
|
2012-10-29 18:27:14 +00:00
|
|
|
}
|
|
|
|
|
2018-08-13 02:47:07 +00:00
|
|
|
static void merge_temperatures(struct dive *res, const struct dive *a, const struct dive *b)
|
2013-02-14 17:44:18 +00:00
|
|
|
{
|
2018-08-13 02:47:07 +00:00
|
|
|
temperature_t airtemp_a = un_fixup_airtemp(a);
|
|
|
|
temperature_t airtemp_b = un_fixup_airtemp(b);
|
|
|
|
res->airtemp = airtemp_a.mkelvin ? airtemp_a : airtemp_b;
|
2017-02-19 20:56:54 +00:00
|
|
|
MERGE_NONZERO(res, a, b, watertemp.mkelvin);
|
2013-02-14 17:44:18 +00:00
|
|
|
}
|
|
|
|
|
2012-11-09 18:46:39 +00:00
|
|
|
/*
|
|
|
|
* Pick a trip for a dive
|
|
|
|
*/
|
2018-12-23 11:46:45 +00:00
|
|
|
static struct dive_trip *get_preferred_trip(const struct dive *a, const struct dive *b)
|
2012-11-09 18:46:39 +00:00
|
|
|
{
|
2012-11-26 00:51:55 +00:00
|
|
|
dive_trip_t *atrip, *btrip;
|
|
|
|
|
2018-11-18 10:06:24 +00:00
|
|
|
/* If only one dive has a trip, choose that */
|
2012-11-26 00:51:55 +00:00
|
|
|
atrip = a->divetrip;
|
|
|
|
btrip = b->divetrip;
|
|
|
|
if (!atrip)
|
2018-12-23 11:46:45 +00:00
|
|
|
return btrip;
|
2012-11-26 00:51:55 +00:00
|
|
|
if (!btrip)
|
2018-12-23 11:46:45 +00:00
|
|
|
return atrip;
|
2018-11-18 10:06:24 +00:00
|
|
|
|
|
|
|
/* Both dives have a trip - prefer the non-autogenerated one */
|
|
|
|
if (atrip->autogen && !btrip->autogen)
|
2018-12-23 11:46:45 +00:00
|
|
|
return btrip;
|
2018-11-18 10:06:24 +00:00
|
|
|
if (!atrip->autogen && btrip->autogen)
|
2018-12-23 11:46:45 +00:00
|
|
|
return atrip;
|
2018-11-18 10:06:24 +00:00
|
|
|
|
|
|
|
/* Otherwise, look at the trip data and pick the "better" one */
|
2012-11-26 00:51:55 +00:00
|
|
|
if (!atrip->location)
|
2018-12-23 11:46:45 +00:00
|
|
|
return btrip;
|
2012-11-26 00:51:55 +00:00
|
|
|
if (!btrip->location)
|
2018-12-23 11:46:45 +00:00
|
|
|
return atrip;
|
2012-11-26 00:51:55 +00:00
|
|
|
if (!atrip->notes)
|
2018-12-23 11:46:45 +00:00
|
|
|
return btrip;
|
2012-11-26 00:51:55 +00:00
|
|
|
if (!btrip->notes)
|
2018-12-23 11:46:45 +00:00
|
|
|
return atrip;
|
2012-11-09 18:46:39 +00:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Ok, so both have location and notes.
|
|
|
|
* Pick the earlier one.
|
|
|
|
*/
|
|
|
|
if (a->when < b->when)
|
2018-12-23 11:46:45 +00:00
|
|
|
return atrip;
|
|
|
|
return btrip;
|
2012-11-09 18:46:39 +00:00
|
|
|
}
|
|
|
|
|
2012-11-25 23:10:03 +00:00
|
|
|
#if CURRENTLY_NOT_USED
|
Try to find optimal dive sample merge offset
When we merge dives where the samples have come from different dive
computers, the samples may be offset from each other due to the dive
computers not having decided that the dive starts at quite the same
time.
For example, some dive computers may take a while to wake up when
submerged, or there may be differences in exactly when the dive
computer decides that a dive has started. Different computers tend to
have different depths that they consider the start of a real dive.
So when we merge two dives, look for differences in the sample data,
and search for the sample time offset that minimizes the differences
(logic: minimize the sum-of-square of the depth differences over a
two-minute window at the start of the dive).
This still doesn't really result in perfect merges, since different
computers will give slightly different values anyway, but it improves
the dive merging noticeably. To the point that this seems to have
found a bug in our Uemis data import (it looks like the Uemis importer
does an incorrect saltwater pressure conversion, and the data is
actually in centimeter, not in pressure).
So there is room for improvement, but this is at least a reasonable
approximation and starting point.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-11-10 11:23:13 +00:00
|
|
|
/*
|
|
|
|
* Sample 's' is between samples 'a' and 'b'. It is 'offset' seconds before 'b'.
|
|
|
|
*
|
|
|
|
* If 's' and 'a' are at the same time, offset is 0, and b is NULL.
|
|
|
|
*/
|
|
|
|
static int compare_sample(struct sample *s, struct sample *a, struct sample *b, int offset)
|
|
|
|
{
|
|
|
|
unsigned int depth = a->depth.mm;
|
|
|
|
int diff;
|
|
|
|
|
|
|
|
if (offset) {
|
|
|
|
unsigned int interval = b->time.seconds - a->time.seconds;
|
|
|
|
unsigned int depth_a = a->depth.mm;
|
|
|
|
unsigned int depth_b = b->depth.mm;
|
|
|
|
|
|
|
|
if (offset > interval)
|
|
|
|
return -1;
|
|
|
|
|
|
|
|
/* pick the average depth, scaled by the offset from 'b' */
|
|
|
|
depth = (depth_a * offset) + (depth_b * (interval - offset));
|
|
|
|
depth /= interval;
|
|
|
|
}
|
|
|
|
diff = s->depth.mm - depth;
|
|
|
|
if (diff < 0)
|
|
|
|
diff = -diff;
|
|
|
|
/* cut off at one meter difference */
|
|
|
|
if (diff > 1000)
|
|
|
|
diff = 1000;
|
2014-02-28 04:09:57 +00:00
|
|
|
return diff * diff;
|
Try to find optimal dive sample merge offset
When we merge dives where the samples have come from different dive
computers, the samples may be offset from each other due to the dive
computers not having decided that the dive starts at quite the same
time.
For example, some dive computers may take a while to wake up when
submerged, or there may be differences in exactly when the dive
computer decides that a dive has started. Different computers tend to
have different depths that they consider the start of a real dive.
So when we merge two dives, look for differences in the sample data,
and search for the sample time offset that minimizes the differences
(logic: minimize the sum-of-square of the depth differences over a
two-minute window at the start of the dive).
This still doesn't really result in perfect merges, since different
computers will give slightly different values anyway, but it improves
the dive merging noticeably. To the point that this seems to have
found a bug in our Uemis data import (it looks like the Uemis importer
does an incorrect saltwater pressure conversion, and the data is
actually in centimeter, not in pressure).
So there is room for improvement, but this is at least a reasonable
approximation and starting point.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-11-10 11:23:13 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Calculate a "difference" in samples between the two dives, given
|
|
|
|
* the offset in seconds between them. Use this to find the best
|
|
|
|
* match of samples between two different dive computers.
|
|
|
|
*/
|
2012-11-24 02:51:27 +00:00
|
|
|
static unsigned long sample_difference(struct divecomputer *a, struct divecomputer *b, int offset)
|
Try to find optimal dive sample merge offset
When we merge dives where the samples have come from different dive
computers, the samples may be offset from each other due to the dive
computers not having decided that the dive starts at quite the same
time.
For example, some dive computers may take a while to wake up when
submerged, or there may be differences in exactly when the dive
computer decides that a dive has started. Different computers tend to
have different depths that they consider the start of a real dive.
So when we merge two dives, look for differences in the sample data,
and search for the sample time offset that minimizes the differences
(logic: minimize the sum-of-square of the depth differences over a
two-minute window at the start of the dive).
This still doesn't really result in perfect merges, since different
computers will give slightly different values anyway, but it improves
the dive merging noticeably. To the point that this seems to have
found a bug in our Uemis data import (it looks like the Uemis importer
does an incorrect saltwater pressure conversion, and the data is
actually in centimeter, not in pressure).
So there is room for improvement, but this is at least a reasonable
approximation and starting point.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-11-10 11:23:13 +00:00
|
|
|
{
|
|
|
|
int asamples = a->samples;
|
|
|
|
int bsamples = b->samples;
|
|
|
|
struct sample *as = a->sample;
|
|
|
|
struct sample *bs = b->sample;
|
|
|
|
unsigned long error = 0;
|
|
|
|
int start = -1;
|
|
|
|
|
|
|
|
if (!asamples || !bsamples)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* skip the first sample - this way we know can always look at
|
|
|
|
* as/bs[-1] to look at the samples around it in the loop.
|
|
|
|
*/
|
2014-02-28 04:09:57 +00:00
|
|
|
as++;
|
|
|
|
bs++;
|
Try to find optimal dive sample merge offset
When we merge dives where the samples have come from different dive
computers, the samples may be offset from each other due to the dive
computers not having decided that the dive starts at quite the same
time.
For example, some dive computers may take a while to wake up when
submerged, or there may be differences in exactly when the dive
computer decides that a dive has started. Different computers tend to
have different depths that they consider the start of a real dive.
So when we merge two dives, look for differences in the sample data,
and search for the sample time offset that minimizes the differences
(logic: minimize the sum-of-square of the depth differences over a
two-minute window at the start of the dive).
This still doesn't really result in perfect merges, since different
computers will give slightly different values anyway, but it improves
the dive merging noticeably. To the point that this seems to have
found a bug in our Uemis data import (it looks like the Uemis importer
does an incorrect saltwater pressure conversion, and the data is
actually in centimeter, not in pressure).
So there is room for improvement, but this is at least a reasonable
approximation and starting point.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-11-10 11:23:13 +00:00
|
|
|
asamples--;
|
|
|
|
bsamples--;
|
|
|
|
|
|
|
|
for (;;) {
|
|
|
|
int at, bt, diff;
|
|
|
|
|
|
|
|
|
|
|
|
/* If we run out of samples, punt */
|
|
|
|
if (!asamples)
|
|
|
|
return INT_MAX;
|
|
|
|
if (!bsamples)
|
|
|
|
return INT_MAX;
|
|
|
|
|
|
|
|
at = as->time.seconds;
|
|
|
|
bt = bs->time.seconds + offset;
|
|
|
|
|
|
|
|
/* b hasn't started yet? Ignore it */
|
|
|
|
if (bt < 0) {
|
|
|
|
bs++;
|
|
|
|
bsamples--;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (at < bt) {
|
2014-02-28 04:09:57 +00:00
|
|
|
diff = compare_sample(as, bs - 1, bs, bt - at);
|
Try to find optimal dive sample merge offset
When we merge dives where the samples have come from different dive
computers, the samples may be offset from each other due to the dive
computers not having decided that the dive starts at quite the same
time.
For example, some dive computers may take a while to wake up when
submerged, or there may be differences in exactly when the dive
computer decides that a dive has started. Different computers tend to
have different depths that they consider the start of a real dive.
So when we merge two dives, look for differences in the sample data,
and search for the sample time offset that minimizes the differences
(logic: minimize the sum-of-square of the depth differences over a
two-minute window at the start of the dive).
This still doesn't really result in perfect merges, since different
computers will give slightly different values anyway, but it improves
the dive merging noticeably. To the point that this seems to have
found a bug in our Uemis data import (it looks like the Uemis importer
does an incorrect saltwater pressure conversion, and the data is
actually in centimeter, not in pressure).
So there is room for improvement, but this is at least a reasonable
approximation and starting point.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-11-10 11:23:13 +00:00
|
|
|
as++;
|
|
|
|
asamples--;
|
|
|
|
} else if (at > bt) {
|
2014-02-28 04:09:57 +00:00
|
|
|
diff = compare_sample(bs, as - 1, as, at - bt);
|
Try to find optimal dive sample merge offset
When we merge dives where the samples have come from different dive
computers, the samples may be offset from each other due to the dive
computers not having decided that the dive starts at quite the same
time.
For example, some dive computers may take a while to wake up when
submerged, or there may be differences in exactly when the dive
computer decides that a dive has started. Different computers tend to
have different depths that they consider the start of a real dive.
So when we merge two dives, look for differences in the sample data,
and search for the sample time offset that minimizes the differences
(logic: minimize the sum-of-square of the depth differences over a
two-minute window at the start of the dive).
This still doesn't really result in perfect merges, since different
computers will give slightly different values anyway, but it improves
the dive merging noticeably. To the point that this seems to have
found a bug in our Uemis data import (it looks like the Uemis importer
does an incorrect saltwater pressure conversion, and the data is
actually in centimeter, not in pressure).
So there is room for improvement, but this is at least a reasonable
approximation and starting point.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-11-10 11:23:13 +00:00
|
|
|
bs++;
|
|
|
|
bsamples--;
|
|
|
|
} else {
|
|
|
|
diff = compare_sample(as, bs, NULL, 0);
|
2014-02-28 04:09:57 +00:00
|
|
|
as++;
|
|
|
|
bs++;
|
|
|
|
asamples--;
|
|
|
|
bsamples--;
|
Try to find optimal dive sample merge offset
When we merge dives where the samples have come from different dive
computers, the samples may be offset from each other due to the dive
computers not having decided that the dive starts at quite the same
time.
For example, some dive computers may take a while to wake up when
submerged, or there may be differences in exactly when the dive
computer decides that a dive has started. Different computers tend to
have different depths that they consider the start of a real dive.
So when we merge two dives, look for differences in the sample data,
and search for the sample time offset that minimizes the differences
(logic: minimize the sum-of-square of the depth differences over a
two-minute window at the start of the dive).
This still doesn't really result in perfect merges, since different
computers will give slightly different values anyway, but it improves
the dive merging noticeably. To the point that this seems to have
found a bug in our Uemis data import (it looks like the Uemis importer
does an incorrect saltwater pressure conversion, and the data is
actually in centimeter, not in pressure).
So there is room for improvement, but this is at least a reasonable
approximation and starting point.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-11-10 11:23:13 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Invalid comparison point? */
|
|
|
|
if (diff < 0)
|
|
|
|
continue;
|
|
|
|
|
|
|
|
if (start < 0)
|
|
|
|
start = at;
|
|
|
|
|
|
|
|
error += diff;
|
|
|
|
|
|
|
|
if (at - start > 120)
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Dive 'a' is 'offset' seconds before dive 'b'
|
|
|
|
*
|
|
|
|
* This is *not* because the dive computers clocks aren't in sync,
|
|
|
|
* it is because the dive computers may "start" the dive at different
|
|
|
|
* points in the dive, so the sample at time X in dive 'a' is the
|
|
|
|
* same as the sample at time X+offset in dive 'b'.
|
|
|
|
*
|
|
|
|
* For example, some dive computers take longer to "wake up" when
|
|
|
|
* they sense that you are under water (ie Uemis Zurich if it was off
|
|
|
|
* when the dive started). And other dive computers have different
|
|
|
|
* depths that they activate at, etc etc.
|
|
|
|
*
|
|
|
|
* If we cannot find a shared offset, don't try to merge.
|
|
|
|
*/
|
2012-11-24 02:51:27 +00:00
|
|
|
static int find_sample_offset(struct divecomputer *a, struct divecomputer *b)
|
Try to find optimal dive sample merge offset
When we merge dives where the samples have come from different dive
computers, the samples may be offset from each other due to the dive
computers not having decided that the dive starts at quite the same
time.
For example, some dive computers may take a while to wake up when
submerged, or there may be differences in exactly when the dive
computer decides that a dive has started. Different computers tend to
have different depths that they consider the start of a real dive.
So when we merge two dives, look for differences in the sample data,
and search for the sample time offset that minimizes the differences
(logic: minimize the sum-of-square of the depth differences over a
two-minute window at the start of the dive).
This still doesn't really result in perfect merges, since different
computers will give slightly different values anyway, but it improves
the dive merging noticeably. To the point that this seems to have
found a bug in our Uemis data import (it looks like the Uemis importer
does an incorrect saltwater pressure conversion, and the data is
actually in centimeter, not in pressure).
So there is room for improvement, but this is at least a reasonable
approximation and starting point.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-11-10 11:23:13 +00:00
|
|
|
{
|
|
|
|
int offset, best;
|
|
|
|
unsigned long max;
|
|
|
|
|
|
|
|
/* No samples? Merge at any time (0 offset) */
|
|
|
|
if (!a->samples)
|
|
|
|
return 0;
|
|
|
|
if (!b->samples)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Common special-case: merging a dive that came from
|
|
|
|
* the same dive computer, so the samples are identical.
|
|
|
|
* Check this first, without wasting time trying to find
|
|
|
|
* some minimal offset case.
|
|
|
|
*/
|
|
|
|
best = 0;
|
|
|
|
max = sample_difference(a, b, 0);
|
|
|
|
if (!max)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Otherwise, look if we can find anything better within
|
|
|
|
* a thirty second window..
|
|
|
|
*/
|
|
|
|
for (offset = -30; offset <= 30; offset++) {
|
|
|
|
unsigned long diff;
|
|
|
|
|
|
|
|
diff = sample_difference(a, b, offset);
|
|
|
|
if (diff > max)
|
|
|
|
continue;
|
|
|
|
best = offset;
|
|
|
|
max = diff;
|
|
|
|
}
|
|
|
|
|
|
|
|
return best;
|
|
|
|
}
|
2012-11-25 23:10:03 +00:00
|
|
|
#endif
|
Try to find optimal dive sample merge offset
When we merge dives where the samples have come from different dive
computers, the samples may be offset from each other due to the dive
computers not having decided that the dive starts at quite the same
time.
For example, some dive computers may take a while to wake up when
submerged, or there may be differences in exactly when the dive
computer decides that a dive has started. Different computers tend to
have different depths that they consider the start of a real dive.
So when we merge two dives, look for differences in the sample data,
and search for the sample time offset that minimizes the differences
(logic: minimize the sum-of-square of the depth differences over a
two-minute window at the start of the dive).
This still doesn't really result in perfect merges, since different
computers will give slightly different values anyway, but it improves
the dive merging noticeably. To the point that this seems to have
found a bug in our Uemis data import (it looks like the Uemis importer
does an incorrect saltwater pressure conversion, and the data is
actually in centimeter, not in pressure).
So there is room for improvement, but this is at least a reasonable
approximation and starting point.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-11-10 11:23:13 +00:00
|
|
|
|
Improve automatic dive merging logic
This tunes the heuristics for when to merge two dives together into a
single dive. We used to just look at the date, and say "if they're
within one minute of each other, try to merge". This looks at the
actual dive data, and tries to see just how much sense it makes to
merge the dive.
It also checks if the dives to be merged use different dive computers,
and if so relaxes the one minute to five, since most people aren't
quite as OCD as I am, and don't tend to set their dive computers quite
that exactly to the same time and date.
I'm sure people can come up with other heuristics, but this should
make that easier too.
NOTE! If you have things like wrong timezones etc, and the
divecomputer dates are thus off by hours rather than by a couple of
minutes, this will still not merge them. For that kind of situation,
we'd need some kind of manual merge option. Note that that is *not*
the same as the current "merge two adjacent dives" together, which
joins two separate dives into one *longer* dive with a surface
interval in between.
That kind of manual merge UI makes sense, but is independent of this
partical change.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-12-04 20:26:28 +00:00
|
|
|
/*
|
|
|
|
* Are a and b "similar" values, when given a reasonable lower end expected
|
|
|
|
* difference?
|
|
|
|
*
|
|
|
|
* So for example, we'd expect different dive computers to give different
|
2017-03-06 12:27:39 +00:00
|
|
|
* max. depth readings. You might have them on different arms, and they
|
Improve automatic dive merging logic
This tunes the heuristics for when to merge two dives together into a
single dive. We used to just look at the date, and say "if they're
within one minute of each other, try to merge". This looks at the
actual dive data, and tries to see just how much sense it makes to
merge the dive.
It also checks if the dives to be merged use different dive computers,
and if so relaxes the one minute to five, since most people aren't
quite as OCD as I am, and don't tend to set their dive computers quite
that exactly to the same time and date.
I'm sure people can come up with other heuristics, but this should
make that easier too.
NOTE! If you have things like wrong timezones etc, and the
divecomputer dates are thus off by hours rather than by a couple of
minutes, this will still not merge them. For that kind of situation,
we'd need some kind of manual merge option. Note that that is *not*
the same as the current "merge two adjacent dives" together, which
joins two separate dives into one *longer* dive with a surface
interval in between.
That kind of manual merge UI makes sense, but is independent of this
partical change.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-12-04 20:26:28 +00:00
|
|
|
* have different pressure sensors and possibly different ideas about
|
|
|
|
* water salinity etc.
|
|
|
|
*
|
|
|
|
* So have an expected minimum difference, but also allow a larger relative
|
|
|
|
* error value.
|
|
|
|
*/
|
|
|
|
static int similar(unsigned long a, unsigned long b, unsigned long expected)
|
|
|
|
{
|
2016-02-04 19:16:04 +00:00
|
|
|
if (!a && !b)
|
|
|
|
return 1;
|
|
|
|
|
Improve automatic dive merging logic
This tunes the heuristics for when to merge two dives together into a
single dive. We used to just look at the date, and say "if they're
within one minute of each other, try to merge". This looks at the
actual dive data, and tries to see just how much sense it makes to
merge the dive.
It also checks if the dives to be merged use different dive computers,
and if so relaxes the one minute to five, since most people aren't
quite as OCD as I am, and don't tend to set their dive computers quite
that exactly to the same time and date.
I'm sure people can come up with other heuristics, but this should
make that easier too.
NOTE! If you have things like wrong timezones etc, and the
divecomputer dates are thus off by hours rather than by a couple of
minutes, this will still not merge them. For that kind of situation,
we'd need some kind of manual merge option. Note that that is *not*
the same as the current "merge two adjacent dives" together, which
joins two separate dives into one *longer* dive with a surface
interval in between.
That kind of manual merge UI makes sense, but is independent of this
partical change.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-12-04 20:26:28 +00:00
|
|
|
if (a && b) {
|
|
|
|
unsigned long min, max, diff;
|
|
|
|
|
2014-02-28 04:09:57 +00:00
|
|
|
min = a;
|
|
|
|
max = b;
|
Improve automatic dive merging logic
This tunes the heuristics for when to merge two dives together into a
single dive. We used to just look at the date, and say "if they're
within one minute of each other, try to merge". This looks at the
actual dive data, and tries to see just how much sense it makes to
merge the dive.
It also checks if the dives to be merged use different dive computers,
and if so relaxes the one minute to five, since most people aren't
quite as OCD as I am, and don't tend to set their dive computers quite
that exactly to the same time and date.
I'm sure people can come up with other heuristics, but this should
make that easier too.
NOTE! If you have things like wrong timezones etc, and the
divecomputer dates are thus off by hours rather than by a couple of
minutes, this will still not merge them. For that kind of situation,
we'd need some kind of manual merge option. Note that that is *not*
the same as the current "merge two adjacent dives" together, which
joins two separate dives into one *longer* dive with a surface
interval in between.
That kind of manual merge UI makes sense, but is independent of this
partical change.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-12-04 20:26:28 +00:00
|
|
|
if (a > b) {
|
|
|
|
min = b;
|
|
|
|
max = a;
|
|
|
|
}
|
|
|
|
diff = max - min;
|
|
|
|
|
|
|
|
/* Smaller than expected difference? */
|
|
|
|
if (diff < expected)
|
|
|
|
return 1;
|
|
|
|
/* Error less than 10% or the maximum */
|
2014-02-28 04:09:57 +00:00
|
|
|
if (diff * 10 < max)
|
Improve automatic dive merging logic
This tunes the heuristics for when to merge two dives together into a
single dive. We used to just look at the date, and say "if they're
within one minute of each other, try to merge". This looks at the
actual dive data, and tries to see just how much sense it makes to
merge the dive.
It also checks if the dives to be merged use different dive computers,
and if so relaxes the one minute to five, since most people aren't
quite as OCD as I am, and don't tend to set their dive computers quite
that exactly to the same time and date.
I'm sure people can come up with other heuristics, but this should
make that easier too.
NOTE! If you have things like wrong timezones etc, and the
divecomputer dates are thus off by hours rather than by a couple of
minutes, this will still not merge them. For that kind of situation,
we'd need some kind of manual merge option. Note that that is *not*
the same as the current "merge two adjacent dives" together, which
joins two separate dives into one *longer* dive with a surface
interval in between.
That kind of manual merge UI makes sense, but is independent of this
partical change.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-12-04 20:26:28 +00:00
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2012-12-16 18:55:58 +00:00
|
|
|
/*
|
|
|
|
* Match every dive computer against each other to see if
|
|
|
|
* we have a matching dive.
|
|
|
|
*
|
|
|
|
* Return values:
|
|
|
|
* -1 for "is definitely *NOT* the same dive"
|
|
|
|
* 0 for "don't know"
|
|
|
|
* 1 for "is definitely the same dive"
|
|
|
|
*/
|
2018-08-23 17:18:43 +00:00
|
|
|
static int match_dc_dive(const struct divecomputer *a, const struct divecomputer *b)
|
2012-12-16 18:55:58 +00:00
|
|
|
{
|
|
|
|
do {
|
2018-08-23 17:18:43 +00:00
|
|
|
const struct divecomputer *tmp = b;
|
2012-12-16 18:55:58 +00:00
|
|
|
do {
|
|
|
|
int match = match_one_dc(a, tmp);
|
|
|
|
if (match)
|
|
|
|
return match;
|
|
|
|
tmp = tmp->next;
|
|
|
|
} while (tmp);
|
|
|
|
a = a->next;
|
|
|
|
} while (a);
|
Improve automatic dive merging logic
This tunes the heuristics for when to merge two dives together into a
single dive. We used to just look at the date, and say "if they're
within one minute of each other, try to merge". This looks at the
actual dive data, and tries to see just how much sense it makes to
merge the dive.
It also checks if the dives to be merged use different dive computers,
and if so relaxes the one minute to five, since most people aren't
quite as OCD as I am, and don't tend to set their dive computers quite
that exactly to the same time and date.
I'm sure people can come up with other heuristics, but this should
make that easier too.
NOTE! If you have things like wrong timezones etc, and the
divecomputer dates are thus off by hours rather than by a couple of
minutes, this will still not merge them. For that kind of situation,
we'd need some kind of manual merge option. Note that that is *not*
the same as the current "merge two adjacent dives" together, which
joins two separate dives into one *longer* dive with a surface
interval in between.
That kind of manual merge UI makes sense, but is independent of this
partical change.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-12-04 20:26:28 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Do we want to automatically try to merge two dives that
|
|
|
|
* look like they are the same dive?
|
|
|
|
*
|
|
|
|
* This happens quite commonly because you download a dive
|
|
|
|
* that you already had, or perhaps because you maintained
|
|
|
|
* multiple dive logs and want to load them all together
|
|
|
|
* (possibly one of them was imported from another dive log
|
|
|
|
* application entirely).
|
|
|
|
*
|
|
|
|
* NOTE! We mainly look at the dive time, but it can differ
|
|
|
|
* between two dives due to a few issues:
|
|
|
|
*
|
|
|
|
* - rounding the dive date to the nearest minute in other dive
|
|
|
|
* applications
|
|
|
|
*
|
|
|
|
* - dive computers with "relative datestamps" (ie the dive
|
|
|
|
* computer doesn't actually record an absolute date at all,
|
2015-11-15 18:15:40 +00:00
|
|
|
* but instead at download-time synchronizes its internal
|
Improve automatic dive merging logic
This tunes the heuristics for when to merge two dives together into a
single dive. We used to just look at the date, and say "if they're
within one minute of each other, try to merge". This looks at the
actual dive data, and tries to see just how much sense it makes to
merge the dive.
It also checks if the dives to be merged use different dive computers,
and if so relaxes the one minute to five, since most people aren't
quite as OCD as I am, and don't tend to set their dive computers quite
that exactly to the same time and date.
I'm sure people can come up with other heuristics, but this should
make that easier too.
NOTE! If you have things like wrong timezones etc, and the
divecomputer dates are thus off by hours rather than by a couple of
minutes, this will still not merge them. For that kind of situation,
we'd need some kind of manual merge option. Note that that is *not*
the same as the current "merge two adjacent dives" together, which
joins two separate dives into one *longer* dive with a surface
interval in between.
That kind of manual merge UI makes sense, but is independent of this
partical change.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-12-04 20:26:28 +00:00
|
|
|
* time with real-time on the downloading computer)
|
|
|
|
*
|
|
|
|
* - using multiple dive computers with different real time on
|
|
|
|
* the same dive
|
|
|
|
*
|
|
|
|
* We do not merge dives that look radically different, and if
|
|
|
|
* the dates are *too* far off the user will have to join two
|
|
|
|
* dives together manually. But this tries to handle the sane
|
|
|
|
* cases.
|
|
|
|
*/
|
2018-08-23 17:18:43 +00:00
|
|
|
static int likely_same_dive(const struct dive *a, const struct dive *b)
|
Improve automatic dive merging logic
This tunes the heuristics for when to merge two dives together into a
single dive. We used to just look at the date, and say "if they're
within one minute of each other, try to merge". This looks at the
actual dive data, and tries to see just how much sense it makes to
merge the dive.
It also checks if the dives to be merged use different dive computers,
and if so relaxes the one minute to five, since most people aren't
quite as OCD as I am, and don't tend to set their dive computers quite
that exactly to the same time and date.
I'm sure people can come up with other heuristics, but this should
make that easier too.
NOTE! If you have things like wrong timezones etc, and the
divecomputer dates are thus off by hours rather than by a couple of
minutes, this will still not merge them. For that kind of situation,
we'd need some kind of manual merge option. Note that that is *not*
the same as the current "merge two adjacent dives" together, which
joins two separate dives into one *longer* dive with a surface
interval in between.
That kind of manual merge UI makes sense, but is independent of this
partical change.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-12-04 20:26:28 +00:00
|
|
|
{
|
2013-01-23 19:53:42 +00:00
|
|
|
int match, fuzz = 20 * 60;
|
Improve automatic dive merging logic
This tunes the heuristics for when to merge two dives together into a
single dive. We used to just look at the date, and say "if they're
within one minute of each other, try to merge". This looks at the
actual dive data, and tries to see just how much sense it makes to
merge the dive.
It also checks if the dives to be merged use different dive computers,
and if so relaxes the one minute to five, since most people aren't
quite as OCD as I am, and don't tend to set their dive computers quite
that exactly to the same time and date.
I'm sure people can come up with other heuristics, but this should
make that easier too.
NOTE! If you have things like wrong timezones etc, and the
divecomputer dates are thus off by hours rather than by a couple of
minutes, this will still not merge them. For that kind of situation,
we'd need some kind of manual merge option. Note that that is *not*
the same as the current "merge two adjacent dives" together, which
joins two separate dives into one *longer* dive with a surface
interval in between.
That kind of manual merge UI makes sense, but is independent of this
partical change.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-12-04 20:26:28 +00:00
|
|
|
|
2015-09-30 11:45:55 +00:00
|
|
|
/* don't merge manually added dives with anything */
|
|
|
|
if (same_string(a->dc.model, "manually added dive") ||
|
|
|
|
same_string(b->dc.model, "manually added dive"))
|
|
|
|
return 0;
|
|
|
|
|
Improve automatic dive merging logic
This tunes the heuristics for when to merge two dives together into a
single dive. We used to just look at the date, and say "if they're
within one minute of each other, try to merge". This looks at the
actual dive data, and tries to see just how much sense it makes to
merge the dive.
It also checks if the dives to be merged use different dive computers,
and if so relaxes the one minute to five, since most people aren't
quite as OCD as I am, and don't tend to set their dive computers quite
that exactly to the same time and date.
I'm sure people can come up with other heuristics, but this should
make that easier too.
NOTE! If you have things like wrong timezones etc, and the
divecomputer dates are thus off by hours rather than by a couple of
minutes, this will still not merge them. For that kind of situation,
we'd need some kind of manual merge option. Note that that is *not*
the same as the current "merge two adjacent dives" together, which
joins two separate dives into one *longer* dive with a surface
interval in between.
That kind of manual merge UI makes sense, but is independent of this
partical change.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-12-04 20:26:28 +00:00
|
|
|
/*
|
|
|
|
* Do some basic sanity testing of the values we
|
|
|
|
* have filled in during 'fixup_dive()'
|
|
|
|
*/
|
2013-02-09 15:12:30 +00:00
|
|
|
if (!similar(a->maxdepth.mm, b->maxdepth.mm, 1000) ||
|
2013-02-16 17:04:03 +00:00
|
|
|
(a->meandepth.mm && b->meandepth.mm && !similar(a->meandepth.mm, b->meandepth.mm, 1000)) ||
|
2017-09-10 08:39:25 +00:00
|
|
|
!a->duration.seconds || !b->duration.seconds ||
|
2014-02-28 04:09:57 +00:00
|
|
|
!similar(a->duration.seconds, b->duration.seconds, 5 * 60))
|
Improve automatic dive merging logic
This tunes the heuristics for when to merge two dives together into a
single dive. We used to just look at the date, and say "if they're
within one minute of each other, try to merge". This looks at the
actual dive data, and tries to see just how much sense it makes to
merge the dive.
It also checks if the dives to be merged use different dive computers,
and if so relaxes the one minute to five, since most people aren't
quite as OCD as I am, and don't tend to set their dive computers quite
that exactly to the same time and date.
I'm sure people can come up with other heuristics, but this should
make that easier too.
NOTE! If you have things like wrong timezones etc, and the
divecomputer dates are thus off by hours rather than by a couple of
minutes, this will still not merge them. For that kind of situation,
we'd need some kind of manual merge option. Note that that is *not*
the same as the current "merge two adjacent dives" together, which
joins two separate dives into one *longer* dive with a surface
interval in between.
That kind of manual merge UI makes sense, but is independent of this
partical change.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-12-04 20:26:28 +00:00
|
|
|
return 0;
|
|
|
|
|
2012-12-16 18:55:58 +00:00
|
|
|
/* See if we can get an exact match on the dive computer */
|
|
|
|
match = match_dc_dive(&a->dc, &b->dc);
|
|
|
|
if (match)
|
|
|
|
return match > 0;
|
|
|
|
|
Improve automatic dive merging logic
This tunes the heuristics for when to merge two dives together into a
single dive. We used to just look at the date, and say "if they're
within one minute of each other, try to merge". This looks at the
actual dive data, and tries to see just how much sense it makes to
merge the dive.
It also checks if the dives to be merged use different dive computers,
and if so relaxes the one minute to five, since most people aren't
quite as OCD as I am, and don't tend to set their dive computers quite
that exactly to the same time and date.
I'm sure people can come up with other heuristics, but this should
make that easier too.
NOTE! If you have things like wrong timezones etc, and the
divecomputer dates are thus off by hours rather than by a couple of
minutes, this will still not merge them. For that kind of situation,
we'd need some kind of manual merge option. Note that that is *not*
the same as the current "merge two adjacent dives" together, which
joins two separate dives into one *longer* dive with a surface
interval in between.
That kind of manual merge UI makes sense, but is independent of this
partical change.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-12-04 20:26:28 +00:00
|
|
|
/*
|
2012-12-16 18:55:58 +00:00
|
|
|
* Allow a time difference due to dive computer time
|
|
|
|
* setting etc. Check if they overlap.
|
Improve automatic dive merging logic
This tunes the heuristics for when to merge two dives together into a
single dive. We used to just look at the date, and say "if they're
within one minute of each other, try to merge". This looks at the
actual dive data, and tries to see just how much sense it makes to
merge the dive.
It also checks if the dives to be merged use different dive computers,
and if so relaxes the one minute to five, since most people aren't
quite as OCD as I am, and don't tend to set their dive computers quite
that exactly to the same time and date.
I'm sure people can come up with other heuristics, but this should
make that easier too.
NOTE! If you have things like wrong timezones etc, and the
divecomputer dates are thus off by hours rather than by a couple of
minutes, this will still not merge them. For that kind of situation,
we'd need some kind of manual merge option. Note that that is *not*
the same as the current "merge two adjacent dives" together, which
joins two separate dives into one *longer* dive with a surface
interval in between.
That kind of manual merge UI makes sense, but is independent of this
partical change.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-12-04 20:26:28 +00:00
|
|
|
*/
|
2013-02-09 15:12:30 +00:00
|
|
|
fuzz = MAX(a->duration.seconds, b->duration.seconds) / 2;
|
2012-12-16 18:55:58 +00:00
|
|
|
if (fuzz < 60)
|
|
|
|
fuzz = 60;
|
Improve automatic dive merging logic
This tunes the heuristics for when to merge two dives together into a
single dive. We used to just look at the date, and say "if they're
within one minute of each other, try to merge". This looks at the
actual dive data, and tries to see just how much sense it makes to
merge the dive.
It also checks if the dives to be merged use different dive computers,
and if so relaxes the one minute to five, since most people aren't
quite as OCD as I am, and don't tend to set their dive computers quite
that exactly to the same time and date.
I'm sure people can come up with other heuristics, but this should
make that easier too.
NOTE! If you have things like wrong timezones etc, and the
divecomputer dates are thus off by hours rather than by a couple of
minutes, this will still not merge them. For that kind of situation,
we'd need some kind of manual merge option. Note that that is *not*
the same as the current "merge two adjacent dives" together, which
joins two separate dives into one *longer* dive with a surface
interval in between.
That kind of manual merge UI makes sense, but is independent of this
partical change.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-12-04 20:26:28 +00:00
|
|
|
|
2018-02-17 20:21:16 +00:00
|
|
|
return (a->when <= b->when + fuzz) && (a->when >= b->when - fuzz);
|
Improve automatic dive merging logic
This tunes the heuristics for when to merge two dives together into a
single dive. We used to just look at the date, and say "if they're
within one minute of each other, try to merge". This looks at the
actual dive data, and tries to see just how much sense it makes to
merge the dive.
It also checks if the dives to be merged use different dive computers,
and if so relaxes the one minute to five, since most people aren't
quite as OCD as I am, and don't tend to set their dive computers quite
that exactly to the same time and date.
I'm sure people can come up with other heuristics, but this should
make that easier too.
NOTE! If you have things like wrong timezones etc, and the
divecomputer dates are thus off by hours rather than by a couple of
minutes, this will still not merge them. For that kind of situation,
we'd need some kind of manual merge option. Note that that is *not*
the same as the current "merge two adjacent dives" together, which
joins two separate dives into one *longer* dive with a surface
interval in between.
That kind of manual merge UI makes sense, but is independent of this
partical change.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2012-12-04 20:26:28 +00:00
|
|
|
}
|
|
|
|
|
2011-09-03 20:19:26 +00:00
|
|
|
/*
|
|
|
|
* This could do a lot more merging. Right now it really only
|
|
|
|
* merges almost exact duplicates - something that happens easily
|
|
|
|
* with overlapping dive downloads.
|
2018-10-03 19:32:28 +00:00
|
|
|
*
|
|
|
|
* If new dives are merged into the dive table, dive a is supposed to
|
|
|
|
* be the old dive and dive b is supposed to be the newly imported
|
|
|
|
* dive. If the flag "prefer_downloaded" is set, data of the latter
|
|
|
|
* will take priority over the former.
|
2019-03-05 21:58:47 +00:00
|
|
|
*
|
|
|
|
* Attn: The dive_site parameter of the dive will be set, but the caller
|
|
|
|
* still has to register the dive in the dive site!
|
2011-09-03 20:19:26 +00:00
|
|
|
*/
|
2013-10-05 07:29:09 +00:00
|
|
|
struct dive *try_to_merge(struct dive *a, struct dive *b, bool prefer_downloaded)
|
2011-09-03 20:19:26 +00:00
|
|
|
{
|
2019-03-05 21:58:47 +00:00
|
|
|
struct dive *res;
|
|
|
|
struct dive_site *site;
|
|
|
|
|
|
|
|
if (!likely_same_dive(a, b))
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
res = merge_dives(a, b, 0, prefer_downloaded, NULL, &site);
|
|
|
|
res->dive_site = site; /* Caller has to call add_dive_to_dive_site()! */
|
|
|
|
return res;
|
2012-11-25 04:29:14 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static int same_sample(struct sample *a, struct sample *b)
|
|
|
|
{
|
|
|
|
if (a->time.seconds != b->time.seconds)
|
|
|
|
return 0;
|
|
|
|
if (a->depth.mm != b->depth.mm)
|
|
|
|
return 0;
|
|
|
|
if (a->temperature.mkelvin != b->temperature.mkelvin)
|
|
|
|
return 0;
|
2017-07-20 21:39:02 +00:00
|
|
|
if (a->pressure[0].mbar != b->pressure[0].mbar)
|
2012-11-25 04:29:14 +00:00
|
|
|
return 0;
|
Start cleaning up sensor indexing for multiple sensors
This is a very timid start at making us actually use multiple sensors
without the magical special case for just CCR oxygen tracking.
It mainly does:
- turn the "sample->sensor" index into an array of two indexes, to
match the pressures themselves.
- get rid of dive->{oxygen_cylinder_index,diluent_cylinder_index},
since a CCR dive should now simply set the sample->sensor[] indices
correctly instead.
- in a couple of places, start actually looping over the sensors rather
than special-case the O2 case (although often the small "loops" are
just unrolled, since it's just two cases.
but in many cases we still end up only covering the zero sensor case,
because the CCR O2 sensor code coverage was fairly limited.
It's entirely possible (even likely) that this migth break some existing
case: it tries to be a fairly direct ("stupid") translation of the old
code, but unlike the preparatory patch this does actually does change
some semantics.
For example, right now the git loader code assumes that if the git save
data contains a o2pressure entry, it just hardcodes the O2 sensor index
to 1.
In fact, one issue is going to simply be that our file formats do not
have that multiple sensor format, but instead had very clearly encoded
things as being the CCR O2 pressure sensor.
But this is hopefully close to usable, and I will need feedback (and
maybe test cases) from people who have existing CCR dives with pressure
data.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2017-07-21 02:49:45 +00:00
|
|
|
return a->sensor[0] == b->sensor[0];
|
2012-11-25 04:29:14 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static int same_dc(struct divecomputer *a, struct divecomputer *b)
|
|
|
|
{
|
|
|
|
int i;
|
2018-08-16 22:58:30 +00:00
|
|
|
const struct event *eva, *evb;
|
2012-11-25 04:29:14 +00:00
|
|
|
|
2012-12-16 20:33:37 +00:00
|
|
|
i = match_one_dc(a, b);
|
|
|
|
if (i)
|
|
|
|
return i > 0;
|
|
|
|
|
2012-11-25 04:29:14 +00:00
|
|
|
if (a->when && b->when && a->when != b->when)
|
|
|
|
return 0;
|
|
|
|
if (a->samples != b->samples)
|
|
|
|
return 0;
|
|
|
|
for (i = 0; i < a->samples; i++)
|
2014-02-28 04:09:57 +00:00
|
|
|
if (!same_sample(a->sample + i, b->sample + i))
|
2012-11-25 04:29:14 +00:00
|
|
|
return 0;
|
|
|
|
eva = a->events;
|
|
|
|
evb = b->events;
|
|
|
|
while (eva && evb) {
|
|
|
|
if (!same_event(eva, evb))
|
|
|
|
return 0;
|
|
|
|
eva = eva->next;
|
|
|
|
evb = evb->next;
|
|
|
|
}
|
|
|
|
return eva == evb;
|
|
|
|
}
|
|
|
|
|
2018-08-23 17:18:43 +00:00
|
|
|
static int might_be_same_device(const struct divecomputer *a, const struct divecomputer *b)
|
2013-01-23 00:57:07 +00:00
|
|
|
{
|
|
|
|
/* No dive computer model? That matches anything */
|
|
|
|
if (!a->model || !b->model)
|
|
|
|
return 1;
|
|
|
|
|
|
|
|
/* Otherwise at least the model names have to match */
|
|
|
|
if (strcasecmp(a->model, b->model))
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
/* No device ID? Match */
|
|
|
|
if (!a->deviceid || !b->deviceid)
|
|
|
|
return 1;
|
|
|
|
|
|
|
|
return a->deviceid == b->deviceid;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void remove_redundant_dc(struct divecomputer *dc, int prefer_downloaded)
|
2012-11-25 04:29:14 +00:00
|
|
|
{
|
|
|
|
do {
|
|
|
|
struct divecomputer **p = &dc->next;
|
|
|
|
|
|
|
|
/* Check this dc against all the following ones.. */
|
|
|
|
while (*p) {
|
|
|
|
struct divecomputer *check = *p;
|
2013-01-23 00:57:07 +00:00
|
|
|
if (same_dc(dc, check) || (prefer_downloaded && might_be_same_device(dc, check))) {
|
2012-11-25 04:29:14 +00:00
|
|
|
*p = check->next;
|
|
|
|
check->next = NULL;
|
|
|
|
free_dc(check);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
p = &check->next;
|
|
|
|
}
|
|
|
|
|
2013-01-23 00:57:07 +00:00
|
|
|
/* .. and then continue down the chain, but we */
|
|
|
|
prefer_downloaded = 0;
|
2012-11-25 04:29:14 +00:00
|
|
|
dc = dc->next;
|
|
|
|
} while (dc);
|
2012-11-11 06:20:05 +00:00
|
|
|
}
|
|
|
|
|
2018-08-13 02:47:07 +00:00
|
|
|
static const struct divecomputer *find_matching_computer(const struct divecomputer *match, const struct divecomputer *list)
|
2012-11-25 20:39:08 +00:00
|
|
|
{
|
2018-08-13 02:47:07 +00:00
|
|
|
const struct divecomputer *p;
|
2012-11-25 20:39:08 +00:00
|
|
|
|
|
|
|
while ((p = list) != NULL) {
|
|
|
|
list = list->next;
|
|
|
|
|
2013-01-23 00:57:07 +00:00
|
|
|
if (might_be_same_device(match, p))
|
2012-11-25 20:39:08 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
return p;
|
|
|
|
}
|
|
|
|
|
2018-08-23 17:18:43 +00:00
|
|
|
static void copy_dive_computer(struct divecomputer *res, const struct divecomputer *a)
|
2013-02-04 05:21:47 +00:00
|
|
|
{
|
|
|
|
*res = *a;
|
2014-07-03 04:05:22 +00:00
|
|
|
res->model = copy_string(a->model);
|
2018-10-16 05:50:38 +00:00
|
|
|
res->serial = copy_string(a->serial);
|
|
|
|
res->fw_version = copy_string(a->fw_version);
|
2018-10-16 05:41:48 +00:00
|
|
|
STRUCTURED_LIST_COPY(struct extra_data, a->extra_data, res->extra_data, copy_extra_data);
|
2013-02-04 05:21:47 +00:00
|
|
|
res->samples = res->alloc_samples = 0;
|
|
|
|
res->sample = NULL;
|
|
|
|
res->events = NULL;
|
|
|
|
res->next = NULL;
|
|
|
|
}
|
|
|
|
|
2012-11-25 20:39:08 +00:00
|
|
|
/*
|
|
|
|
* Join dive computers with a specific time offset between
|
|
|
|
* them.
|
|
|
|
*
|
|
|
|
* Use the dive computer ID's (or names, if ID's are missing)
|
|
|
|
* to match them up. If we find a matching dive computer, we
|
|
|
|
* merge them. If not, we just take the data from 'a'.
|
|
|
|
*/
|
2018-08-13 02:47:07 +00:00
|
|
|
static void interleave_dive_computers(struct dive *d, struct divecomputer *res,
|
|
|
|
const struct divecomputer *a, const struct divecomputer *b,
|
|
|
|
const int cylinders_map_a[], const int cylinders_map_b[],
|
|
|
|
int offset)
|
2012-11-25 20:39:08 +00:00
|
|
|
{
|
|
|
|
do {
|
2018-08-13 02:47:07 +00:00
|
|
|
const struct divecomputer *match;
|
2012-11-25 20:39:08 +00:00
|
|
|
|
2013-02-04 05:21:47 +00:00
|
|
|
copy_dive_computer(res, a);
|
2012-11-25 20:39:08 +00:00
|
|
|
|
|
|
|
match = find_matching_computer(a, b);
|
|
|
|
if (match) {
|
2018-08-13 02:47:07 +00:00
|
|
|
merge_events(d, res, a, match, cylinders_map_a, cylinders_map_b, offset);
|
|
|
|
merge_samples(res, a, match, cylinders_map_a, cylinders_map_b, offset);
|
2019-04-06 21:29:42 +00:00
|
|
|
merge_extra_data(res, a, match);
|
2014-05-20 05:01:40 +00:00
|
|
|
/* Use the diveid of the later dive! */
|
|
|
|
if (offset > 0)
|
|
|
|
res->diveid = match->diveid;
|
2012-11-25 20:39:08 +00:00
|
|
|
} else {
|
2018-08-13 02:47:07 +00:00
|
|
|
copy_dc_renumber(d, a, res, cylinders_map_a);
|
2012-11-25 20:39:08 +00:00
|
|
|
}
|
|
|
|
a = a->next;
|
|
|
|
if (!a)
|
|
|
|
break;
|
|
|
|
res->next = calloc(1, sizeof(struct divecomputer));
|
|
|
|
res = res->next;
|
|
|
|
} while (res);
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Join dive computer information.
|
|
|
|
*
|
|
|
|
* If we have old-style dive computer information (no model
|
|
|
|
* name etc), we will prefer a new-style one and just throw
|
|
|
|
* away the old. We're assuming it's a re-download.
|
|
|
|
*
|
2013-01-23 00:57:07 +00:00
|
|
|
* Otherwise, we'll just try to keep all the information,
|
|
|
|
* unless the user has specified that they prefer the
|
|
|
|
* downloaded computer, in which case we'll aggressively
|
|
|
|
* try to throw out old information that *might* be from
|
|
|
|
* that one.
|
2012-11-25 20:39:08 +00:00
|
|
|
*/
|
2018-08-13 02:47:07 +00:00
|
|
|
static void join_dive_computers(struct dive *d, struct divecomputer *res,
|
|
|
|
const struct divecomputer *a, const struct divecomputer *b,
|
|
|
|
const int cylinders_map_a[], const int cylinders_map_b[],
|
|
|
|
int prefer_downloaded)
|
2012-11-25 20:39:08 +00:00
|
|
|
{
|
2012-12-16 20:33:37 +00:00
|
|
|
struct divecomputer *tmp;
|
|
|
|
|
2012-11-25 20:39:08 +00:00
|
|
|
if (a->model && !b->model) {
|
2018-08-13 02:47:07 +00:00
|
|
|
copy_dc_renumber(d, a, res, cylinders_map_a);
|
2012-11-25 20:39:08 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
if (b->model && !a->model) {
|
2018-08-13 02:47:07 +00:00
|
|
|
copy_dc_renumber(d, b, res, cylinders_map_b);
|
2012-11-25 20:39:08 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2018-08-13 02:47:07 +00:00
|
|
|
copy_dc_renumber(d, a, res, cylinders_map_a);
|
2012-12-16 20:33:37 +00:00
|
|
|
tmp = res;
|
|
|
|
while (tmp->next)
|
|
|
|
tmp = tmp->next;
|
2012-11-25 20:39:08 +00:00
|
|
|
|
2012-12-16 20:33:37 +00:00
|
|
|
tmp->next = calloc(1, sizeof(*tmp));
|
2018-08-13 02:47:07 +00:00
|
|
|
copy_dc_renumber(d, b, tmp->next, cylinders_map_b);
|
2012-11-25 20:39:08 +00:00
|
|
|
|
2013-01-23 00:57:07 +00:00
|
|
|
remove_redundant_dc(res, prefer_downloaded);
|
2012-11-25 20:39:08 +00:00
|
|
|
}
|
|
|
|
|
2019-01-01 17:49:56 +00:00
|
|
|
// Does this dive have a dive computer for which is_dc_planner has value planned
|
2019-05-30 15:36:44 +00:00
|
|
|
bool has_planned(const struct dive *dive, bool planned)
|
|
|
|
{
|
2019-01-01 17:49:56 +00:00
|
|
|
const struct divecomputer *dc = &dive->dc;
|
|
|
|
|
|
|
|
while (dc) {
|
|
|
|
if (is_dc_planner(&dive->dc) == planned)
|
|
|
|
return true;
|
|
|
|
dc = dc->next;
|
|
|
|
}
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2015-09-22 19:32:27 +00:00
|
|
|
/*
|
|
|
|
* Merging two dives can be subtle, because there's two different ways
|
|
|
|
* of merging:
|
|
|
|
*
|
|
|
|
* (a) two distinctly _different_ dives that have the same dive computer
|
|
|
|
* are merged into one longer dive, because the user asked for it
|
|
|
|
* in the divelist.
|
|
|
|
*
|
2015-11-15 18:15:40 +00:00
|
|
|
* Because this case is with the same dive computer, we *know* the
|
2015-09-22 19:32:27 +00:00
|
|
|
* two must have a different start time, and "offset" is the relative
|
|
|
|
* time difference between the two.
|
|
|
|
*
|
2018-10-03 19:32:28 +00:00
|
|
|
* (b) two different dive computers that we might want to merge into
|
2015-09-22 19:32:27 +00:00
|
|
|
* one single dive with multiple dive computers.
|
|
|
|
*
|
|
|
|
* This is the "try_to_merge()" case, which will have offset == 0,
|
2015-11-16 09:42:36 +00:00
|
|
|
* even if the dive times might be different.
|
2018-10-03 19:32:28 +00:00
|
|
|
*
|
|
|
|
* If new dives are merged into the dive table, dive a is supposed to
|
|
|
|
* be the old dive and dive b is supposed to be the newly imported
|
|
|
|
* dive. If the flag "prefer_downloaded" is set, data of the latter
|
|
|
|
* will take priority over the former.
|
2018-07-21 16:28:33 +00:00
|
|
|
*
|
|
|
|
* The trip the new dive should be associated with (if any) is returned
|
2019-03-05 21:58:47 +00:00
|
|
|
* in the "trip" output parameter.
|
|
|
|
*
|
|
|
|
* The dive site the new dive should be added to (if any) is returned
|
|
|
|
* in the "dive_site" output parameter.
|
2015-09-22 19:32:27 +00:00
|
|
|
*/
|
2019-03-05 21:58:47 +00:00
|
|
|
struct dive *merge_dives(const struct dive *a, const struct dive *b, int offset, bool prefer_downloaded, struct dive_trip **trip, struct dive_site **site)
|
2012-11-11 06:20:05 +00:00
|
|
|
{
|
|
|
|
struct dive *res = alloc_dive();
|
2019-06-27 20:03:53 +00:00
|
|
|
int *cylinders_map_a, *cylinders_map_b;
|
2011-09-03 20:19:26 +00:00
|
|
|
|
2015-09-22 19:32:27 +00:00
|
|
|
if (offset) {
|
|
|
|
/*
|
|
|
|
* If "likely_same_dive()" returns true, that means that
|
|
|
|
* it is *not* the same dive computer, and we do not want
|
|
|
|
* to try to turn it into a single longer dive. So we'd
|
|
|
|
* join them as two separate dive computers at zero offset.
|
|
|
|
*/
|
|
|
|
if (likely_same_dive(a, b))
|
|
|
|
offset = 0;
|
2012-11-21 23:34:04 +00:00
|
|
|
}
|
2014-01-11 07:46:05 +00:00
|
|
|
|
2019-01-01 17:02:04 +00:00
|
|
|
if (is_dc_planner(&a->dc)) {
|
2018-08-13 02:47:07 +00:00
|
|
|
const struct dive *tmp = a;
|
2017-02-02 14:31:52 +00:00
|
|
|
a = b;
|
|
|
|
b = tmp;
|
|
|
|
}
|
2018-10-03 19:32:28 +00:00
|
|
|
res->when = prefer_downloaded ? b->when : a->when;
|
2012-11-11 10:00:27 +00:00
|
|
|
res->selected = a->selected || b->selected;
|
2018-07-21 16:28:33 +00:00
|
|
|
if (trip)
|
2018-12-23 11:46:45 +00:00
|
|
|
*trip = get_preferred_trip(a, b);
|
2017-11-27 18:39:10 +00:00
|
|
|
MERGE_TXT(res, a, b, notes, "\n--\n");
|
|
|
|
MERGE_TXT(res, a, b, buddy, ", ");
|
|
|
|
MERGE_TXT(res, a, b, divemaster, ", ");
|
2011-12-07 19:58:16 +00:00
|
|
|
MERGE_MAX(res, a, b, rating);
|
2017-11-27 18:39:10 +00:00
|
|
|
MERGE_TXT(res, a, b, suit, ", ");
|
Be smarter about dive renumbering when merging dives
We really have two different cases for merging dives:
(a) downloading a new dive from a dive computer, and merging it with an
existing dive that we had already created using a different dive
computer. This is the "try_to_merge()" case, called from
"process_dives()
(b) merging two different dives into one longer dive. This is the
"merge_two_dives()" case when you explicitly merge dives using the
divelist.
While a lot of the issues are the same, many details differ, and one of
the details is how dive numbering should be handled.
In particular, when you download from a dive computer and merge with an
existing dive, you want too take the *maximum* dive number, because the
dive computer notion of which dive it is may well not match what the
user dive number is.
On the other hand, when you explicitly merge in the dive list, you end
up renumbering not just the dive you are merging, but also all
subsequent dives, since you now have one fewer dives overall. So that
case already has to be handled by the caller.
Now, the simpler "download from dive computer" case was broken by commit
ce3a78efcac2 ("Assign lower number to a merged dive instead of higher
one"). It fixed the numbering for the divelist case, but broke the
download case.
So this commit reverts commit ce3a78efcac2, and instead extends and
clarifies the dive renumbering that "merge_two_dives()" already did. It
now explicitly renumbers not just the following dives, but also
renumbers the merged dive itself, so now we can go back to the old "take
the bigger dive number" for the core merging, which fixes the download
case.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2016-03-30 19:42:27 +00:00
|
|
|
MERGE_MAX(res, a, b, number);
|
2012-12-11 20:30:34 +00:00
|
|
|
MERGE_NONZERO(res, a, b, cns);
|
2012-11-10 18:18:10 +00:00
|
|
|
MERGE_NONZERO(res, a, b, visibility);
|
2020-04-11 15:41:56 +00:00
|
|
|
copy_pictures(a->pictures.nr ? &a->pictures : &b->pictures, &res->pictures);
|
Get rid of crazy empty tag_list element at the start
So this is totally unrelated to the git repository format, except for
the fact that I noticed it while writing the git saving code.
The subsurface divetag list handling is being stupid, and has a
initial dummy entry at the head of the list for no good reason.
I say "no good reason", because there *is* a reason for it: it allows
code to avoid the special case of empty list and adding entries to
before the first entry etc etc. But that reason is a really *bad*
reason, because it's valid only because people don't understand basic
list manipulation and pointers to pointers.
So get rid of the dummy element, and do things right instead - by
passing a *pointer* to the list, instead of the list. And then when
traversing the list and looking for a place to insert things, don't go
to the next entry - just update the "pointer to pointer" to point to
the address of the next entry. Each entry in a C linked list is no
different than the list itself, so you can use the pointer to the
pointer to the next entry as a pointer to the list.
This is a pet peeve of mine. The real beauty of pointers can never be
understood unless you understand the indirection they allow. People
who grew up with Pascal and were corrupted by that mindset are
mentally stunted. Niklaus Wirth has a lot to answer for!
But never fear. You too can overcome that mental limitation, it just
needs some brain exercise. Reading this patch may help. In particular,
contemplate the new "taglist_add_divetag()".
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
2014-03-10 17:18:13 +00:00
|
|
|
taglist_merge(&res->tag_list, a->tag_list, b->tag_list);
|
2019-08-04 16:44:57 +00:00
|
|
|
cylinders_map_a = malloc(a->cylinders.nr * sizeof(*cylinders_map_a));
|
|
|
|
cylinders_map_b = malloc(b->cylinders.nr * sizeof(*cylinders_map_b));
|
2018-08-13 02:47:07 +00:00
|
|
|
merge_cylinders(res, a, b, cylinders_map_a, cylinders_map_b);
|
2012-10-29 18:27:14 +00:00
|
|
|
merge_equipment(res, a, b);
|
2017-02-19 20:56:54 +00:00
|
|
|
merge_temperatures(res, a, b);
|
2018-10-03 19:32:28 +00:00
|
|
|
if (prefer_downloaded) {
|
2013-01-23 00:57:07 +00:00
|
|
|
/* If we prefer downloaded, do those first, and get rid of "might be same" computers */
|
2018-10-15 19:58:30 +00:00
|
|
|
join_dive_computers(res, &res->dc, &b->dc, &a->dc, cylinders_map_b, cylinders_map_a, 1);
|
2014-05-14 04:08:06 +00:00
|
|
|
} else if (offset && might_be_same_device(&a->dc, &b->dc))
|
2018-08-13 02:47:07 +00:00
|
|
|
interleave_dive_computers(res, &res->dc, &a->dc, &b->dc, cylinders_map_a, cylinders_map_b, offset);
|
2012-11-25 20:39:08 +00:00
|
|
|
else
|
2018-08-13 02:47:07 +00:00
|
|
|
join_dive_computers(res, &res->dc, &a->dc, &b->dc, cylinders_map_a, cylinders_map_b, 0);
|
|
|
|
|
2017-02-22 02:18:44 +00:00
|
|
|
/* we take the first dive site, unless it's empty */
|
2019-03-05 21:58:47 +00:00
|
|
|
*site = a->dive_site && !dive_site_is_empty(a->dive_site) ? a->dive_site : b->dive_site;
|
2012-11-24 02:51:27 +00:00
|
|
|
fixup_dive(res);
|
2019-06-27 20:03:53 +00:00
|
|
|
free(cylinders_map_a);
|
|
|
|
free(cylinders_map_b);
|
2012-11-24 02:51:27 +00:00
|
|
|
return res;
|
2011-09-03 20:19:26 +00:00
|
|
|
}
|
2013-01-31 03:09:16 +00:00
|
|
|
|
2015-10-02 01:17:37 +00:00
|
|
|
// copy_dive(), but retaining the new ID for the copied dive
|
2018-07-20 18:26:06 +00:00
|
|
|
static struct dive *create_new_copy(const struct dive *from)
|
2015-10-02 01:17:37 +00:00
|
|
|
{
|
|
|
|
struct dive *to = alloc_dive();
|
|
|
|
int id;
|
|
|
|
|
|
|
|
// alloc_dive() gave us a new ID, we just need to
|
|
|
|
// make sure it's not overwritten.
|
|
|
|
id = to->id;
|
|
|
|
copy_dive(from, to);
|
|
|
|
to->id = id;
|
|
|
|
return to;
|
|
|
|
}
|
|
|
|
|
2019-06-27 20:03:53 +00:00
|
|
|
struct start_end_pressure {
|
|
|
|
pressure_t start;
|
|
|
|
pressure_t end;
|
|
|
|
};
|
|
|
|
|
2015-10-06 15:41:36 +00:00
|
|
|
static void force_fixup_dive(struct dive *d)
|
|
|
|
{
|
|
|
|
struct divecomputer *dc = &d->dc;
|
|
|
|
int old_temp = dc->watertemp.mkelvin;
|
|
|
|
int old_mintemp = d->mintemp.mkelvin;
|
|
|
|
int old_maxtemp = d->maxtemp.mkelvin;
|
|
|
|
duration_t old_duration = d->duration;
|
2019-08-04 16:44:57 +00:00
|
|
|
struct start_end_pressure *old_pressures = malloc(d->cylinders.nr * sizeof(*old_pressures));
|
2015-10-06 15:41:36 +00:00
|
|
|
|
|
|
|
d->maxdepth.mm = 0;
|
|
|
|
dc->maxdepth.mm = 0;
|
|
|
|
d->watertemp.mkelvin = 0;
|
|
|
|
dc->watertemp.mkelvin = 0;
|
|
|
|
d->duration.seconds = 0;
|
|
|
|
d->maxtemp.mkelvin = 0;
|
|
|
|
d->mintemp.mkelvin = 0;
|
2019-08-04 16:44:57 +00:00
|
|
|
for (int i = 0; i < d->cylinders.nr; i++) {
|
2019-08-04 20:13:49 +00:00
|
|
|
cylinder_t *cyl = get_cylinder(d, i);
|
|
|
|
old_pressures[i].start = cyl->start;
|
|
|
|
old_pressures[i].end = cyl->end;
|
|
|
|
cyl->start.mbar = 0;
|
|
|
|
cyl->end.mbar = 0;
|
2018-07-02 19:12:44 +00:00
|
|
|
}
|
2015-10-06 15:41:36 +00:00
|
|
|
|
|
|
|
fixup_dive(d);
|
|
|
|
|
|
|
|
if (!d->watertemp.mkelvin)
|
|
|
|
d->watertemp.mkelvin = old_temp;
|
|
|
|
|
|
|
|
if (!dc->watertemp.mkelvin)
|
|
|
|
dc->watertemp.mkelvin = old_temp;
|
|
|
|
|
|
|
|
if (!d->maxtemp.mkelvin)
|
|
|
|
d->maxtemp.mkelvin = old_maxtemp;
|
|
|
|
|
|
|
|
if (!d->mintemp.mkelvin)
|
|
|
|
d->mintemp.mkelvin = old_mintemp;
|
|
|
|
|
|
|
|
if (!d->duration.seconds)
|
|
|
|
d->duration = old_duration;
|
2019-08-04 16:44:57 +00:00
|
|
|
for (int i = 0; i < d->cylinders.nr; i++) {
|
2019-08-04 20:13:49 +00:00
|
|
|
if (!get_cylinder(d, i)->start.mbar)
|
|
|
|
get_cylinder(d, i)->start = old_pressures[i].start;
|
|
|
|
if (!get_cylinder(d, i)->end.mbar)
|
|
|
|
get_cylinder(d, i)->end = old_pressures[i].end;
|
2018-07-02 19:12:44 +00:00
|
|
|
}
|
2019-06-27 20:03:53 +00:00
|
|
|
free(old_pressures);
|
2015-10-06 15:41:36 +00:00
|
|
|
}
|
|
|
|
|
2015-10-02 01:17:37 +00:00
|
|
|
/*
|
|
|
|
* Split a dive that has a surface interval from samples 'a' to 'b'
|
2018-07-20 18:26:06 +00:00
|
|
|
* into two dives, but don't add them to the log yet.
|
|
|
|
* Returns the nr of the old dive or <0 on failure.
|
2019-03-31 08:20:13 +00:00
|
|
|
* Moreover, on failure both output dives are set to NULL.
|
2018-07-20 18:26:06 +00:00
|
|
|
* On success, the newly allocated dives are returned in out1 and out2.
|
2015-10-02 01:17:37 +00:00
|
|
|
*/
|
2018-07-20 18:26:06 +00:00
|
|
|
static int split_dive_at(const struct dive *dive, int a, int b, struct dive **out1, struct dive **out2)
|
2015-10-02 01:17:37 +00:00
|
|
|
{
|
2016-03-10 02:18:58 +00:00
|
|
|
int i, nr;
|
|
|
|
uint32_t t;
|
2015-10-02 01:17:37 +00:00
|
|
|
struct dive *d1, *d2;
|
|
|
|
struct divecomputer *dc1, *dc2;
|
|
|
|
struct event *event, **evp;
|
|
|
|
|
2015-10-03 13:44:16 +00:00
|
|
|
/* if we can't find the dive in the dive list, don't bother */
|
2015-10-04 11:02:54 +00:00
|
|
|
if ((nr = get_divenr(dive)) < 0)
|
2018-07-20 18:26:06 +00:00
|
|
|
return -1;
|
2015-10-03 13:44:16 +00:00
|
|
|
|
2018-07-02 19:13:44 +00:00
|
|
|
/* Splitting should leave at least 3 samples per dive */
|
|
|
|
if (a < 3 || b > dive->dc.samples - 4)
|
2018-07-20 18:26:06 +00:00
|
|
|
return -1;
|
2018-07-02 19:13:44 +00:00
|
|
|
|
2015-10-02 01:17:37 +00:00
|
|
|
/* We're not trying to be efficient here.. */
|
|
|
|
d1 = create_new_copy(dive);
|
|
|
|
d2 = create_new_copy(dive);
|
2018-07-20 18:26:06 +00:00
|
|
|
d1->divetrip = d2->divetrip = 0;
|
2015-10-02 01:17:37 +00:00
|
|
|
|
2015-10-03 11:25:52 +00:00
|
|
|
/* now unselect the first first segment so we don't keep all
|
|
|
|
* dives selected by mistake. But do keep the second one selected
|
|
|
|
* so the algorithm keeps splitting the dive further */
|
|
|
|
d1->selected = false;
|
|
|
|
|
2015-10-02 01:17:37 +00:00
|
|
|
dc1 = &d1->dc;
|
|
|
|
dc2 = &d2->dc;
|
|
|
|
/*
|
|
|
|
* Cut off the samples of d1 at the beginning
|
|
|
|
* of the interval.
|
|
|
|
*/
|
|
|
|
dc1->samples = a;
|
|
|
|
|
|
|
|
/* And get rid of the 'b' first samples of d2 */
|
|
|
|
dc2->samples -= b;
|
|
|
|
memmove(dc2->sample, dc2->sample+b, dc2->samples * sizeof(struct sample));
|
|
|
|
|
2018-07-03 09:25:38 +00:00
|
|
|
/* Now the secondary dive computers */
|
|
|
|
t = dc2->sample[0].time.seconds;
|
|
|
|
while ((dc1 = dc1->next)) {
|
|
|
|
i = 0;
|
|
|
|
while (dc1->samples < i && dc1->sample[i].time.seconds <= t)
|
|
|
|
++i;
|
|
|
|
dc1->samples = i;
|
|
|
|
}
|
|
|
|
while ((dc2 = dc2->next)) {
|
|
|
|
i = 0;
|
|
|
|
while (dc2->samples < i && dc2->sample[i].time.seconds < t)
|
|
|
|
++i;
|
|
|
|
dc2->samples -= i;
|
|
|
|
memmove(dc2->sample, dc2->sample + i, dc2->samples * sizeof(struct sample));
|
|
|
|
}
|
|
|
|
dc1 = &d1->dc;
|
|
|
|
dc2 = &d2->dc;
|
2015-10-02 01:17:37 +00:00
|
|
|
/*
|
|
|
|
* This is where we cut off events from d1,
|
|
|
|
* and shift everything in d2
|
|
|
|
*/
|
|
|
|
d2->when += t;
|
2018-07-03 09:25:38 +00:00
|
|
|
while (dc1 && dc2) {
|
|
|
|
dc2->when += t;
|
|
|
|
for (i = 0; i < dc2->samples; i++)
|
|
|
|
dc2->sample[i].time.seconds -= t;
|
|
|
|
|
|
|
|
/* Remove the events past 't' from d1 */
|
|
|
|
evp = &dc1->events;
|
|
|
|
while ((event = *evp) != NULL && event->time.seconds < t)
|
|
|
|
evp = &event->next;
|
|
|
|
*evp = NULL;
|
|
|
|
while (event) {
|
|
|
|
struct event *next = event->next;
|
2015-10-02 01:17:37 +00:00
|
|
|
free(event);
|
2018-07-03 09:25:38 +00:00
|
|
|
event = next;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Remove the events before 't' from d2, and shift the rest */
|
|
|
|
evp = &dc2->events;
|
|
|
|
while ((event = *evp) != NULL) {
|
|
|
|
if (event->time.seconds < t) {
|
|
|
|
*evp = event->next;
|
|
|
|
free(event);
|
|
|
|
} else {
|
|
|
|
event->time.seconds -= t;
|
|
|
|
}
|
2015-10-02 01:17:37 +00:00
|
|
|
}
|
2018-07-03 09:25:38 +00:00
|
|
|
dc1 = dc1->next;
|
|
|
|
dc2 = dc2->next;
|
2015-10-02 01:17:37 +00:00
|
|
|
}
|
2015-10-06 15:41:36 +00:00
|
|
|
|
|
|
|
force_fixup_dive(d1);
|
|
|
|
force_fixup_dive(d2);
|
|
|
|
|
2015-10-02 01:17:37 +00:00
|
|
|
/*
|
|
|
|
* Was the dive numbered? If it was the last dive, then we'll
|
|
|
|
* increment the dive number for the tail part that we split off.
|
|
|
|
* Otherwise the tail is unnumbered.
|
|
|
|
*/
|
|
|
|
if (d2->number) {
|
2015-10-04 11:02:54 +00:00
|
|
|
if (dive_table.nr == nr + 1)
|
2015-10-02 01:17:37 +00:00
|
|
|
d2->number++;
|
|
|
|
else
|
|
|
|
d2->number = 0;
|
|
|
|
}
|
|
|
|
|
2018-07-20 18:26:06 +00:00
|
|
|
*out1 = d1;
|
|
|
|
*out2 = d2;
|
|
|
|
return nr;
|
|
|
|
}
|
|
|
|
|
2015-10-04 11:13:10 +00:00
|
|
|
/* in freedive mode we split for as little as 10 seconds on the surface,
|
|
|
|
* otherwise we use a minute */
|
2018-07-20 18:26:06 +00:00
|
|
|
static bool should_split(const struct divecomputer *dc, int t1, int t2)
|
2015-10-04 11:13:10 +00:00
|
|
|
{
|
|
|
|
int threshold = dc->divemode == FREEDIVE ? 10 : 60;
|
|
|
|
|
|
|
|
return t2 - t1 >= threshold;
|
|
|
|
}
|
|
|
|
|
2015-10-02 01:17:37 +00:00
|
|
|
/*
|
|
|
|
* Try to split a dive into multiple dives at a surface interval point.
|
|
|
|
*
|
2018-07-03 09:25:38 +00:00
|
|
|
* NOTE! We will split when there is at least one surface event that has
|
2015-10-02 01:17:37 +00:00
|
|
|
* non-surface events on both sides.
|
|
|
|
*
|
2018-07-03 09:25:38 +00:00
|
|
|
* The surface interval points are determined using the first dive computer.
|
|
|
|
*
|
2015-10-02 01:17:37 +00:00
|
|
|
* In other words, this is a (simplified) reversal of the dive merging.
|
|
|
|
*/
|
2018-12-09 12:17:45 +00:00
|
|
|
int split_dive(const struct dive *dive, struct dive **new1, struct dive **new2)
|
2015-10-02 01:17:37 +00:00
|
|
|
{
|
|
|
|
int i;
|
|
|
|
int at_surface, surface_start;
|
2018-07-20 18:26:06 +00:00
|
|
|
const struct divecomputer *dc;
|
2015-10-02 01:17:37 +00:00
|
|
|
|
2019-04-14 21:24:24 +00:00
|
|
|
*new1 = *new2 = NULL;
|
2018-07-03 09:25:38 +00:00
|
|
|
if (!dive)
|
2018-07-20 18:26:06 +00:00
|
|
|
return -1;
|
2015-10-02 01:17:37 +00:00
|
|
|
|
2018-07-03 09:25:38 +00:00
|
|
|
dc = &dive->dc;
|
2015-10-02 01:17:37 +00:00
|
|
|
surface_start = 0;
|
|
|
|
at_surface = 1;
|
|
|
|
for (i = 1; i < dc->samples; i++) {
|
|
|
|
struct sample *sample = dc->sample+i;
|
|
|
|
int surface_sample = sample->depth.mm < SURFACE_THRESHOLD;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We care about the transition from and to depth 0,
|
|
|
|
* not about the depth staying similar.
|
|
|
|
*/
|
|
|
|
if (at_surface == surface_sample)
|
|
|
|
continue;
|
|
|
|
at_surface = surface_sample;
|
|
|
|
|
|
|
|
// Did it become surface after having been non-surface? We found the start
|
|
|
|
if (at_surface) {
|
|
|
|
surface_start = i;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2015-11-15 18:15:40 +00:00
|
|
|
// Going down again? We want at least a minute from
|
2015-10-02 01:17:37 +00:00
|
|
|
// the surface start.
|
|
|
|
if (!surface_start)
|
|
|
|
continue;
|
2018-07-01 21:03:39 +00:00
|
|
|
if (!should_split(dc, dc->sample[surface_start].time.seconds, sample[-1].time.seconds))
|
2015-10-02 01:17:37 +00:00
|
|
|
continue;
|
|
|
|
|
2018-07-20 18:26:06 +00:00
|
|
|
return split_dive_at(dive, surface_start, i-1, new1, new2);
|
2015-10-02 01:17:37 +00:00
|
|
|
}
|
2018-07-20 18:26:06 +00:00
|
|
|
return -1;
|
2015-10-02 01:17:37 +00:00
|
|
|
}
|
|
|
|
|
2018-12-09 12:17:45 +00:00
|
|
|
int split_dive_at_time(const struct dive *dive, duration_t time, struct dive **new1, struct dive **new2)
|
2018-07-02 19:13:44 +00:00
|
|
|
{
|
|
|
|
int i = 0;
|
|
|
|
|
|
|
|
if (!dive)
|
2018-07-20 18:26:06 +00:00
|
|
|
return -1;
|
2019-10-27 11:28:57 +00:00
|
|
|
|
|
|
|
struct sample *sample = dive->dc.sample;
|
|
|
|
*new1 = *new2 = NULL;
|
2018-07-02 19:13:44 +00:00
|
|
|
while(sample->time.seconds < time.seconds) {
|
|
|
|
++sample;
|
|
|
|
++i;
|
|
|
|
if (dive->dc.samples == i)
|
2018-07-20 18:26:06 +00:00
|
|
|
return -1;
|
2018-07-02 19:13:44 +00:00
|
|
|
}
|
2018-07-20 18:26:06 +00:00
|
|
|
return split_dive_at(dive, i, i - 1, new1, new2);
|
|
|
|
}
|
|
|
|
|
2015-09-22 19:32:27 +00:00
|
|
|
/*
|
|
|
|
* "dc_maxtime()" is how much total time this dive computer
|
|
|
|
* has for this dive. Note that it can differ from "duration"
|
|
|
|
* if there are surface events in the middle.
|
|
|
|
*
|
|
|
|
* Still, we do ignore all but the last surface samples from the
|
|
|
|
* end, because some divecomputers just generate lots of them.
|
|
|
|
*/
|
|
|
|
static inline int dc_totaltime(const struct divecomputer *dc)
|
|
|
|
{
|
|
|
|
int time = dc->duration.seconds;
|
|
|
|
int nr = dc->samples;
|
|
|
|
|
|
|
|
while (nr--) {
|
|
|
|
struct sample *s = dc->sample + nr;
|
|
|
|
time = s->time.seconds;
|
|
|
|
if (s->depth.mm >= SURFACE_THRESHOLD)
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
return time;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The end of a dive is actually not trivial, because "duration"
|
|
|
|
* is not the duration until the end, but the time we spend under
|
|
|
|
* water, which can be very different if there are surface events
|
|
|
|
* during the dive.
|
|
|
|
*
|
|
|
|
* So walk the dive computers, looking for the longest actual
|
|
|
|
* time in the samples (and just default to the dive duration if
|
|
|
|
* there are no samples).
|
|
|
|
*/
|
|
|
|
static inline int dive_totaltime(const struct dive *dive)
|
|
|
|
{
|
|
|
|
int time = dive->duration.seconds;
|
|
|
|
const struct divecomputer *dc;
|
|
|
|
|
|
|
|
for_each_dc(dive, dc) {
|
|
|
|
int dc_time = dc_totaltime(dc);
|
|
|
|
if (dc_time > time)
|
|
|
|
time = dc_time;
|
|
|
|
}
|
|
|
|
return time;
|
|
|
|
}
|
|
|
|
|
|
|
|
timestamp_t dive_endtime(const struct dive *dive)
|
|
|
|
{
|
|
|
|
return dive->when + dive_totaltime(dive);
|
|
|
|
}
|
|
|
|
|
2020-05-22 20:14:24 +00:00
|
|
|
bool time_during_dive_with_offset(const struct dive *dive, timestamp_t when, timestamp_t offset)
|
2015-06-25 05:38:44 +00:00
|
|
|
{
|
2015-09-22 19:32:27 +00:00
|
|
|
timestamp_t start = dive->when;
|
|
|
|
timestamp_t end = dive_endtime(dive);
|
|
|
|
return start - offset <= when && when <= end + offset;
|
2015-06-25 05:38:44 +00:00
|
|
|
}
|
|
|
|
|
2015-06-17 03:28:42 +00:00
|
|
|
/* this sets a usually unused copy of the preferences with the units
|
|
|
|
* that were active the last time the dive list was saved to git storage
|
|
|
|
* (this isn't used in XML files); storing the unit preferences in the
|
|
|
|
* data file is usually pointless (that's a setting of the software,
|
|
|
|
* not a property of the data), but it's a great hint of what the user
|
|
|
|
* might expect to see when creating a backend service that visualizes
|
|
|
|
* the dive list without Subsurface running - so this is basically a
|
|
|
|
* functionality for the core library that Subsurface itself doesn't
|
|
|
|
* use but that another consumer of the library (like an HTML exporter)
|
|
|
|
* will need */
|
2018-03-03 09:10:51 +00:00
|
|
|
void set_informational_units(const char *units)
|
2015-06-17 03:28:42 +00:00
|
|
|
{
|
|
|
|
if (strstr(units, "METRIC")) {
|
2017-02-04 16:55:25 +00:00
|
|
|
git_prefs.unit_system = METRIC;
|
2015-06-17 03:28:42 +00:00
|
|
|
} else if (strstr(units, "IMPERIAL")) {
|
2017-02-04 16:55:25 +00:00
|
|
|
git_prefs.unit_system = IMPERIAL;
|
2015-06-17 03:28:42 +00:00
|
|
|
} else if (strstr(units, "PERSONALIZE")) {
|
2017-02-04 16:55:25 +00:00
|
|
|
git_prefs.unit_system = PERSONALIZE;
|
2015-06-17 03:28:42 +00:00
|
|
|
if (strstr(units, "METERS"))
|
2017-02-04 16:55:25 +00:00
|
|
|
git_prefs.units.length = METERS;
|
2015-06-17 03:28:42 +00:00
|
|
|
if (strstr(units, "FEET"))
|
2017-02-04 16:55:25 +00:00
|
|
|
git_prefs.units.length = FEET;
|
2015-06-17 03:28:42 +00:00
|
|
|
if (strstr(units, "LITER"))
|
2017-02-04 16:55:25 +00:00
|
|
|
git_prefs.units.volume = LITER;
|
2015-06-17 03:28:42 +00:00
|
|
|
if (strstr(units, "CUFT"))
|
2017-02-04 16:55:25 +00:00
|
|
|
git_prefs.units.volume = CUFT;
|
2015-06-17 03:28:42 +00:00
|
|
|
if (strstr(units, "BAR"))
|
2017-02-04 16:55:25 +00:00
|
|
|
git_prefs.units.pressure = BAR;
|
2015-06-17 03:28:42 +00:00
|
|
|
if (strstr(units, "PSI"))
|
2017-02-04 16:55:25 +00:00
|
|
|
git_prefs.units.pressure = PSI;
|
2015-06-17 03:28:42 +00:00
|
|
|
if (strstr(units, "CELSIUS"))
|
2017-02-04 16:55:25 +00:00
|
|
|
git_prefs.units.temperature = CELSIUS;
|
2015-06-17 03:28:42 +00:00
|
|
|
if (strstr(units, "FAHRENHEIT"))
|
2017-02-04 16:55:25 +00:00
|
|
|
git_prefs.units.temperature = FAHRENHEIT;
|
2015-06-17 03:28:42 +00:00
|
|
|
if (strstr(units, "KG"))
|
2017-02-04 16:55:25 +00:00
|
|
|
git_prefs.units.weight = KG;
|
2015-06-17 03:28:42 +00:00
|
|
|
if (strstr(units, "LBS"))
|
2017-02-04 16:55:25 +00:00
|
|
|
git_prefs.units.weight = LBS;
|
2015-06-17 03:28:42 +00:00
|
|
|
if (strstr(units, "SECONDS"))
|
2017-02-04 16:55:25 +00:00
|
|
|
git_prefs.units.vertical_speed_time = SECONDS;
|
2015-06-17 03:28:42 +00:00
|
|
|
if (strstr(units, "MINUTES"))
|
2017-02-04 16:55:25 +00:00
|
|
|
git_prefs.units.vertical_speed_time = MINUTES;
|
2015-06-17 03:28:42 +00:00
|
|
|
}
|
2017-02-04 16:55:25 +00:00
|
|
|
|
2015-06-17 03:28:42 +00:00
|
|
|
}
|
|
|
|
|
2018-03-03 09:10:51 +00:00
|
|
|
void set_git_prefs(const char *prefs)
|
2017-02-04 09:13:58 +00:00
|
|
|
{
|
|
|
|
if (strstr(prefs, "TANKBAR"))
|
|
|
|
git_prefs.tankbar = 1;
|
|
|
|
if (strstr(prefs, "DCCEILING"))
|
|
|
|
git_prefs.dcceiling = 1;
|
2017-02-04 16:55:25 +00:00
|
|
|
if (strstr(prefs, "SHOW_SETPOINT"))
|
|
|
|
git_prefs.show_ccr_setpoint = 1;
|
|
|
|
if (strstr(prefs, "SHOW_SENSORS"))
|
|
|
|
git_prefs.show_ccr_sensors = 1;
|
|
|
|
if (strstr(prefs, "PO2_GRAPH"))
|
|
|
|
git_prefs.pp_graphs.po2 = 1;
|
2017-02-04 09:13:58 +00:00
|
|
|
}
|
|
|
|
|
2019-05-17 20:22:55 +00:00
|
|
|
/* clones a dive and moves given dive computer to front */
|
|
|
|
struct dive *make_first_dc(const struct dive *d, int dc_number)
|
2014-06-11 20:56:33 +00:00
|
|
|
{
|
2019-05-17 20:22:55 +00:00
|
|
|
struct dive *res;
|
|
|
|
struct divecomputer *dc, *newdc, *old_dc;
|
|
|
|
|
|
|
|
/* copy the dive */
|
|
|
|
res = alloc_dive();
|
|
|
|
copy_dive(d, res);
|
|
|
|
|
|
|
|
/* make a new unique id, since we still can't handle two equal ids */
|
|
|
|
res->id = dive_getUniqID();
|
|
|
|
|
|
|
|
if (dc_number == 0)
|
|
|
|
return res;
|
|
|
|
|
|
|
|
dc = &res->dc;
|
|
|
|
newdc = malloc(sizeof(*newdc));
|
|
|
|
old_dc = get_dive_dc(res, dc_number);
|
2014-06-11 20:56:33 +00:00
|
|
|
|
|
|
|
/* skip the current DC in the linked list */
|
2019-05-17 20:22:55 +00:00
|
|
|
for (dc = &res->dc; dc && dc->next != old_dc; dc = dc->next)
|
|
|
|
;
|
2014-06-11 20:56:33 +00:00
|
|
|
if (!dc) {
|
2014-07-10 20:11:42 +00:00
|
|
|
free(newdc);
|
2014-06-11 20:56:33 +00:00
|
|
|
fprintf(stderr, "data inconsistent: can't find the current DC");
|
2019-05-17 20:22:55 +00:00
|
|
|
return res;
|
2014-06-11 20:56:33 +00:00
|
|
|
}
|
2019-05-17 20:22:55 +00:00
|
|
|
dc->next = old_dc->next;
|
|
|
|
*newdc = res->dc;
|
|
|
|
res->dc = *old_dc;
|
|
|
|
res->dc.next = newdc;
|
|
|
|
free(old_dc);
|
|
|
|
|
|
|
|
return res;
|
2014-06-11 20:56:33 +00:00
|
|
|
}
|
|
|
|
|
2019-03-31 08:20:13 +00:00
|
|
|
static void delete_divecomputer(struct dive *d, int num)
|
2014-06-11 20:56:33 +00:00
|
|
|
{
|
2019-03-31 08:20:13 +00:00
|
|
|
int i;
|
|
|
|
|
|
|
|
/* Refuse to delete the last dive computer */
|
|
|
|
if (!d->dc.next)
|
|
|
|
return;
|
2014-06-11 20:56:33 +00:00
|
|
|
|
2019-03-31 08:20:13 +00:00
|
|
|
if (num == 0) {
|
2014-06-11 20:56:33 +00:00
|
|
|
/* remove the first one, so copy the second one in place of the first and free the second one
|
|
|
|
* be careful about freeing the no longer needed structures - since we copy things around we can't use free_dc()*/
|
2019-03-31 08:20:13 +00:00
|
|
|
struct divecomputer *fdc = d->dc.next;
|
|
|
|
free_dc_contents(&d->dc);
|
|
|
|
memcpy(&d->dc, fdc, sizeof(struct divecomputer));
|
2014-06-11 20:56:33 +00:00
|
|
|
free(fdc);
|
|
|
|
} else {
|
2019-03-31 08:20:13 +00:00
|
|
|
struct divecomputer *pdc = &d->dc;
|
|
|
|
for (i = 0; i < num - 1 && pdc; i++)
|
2014-06-11 20:56:33 +00:00
|
|
|
pdc = pdc->next;
|
2019-10-27 11:28:57 +00:00
|
|
|
if (pdc && pdc->next) {
|
2019-03-31 08:20:13 +00:00
|
|
|
struct divecomputer *dc = pdc->next;
|
2014-06-11 20:56:33 +00:00
|
|
|
pdc->next = dc->next;
|
|
|
|
free_dc(dc);
|
|
|
|
}
|
|
|
|
}
|
2019-03-31 08:20:13 +00:00
|
|
|
}
|
|
|
|
|
2019-05-19 12:27:10 +00:00
|
|
|
/* Clone a dive and delete goven dive computer */
|
|
|
|
struct dive *clone_delete_divecomputer(const struct dive *d, int dc_number)
|
2019-03-31 08:20:13 +00:00
|
|
|
{
|
2019-05-19 12:27:10 +00:00
|
|
|
struct dive *res;
|
|
|
|
|
|
|
|
/* copy the dive */
|
|
|
|
res = alloc_dive();
|
|
|
|
copy_dive(d, res);
|
|
|
|
|
|
|
|
/* make a new unique id, since we still can't handle two equal ids */
|
|
|
|
res->id = dive_getUniqID();
|
|
|
|
|
|
|
|
delete_divecomputer(res, dc_number);
|
|
|
|
|
|
|
|
return res;
|
2019-03-31 08:20:13 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This splits the dive src by dive computer. The first output dive has all
|
|
|
|
* dive computers except num, the second only dive computer num.
|
|
|
|
* The dives will not be associated with a trip.
|
|
|
|
* On error, both output parameters are set to NULL.
|
|
|
|
*/
|
|
|
|
void split_divecomputer(const struct dive *src, int num, struct dive **out1, struct dive **out2)
|
|
|
|
{
|
|
|
|
struct divecomputer *srcdc = get_dive_dc(current_dive, dc_number);
|
|
|
|
|
|
|
|
if (src && srcdc) {
|
|
|
|
// Copy the dive, but only using the selected dive computer
|
|
|
|
*out2 = alloc_dive();
|
|
|
|
copy_dive_onedc(src, srcdc, *out2);
|
|
|
|
|
|
|
|
// This will also make fixup_dive() to allocate a new dive id...
|
|
|
|
(*out2)->id = 0;
|
|
|
|
fixup_dive(*out2);
|
|
|
|
|
|
|
|
// Copy the dive with all dive computers
|
|
|
|
*out1 = create_new_copy(src);
|
|
|
|
|
|
|
|
// .. and then delete the split-out dive computer
|
|
|
|
delete_divecomputer(*out1, num);
|
|
|
|
|
|
|
|
(*out1)->divetrip = (*out2)->divetrip = NULL;
|
|
|
|
} else {
|
|
|
|
*out1 = *out2 = NULL;
|
|
|
|
}
|
2014-06-11 20:56:33 +00:00
|
|
|
}
|
2015-07-04 16:12:54 +00:00
|
|
|
|
2016-05-21 09:32:07 +00:00
|
|
|
//Calculate O2 in best mix
|
2020-10-27 22:04:24 +00:00
|
|
|
fraction_t best_o2(depth_t depth, const struct dive *dive, bool in_planner)
|
2016-05-21 09:32:07 +00:00
|
|
|
{
|
|
|
|
fraction_t fo2;
|
2020-10-27 22:04:24 +00:00
|
|
|
int po2 = in_planner ? prefs.bottompo2 : prefs.modpO2 * 1000;
|
2016-05-21 09:32:07 +00:00
|
|
|
|
2020-09-29 21:59:56 +00:00
|
|
|
fo2.permille = (po2 * 100 / depth_to_mbar(depth.mm, dive)) * 10; //use integer arithmetic to round down to nearest percent
|
2016-07-06 12:40:34 +00:00
|
|
|
// Don't permit >100% O2
|
|
|
|
if (fo2.permille > 1000)
|
|
|
|
fo2.permille = 1000;
|
2016-05-21 09:32:07 +00:00
|
|
|
return fo2;
|
|
|
|
}
|
|
|
|
|
|
|
|
//Calculate He in best mix. O2 is considered narcopic
|
2019-10-29 16:57:34 +00:00
|
|
|
fraction_t best_he(depth_t depth, const struct dive *dive, bool o2narcotic, fraction_t fo2)
|
2016-05-21 09:32:07 +00:00
|
|
|
{
|
|
|
|
fraction_t fhe;
|
|
|
|
int pnarcotic, ambient;
|
2016-07-06 12:40:31 +00:00
|
|
|
pnarcotic = depth_to_mbar(prefs.bestmixend.mm, dive);
|
2016-05-21 09:32:07 +00:00
|
|
|
ambient = depth_to_mbar(depth.mm, dive);
|
2019-10-29 16:57:34 +00:00
|
|
|
if (o2narcotic) {
|
|
|
|
fhe.permille = (100 - 100 * pnarcotic / ambient) * 10; //use integer arithmetic to round up to nearest percent
|
|
|
|
} else {
|
|
|
|
fhe.permille = 1000 - fo2.permille - N2_IN_AIR * pnarcotic / ambient;
|
|
|
|
}
|
2016-05-21 09:32:07 +00:00
|
|
|
if (fhe.permille < 0)
|
|
|
|
fhe.permille = 0;
|
|
|
|
return fhe;
|
|
|
|
}
|
2018-07-18 18:47:19 +00:00
|
|
|
|
|
|
|
void invalidate_dive_cache(struct dive *dive)
|
|
|
|
{
|
|
|
|
memset(dive->git_id, 0, 20);
|
|
|
|
}
|
|
|
|
|
|
|
|
bool dive_cache_is_valid(const struct dive *dive)
|
|
|
|
{
|
|
|
|
static const unsigned char null_id[20] = { 0, };
|
|
|
|
return !!memcmp(dive->git_id, null_id, 20);
|
|
|
|
}
|
|
|
|
|
|
|
|
int get_surface_pressure_in_mbar(const struct dive *dive, bool non_null)
|
|
|
|
{
|
|
|
|
int mbar = dive->surface_pressure.mbar;
|
|
|
|
if (!mbar && non_null)
|
|
|
|
mbar = SURFACE_PRESSURE;
|
|
|
|
return mbar;
|
|
|
|
}
|
|
|
|
|
2020-09-02 18:14:45 +00:00
|
|
|
/* This returns the conversion factor that you need to multiply
|
|
|
|
* a (relative) depth in mm to obtain a (relative) pressure in mbar.
|
|
|
|
* As everywhere in Subsurface, the expected unit of a salinity is
|
|
|
|
* g/10l such that sea water has a salinity of 10300
|
|
|
|
*/
|
|
|
|
static double salinity_to_specific_weight(int salinity)
|
|
|
|
{
|
|
|
|
return salinity * 0.981 / 100000.0;
|
|
|
|
}
|
|
|
|
|
2018-07-18 18:47:19 +00:00
|
|
|
/* Pa = N/m^2 - so we determine the weight (in N) of the mass of 10m
|
|
|
|
* of water (and use standard salt water at 1.03kg per liter if we don't know salinity)
|
|
|
|
* and add that to the surface pressure (or to 1013 if that's unknown) */
|
2020-09-02 18:14:45 +00:00
|
|
|
static int calculate_depth_to_mbar(int depth, pressure_t surface_pressure, int salinity)
|
2018-07-18 18:47:19 +00:00
|
|
|
{
|
|
|
|
double specific_weight;
|
|
|
|
int mbar = surface_pressure.mbar;
|
|
|
|
|
|
|
|
if (!mbar)
|
|
|
|
mbar = SURFACE_PRESSURE;
|
|
|
|
if (!salinity)
|
|
|
|
salinity = SEAWATER_SALINITY;
|
|
|
|
if (salinity < 500)
|
|
|
|
salinity += FRESHWATER_SALINITY;
|
2020-09-02 18:14:45 +00:00
|
|
|
specific_weight = salinity_to_specific_weight(salinity);
|
|
|
|
mbar += lrint(depth * specific_weight);
|
2018-07-18 18:47:19 +00:00
|
|
|
return mbar;
|
|
|
|
}
|
|
|
|
|
2018-08-16 22:36:51 +00:00
|
|
|
int depth_to_mbar(int depth, const struct dive *dive)
|
2018-07-18 18:47:19 +00:00
|
|
|
{
|
|
|
|
return calculate_depth_to_mbar(depth, dive->surface_pressure, dive->salinity);
|
|
|
|
}
|
|
|
|
|
2018-08-16 22:36:51 +00:00
|
|
|
double depth_to_bar(int depth, const struct dive *dive)
|
2018-07-18 18:47:19 +00:00
|
|
|
{
|
|
|
|
return depth_to_mbar(depth, dive) / 1000.0;
|
|
|
|
}
|
|
|
|
|
2018-08-16 22:36:51 +00:00
|
|
|
double depth_to_atm(int depth, const struct dive *dive)
|
2018-07-18 18:47:19 +00:00
|
|
|
{
|
|
|
|
return mbar_to_atm(depth_to_mbar(depth, dive));
|
|
|
|
}
|
|
|
|
|
|
|
|
/* for the inverse calculation we use just the relative pressure
|
|
|
|
* (that's the one that some dive computers like the Uemis Zurich
|
|
|
|
* provide - for the other models that do this libdivecomputer has to
|
|
|
|
* take care of this, but the Uemis we support natively */
|
2018-08-16 22:36:51 +00:00
|
|
|
int rel_mbar_to_depth(int mbar, const struct dive *dive)
|
2018-07-18 18:47:19 +00:00
|
|
|
{
|
2020-09-02 18:14:45 +00:00
|
|
|
double specific_weight = salinity_to_specific_weight(SEAWATER_SALINITY);
|
2018-07-18 18:47:19 +00:00
|
|
|
if (dive->dc.salinity)
|
2020-09-02 18:14:45 +00:00
|
|
|
specific_weight = salinity_to_specific_weight(dive->dc.salinity);
|
2018-07-18 18:47:19 +00:00
|
|
|
/* whole mbar gives us cm precision */
|
2020-09-02 18:14:45 +00:00
|
|
|
return (int)lrint(mbar / specific_weight);
|
2018-07-18 18:47:19 +00:00
|
|
|
}
|
|
|
|
|
2018-08-16 22:36:51 +00:00
|
|
|
int mbar_to_depth(int mbar, const struct dive *dive)
|
2018-07-18 18:47:19 +00:00
|
|
|
{
|
|
|
|
pressure_t surface_pressure;
|
|
|
|
if (dive->surface_pressure.mbar)
|
|
|
|
surface_pressure = dive->surface_pressure;
|
|
|
|
else
|
|
|
|
surface_pressure.mbar = SURFACE_PRESSURE;
|
|
|
|
return rel_mbar_to_depth(mbar - surface_pressure.mbar, dive);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* MOD rounded to multiples of roundto mm */
|
2018-08-16 22:36:51 +00:00
|
|
|
depth_t gas_mod(struct gasmix mix, pressure_t po2_limit, const struct dive *dive, int roundto)
|
2018-07-18 18:47:19 +00:00
|
|
|
{
|
|
|
|
depth_t rounded_depth;
|
|
|
|
|
|
|
|
double depth = (double) mbar_to_depth(po2_limit.mbar * 1000 / get_o2(mix), dive);
|
|
|
|
rounded_depth.mm = (int)lrint(depth / roundto) * roundto;
|
|
|
|
return rounded_depth;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Maximum narcotic depth rounded to multiples of roundto mm */
|
2018-08-16 22:36:51 +00:00
|
|
|
depth_t gas_mnd(struct gasmix mix, depth_t end, const struct dive *dive, int roundto)
|
2018-07-18 18:47:19 +00:00
|
|
|
{
|
|
|
|
depth_t rounded_depth;
|
|
|
|
pressure_t ppo2n2;
|
|
|
|
ppo2n2.mbar = depth_to_mbar(end.mm, dive);
|
|
|
|
|
2020-07-11 11:15:21 +00:00
|
|
|
int maxambient = prefs.o2narcotic ?
|
|
|
|
(int)lrint(ppo2n2.mbar / (1 - get_he(mix) / 1000.0))
|
|
|
|
:
|
2020-11-13 08:38:08 +00:00
|
|
|
get_n2(mix) > 0 ?
|
|
|
|
(int)lrint(ppo2n2.mbar * N2_IN_AIR / get_n2(mix))
|
|
|
|
:
|
|
|
|
// Actually: Infinity
|
|
|
|
1000000;
|
2018-07-18 18:47:19 +00:00
|
|
|
rounded_depth.mm = (int)lrint(((double)mbar_to_depth(maxambient, dive)) / roundto) * roundto;
|
|
|
|
return rounded_depth;
|
|
|
|
}
|
|
|
|
|
|
|
|
struct dive *get_dive(int nr)
|
|
|
|
{
|
|
|
|
if (nr >= dive_table.nr || nr < 0)
|
|
|
|
return NULL;
|
|
|
|
return dive_table.dives[nr];
|
|
|
|
}
|
|
|
|
|
2018-08-16 22:36:51 +00:00
|
|
|
struct dive_site *get_dive_site_for_dive(const struct dive *dive)
|
2018-07-18 18:47:19 +00:00
|
|
|
{
|
2018-10-26 15:03:54 +00:00
|
|
|
return dive->dive_site;
|
2018-07-18 18:47:19 +00:00
|
|
|
}
|
|
|
|
|
2018-08-16 22:36:51 +00:00
|
|
|
const char *get_dive_country(const struct dive *dive)
|
2018-07-18 18:47:19 +00:00
|
|
|
{
|
2018-10-26 15:03:54 +00:00
|
|
|
struct dive_site *ds = dive->dive_site;
|
2020-09-06 11:27:00 +00:00
|
|
|
return ds ? taxonomy_get_country(&ds->taxonomy) : NULL;
|
2018-07-18 18:47:19 +00:00
|
|
|
}
|
|
|
|
|
2018-08-16 22:36:51 +00:00
|
|
|
const char *get_dive_location(const struct dive *dive)
|
2018-07-18 18:47:19 +00:00
|
|
|
{
|
2018-10-26 15:03:54 +00:00
|
|
|
const struct dive_site *ds = dive->dive_site;
|
2018-07-18 18:47:19 +00:00
|
|
|
if (ds && ds->name)
|
|
|
|
return ds->name;
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2018-08-16 22:36:51 +00:00
|
|
|
unsigned int number_of_computers(const struct dive *dive)
|
2018-07-18 18:47:19 +00:00
|
|
|
{
|
|
|
|
unsigned int total_number = 0;
|
2018-08-16 22:36:51 +00:00
|
|
|
const struct divecomputer *dc = &dive->dc;
|
2018-07-18 18:47:19 +00:00
|
|
|
|
|
|
|
if (!dive)
|
|
|
|
return 1;
|
|
|
|
|
|
|
|
do {
|
|
|
|
total_number++;
|
|
|
|
dc = dc->next;
|
|
|
|
} while (dc);
|
|
|
|
return total_number;
|
|
|
|
}
|
|
|
|
|
|
|
|
struct divecomputer *get_dive_dc(struct dive *dive, int nr)
|
|
|
|
{
|
|
|
|
struct divecomputer *dc;
|
|
|
|
if (!dive)
|
|
|
|
return NULL;
|
|
|
|
dc = &dive->dc;
|
|
|
|
|
|
|
|
while (nr-- > 0) {
|
|
|
|
dc = dc->next;
|
|
|
|
if (!dc)
|
|
|
|
return &dive->dc;
|
|
|
|
}
|
|
|
|
return dc;
|
|
|
|
}
|
|
|
|
|
2021-01-09 17:58:33 +00:00
|
|
|
const struct divecomputer *get_dive_dc_const(const struct dive *dive, int nr)
|
|
|
|
{
|
|
|
|
return get_dive_dc((struct dive *)dive, nr);
|
|
|
|
}
|
|
|
|
|
2018-07-18 18:47:19 +00:00
|
|
|
struct dive *get_dive_by_uniq_id(int id)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
struct dive *dive = NULL;
|
|
|
|
|
|
|
|
for_each_dive (i, dive) {
|
|
|
|
if (dive->id == id)
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
#ifdef DEBUG
|
|
|
|
if (dive == NULL) {
|
|
|
|
fprintf(stderr, "Invalid id %x passed to get_dive_by_diveid, try to fix the code\n", id);
|
|
|
|
exit(1);
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
return dive;
|
|
|
|
}
|
|
|
|
|
|
|
|
int get_idx_by_uniq_id(int id)
|
|
|
|
{
|
|
|
|
int i;
|
|
|
|
struct dive *dive = NULL;
|
|
|
|
|
|
|
|
for_each_dive (i, dive) {
|
|
|
|
if (dive->id == id)
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
#ifdef DEBUG
|
|
|
|
if (dive == NULL) {
|
|
|
|
fprintf(stderr, "Invalid id %x passed to get_dive_by_diveid, try to fix the code\n", id);
|
|
|
|
exit(1);
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
return i;
|
|
|
|
}
|
|
|
|
|
2018-08-16 22:36:51 +00:00
|
|
|
bool dive_site_has_gps_location(const struct dive_site *ds)
|
2018-07-18 18:47:19 +00:00
|
|
|
{
|
2018-10-20 18:12:15 +00:00
|
|
|
return ds && has_location(&ds->location);
|
2018-07-18 18:47:19 +00:00
|
|
|
}
|
|
|
|
|
2018-08-16 22:36:51 +00:00
|
|
|
int dive_has_gps_location(const struct dive *dive)
|
2018-07-18 18:47:19 +00:00
|
|
|
{
|
|
|
|
if (!dive)
|
|
|
|
return false;
|
2018-10-26 15:03:54 +00:00
|
|
|
return dive_site_has_gps_location(dive->dive_site);
|
2018-07-18 18:47:19 +00:00
|
|
|
}
|
|
|
|
|
2019-04-24 21:59:59 +00:00
|
|
|
/* Extract GPS location of a dive computer stored in the GPS1
|
|
|
|
* or GPS2 extra data fields */
|
|
|
|
static location_t dc_get_gps_location(const struct divecomputer *dc)
|
|
|
|
{
|
|
|
|
location_t res = { };
|
|
|
|
|
|
|
|
for (struct extra_data *data = dc->extra_data; data; data = data->next) {
|
|
|
|
if (!strcmp(data->key, "GPS1")) {
|
|
|
|
parse_location(data->value, &res);
|
|
|
|
/* If we found a valid GPS1 field exit early since
|
|
|
|
* it has priority over GPS2 */
|
|
|
|
if (has_location(&res))
|
|
|
|
break;
|
|
|
|
} else if (!strcmp(data->key, "GPS2")) {
|
|
|
|
/* For GPS2 fields continue searching, as we might
|
|
|
|
* still find a GPS1 field */
|
|
|
|
parse_location(data->value, &res);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return res;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Get GPS location for a dive. Highest priority is given to the GPS1
|
|
|
|
* extra data written by libdivecomputer, as this comes from a real GPS
|
|
|
|
* device. If that doesn't exits, use the currently set dive site.
|
|
|
|
* This function is potentially slow, therefore only call sparingly
|
|
|
|
* and remember the result.
|
|
|
|
*/
|
|
|
|
location_t dive_get_gps_location(const struct dive *d)
|
|
|
|
{
|
|
|
|
location_t res = { };
|
|
|
|
|
|
|
|
for (const struct divecomputer *dc = &d->dc; dc; dc = dc->next) {
|
|
|
|
res = dc_get_gps_location(dc);
|
|
|
|
if (has_location(&res))
|
|
|
|
return res;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* No libdivecomputer generated GPS data found.
|
|
|
|
* Let's use the location of the current dive site.
|
|
|
|
*/
|
|
|
|
if (d->dive_site)
|
|
|
|
res = d->dive_site->location;
|
|
|
|
|
|
|
|
return res;
|
|
|
|
}
|
|
|
|
|
2018-10-30 11:19:00 +00:00
|
|
|
/* When evaluated at the time of a gasswitch, this returns the new gas */
|
2018-08-16 22:58:30 +00:00
|
|
|
struct gasmix get_gasmix(const struct dive *dive, const struct divecomputer *dc, int time, const struct event **evp, struct gasmix gasmix)
|
2018-07-18 18:47:19 +00:00
|
|
|
{
|
2018-08-16 22:58:30 +00:00
|
|
|
const struct event *ev = *evp;
|
2018-08-16 11:35:14 +00:00
|
|
|
struct gasmix res;
|
2018-07-18 18:47:19 +00:00
|
|
|
|
2019-08-04 16:44:57 +00:00
|
|
|
/* if there is no cylinder, return air */
|
|
|
|
if (dive->cylinders.nr <= 0)
|
|
|
|
return gasmix_air;
|
|
|
|
|
2018-08-16 11:35:14 +00:00
|
|
|
if (!ev) {
|
|
|
|
/* on first invocation, get initial gas mix and first event (if any) */
|
2018-07-18 18:47:19 +00:00
|
|
|
int cyl = explicit_first_cylinder(dive, dc);
|
2019-08-04 20:13:49 +00:00
|
|
|
res = get_cylinder(dive, cyl)->gasmix;
|
2018-07-18 18:47:19 +00:00
|
|
|
ev = dc ? get_next_event(dc->events, "gaschange") : NULL;
|
2018-08-16 11:35:14 +00:00
|
|
|
} else {
|
2018-08-16 17:10:10 +00:00
|
|
|
res = gasmix;
|
2018-07-18 18:47:19 +00:00
|
|
|
}
|
2018-08-16 11:35:14 +00:00
|
|
|
|
2018-10-29 22:55:38 +00:00
|
|
|
while (ev && ev->time.seconds <= time) {
|
2018-08-16 11:35:14 +00:00
|
|
|
res = get_gasmix_from_event(dive, ev);
|
2018-07-18 18:47:19 +00:00
|
|
|
ev = get_next_event(ev->next, "gaschange");
|
|
|
|
}
|
|
|
|
*evp = ev;
|
2018-08-16 11:35:14 +00:00
|
|
|
return res;
|
2018-07-18 18:47:19 +00:00
|
|
|
}
|
2018-08-16 15:11:51 +00:00
|
|
|
|
|
|
|
/* get the gas at a certain time during the dive */
|
2018-10-30 11:19:00 +00:00
|
|
|
/* If there is a gasswitch at that time, it returns the new gasmix */
|
2018-08-16 22:58:30 +00:00
|
|
|
struct gasmix get_gasmix_at_time(const struct dive *d, const struct divecomputer *dc, duration_t time)
|
2018-08-16 15:11:51 +00:00
|
|
|
{
|
2018-08-16 22:58:30 +00:00
|
|
|
const struct event *ev = NULL;
|
2018-09-10 18:40:25 +00:00
|
|
|
struct gasmix gasmix = gasmix_air;
|
2018-08-16 17:10:10 +00:00
|
|
|
return get_gasmix(d, dc, time.seconds, &ev, gasmix);
|
2018-08-16 15:11:51 +00:00
|
|
|
}
|